From patchwork Fri Mar 31 09:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 13195678 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BD1C76196 for ; Fri, 31 Mar 2023 09:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232140AbjCaJ1v (ORCPT ); Fri, 31 Mar 2023 05:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232137AbjCaJ13 (ORCPT ); Fri, 31 Mar 2023 05:27:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D611EFE0; Fri, 31 Mar 2023 02:27:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D1EAB82DAF; Fri, 31 Mar 2023 09:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49991C433D2; Fri, 31 Mar 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254821; bh=jDg9+LbHBtf4EjDGettNNrjuuWGpis85RdG5aiSWD5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXZqS0n3DzEGbnhm/VuFgz81qhHhbB8LYxa+QNGAK8aCAKZfMDsCONopQkz8C59WJ g+wiN/k7a9am8lJiu10gLlcLLq0pkMCDKLjQUF9kQV0/UzS6ZgKXtvMjql8GREQSDj JLo/9iiWbrsgQvqctkGbq4tBXdPctKCLSWoKS7w3/uO3PUHxqYSQvycxPNZIa4dQhe ETiYPunbpUdXC1m0XmEaMVB4f1zGu8ws65dTCpINbY9ntnfw+Kmw5iIWHAZGE0U+Rh /HgCOd+PyR8UBGJPb2K5PUtZV95W4tDsGUbWREGq14UCvHYGepF2JwZpMrlSLkVwu6 P1tN1uJeoFwmA== From: Lee Jones To: lee@kernel.org Cc: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header Date: Fri, 31 Mar 2023 10:26:04 +0100 Message-Id: <20230331092607.700644-17-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_vma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index f51fd9fd4c89c..20a44788999e5 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -739,6 +739,7 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, unsigned long color) /** * i915_vma_insert - finds a slot for the vma in its address space * @vma: the vma + * @ww: An optional struct i915_gem_ww_ctx * @size: requested size in bytes (can be larger than the VMA) * @alignment: required alignment * @flags: mask of PIN_* flags to use @@ -1714,7 +1715,7 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, i915_vma_free(vma); } -/** +/* * i915_vma_destroy_locked - Remove all weak reference to the vma and put * the initial reference. *