diff mbox series

[v3,4/9] media: dt-bindings: cadence-csi2rx: Add resets property

Message ID 20230331121826.96973-5-jack.zhu@starfivetech.com (mailing list archive)
State New, archived
Headers show
Series Add Starfive Camera Subsystem driver | expand

Commit Message

Jack Zhu March 31, 2023, 12:18 p.m. UTC
Add resets property for Cadence MIPI-CSI2 RX controller

Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
---
 .../bindings/media/cdns,csi2rx.yaml           | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

Comments

Krzysztof Kozlowski March 31, 2023, 8:12 p.m. UTC | #1
On 31/03/2023 14:18, Jack Zhu wrote:
> Add resets property for Cadence MIPI-CSI2 RX controller
> 
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Laurent Pinchart April 4, 2023, 4:56 a.m. UTC | #2
Hi Jack,

Thank you for the patch.

On Fri, Mar 31, 2023 at 08:18:21PM +0800, Jack Zhu wrote:
> Add resets property for Cadence MIPI-CSI2 RX controller
> 
> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  .../bindings/media/cdns,csi2rx.yaml           | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> index 89f414eeef47..f8da4a35e98e 100644
> --- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> +++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
> @@ -38,6 +38,24 @@ properties:
>        - const: pixel_if2_clk
>        - const: pixel_if3_clk
>  
> +  resets:
> +    items:
> +      - description: CSI2Rx system reset
> +      - description: Gated Register bank reset for APB interface
> +      - description: pixel reset for Stream interface 0
> +      - description: pixel reset for Stream interface 1
> +      - description: pixel reset for Stream interface 2
> +      - description: pixel reset for Stream interface 3
> +
> +  reset-names:
> +    items:
> +      - const: sys
> +      - const: reg_bank
> +      - const: pixel_if0
> +      - const: pixel_if1
> +      - const: pixel_if2
> +      - const: pixel_if3
> +
>    phys:
>      maxItems: 1
>      description: MIPI D-PHY
> @@ -120,6 +138,12 @@ examples:
>          clock-names = "sys_clk", "p_clk",
>                        "pixel_if0_clk", "pixel_if1_clk",
>                        "pixel_if2_clk", "pixel_if3_clk";
> +        resets = <&bytereset 9>, <&bytereset 4>,
> +                 <&corereset 5>, <&corereset 6>,
> +                 <&corereset 7>, <&corereset 8>;
> +        reset-names = "sys", "reg_bank",
> +                      "pixel_if0", "pixel_if1",
> +                      "pixel_if2", "pixel_if3";
>          phys = <&csi_phy>;
>          phy-names = "dphy";
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
index 89f414eeef47..f8da4a35e98e 100644
--- a/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
+++ b/Documentation/devicetree/bindings/media/cdns,csi2rx.yaml
@@ -38,6 +38,24 @@  properties:
       - const: pixel_if2_clk
       - const: pixel_if3_clk
 
+  resets:
+    items:
+      - description: CSI2Rx system reset
+      - description: Gated Register bank reset for APB interface
+      - description: pixel reset for Stream interface 0
+      - description: pixel reset for Stream interface 1
+      - description: pixel reset for Stream interface 2
+      - description: pixel reset for Stream interface 3
+
+  reset-names:
+    items:
+      - const: sys
+      - const: reg_bank
+      - const: pixel_if0
+      - const: pixel_if1
+      - const: pixel_if2
+      - const: pixel_if3
+
   phys:
     maxItems: 1
     description: MIPI D-PHY
@@ -120,6 +138,12 @@  examples:
         clock-names = "sys_clk", "p_clk",
                       "pixel_if0_clk", "pixel_if1_clk",
                       "pixel_if2_clk", "pixel_if3_clk";
+        resets = <&bytereset 9>, <&bytereset 4>,
+                 <&corereset 5>, <&corereset 6>,
+                 <&corereset 7>, <&corereset 8>;
+        reset-names = "sys", "reg_bank",
+                      "pixel_if0", "pixel_if1",
+                      "pixel_if2", "pixel_if3";
         phys = <&csi_phy>;
         phy-names = "dphy";