From patchwork Tue Apr 25 09:45:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Riesch X-Patchwork-Id: 13223134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A509AC77B71 for ; Tue, 25 Apr 2023 09:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233655AbjDYJpa (ORCPT ); Tue, 25 Apr 2023 05:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233613AbjDYJp2 (ORCPT ); Tue, 25 Apr 2023 05:45:28 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2078.outbound.protection.outlook.com [40.107.21.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D9C45BBA; Tue, 25 Apr 2023 02:45:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NepYPkVHhO9ZUgY84UmijyRV7fGRkSPycmcSV2JDsy9I12uxI1deiewqrjTJJrwJex3i4wLRf9m9qUOJOvOW1lgCyp8F56dhVDjVF5MJ/AZlbTHrmSvXhRie9Mr7fsuoGkDTUTyju9bqkyxL8MU85ywFNGtpEaLf9aOrm1PAJ4UqoTUHCy7KTuMxD0TboSJrhb+9/u28OImW9SFoUm7VSbhurs2GY5Vq4LqDq3wnAUm/XwsrZmKixJWe2FTeYNPiNitZjFa5wJMdoO/FHYXHGp76lM3DQk1pvnWmEd68GE3wdN5Q+DoWaOnp2TcfXm0A+z/RDLj5t7MFNToJT4EoPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E/np1ssZ/vRL41pK51a5xuP3Pd/7WNHyAEgiJNx8ZtI=; b=GGb+NHgV9zhzuR/E+giLc+FdhwzD7HavzdubrZlqxogrUmFnsDI2FHSXggpa39uQbD92h04RhVetlAB8t8PBehjw72+9SXJlPuG63/rmrs+BOSJZn+YIbC7jQkd1TjBMMeOPtOXxCPbz0HK/6/EPAc3TPhi3NKbt3tuDq1LjbKyUjELTVYg3GEcDXBNJV21IbEYXfqL/tNATRBjz+BG4YSqD2GbMVwvG7E1N1ospHrDCj/cOmCXXFSicNIjTb10XPWLNTeeHnAP04IFYlUMY7Il6UMt6RGHrAzniGM7n4PtdOCMG8rIqUSnyoeutpLBTbAxyLBGDFqAHgaBGqbNgFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wolfvision.net; dmarc=pass action=none header.from=wolfvision.net; dkim=pass header.d=wolfvision.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E/np1ssZ/vRL41pK51a5xuP3Pd/7WNHyAEgiJNx8ZtI=; b=F5Ov3f4Bm0iEJAcGuRgzMQXUaSW5vRycLzeaI3FdFqcEZmt5jx0dQ5bb10rF969CjodpfOHmWZ6paAW8w/cDMYT0dbAmZ3r57dO4ZmGydcAwLuCApAn29UikNSd+X2kdzVCs9yZahTTlfrximSFJnGOkps88HCY+ftgzdmJJts8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from GV1SPRMB0046.eurprd08.prod.outlook.com (2603:10a6:150:84::17) by DU0PR08MB7995.eurprd08.prod.outlook.com (2603:10a6:10:3e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 09:45:24 +0000 Received: from GV1SPRMB0046.eurprd08.prod.outlook.com ([fe80::3734:409a:8031:4f54]) by GV1SPRMB0046.eurprd08.prod.outlook.com ([fe80::3734:409a:8031:4f54%3]) with mapi id 15.20.6319.034; Tue, 25 Apr 2023 09:45:24 +0000 From: Michael Riesch Date: Tue, 25 Apr 2023 11:45:11 +0200 Subject: [PATCH RFC v2 1/6] media: v4l2-ctrls: fix documentation of V4L2_CID_FOCUS_ABSOLUTE unit Message-Id: <20230406-feature-controls-lens-v2-1-faa8ad2bc404@wolfvision.net> References: <20230406-feature-controls-lens-v2-0-faa8ad2bc404@wolfvision.net> In-Reply-To: <20230406-feature-controls-lens-v2-0-faa8ad2bc404@wolfvision.net> To: Mauro Carvalho Chehab Cc: libcamera-devel@lists.libcamera.org, Laurent Pinchart , Sakari Ailus , Hans Verkuil , Matthias Fend , Dave Stevenson , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Riesch X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1682415922; l=1253; i=michael.riesch@wolfvision.net; s=20230425; h=from:subject:message-id; bh=DUug3cmze1JbFFjqafjKeI2QEmsiWz/5lD5k/gkcZ58=; b=40z38y3YqQBmvZU3HiBECHWzurcl45POnP1/YBhONJ1NWvd1gw6ma7sgzem1tfv6Mi9XXAMa3 nFNM9CdEmF/Cf0aH9vwC3N4JgmhMLL4fX7bcklRpWRtPcuBVcbGarUm X-Developer-Key: i=michael.riesch@wolfvision.net; a=ed25519; pk=1QQdXA2QbwdxaQn/VQK0hz04C8IBYhDowbK0hlNU4Ng= X-ClientProxiedBy: VI1PR0802CA0032.eurprd08.prod.outlook.com (2603:10a6:800:a9::18) To GV1SPRMB0046.eurprd08.prod.outlook.com (2603:10a6:150:84::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1SPRMB0046:EE_|DU0PR08MB7995:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b4356f3-14d9-4cd8-b376-08db4571caad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AsHcqLnyJEAAFi+ENSoGCZxrqnKYvmvFjTOiJtRPoHzwWA2Mojxj3jgLu/zlpbYXrcxjU5XHncOQ+fZCRdEFkPmMiTMcVvfLuULeFkVaLNQItNhUDswHwfpREhJU6Flo2hgqovLjYzrDng6rIIrFt1H8WBmuuAOWnIA7WzWBLo6jjCpnalcXaRHSDRq7/XhPEhEOlzfpYt093qJg6vw16pESJq/kFpMyGZfwa8v0qVRxdhUL8BIOsNHZbQJvqXy/YO25ZJk7hzqpEVNO0yw0aFq+ODpBqrd4pBpNc/HIbSWLF+GJgSxbLQ3BDq2M5jh4PRjnMwkyyqku54/wB6dkbDBfB5uy2FAPgqALv8rFyzlqXHDldpsWgooluJ6u3qmMysr7ZuR8TyChQaKT7HhyT3AmfPlgoUsSpSwnRBkkDnC78j4828+mb6jn/tJv/9NqYOwntp3rLUXhL2pFV6G37BWgJ4aH/4GyGYatBFmYmBSZewYuXdW+mb3EiGB42zGL7kiW7jKI92ViKZKAOQA0UGsfeFdRZk7eXiyo2sCcTxdBTyEc0UFpQAS530ottx4BdRHD4WX/Mp4guZdQwUwyvzSlg/+zznnooueQFu+NorBr7J2Vhrc5QtDuGt/pzJs5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1SPRMB0046.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(366004)(39850400004)(346002)(451199021)(38350700002)(38100700002)(6506007)(6512007)(26005)(186003)(8936002)(2616005)(83380400001)(107886003)(44832011)(2906002)(8676002)(5660300002)(36756003)(478600001)(54906003)(6486002)(52116002)(316002)(6666004)(4326008)(6916009)(66556008)(41300700001)(66946007)(86362001)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?8kXq4cE8imbXLOArXieAvTN7qCrK?= =?utf-8?q?DdbgOt6NfF64xwWAMsoIaczbY+7I776YFP5fTuVS7LuUZ4pcOK/XJYqP0vSFrcxjA?= =?utf-8?q?1dIfTW3NxYEw0NMWl7f6Do7kaYUuky/z2MImCIOTdyvlQCCin04qu/zub8x2VOwbN?= =?utf-8?q?lFZplf1yjIT3Pkj/bZXGeEXwwxGnsiVXeGG6SGGZFcKNbpJV3g8BCV9rOxc3NRLp/?= =?utf-8?q?b5OCGKPORgq5wDYsonyI8v9lLQIrOnpsV8gOP41OQTv5WweS/9otJl+kENLMpDWT3?= =?utf-8?q?src2RavtRRZLi7JCHx8jwIdufmAqUzx8du/RH0+d2v2VGsrT/XPJiEP4WTXvPeL0o?= =?utf-8?q?SEBv//82rUTrLov8uq7vV0/C8tlA8MDVm6cv9BvySMNnjtQWrw3zOFXtkUB+CaQez?= =?utf-8?q?bG9LltYCJiuABah/50go67GYQ5QyTTDa2ikKoWRTQ9i6dJhzCdwoz1bYiCMVZ61mY?= =?utf-8?q?GZTgLUE7y/6gynsE5gpdSpMoCkiNxGuXQ0BxF3FvsnOpvO84/vrwUJemhES9Fbmm+?= =?utf-8?q?siwsj1BVILymmQt3Z1Z0bgw44u/NtRU6xZRvMYB8QjgyX8/2HpcwBQqthZnP0P2ok?= =?utf-8?q?FsE6yGcePzXO/0hPALYgKiRg85o2aC6NHWn6FdDHl9RtM5NRM5T1MJFtlbNBXaXX7?= =?utf-8?q?zsIgorUy/pB6R0adFkVwgNQHh/n1Aiy/FAj89kDD8PZ6e8P5wF6ckDg1qO5dJsHG+?= =?utf-8?q?Tin5NVtvAjsxnLYOKZQQt1BFJnGQFM0wVW3OVWXE9VFC6GjoL3PSHzKYf7kZhYH1Q?= =?utf-8?q?h1F6dHE3+0DTNscIydnvGrS8Ggc87lAgh08VYXt7ChgLZMUYkPhZbCYxeJINTS8lj?= =?utf-8?q?zzWXghkQDkai78+iBLPFJxwBFcjBcYPNbtWun1ZNb3wcF3gR5zH+BiAKDpJdZ/CbL?= =?utf-8?q?SGqlD1II1q/UnQvfBPnFpGAycMmzH4ixWWeOf4ucikQVvosgYbYioNHLwjjvnDqmy?= =?utf-8?q?fX5yGgMCA8ZHqtKNVvkYVsolFhTBwNYlns0lXIYGNLbXuj3TPVSpYK0hMcwcOKfsf?= =?utf-8?q?XO+2B5qzT2Wp8EFrMXe/W8Xg8haotL0EagAzbqdAe4Q8pg2RQUQK8qFX6YzK11z0p?= =?utf-8?q?4Ae/kpLyW9PrIp9axqwWUSRROWjzcf4QDS08Xl/S8BEfZ0XA/G0NQzEIrH35D94BU?= =?utf-8?q?kGp+o/TfezMEDJ3pe/kq+H4imXLpr7zudf/you6bNGHn1aIjijjcZFjRuVVXK5qMg?= =?utf-8?q?uKpZMG4DHSBH3bbaIjWxPlwZFM417n9ffhBHjztpPmEReGrpLLimErnKyUaueNzB7?= =?utf-8?q?l01LrSMqqcuRMH+Zyjf6E2N1dqVFExHXo9paSKNqJXjF4mgydUTLoYf+2uM6ZKRLR?= =?utf-8?q?n9H1vJBdRbYERqy7JsUNkQuSp3DwbV4tP2FAU+IQS6un/LmLWZBE5lSKqyLpm6gTC?= =?utf-8?q?xqNXGA/UnWnMP9heZcD0JETMEkc9s/EP4sWGBXLnriMBxkW2CZ20VTpChbiQ65Cpa?= =?utf-8?q?m76bNUE7mqqN5VKgcbKkaPoDkji2oCJXT5DPK2nN85M1rFU8K0ea1FtupNfDDNLIB?= =?utf-8?q?tpDxZwKYJxHJTbjGr4qavBiO7mIIz6m3pA=3D=3D?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4356f3-14d9-4cd8-b376-08db4571caad X-MS-Exchange-CrossTenant-AuthSource: GV1SPRMB0046.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2023 09:45:23.9518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jmseUhbvjM/qRoDvC7JYfFdSD75bfxI3qXkYxrfUqd3GsQs0OYvdQBDkzDLZAW2GXPk8D+K666yjzEdaMYGOtIPzHITSeHwo/8Y+kY+zaCM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7995 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The current unit description of the V4L2_CID_FOCUS_ABSOLUTE does not make sense and was probably copy-pasted from V4L2_CID_FOCUS_RELATIVE. Fix the unit description in the documentation. Signed-off-by: Michael Riesch Reviewed-by: Laurent Pinchart --- Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst index daa4f40869f8..df29150dce7b 100644 --- a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst @@ -140,8 +140,8 @@ enum v4l2_exposure_metering - ``V4L2_CID_FOCUS_ABSOLUTE (integer)`` This control sets the focal point of the camera to the specified - position. The unit is undefined. Positive values set the focus - closer to the camera, negative values towards infinity. + position. The unit is undefined. Larger values move the focus closer to + the camera, smaller values move the focus to infinity. ``V4L2_CID_FOCUS_RELATIVE (integer)`` This control moves the focal point of the camera by the specified