| Message ID | 20230503072543.4837-2-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: camss: Link CAMSS power domain on MSM8996 | expand |
On 03/05/2023 08:25, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add the CAMSS power domain which is needed for the proper operation of CAMSS, and add > power-domain-names to ease fetching it as well as the other power domains. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > .../bindings/media/qcom,msm8996-camss.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > index 8a10aa1cafc5..27c9a11f0df9 100644 > --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml > @@ -85,6 +85,13 @@ properties: > items: > - description: VFE0 GDSC - Video Front End, Global Distributed Switch Controller. > - description: VFE1 GDSC - Video Front End, Global Distributed Switch Controller. > + - description: CAMSS GDSC - Camera Subsystem, Global Distributed Switch Controller. > + > + power-domain-names: > + items: > + - const: vfe0 > + - const: vfe1 > + - const: camss > > ports: > $ref: /schemas/graph.yaml#/properties/ports > @@ -209,6 +216,7 @@ required: > - interrupts > - iommus > - power-domains > + - power-domain-names > - reg > - reg-names > - vdda-supply > @@ -326,7 +334,10 @@ examples: > <&vfe_smmu 3>; > > power-domains = <&mmcc VFE0_GDSC>, > - <&mmcc VFE1_GDSC>; > + <&mmcc VFE1_GDSC>, > + <&mmcc CAMSS_GDSC>; > + > + power-domain-names = "vfe0", "vfe1", "camss"; > > reg = <0x00a34000 0x1000>, > <0x00a00030 0x4>, Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 03/05/2023 09:25, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add the CAMSS power domain which is needed for the proper operation of CAMSS, and add > power-domain-names to ease fetching it as well as the other power domains. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 Same for all other patches. Subject: you have double media, drop the latter one. Your subject is anyway too long, so shorten it. camss: is also a redundant prefix. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml index 8a10aa1cafc5..27c9a11f0df9 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml @@ -85,6 +85,13 @@ properties: items: - description: VFE0 GDSC - Video Front End, Global Distributed Switch Controller. - description: VFE1 GDSC - Video Front End, Global Distributed Switch Controller. + - description: CAMSS GDSC - Camera Subsystem, Global Distributed Switch Controller. + + power-domain-names: + items: + - const: vfe0 + - const: vfe1 + - const: camss ports: $ref: /schemas/graph.yaml#/properties/ports @@ -209,6 +216,7 @@ required: - interrupts - iommus - power-domains + - power-domain-names - reg - reg-names - vdda-supply @@ -326,7 +334,10 @@ examples: <&vfe_smmu 3>; power-domains = <&mmcc VFE0_GDSC>, - <&mmcc VFE1_GDSC>; + <&mmcc VFE1_GDSC>, + <&mmcc CAMSS_GDSC>; + + power-domain-names = "vfe0", "vfe1", "camss"; reg = <0x00a34000 0x1000>, <0x00a00030 0x4>,