| Message ID | 20230513123159.33234-14-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: atomisp: Register only 1 /dev/video# node + cleanups | expand |
On Sat, May 13, 2023 at 3:32 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Both the atomisp_device and the atomisp_sub_device structs have > an used mipi_frame_size field, remove the field from both. I am confused. Perhaps 'an unused'?
diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c index 39eba99feee0..37d8c8af3e8c 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c @@ -448,7 +448,6 @@ static void atomisp_dev_init_struct(struct atomisp_device *isp) unsigned int i; isp->isp_fatal_error = false; - isp->mipi_frame_size = 0; for (i = 0; i < isp->input_cnt; i++) isp->inputs[i].asd = NULL; @@ -478,7 +477,6 @@ static void atomisp_subdev_init_struct(struct atomisp_sub_device *asd) /* Add for channel */ asd->input_curr = 0; - asd->mipi_frame_size = 0; asd->copy_mode = false; asd->stream_prepared = false; diff --git a/drivers/staging/media/atomisp/pci/atomisp_internal.h b/drivers/staging/media/atomisp/pci/atomisp_internal.h index e531f0c71a15..cec0ac92726e 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_internal.h +++ b/drivers/staging/media/atomisp/pci/atomisp_internal.h @@ -211,7 +211,6 @@ struct atomisp_device { spinlock_t lock; /* Protects asd.streaming */ - unsigned int mipi_frame_size; const struct atomisp_dfs_config *dfs; unsigned int hpll_freq; unsigned int running_freq; diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.h b/drivers/staging/media/atomisp/pci/atomisp_subdev.h index 28afcdd41ef3..a702890003f9 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.h +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.h @@ -304,8 +304,6 @@ struct atomisp_sub_device { unsigned int latest_preview_exp_id; /* CSS ZSL/SDV raw buffer id */ - unsigned int mipi_frame_size; - bool copy_mode; /* CSI2+ use copy mode */ int raw_buffer_bitmap[ATOMISP_MAX_EXP_ID / 32 +
Both the atomisp_device and the atomisp_sub_device structs have an used mipi_frame_size field, remove the field from both. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/staging/media/atomisp/pci/atomisp_fops.c | 2 -- drivers/staging/media/atomisp/pci/atomisp_internal.h | 1 - drivers/staging/media/atomisp/pci/atomisp_subdev.h | 2 -- 3 files changed, 5 deletions(-)