| Message ID | 20230715170906.3627-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] media: atomisp: Remove empty isys_public.h | expand |
Hi Hans, On Sun, Jul 16, 2023 at 1:09 AM Hans de Goede <hdegoede@redhat.com> wrote: > > isp2400_input_system_local.h defines 2 aliases for MIPI_FORMAT_2400_CUSTOM0 > MIPI_FORMAT_JPEG, which is entirely unused and MIPI_FORMAT_BINARY_8 which > is used once in ia_css_isys_2400_set_fmt_type(). > > Drop these aliases and directly use MIPI_FORMAT_2400_CUSTOM0 in > ia_css_isys_2400_set_fmt_type(). > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/staging/media/atomisp/pci/isp2400_input_system_local.h | 2 -- > drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 2 +- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h b/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h > index e7b84fdbb4e0..6319d6449f20 100644 > --- a/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h > +++ b/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h > @@ -200,8 +200,6 @@ typedef enum { > N_MIPI_FORMAT_2400, > } mipi_format_2400_t; > > -#define MIPI_FORMAT_JPEG MIPI_FORMAT_2400_CUSTOM0 > -#define MIPI_FORMAT_BINARY_8 MIPI_FORMAT_2400_CUSTOM0 > #define N_MIPI_FORMAT_CUSTOM 8 > > /* The number of stores for compressed format types */ > diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > index c8316e0965d0..deb4130f710c 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c > @@ -271,7 +271,7 @@ static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format, > *fmt_type = MIPI_FORMAT_2400_RAW16; > break; > case ATOMISP_INPUT_FORMAT_BINARY_8: > - *fmt_type = MIPI_FORMAT_BINARY_8; > + *fmt_type = MIPI_FORMAT_2400_CUSTOM0; > break; > case ATOMISP_INPUT_FORMAT_YUV420_16: > case ATOMISP_INPUT_FORMAT_YUV422_16: > -- > 2.41.0 > Thank you for working on this. It looks good to me. Reviewed-by: Kate Hsuan <hpa@redhat.com> -- BR, Kate
diff --git a/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h b/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h index e7b84fdbb4e0..6319d6449f20 100644 --- a/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h +++ b/drivers/staging/media/atomisp/pci/isp2400_input_system_local.h @@ -200,8 +200,6 @@ typedef enum { N_MIPI_FORMAT_2400, } mipi_format_2400_t; -#define MIPI_FORMAT_JPEG MIPI_FORMAT_2400_CUSTOM0 -#define MIPI_FORMAT_BINARY_8 MIPI_FORMAT_2400_CUSTOM0 #define N_MIPI_FORMAT_CUSTOM 8 /* The number of stores for compressed format types */ diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c index c8316e0965d0..deb4130f710c 100644 --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c @@ -271,7 +271,7 @@ static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format, *fmt_type = MIPI_FORMAT_2400_RAW16; break; case ATOMISP_INPUT_FORMAT_BINARY_8: - *fmt_type = MIPI_FORMAT_BINARY_8; + *fmt_type = MIPI_FORMAT_2400_CUSTOM0; break; case ATOMISP_INPUT_FORMAT_YUV420_16: case ATOMISP_INPUT_FORMAT_YUV422_16:
isp2400_input_system_local.h defines 2 aliases for MIPI_FORMAT_2400_CUSTOM0 MIPI_FORMAT_JPEG, which is entirely unused and MIPI_FORMAT_BINARY_8 which is used once in ia_css_isys_2400_set_fmt_type(). Drop these aliases and directly use MIPI_FORMAT_2400_CUSTOM0 in ia_css_isys_2400_set_fmt_type(). Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/staging/media/atomisp/pci/isp2400_input_system_local.h | 2 -- drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-)