| Message ID | 20230821223001.28480-3-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: imx219: Miscellaneous cleanups and improvements | expand |
Hi Laurent Thanks for the patch. On Mon, 21 Aug 2023 at 23:29, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Drop a handful of macros that are not used and don't provide any value. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/media/i2c/imx219.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index c5aeec50b9e8..229dfe24304b 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -72,12 +72,6 @@ > > #define IMX219_VBLANK_MIN 4 > > -/*Frame Length Line*/ > -#define IMX219_FLL_MIN 0x08a6 > -#define IMX219_FLL_MAX 0xffff > -#define IMX219_FLL_STEP 1 > -#define IMX219_FLL_DEFAULT 0x0c98 > - > /* HBLANK control - read only */ > #define IMX219_PPL_DEFAULT 3448 > > @@ -105,10 +99,6 @@ > #define IMX219_TESTP_COLOUR_MIN 0 > #define IMX219_TESTP_COLOUR_MAX 0x03ff > #define IMX219_TESTP_COLOUR_STEP 1 > -#define IMX219_TESTP_RED_DEFAULT IMX219_TESTP_COLOUR_MAX > -#define IMX219_TESTP_GREENR_DEFAULT 0 > -#define IMX219_TESTP_BLUE_DEFAULT 0 > -#define IMX219_TESTP_GREENB_DEFAULT 0 > > /* External clock frequency is 24.0M */ > #define IMX219_XCLK_FREQ 24000000 > -- > Regards, > > Laurent Pinchart >
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index c5aeec50b9e8..229dfe24304b 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -72,12 +72,6 @@ #define IMX219_VBLANK_MIN 4 -/*Frame Length Line*/ -#define IMX219_FLL_MIN 0x08a6 -#define IMX219_FLL_MAX 0xffff -#define IMX219_FLL_STEP 1 -#define IMX219_FLL_DEFAULT 0x0c98 - /* HBLANK control - read only */ #define IMX219_PPL_DEFAULT 3448 @@ -105,10 +99,6 @@ #define IMX219_TESTP_COLOUR_MIN 0 #define IMX219_TESTP_COLOUR_MAX 0x03ff #define IMX219_TESTP_COLOUR_STEP 1 -#define IMX219_TESTP_RED_DEFAULT IMX219_TESTP_COLOUR_MAX -#define IMX219_TESTP_GREENR_DEFAULT 0 -#define IMX219_TESTP_BLUE_DEFAULT 0 -#define IMX219_TESTP_GREENB_DEFAULT 0 /* External clock frequency is 24.0M */ #define IMX219_XCLK_FREQ 24000000
Drop a handful of macros that are not used and don't provide any value. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/i2c/imx219.c | 10 ---------- 1 file changed, 10 deletions(-)