| Message ID | 20230826171711.366710-1-sean@mess.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx | expand |
On 26/08/2023 19:17, Sean Young wrote: > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir > can be removed. > > Signed-off-by: Sean Young <sean@mess.org> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Sat, Aug 26, 2023 at 09:54:04PM +0200, Krzysztof Kozlowski wrote: > On 26/08/2023 19:17, Sean Young wrote: > > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir > > can be removed. > > > > Signed-off-by: Sean Young <sean@mess.org> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. You are right, I -- again -- messed up. The Cc: list for 1/2 and 2/2 got mixed up. I am sorry about this, it's getting embarrassing now. Is there any tooling which does this automagically? I'm copying and pasting the output of scripts/get_maintainers.pl into shell scripts, which is very error-prone (as evidenced by today's mistake). Sean
On 26/08/2023 22:39, Sean Young wrote: > On Sat, Aug 26, 2023 at 09:54:04PM +0200, Krzysztof Kozlowski wrote: >> On 26/08/2023 19:17, Sean Young wrote: >>> The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir >>> can be removed. >>> >>> Signed-off-by: Sean Young <sean@mess.org> >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. > > You are right, I -- again -- messed up. The Cc: list for 1/2 and 2/2 got > mixed up. > > I am sorry about this, it's getting embarrassing now. > > Is there any tooling which does this automagically? I'm copying and > pasting the output of scripts/get_maintainers.pl into shell scripts, > which is very error-prone (as evidenced by today's mistake). I am using this: https://github.com/krzk/tools/blob/master/linux/.bash_aliases_linux#L91 Other option, sending each patch to separate recipients, is: [sendemail.linux] tocmd ="scripts/get_maintainer.pl --no-git --no-git-fallback --no-l --no-roles --no-rolestats" cccmd ="scripts/get_maintainer.pl --no-git --no-git-fallback --no-m --no-roles --no-rolestats" confirm = always and then git send-email --identity=.... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml index f2a6fa140f38..7526e3149f72 100644 --- a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml +++ b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.yaml @@ -15,7 +15,10 @@ description: properties: compatible: - const: pwm-ir-tx + oneOf: + - const: pwm-ir-tx + - const: nokia,n900-ir + deprecated: true pwms: maxItems: 1 diff --git a/Documentation/devicetree/bindings/media/nokia,n900-ir b/Documentation/devicetree/bindings/media/nokia,n900-ir deleted file mode 100644 index 13a18ce37dd1..000000000000 --- a/Documentation/devicetree/bindings/media/nokia,n900-ir +++ /dev/null @@ -1,20 +0,0 @@ -Device-Tree bindings for LIRC TX driver for Nokia N900(RX51) - -Required properties: - - compatible: should be "nokia,n900-ir". - - pwms: specifies PWM used for IR signal transmission. - -Example node: - - pwm9: dmtimer-pwm@9 { - compatible = "ti,omap-dmtimer-pwm"; - ti,timers = <&timer9>; - ti,clock-source = <0x00>; /* timer_sys_ck */ - #pwm-cells = <3>; - }; - - ir: n900-ir { - compatible = "nokia,n900-ir"; - - pwms = <&pwm9 0 26316 0>; /* 38000 Hz */ - };
The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir can be removed. Signed-off-by: Sean Young <sean@mess.org> --- .../bindings/leds/irled/pwm-ir-tx.yaml | 5 ++++- .../devicetree/bindings/media/nokia,n900-ir | 20 ------------------- 2 files changed, 4 insertions(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir