| Message ID | 20230922072116.11009-4-moudy.ho@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | introduce more MDP3 components in MT8195 | expand |
On Fri, Sep 22, 2023 at 03:21:03PM +0800, Moudy Ho wrote: > To minimize duplication and standardize the document style, > include the common properties for MT8183 RDMA. Duplication that you created in the previous patch? Why not combine patches 2 & 3? Cheers, Conor. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > .../bindings/media/mediatek,mdp3-rdma.yaml | 43 ++----------------- > 1 file changed, 4 insertions(+), 39 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index 3e128733ef53..0539badc9821 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/media/mediatek,mdp3-rdma.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: MediaTek Read Direct Memory Access > +title: MediaTek MT8183 Read Direct Memory Access > > maintainers: > - Matthias Brugger <matthias.bgg@gmail.com> > @@ -18,62 +18,27 @@ description: | > Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > for details. > > +allOf: > + - $ref: mediatek,mdp3-rdma-common.yaml# > + > properties: > compatible: > items: > - const: mediatek,mt8183-mdp3-rdma > > - reg: > - maxItems: 1 > - > - mediatek,gce-client-reg: > - $ref: /schemas/types.yaml#/definitions/phandle-array > - items: > - items: > - - description: phandle of GCE > - - description: GCE subsys id > - - description: register offset > - - description: register size > - description: The register of client driver can be configured by gce with > - 4 arguments defined in this property. Each GCE subsys id is mapping to > - a client defined in the header include/dt-bindings/gce/<chip>-gce.h. > - > - mediatek,gce-events: > - description: > - The event id which is mapping to the specific hardware event signal > - to gce. The event id is defined in the gce header > - include/dt-bindings/gce/<chip>-gce.h of each chips. > - $ref: /schemas/types.yaml#/definitions/uint32-array > - > - power-domains: > - maxItems: 1 > - > clocks: > items: > - description: RDMA clock > - description: RSZ clock > > - iommus: > - maxItems: 1 > - > mboxes: > items: > - description: used for 1st data pipe from RDMA > - description: used for 2nd data pipe from RDMA > > - '#dma-cells': > - const: 1 > - > required: > - compatible > - - reg > - - mediatek,gce-client-reg > - - mediatek,gce-events > - - power-domains > - - clocks > - - iommus > - mboxes > - - '#dma-cells' > > additionalProperties: false > > -- > 2.18.0 >
On 22/09/2023 09:21, Moudy Ho wrote: > To minimize duplication and standardize the document style, > include the common properties for MT8183 RDMA. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > .../bindings/media/mediatek,mdp3-rdma.yaml | 43 ++----------------- > 1 file changed, 4 insertions(+), 39 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index 3e128733ef53..0539badc9821 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/media/mediatek,mdp3-rdma.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: MediaTek Read Direct Memory Access > +title: MediaTek MT8183 Read Direct Memory Access How is this related to patch? Why rename is separate? This is poor way to split your work. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index 3e128733ef53..0539badc9821 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/media/mediatek,mdp3-rdma.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: MediaTek Read Direct Memory Access +title: MediaTek MT8183 Read Direct Memory Access maintainers: - Matthias Brugger <matthias.bgg@gmail.com> @@ -18,62 +18,27 @@ description: | Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml for details. +allOf: + - $ref: mediatek,mdp3-rdma-common.yaml# + properties: compatible: items: - const: mediatek,mt8183-mdp3-rdma - reg: - maxItems: 1 - - mediatek,gce-client-reg: - $ref: /schemas/types.yaml#/definitions/phandle-array - items: - items: - - description: phandle of GCE - - description: GCE subsys id - - description: register offset - - description: register size - description: The register of client driver can be configured by gce with - 4 arguments defined in this property. Each GCE subsys id is mapping to - a client defined in the header include/dt-bindings/gce/<chip>-gce.h. - - mediatek,gce-events: - description: - The event id which is mapping to the specific hardware event signal - to gce. The event id is defined in the gce header - include/dt-bindings/gce/<chip>-gce.h of each chips. - $ref: /schemas/types.yaml#/definitions/uint32-array - - power-domains: - maxItems: 1 - clocks: items: - description: RDMA clock - description: RSZ clock - iommus: - maxItems: 1 - mboxes: items: - description: used for 1st data pipe from RDMA - description: used for 2nd data pipe from RDMA - '#dma-cells': - const: 1 - required: - compatible - - reg - - mediatek,gce-client-reg - - mediatek,gce-events - - power-domains - - clocks - - iommus - mboxes - - '#dma-cells' additionalProperties: false
To minimize duplication and standardize the document style, include the common properties for MT8183 RDMA. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> --- .../bindings/media/mediatek,mdp3-rdma.yaml | 43 ++----------------- 1 file changed, 4 insertions(+), 39 deletions(-)