From patchwork Mon Oct 9 10:47:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13413386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FEBE95A8E for ; Mon, 9 Oct 2023 10:47:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234423AbjJIKra (ORCPT ); Mon, 9 Oct 2023 06:47:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232713AbjJIKr3 (ORCPT ); Mon, 9 Oct 2023 06:47:29 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EAD999 for ; Mon, 9 Oct 2023 03:47:27 -0700 (PDT) Received: from umang.jainideasonboard.com (unknown [IPv6:2405:201:2033:3002:3848:5d20:59c9:c87c]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E85D97E2; Mon, 9 Oct 2023 12:47:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1696848445; bh=WHU7IPXZKXTE1rhuy3e+aOCX4v7cqCvPdHa9poBLiDU=; h=From:To:Cc:Subject:Date:From; b=VNGmRy+iA/wTsHM8P0vpMJuGVk9ygETdTb6P0r4kgn5g4pn8XiTlw6F5oUbiX5SAf 0OK5p0V8RjR2OCCFYZs+Tmssoa+qm7UTW3xdJsS//feWej/RdaHjCaB7hLidw/N6JG IFGTYrDQquATNBn+thPjgUdYJsAJrJdjRz0yOcno= From: Umang Jain To: linux-staging@lists.linux.dev, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dave Stevenson , Umang Jain Subject: [PATCH v2] staging: vc04_services: vchiq_bus: Do not kfree device Date: Mon, 9 Oct 2023 16:17:14 +0530 Message-Id: <20231009104714.142880-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org As per device_register() documentation, this kfree() on error path will crash. The call to put_device() is all that is needed here to free the memory. Fixes: 027e5703de6b ("staging: vc04_services: vchiq_arm: Add new bus type and device type") Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c index 4ac3491efe45..0076d091b9b2 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.c @@ -73,7 +73,6 @@ vchiq_device_register(struct device *parent, const char *name) if (ret) { dev_err(parent, "Cannot register %s: %d\n", name, ret); put_device(&device->dev); - kfree(device); return NULL; }