| Message ID | 20231021110058.85013-1-bergh.jonathan@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] staging: media: atomisp: Removed duplicate comment and fixed comment format | expand |
Hi Jonathan, On 10/21/23 13:00, Jonathan Bergh wrote: > Fixed the following issues: > * Removed a duplicate comment > * Fixed up minor comment format issue > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Thank you for your patch, but please don't resend it every week. I did see the original patch and it looks fine but I have not had any time to work in atomisp support recently and this does not seem like something which needs to get merged urgently. I'll pick this up next time I have time to do a bunch of atomisp work. Regards, Hans > --- > drivers/staging/media/atomisp/i2c/gc2235.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h > index 55ea422291ba..ade28950db73 100644 > --- a/drivers/staging/media/atomisp/i2c/gc2235.h > +++ b/drivers/staging/media/atomisp/i2c/gc2235.h > @@ -74,9 +74,6 @@ > #define GC2235_COARSE_INTG_TIME_MIN 1 > #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6 > > -/* > - * GC2235 System control registers > - */ > /* > * GC2235 System control registers > */ > @@ -167,7 +164,7 @@ enum gc2235_tok_type { > GC2235_TOK_MASK = 0xfff0 > }; > > -/** > +/* > * struct gc2235_reg - MI sensor register format > * @type: type of the register > * @reg: 8-bit offset to register
On Sat, Oct 21, 2023 at 01:57:05PM +0200, Hans de Goede wrote: > Hi Jonathan, > > On 10/21/23 13:00, Jonathan Bergh wrote: > > Fixed the following issues: > > * Removed a duplicate comment > > * Fixed up minor comment format issue > > > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Hi Hans, thanks for the msg. > > Thank you for your patch, but please don't resend > it every week. Apologies. I dont remember when i sent the original but I was cleaning up today and thought i would resend it. (I dont recall resending prior to today (?) but if so, apologies). > I did see the original patch and it looks fine but > I have not had any time to work in atomisp support > recently and this does not seem like something > which needs to get merged urgently. > > I'll pick this up next time I have time to do > a bunch of atomisp work. Yes, for sure, it was just a small thing. Thanks Hans br Jonathan
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h index 55ea422291ba..ade28950db73 100644 --- a/drivers/staging/media/atomisp/i2c/gc2235.h +++ b/drivers/staging/media/atomisp/i2c/gc2235.h @@ -74,9 +74,6 @@ #define GC2235_COARSE_INTG_TIME_MIN 1 #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6 -/* - * GC2235 System control registers - */ /* * GC2235 System control registers */ @@ -167,7 +164,7 @@ enum gc2235_tok_type { GC2235_TOK_MASK = 0xfff0 }; -/** +/* * struct gc2235_reg - MI sensor register format * @type: type of the register * @reg: 8-bit offset to register
Fixed the following issues: * Removed a duplicate comment * Fixed up minor comment format issue Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> --- drivers/staging/media/atomisp/i2c/gc2235.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)