| Message ID | 20231023-imx214-v1-3-b33f1bbd1fcf@apitzsch.eu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: imx214: Extend with sensor size and firmware information | expand |
Hi Andre' On Mon, Oct 23, 2023 at 11:47:52PM +0200, André Apitzsch wrote: > Obtain rotation and orientation information from system firmware and > register the appropriate controls. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > drivers/media/i2c/imx214.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > index 554fc4733128..bef8dc36e2d0 100644 > --- a/drivers/media/i2c/imx214.c > +++ b/drivers/media/i2c/imx214.c > @@ -704,9 +704,14 @@ static int imx214_ctrls_init(struct imx214 *imx214) > .width = 1120, > .height = 1120, > }; > + struct v4l2_fwnode_device_properties props; > struct v4l2_ctrl_handler *ctrl_hdlr; > int ret; > > + ret = v4l2_fwnode_device_parse(imx214->dev, &props); > + if (ret < 0) > + return ret; > + > ctrl_hdlr = &imx214->ctrls; > ret = v4l2_ctrl_handler_init(&imx214->ctrls, 3); > if (ret) > @@ -746,6 +751,8 @@ static int imx214_ctrls_init(struct imx214 *imx214) > V4L2_CID_UNIT_CELL_SIZE, > v4l2_ctrl_ptr_create((void *)&unit_size)); > > + v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx214_ctrl_ops, &props); > + I think it's fine not checking the return value of v4l2_ctrl_new_fwnode_properties() if you inspect ctrl_hdlr->error just after Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > ret = ctrl_hdlr->error; > if (ret) { > v4l2_ctrl_handler_free(ctrl_hdlr); > > -- > 2.42.0 >
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 554fc4733128..bef8dc36e2d0 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -704,9 +704,14 @@ static int imx214_ctrls_init(struct imx214 *imx214) .width = 1120, .height = 1120, }; + struct v4l2_fwnode_device_properties props; struct v4l2_ctrl_handler *ctrl_hdlr; int ret; + ret = v4l2_fwnode_device_parse(imx214->dev, &props); + if (ret < 0) + return ret; + ctrl_hdlr = &imx214->ctrls; ret = v4l2_ctrl_handler_init(&imx214->ctrls, 3); if (ret) @@ -746,6 +751,8 @@ static int imx214_ctrls_init(struct imx214 *imx214) V4L2_CID_UNIT_CELL_SIZE, v4l2_ctrl_ptr_create((void *)&unit_size)); + v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx214_ctrl_ops, &props); + ret = ctrl_hdlr->error; if (ret) { v4l2_ctrl_handler_free(ctrl_hdlr);
Obtain rotation and orientation information from system firmware and register the appropriate controls. Signed-off-by: André Apitzsch <git@apitzsch.eu> --- drivers/media/i2c/imx214.c | 7 +++++++ 1 file changed, 7 insertions(+)