diff mbox series

[1/2] media: pci: mgb4: add COMMON_CLK dependency

Message ID 20231023160539.1537355-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] media: pci: mgb4: add COMMON_CLK dependency | expand

Commit Message

Arnd Bergmann Oct. 23, 2023, 4:05 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

This driver fails to build when HAVE_CLK and COMMON_CLK are disabled:

x86_64-linux-ld: vmlinux.o: in function `mgb4_remove':
mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop'
x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister'

Add a Kconfig dependency to enforce a clean build.

Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/media/pci/mgb4/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Martin Tůma Nov. 6, 2023, 10:45 a.m. UTC | #1
On 23. 10. 23 18:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver fails to build when HAVE_CLK and COMMON_CLK are disabled:
> 
> x86_64-linux-ld: vmlinux.o: in function `mgb4_remove':
> mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop'
> x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister'
> 
> Add a Kconfig dependency to enforce a clean build.
> 
> Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/media/pci/mgb4/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig
> index 13fad15a434c..f2a05a1c8ffa 100644
> --- a/drivers/media/pci/mgb4/Kconfig
> +++ b/drivers/media/pci/mgb4/Kconfig
> @@ -2,6 +2,7 @@
>   config VIDEO_MGB4
>   	tristate "Digiteq Automotive MGB4 support"
>   	depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO
> +	depends on COMMON_CLK
>   	select VIDEOBUF2_DMA_SG
>   	select IIO_BUFFER
>   	select IIO_TRIGGERED_BUFFER

Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
diff mbox series

Patch

diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig
index 13fad15a434c..f2a05a1c8ffa 100644
--- a/drivers/media/pci/mgb4/Kconfig
+++ b/drivers/media/pci/mgb4/Kconfig
@@ -2,6 +2,7 @@ 
 config VIDEO_MGB4
 	tristate "Digiteq Automotive MGB4 support"
 	depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO
+	depends on COMMON_CLK
 	select VIDEOBUF2_DMA_SG
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER