| Message ID | 20231127010955.605-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] media: chips-media: Remove surplus dev_err() when using platform_get_irq() | expand |
Hey Yang, Thanks for the patch! The commit subject line should point to the respective driver and you can drop the brackets, so: `media: chips-media: wave5: Remove surplus dev_err when using platform_get_irq` Greetings, Sebastian On 27.11.2023 09:09, Yang Li wrote: >There is no need to call the dev_err() function directly to print a >custom message when handling an error from either the platform_get_irq() >or platform_get_irq_byname() functions as both are going to display an >appropriate error message in case of a failure. > >Reported-by: Abaci Robot <abaci@linux.alibaba.com> >Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7636 >Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >--- > drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c >index bfe4caa79cc9..3f7c622e8d58 100644 >--- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c >+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c >@@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) > > dev->irq = platform_get_irq(pdev, 0); > if (dev->irq < 0) { >- dev_err(&pdev->dev, "failed to get irq resource\n"); > ret = -ENXIO; > goto err_enc_unreg; > } >-- >2.20.1.7.g153144c > >
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c index bfe4caa79cc9..3f7c622e8d58 100644 --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c @@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) dev->irq = platform_get_irq(pdev, 0); if (dev->irq < 0) { - dev_err(&pdev->dev, "failed to get irq resource\n"); ret = -ENXIO; goto err_enc_unreg; }
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7636 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 - 1 file changed, 1 deletion(-)