| Message ID | 20231207120912.270716-3-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Old non-MC-aware drivers have no sub-device state | expand |
Hi Sakari, Thank you for the patch. On Thu, Dec 07, 2023 at 02:09:08PM +0200, Sakari Ailus wrote: > For the purpose of setting old non-pad based sub-device try format as a > basis for VIDIOC_TRY_FMT implementation, there is no need to set the > format in the sub-device state. Drop the assignment to the state, which > would result in a NULL pointer dereference. > > Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/i2c/adv7183.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/adv7183.c b/drivers/media/i2c/adv7183.c > index bcb99ba9a272..2a2cace4a153 100644 > --- a/drivers/media/i2c/adv7183.c > +++ b/drivers/media/i2c/adv7183.c > @@ -442,8 +442,6 @@ static int adv7183_set_fmt(struct v4l2_subdev *sd, > } > if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) > decoder->fmt = *fmt; > - else > - *v4l2_subdev_state_get_format(sd_state, 0) = *fmt; > return 0; > } >
diff --git a/drivers/media/i2c/adv7183.c b/drivers/media/i2c/adv7183.c index bcb99ba9a272..2a2cace4a153 100644 --- a/drivers/media/i2c/adv7183.c +++ b/drivers/media/i2c/adv7183.c @@ -442,8 +442,6 @@ static int adv7183_set_fmt(struct v4l2_subdev *sd, } if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) decoder->fmt = *fmt; - else - *v4l2_subdev_state_get_format(sd_state, 0) = *fmt; return 0; }
For the purpose of setting old non-pad based sub-device try format as a basis for VIDIOC_TRY_FMT implementation, there is no need to set the format in the sub-device state. Drop the assignment to the state, which would result in a NULL pointer dereference. Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/media/i2c/adv7183.c | 2 -- 1 file changed, 2 deletions(-)