| Message ID | 20231231151112.3994194-3-liujianfeng1994@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add hantro g1 video decoder support for RK3588 | expand |
On Sun, Dec 31, 2023 at 11:11:12PM +0800, Jianfeng Liu wrote: > Add Hantro G1 VPU compatible string for RK3588. > RK3588 has the same Hantro G1 ip as RK3568, which are both > known as VDPU121 in TRM of RK3568 and RK3588. > > Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
Am Sonntag, 31. Dezember 2023, 16:11:12 CET schrieb Jianfeng Liu: > Add Hantro G1 VPU compatible string for RK3588. > RK3588 has the same Hantro G1 ip as RK3568, which are both > known as VDPU121 in TRM of RK3568 and RK3588. > > Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index c57e1f488..16886bccf 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -31,6 +31,9 @@ properties: > - items: > - const: rockchip,rk3228-vpu > - const: rockchip,rk3399-vpu > + - items: > + - const: rockchip,rk3588-vpu > + - const: rockchip,rk3568-vpu at least the rk3588 has multiple v{d/e{.}pu blocks, so this compatible is very misleading. As you mention in the commit description already, this describes the vdpu121, so can we please use that in the compatible as well to distinguish this one from the others that hopefully will come later? Thanks Heiko
Hi Heiko, Fri, 15 Mar 2024 13:22:18 +0100, Heiko Stübner wrote: >at least the rk3588 has multiple v{d/e{.}pu blocks, so this compatible >is very misleading. As you mention in the commit description already, >this describes the vdpu121, so can we please use that in the compatible >as well to distinguish this one from the others that hopefully will come >later? Since vpdu121 is in both rk3568 and rk3588, maybe it's better to change rk3568 as well. But rk3568-vpu has been in kernel for a long time so this would be a big change. I will submit v4 with rockchip,rk3588-vdpu121. Regards, Jianfeng
diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml index c57e1f488..16886bccf 100644 --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml @@ -31,6 +31,9 @@ properties: - items: - const: rockchip,rk3228-vpu - const: rockchip,rk3399-vpu + - items: + - const: rockchip,rk3588-vpu + - const: rockchip,rk3568-vpu reg: maxItems: 1
Add Hantro G1 VPU compatible string for RK3588. RK3588 has the same Hantro G1 ip as RK3568, which are both known as VDPU121 in TRM of RK3568 and RK3588. Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com> --- Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 3 +++ 1 file changed, 3 insertions(+)