| Message ID | 20240203-bus_cleanup-media-v1-1-33e8feeab912@marliere.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drivers: media: struct bus_type cleanup | expand |
On Sat, Feb 03, 2024 at 12:31:26PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the cec_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> > --- > drivers/media/cec/core/cec-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hi Ricardo, Thank you for the patch. On Sat, Feb 03, 2024 at 12:31:26PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the cec_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Hans, I assume you'll pick this patch. Could you also pick 2/2 from the series ? > --- > drivers/media/cec/core/cec-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/core/cec-core.c b/drivers/media/cec/core/cec-core.c > index 7e153c5cad04..5a54db839e5d 100644 > --- a/drivers/media/cec/core/cec-core.c > +++ b/drivers/media/cec/core/cec-core.c > @@ -93,7 +93,7 @@ static void cec_devnode_release(struct device *cd) > cec_delete_adapter(to_cec_adapter(devnode)); > } > > -static struct bus_type cec_bus_type = { > +static const struct bus_type cec_bus_type = { > .name = CEC_NAME, > }; >
On 04/02/2024 09:47, Laurent Pinchart wrote: > Hi Ricardo, > > Thank you for the patch. > > On Sat, Feb 03, 2024 at 12:31:26PM -0300, Ricardo B. Marliere wrote: >> Now that the driver core can properly handle constant struct bus_type, >> move the cec_bus_type variable to be a constant structure as well, >> placing it into read-only memory which can not be modified at runtime. >> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Hans, I assume you'll pick this patch. Could you also pick 2/2 from the > series ? Of course! Hans > >> --- >> drivers/media/cec/core/cec-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/cec/core/cec-core.c b/drivers/media/cec/core/cec-core.c >> index 7e153c5cad04..5a54db839e5d 100644 >> --- a/drivers/media/cec/core/cec-core.c >> +++ b/drivers/media/cec/core/cec-core.c >> @@ -93,7 +93,7 @@ static void cec_devnode_release(struct device *cd) >> cec_delete_adapter(to_cec_adapter(devnode)); >> } >> >> -static struct bus_type cec_bus_type = { >> +static const struct bus_type cec_bus_type = { >> .name = CEC_NAME, >> }; >> >
diff --git a/drivers/media/cec/core/cec-core.c b/drivers/media/cec/core/cec-core.c index 7e153c5cad04..5a54db839e5d 100644 --- a/drivers/media/cec/core/cec-core.c +++ b/drivers/media/cec/core/cec-core.c @@ -93,7 +93,7 @@ static void cec_devnode_release(struct device *cd) cec_delete_adapter(to_cec_adapter(devnode)); } -static struct bus_type cec_bus_type = { +static const struct bus_type cec_bus_type = { .name = CEC_NAME, };
Now that the driver core can properly handle constant struct bus_type, move the cec_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/media/cec/core/cec-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)