| Message ID | 20240215204436.9194-2-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: i2c: Add imx283 camera sensor driver | expand |
On Fri, 16 Feb 2024 02:14:34 +0530, Umang Jain wrote: > - Add dt-bindings documentation for Sony IMX283 sensor driver > - Add MAINTAINERS entry for Sony IMX283 binding documentation > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > .../bindings/media/i2c/sony,imx283.yaml | 100 ++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx283.example.dtb: camera@1a: 'vadd-supply', 'vdd1-supply', 'vdd2-supply' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx283.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240215204436.9194-2-umang.jain@ideasonboard.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 15/02/2024 21:44, Umang Jain wrote: > - Add dt-bindings documentation for Sony IMX283 sensor driver > - Add MAINTAINERS entry for Sony IMX283 binding documentation > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- Due to lack of testing limited review. > .../bindings/media/i2c/sony,imx283.yaml | 100 ++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml > new file mode 100644 > index 000000000000..3cf46429b282 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2024 Ideas on Board Oy > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/sony,imx283.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony IMX283 Sensor > + > +maintainers: > + - Kieran Bingham <kieran.bingham@ideasonboard.com> > + - Umang Jain <umang.jain@ideasonboard.com> > + > +description: > + IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active > + array size of 5472H x 3648V. It is programmable through I2C interface. The > + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is > + sent through MIPI CSI-2. > + > +properties: > + compatible: > + const: sony,imx283 Blank line > + reg: > + description: I2C address Drop description > + maxItems: 1 > + > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true Drop all three, not really needed, just mention them in example. > + > + clocks: > + description: Clock frequency from 6 to 24 MHz. > + maxItems: 1 > + > + vana-supply: > + description: Analog power supply (2.9V) > + > + vdig-supply: > + description: Interface power supply (1.8V) > + > + vddl-supply: > + description: Digital power supply (1.2V) > + > + port: > + additionalProperties: false > + $ref: /schemas/graph.yaml#/$defs/port-base Please reverse above lines, first ref, then additionalprops. > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false Ditto > + > + properties: > + data-lanes: true Provide constraints - which lanes/how many. > + link-frequencies: true > + > + required: > + - data-lanes > + - link-frequencies > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - port > + > +additionalProperties: false > + Best regards, Krzysztof
Hi Krzysztof, Umang, On Fri, Feb 16, 2024 at 09:03:49AM +0100, Krzysztof Kozlowski wrote: > > + properties: > > + data-lanes: true > > Provide constraints - which lanes/how many. Very probably only the number matters on this device. Therefore minimum and maximum should suffice. (Or an enum. 3 is probably an invalid number of lanes here, too.)
Quoting Sakari Ailus (2024-02-16 09:23:50) > Hi Krzysztof, Umang, > > On Fri, Feb 16, 2024 at 09:03:49AM +0100, Krzysztof Kozlowski wrote: > > > + properties: > > > + data-lanes: true > > > > Provide constraints - which lanes/how many. > > Very probably only the number matters on this device. Therefore minimum and > maximum should suffice. (Or an enum. 3 is probably an invalid number of > lanes here, too.) I think we can only support 4 lanes here. I heard rumour that it 'might' be possible to support 2 lanes, but I haven't seen any documentation for that and I don't think it's likely expected to be supported. -- Kieran > > -- > Kind regards, > > Sakari Ailus > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml new file mode 100644 index 000000000000..3cf46429b282 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2024 Ideas on Board Oy +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/sony,imx283.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony IMX283 Sensor + +maintainers: + - Kieran Bingham <kieran.bingham@ideasonboard.com> + - Umang Jain <umang.jain@ideasonboard.com> + +description: + IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active + array size of 5472H x 3648V. It is programmable through I2C interface. The + I2C client address is fixed to 0x1a as per sensor data sheet. Image data is + sent through MIPI CSI-2. + +properties: + compatible: + const: sony,imx283 + reg: + description: I2C address + maxItems: 1 + + assigned-clocks: true + assigned-clock-parents: true + assigned-clock-rates: true + + clocks: + description: Clock frequency from 6 to 24 MHz. + maxItems: 1 + + vana-supply: + description: Analog power supply (2.9V) + + vdig-supply: + description: Interface power supply (1.8V) + + vddl-supply: + description: Digital power supply (1.2V) + + port: + additionalProperties: false + $ref: /schemas/graph.yaml#/$defs/port-base + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: true + link-frequencies: true + + required: + - data-lanes + - link-frequencies + + required: + - endpoint + +required: + - compatible + - reg + - clocks + - port + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + camera@1a { + compatible = "sony,imx283"; + reg = <0x1a>; + clocks = <&imx283_clk>; + + assigned-clocks = <&imx283_clk>; + assigned-clock-parents = <&imx283_clk_parent>; + assigned-clock-rates = <12000000>; + + vadd-supply = <&camera_vadd_2v9>; + vdd1-supply = <&camera_vdd1_1v8>; + vdd2-supply = <&camera_vdd2_1v2>; + + port { + imx283: endpoint { + remote-endpoint = <&cam>; + data-lanes = <1 2 3 4>; + link-frequencies = /bits/ 64 <360000000>; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 8999497011a2..53df4b6e3260 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20366,6 +20366,14 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml F: drivers/media/i2c/imx274.c +SONY IMX283 SENSOR DRIVER +M: Kieran Bingham <kieran.bingham@ideasonboard.com> +M: Umang Jain <umang.jain@ideasonboard.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml + SONY IMX290 SENSOR DRIVER M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> L: linux-media@vger.kernel.org
- Add dt-bindings documentation for Sony IMX283 sensor driver - Add MAINTAINERS entry for Sony IMX283 binding documentation Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- .../bindings/media/i2c/sony,imx283.yaml | 100 ++++++++++++++++++ MAINTAINERS | 8 ++ 2 files changed, 108 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml