| Message ID | 20240225155359.41435-1-bergh.jonathan@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: media: atomisp: Fix formatting issues and minor code issue | expand |
Hi Jonathan, On 2/25/24 16:53, Jonathan Bergh wrote: > This patch fixes the following code style and formatting issues: > * Ensure multiline block comments are correctly formatted > * Remove extra braces not required for single line conditional statements > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> (I'll apply this to my atomisp-branch the next time I'm working on that branch). Regards, Hans > --- > drivers/staging/media/atomisp/pci/atomisp_drvfs.c | 2 +- > drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 +++---- > drivers/staging/media/atomisp/pci/atomisp_subdev.c | 3 ++- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp_drvfs.c > index 1df534bf54d3..8ef25d2f8b87 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_drvfs.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_drvfs.c > @@ -34,7 +34,7 @@ > * bit 0: binary list > * bit 1: running binary > * bit 2: memory statistic > -*/ > + */ > struct _iunit_debug { > struct device_driver *drv; > struct atomisp_device *isp; > diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > index 139ad7ad1dcf..804ffff245f3 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c > @@ -1416,13 +1416,12 @@ static int gmin_get_config_var(struct device *maindev, > if (efi_rt_services_supported(EFI_RT_SUPPORTED_GET_VARIABLE)) > status = efi.get_variable(var16, &GMIN_CFG_VAR_EFI_GUID, NULL, > (unsigned long *)out_len, out); > - if (status == EFI_SUCCESS) { > + if (status == EFI_SUCCESS) > dev_info(maindev, "found EFI entry for '%s'\n", var8); > - } else if (is_gmin) { > + else if (is_gmin) > dev_info(maindev, "Failed to find EFI gmin variable %s\n", var8); > - } else { > + else > dev_info(maindev, "Failed to find EFI variable %s\n", var8); > - } > > return ret; > } > diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c > index a87fc74159e2..f8efaef2c055 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c > @@ -394,7 +394,8 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd, > * (of the desired captured image before > * scaling, or 1 / 6 of what we get from the > * sensor) in both width and height. Remove > - * it. */ > + * it. > + */ > crop[pad]->width = roundup(crop[pad]->width * 5 / 6, > ATOM_ISP_STEP_WIDTH); > crop[pad]->height = roundup(crop[pad]->height * 5 / 6,
diff --git a/drivers/staging/media/atomisp/pci/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp_drvfs.c index 1df534bf54d3..8ef25d2f8b87 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_drvfs.c +++ b/drivers/staging/media/atomisp/pci/atomisp_drvfs.c @@ -34,7 +34,7 @@ * bit 0: binary list * bit 1: running binary * bit 2: memory statistic -*/ + */ struct _iunit_debug { struct device_driver *drv; struct atomisp_device *isp; diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c index 139ad7ad1dcf..804ffff245f3 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c @@ -1416,13 +1416,12 @@ static int gmin_get_config_var(struct device *maindev, if (efi_rt_services_supported(EFI_RT_SUPPORTED_GET_VARIABLE)) status = efi.get_variable(var16, &GMIN_CFG_VAR_EFI_GUID, NULL, (unsigned long *)out_len, out); - if (status == EFI_SUCCESS) { + if (status == EFI_SUCCESS) dev_info(maindev, "found EFI entry for '%s'\n", var8); - } else if (is_gmin) { + else if (is_gmin) dev_info(maindev, "Failed to find EFI gmin variable %s\n", var8); - } else { + else dev_info(maindev, "Failed to find EFI variable %s\n", var8); - } return ret; } diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp/pci/atomisp_subdev.c index a87fc74159e2..f8efaef2c055 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_subdev.c +++ b/drivers/staging/media/atomisp/pci/atomisp_subdev.c @@ -394,7 +394,8 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd, * (of the desired captured image before * scaling, or 1 / 6 of what we get from the * sensor) in both width and height. Remove - * it. */ + * it. + */ crop[pad]->width = roundup(crop[pad]->width * 5 / 6, ATOM_ISP_STEP_WIDTH); crop[pad]->height = roundup(crop[pad]->height * 5 / 6,
This patch fixes the following code style and formatting issues: * Ensure multiline block comments are correctly formatted * Remove extra braces not required for single line conditional statements Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp_drvfs.c | 2 +- drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 +++---- drivers/staging/media/atomisp/pci/atomisp_subdev.c | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-)