| Message ID | 20240313070705.91140-1-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hello, Ping for review and also the streams API streams_mask issue mentioned below. Is anyone interested in looking at this particular issue? On 13/03/24 12:36 pm, Umang Jain wrote: > Add a v4l2 subdevice driver for the Sony IMX283 image sensor. > > The IMX283 is a 20MP Diagonal 15.86 mm (Type 1) CMOS Image Sensor with > Square Pixel for Color Cameras. > > The following features are supported: > - Manual exposure an gain control support > - vblank/hblank/link freq control support > - Test pattern support control > - Arbitrary horizontal and vertical cropping > - Supported resolution: > - 5472x3648 @ 20fps (SRGGB12) > - 5472x3648 @ 25fps (SRGGB10) > - 2736x1824 @ 50fps (SRGGB12) > > The driver is tested on mainline branch v6.8-rc2 on IMX8MP Debix-SOM-A. > Additional testing has been done on RPi5 with the downstream BSP. > > Changes in v3: > - fix headers includes > - Improve #define(s) readability > - Drop __func__ from error logs > - Use HZ_PER_MHZ instead of MEGA > - mdsel* variables should be u8 > - Use container_of_const() instead of container_of() > - Use clamp() used of clamp_t variant > - Use streams API imx283_{enable|disable}_streams (**NOTE**) > - Properly fix PM runtime handling > (pm_ptr(), DEFINE_RUNTIME_DEV_PM_OPS, > imx283_runtime_suspend, imx283_runtime_resume) > - Fix format modifiers, signed-ness at various places > > > **NOTE** > There is streams mask issue, as no routes are defined with 1 pad: > For testing, I have the following applied locally: > ``` > diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c > index 4c6198c48dd6..38545d779620 100644 > --- a/drivers/media/v4l2-core/v4l2-subdev.c > +++ b/drivers/media/v4l2-core/v4l2-subdev.c > @@ -2115,8 +2115,10 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad, > if (pad >= sd->entity.num_pads) > return -EINVAL; > > - if (!streams_mask) > - return 0; > + if (!streams_mask) { > + dev_err(sd->dev, "no streams mask, returning ....\n"); > + //return 0; > + } > > /* Fallback on .s_stream() if .enable_streams() isn't available. */ > if (!sd->ops->pad || !sd->ops->pad->enable_streams) > ``` > > changes in v2 (summary): > - Use u32 wherever possible > - Use MEGA macro instead of self defined MHZ() macro > - Properly refine regs using CCI > - Drop tracking of current mode. Shifted to infer from active state directly. > (Laurent's review) > - Cont. from above: Pass the struct imx283_mode to functions whereever required. > - Remove unused comments > - Remove custom mutex. Use control handler one instead. > - Drop imx283_reset_colorspace() and inline > - Set colorspace field properly (drop _DEFAULTS) > - Use __maybe_unused for imx283_power_on() and imx283_power_off() > - Store controls v4l2_ctrl handles for those required, not all. > - Drop imx283_free_controls(). Use v4l2_ctrl_handler_free > - fix reset-gpios handling and add it to DT schema > - fix data-lanes property in DT schema > - fix IMX283 Kconfig > - Remove unused macros > - Alphabetical case consistency > > Kieran Bingham (1): > media: i2c: Add imx283 camera sensor driver > > Umang Jain (1): > media: dt-bindings: media: Add bindings for IMX283 > > .../bindings/media/i2c/sony,imx283.yaml | 107 ++ > MAINTAINERS | 9 + > drivers/media/i2c/Kconfig | 10 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx283.c | 1596 +++++++++++++++++ > 5 files changed, 1723 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml > create mode 100644 drivers/media/i2c/imx283.c >
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 4c6198c48dd6..38545d779620 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -2115,8 +2115,10 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad, if (pad >= sd->entity.num_pads) return -EINVAL; - if (!streams_mask) - return 0; + if (!streams_mask) { + dev_err(sd->dev, "no streams mask, returning ....\n"); + //return 0; + } /* Fallback on .s_stream() if .enable_streams() isn't available. */ if (!sd->ops->pad || !sd->ops->pad->enable_streams)
Add a v4l2 subdevice driver for the Sony IMX283 image sensor. The IMX283 is a 20MP Diagonal 15.86 mm (Type 1) CMOS Image Sensor with Square Pixel for Color Cameras. The following features are supported: - Manual exposure an gain control support - vblank/hblank/link freq control support - Test pattern support control - Arbitrary horizontal and vertical cropping - Supported resolution: - 5472x3648 @ 20fps (SRGGB12) - 5472x3648 @ 25fps (SRGGB10) - 2736x1824 @ 50fps (SRGGB12) The driver is tested on mainline branch v6.8-rc2 on IMX8MP Debix-SOM-A. Additional testing has been done on RPi5 with the downstream BSP. Changes in v3: - fix headers includes - Improve #define(s) readability - Drop __func__ from error logs - Use HZ_PER_MHZ instead of MEGA - mdsel* variables should be u8 - Use container_of_const() instead of container_of() - Use clamp() used of clamp_t variant - Use streams API imx283_{enable|disable}_streams (**NOTE**) - Properly fix PM runtime handling (pm_ptr(), DEFINE_RUNTIME_DEV_PM_OPS, imx283_runtime_suspend, imx283_runtime_resume) - Fix format modifiers, signed-ness at various places **NOTE** There is streams mask issue, as no routes are defined with 1 pad: For testing, I have the following applied locally: ``` ``` changes in v2 (summary): - Use u32 wherever possible - Use MEGA macro instead of self defined MHZ() macro - Properly refine regs using CCI - Drop tracking of current mode. Shifted to infer from active state directly. (Laurent's review) - Cont. from above: Pass the struct imx283_mode to functions whereever required. - Remove unused comments - Remove custom mutex. Use control handler one instead. - Drop imx283_reset_colorspace() and inline - Set colorspace field properly (drop _DEFAULTS) - Use __maybe_unused for imx283_power_on() and imx283_power_off() - Store controls v4l2_ctrl handles for those required, not all. - Drop imx283_free_controls(). Use v4l2_ctrl_handler_free - fix reset-gpios handling and add it to DT schema - fix data-lanes property in DT schema - fix IMX283 Kconfig - Remove unused macros - Alphabetical case consistency Kieran Bingham (1): media: i2c: Add imx283 camera sensor driver Umang Jain (1): media: dt-bindings: media: Add bindings for IMX283 .../bindings/media/i2c/sony,imx283.yaml | 107 ++ MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/imx283.c | 1596 +++++++++++++++++ 5 files changed, 1723 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml create mode 100644 drivers/media/i2c/imx283.c