From patchwork Thu Mar 14 09:36:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 13592274 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C78122D629; Thu, 14 Mar 2024 09:37:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710409070; cv=none; b=mPuShEMdQFclEMLrCzD+IMHaRvSdjZUxXKBytkZP22yKDWmCpNnIlrUT+DM7oOXGN9jYwvkfBirG65ywiNX+PFMmzfhdKmR7qUo+KsZ+mi01qOa7tVIjFQ2eJRuP1PKIDyOUf7jV39jib+RQn9RMQ71faIDDsar9CsUMhImOtwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710409070; c=relaxed/simple; bh=EwMvKgGe1CCgKNeMgTrUggt9oO1B36dsyMycZ7GH2ww=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GlF+W8l209JMn6tbWB9odudlL2L3q+Vv1JS2XBTP1/1nK8ZHwH7l2J12UDX0azNZ1dqz6hlFrOfbGOvlr4f2egaPzX6QGQX/OQ71+cJv5pxzBKCG6hQdCownhghPUMQtx8If38LPZGi70uwZVgagOlLtCbctO3tAAPyLm4HiNHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=RurdlDfh; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RurdlDfh" Received: from jasper.fritz.box (unknown [IPv6:2a00:6020:448c:6c00:c467:7cd1:67a9:bc4c]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 76F4F675; Thu, 14 Mar 2024 10:37:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1710409043; bh=EwMvKgGe1CCgKNeMgTrUggt9oO1B36dsyMycZ7GH2ww=; h=From:To:Cc:Subject:Date:From; b=RurdlDfhJHS1P8CFseVq5+ZP+KzX5fJZfDMgeKSOTEdwpLjLLcaic/CZ1gWSx31XM PCYIjoQw9ijd425qDTYhfXltbaHFV8otQp27Xel1nn/5pY52lMBfOvU2guwfNYLDAf Mu1QwnQDmTYt+CauGrnvW09bc40LCoAnqkdgjMt0= From: Stefan Klug To: libcamera-devel@lists.libcamera.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Stefan Klug , Laurent Pinchart , Jacopo Mondi , Umang Jain , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH v2] media: mipi-csis: Emit V4L2_EVENT_FRAME_SYNC events Date: Thu, 14 Mar 2024 10:36:50 +0100 Message-Id: <20240314093652.56923-1-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The Samsung CSIS MIPI receiver provides a start-of-frame interrupt and a framecount register. As the CSI receiver is the hardware unit that lies closest to the sensor, the frame counter is the best we can get on these devices. In case of the ISI available on the i.MX8 M Plus it is also the only native start-of-frame signal available. This patch exposes the sof interrupt and the framecount as V4L2_EVENT_FRAME_SYNC event on the subdevice. It was tested on a Debix-Som-A with a 6.8-rc4 kernel. Reviewed-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Umang Jain Signed-off-by: Stefan Klug --- Changes v1 -> v2: - fixed formatting issues from review - moved frame variable declaration to top of subscribe_event() Thanks all for the review! drivers/media/platform/nxp/imx-mipi-csis.c | 34 +++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c index db8ff5f5c4d3..664be27c4224 100644 --- a/drivers/media/platform/nxp/imx-mipi-csis.c +++ b/drivers/media/platform/nxp/imx-mipi-csis.c @@ -30,6 +30,7 @@ #include #include +#include #include #include #include @@ -742,6 +743,18 @@ static void mipi_csis_stop_stream(struct mipi_csis_device *csis) mipi_csis_system_enable(csis, false); } +static void mipi_csis_queue_event_sof(struct mipi_csis_device *csis) +{ + u32 frame; + struct v4l2_event event = { + .type = V4L2_EVENT_FRAME_SYNC, + }; + + frame = mipi_csis_read(csis, MIPI_CSIS_FRAME_COUNTER_CH(0)); + event.u.frame_sync.frame_sequence = frame; + v4l2_event_queue(csis->sd.devnode, &event); +} + static irqreturn_t mipi_csis_irq_handler(int irq, void *dev_id) { struct mipi_csis_device *csis = dev_id; @@ -765,6 +778,10 @@ static irqreturn_t mipi_csis_irq_handler(int irq, void *dev_id) event->counter++; } } + + if (status & MIPI_CSIS_INT_SRC_FRAME_START) + mipi_csis_queue_event_sof(csis); + spin_unlock_irqrestore(&csis->slock, flags); mipi_csis_write(csis, MIPI_CSIS_INT_SRC, status); @@ -1154,8 +1171,23 @@ static int mipi_csis_log_status(struct v4l2_subdev *sd) return 0; } +static int mipi_csis_subscribe_event(struct v4l2_subdev *sd, struct v4l2_fh *fh, + struct v4l2_event_subscription *sub) +{ + if (sub->type != V4L2_EVENT_FRAME_SYNC) + return -EINVAL; + + /* V4L2_EVENT_FRAME_SYNC doesn't require an id, so zero should be set */ + if (sub->id != 0) + return -EINVAL; + + return v4l2_event_subscribe(fh, sub, 0, NULL); +} + static const struct v4l2_subdev_core_ops mipi_csis_core_ops = { .log_status = mipi_csis_log_status, + .subscribe_event = mipi_csis_subscribe_event, + .unsubscribe_event = v4l2_event_subdev_unsubscribe, }; static const struct v4l2_subdev_video_ops mipi_csis_video_ops = { @@ -1358,7 +1390,7 @@ static int mipi_csis_subdev_init(struct mipi_csis_device *csis) snprintf(sd->name, sizeof(sd->name), "csis-%s", dev_name(csis->dev)); - sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS; sd->ctrl_handler = NULL; sd->entity.function = MEDIA_ENT_F_VID_IF_BRIDGE;