diff mbox series

media: videobuf2: core: Drop unneeded forward declaration

Message ID 20240505174033.9163-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State New
Headers show
Series media: videobuf2: core: Drop unneeded forward declaration | expand

Commit Message

Laurent Pinchart May 5, 2024, 5:40 p.m. UTC 
The static __enqueue_in_driver() function is forward-declared
needlessly, as it isn't called before its definition. Drop the forward
declaration.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/common/videobuf2/videobuf2-core.c | 1 -
 1 file changed, 1 deletion(-)


base-commit: e695668af8523b059127dfa8b261c76e7c9cde10

Comments

Tomasz Figa May 7, 2024, 5:48 a.m. UTC | #1 
On Mon, May 6, 2024 at 2:40 AM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> The static __enqueue_in_driver() function is forward-declared
> needlessly, as it isn't called before its definition. Drop the forward
> declaration.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Tomasz Figa <tfiga@chromium.org>

Best,
Tomasz

> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 358f1fe42975..0217392fcc0d 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -199,7 +199,6 @@ module_param(debug, int, 0644);
>  })
>
>  static void __vb2_queue_cancel(struct vb2_queue *q);
> -static void __enqueue_in_driver(struct vb2_buffer *vb);
>
>  static const char *vb2_state_name(enum vb2_buffer_state s)
>  {
>
> base-commit: e695668af8523b059127dfa8b261c76e7c9cde10
> --
> Regards,
>
> Laurent Pinchart
>
diff mbox series

Patch

diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
index 358f1fe42975..0217392fcc0d 100644
--- a/drivers/media/common/videobuf2/videobuf2-core.c
+++ b/drivers/media/common/videobuf2/videobuf2-core.c
@@ -199,7 +199,6 @@  module_param(debug, int, 0644);
 })
 
 static void __vb2_queue_cancel(struct vb2_queue *q);
-static void __enqueue_in_driver(struct vb2_buffer *vb);
 
 static const char *vb2_state_name(enum vb2_buffer_state s)
 {