| Message ID | 20240524140024.161313-8-jacopo.mondi@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: raspberrypi: Add support for PiSP Back End | expand |
Hi Jacppo, Thanks for the update. A few comments on the driver itself... On Fri, May 24, 2024 at 04:00:22PM +0200, Jacopo Mondi wrote: > From: Naushir Patuck <naush@raspberrypi.com> > > Add support for the Raspberry Pi PiSP Back End. > > The driver has been upported from the Raspberry Pi kernel at revision > f74893f8a0c2 ("drivers: media: pisp_be: Update seqeuence numbers of the > buffers"). > > The ISP documentation is available at: > https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.org> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > MAINTAINERS | 1 + > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/raspberrypi/Kconfig | 5 + > drivers/media/platform/raspberrypi/Makefile | 3 + > .../platform/raspberrypi/pisp_be/Kconfig | 12 + > .../platform/raspberrypi/pisp_be/Makefile | 6 + > .../platform/raspberrypi/pisp_be/pisp_be.c | 1848 +++++++++++++++++ > .../raspberrypi/pisp_be/pisp_be_formats.h | 519 +++++ > 9 files changed, 2396 insertions(+) > create mode 100644 drivers/media/platform/raspberrypi/Kconfig > create mode 100644 drivers/media/platform/raspberrypi/Makefile > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Kconfig > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Makefile > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index ba595fad2fb5..6790e5d8fbe2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18522,6 +18522,7 @@ L: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com> > L: linux-media@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml > +F: drivers/media/platform/raspberrypi/pisp_be/ > F: include/uapi/linux/media/raspberrypi/ > > RC-CORE / LIRC FRAMEWORK > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 2d79bfc68c15..36353174a7d9 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -78,6 +78,7 @@ source "drivers/media/platform/nuvoton/Kconfig" > source "drivers/media/platform/nvidia/Kconfig" > source "drivers/media/platform/nxp/Kconfig" > source "drivers/media/platform/qcom/Kconfig" > +source "drivers/media/platform/raspberrypi/Kconfig" > source "drivers/media/platform/renesas/Kconfig" > source "drivers/media/platform/rockchip/Kconfig" > source "drivers/media/platform/samsung/Kconfig" > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index da17301f7439..4b04c51bdd8b 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -21,6 +21,7 @@ obj-y += nuvoton/ > obj-y += nvidia/ > obj-y += nxp/ > obj-y += qcom/ > +obj-y += raspberrypi/ > obj-y += renesas/ > obj-y += rockchip/ > obj-y += samsung/ > diff --git a/drivers/media/platform/raspberrypi/Kconfig b/drivers/media/platform/raspberrypi/Kconfig > new file mode 100644 > index 000000000000..e928f979019e > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/Kconfig > @@ -0,0 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +comment "Raspberry Pi media platform drivers" > + > +source "drivers/media/platform/raspberrypi/pisp_be/Kconfig" > diff --git a/drivers/media/platform/raspberrypi/Makefile b/drivers/media/platform/raspberrypi/Makefile > new file mode 100644 > index 000000000000..c0d1a2dab486 > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +obj-y += pisp_be/ > diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > new file mode 100644 > index 000000000000..d88e66d5c334 > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > @@ -0,0 +1,12 @@ > +config VIDEO_RASPBERRYPI_PISP_BE > + tristate "Raspberry Pi PiSP Backend (BE) ISP driver" > + depends on V4L_PLATFORM_DRIVERS > + depends on VIDEO_DEV && PM > + select VIDEO_V4L2_SUBDEV_API > + select MEDIA_CONTROLLER > + select VIDEOBUF2_DMA_CONTIG > + help > + Say Y here to enable support for the PiSP Backend (BE) ISP driver. > + > + To compile this driver as a module, choose M here. The module will be > + called pisp-be. > diff --git a/drivers/media/platform/raspberrypi/pisp_be/Makefile b/drivers/media/platform/raspberrypi/pisp_be/Makefile > new file mode 100644 > index 000000000000..a70bf5716824 > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/pisp_be/Makefile > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for Raspberry Pi PiSP Backend driver > +# > +pisp-be-objs := pisp_be.o > +obj-$(CONFIG_VIDEO_RASPBERRYPI_PISP_BE) += pisp-be.o > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > new file mode 100644 > index 000000000000..c4d13462eb81 > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > @@ -0,0 +1,1848 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * PiSP Back End driver. > + * Copyright (c) 2021-2024 Raspberry Pi Limited. > + * > + */ > +#include <linux/clk.h> > +#include <linux/interrupt.h> > +#include <linux/io.h> > +#include <linux/kernel.h> > +#include <linux/lockdep.h> > +#include <linux/media/raspberrypi/pisp_be_config.h> Where is the header included from? If it's just this driver, then I'd put it in the driver's directory. > +#include <linux/module.h> > +#include <linux/platform_device.h> > +#include <linux/pm_runtime.h> > +#include <media/v4l2-device.h> > +#include <media/v4l2-ioctl.h> > +#include <media/videobuf2-dma-contig.h> > +#include <media/videobuf2-vmalloc.h> > + > +#include "pisp_be_formats.h" > + > +/* Maximum number of config buffers possible */ > +#define PISP_BE_NUM_CONFIG_BUFFERS VB2_MAX_FRAME > + > +/* > + * We want to support 2 independent instances allowing 2 simultaneous users > + * of the ISP-BE (of course they share hardware, platform resources and mutex). > + * Each such instance comprises a group of device nodes representing input > + * and output queues, and a media controller device node to describe them. > + */ > +#define PISPBE_NUM_NODE_GROUPS 2 While MC and V4L2 don't have a good support for contexts currently, just duplicating the device nodes is a really poor solution. We should do better than that. If we merge this, where is the limit in the number of contexts? Is it 4? 8? Or when we run out of minor numbers? One API-based solution could be moving the IOCTL interface to MC device node only. This wouldn't be a small change so I'm not proposing doing that now. The two short term alternatives I can think of are: - Merge the driver with one set of device nodes. Once the better APIs are available, move to use those. - Merge the driver to the staging tree. I'm not very eager to go this route as the drivers simply end up being abandoned in the staging tree. Work to get the driver out of staging should continue. Perhaps the upside here is that this isn't the only device that would benefit from better context support in MC/V4L2 so multiple parties have incentives to have this matter addressed. > + > +#define PISPBE_NAME "pispbe" > + > +/* Some ISP-BE registers */ > +#define PISP_BE_VERSION_REG 0x0 > +#define PISP_BE_CONTROL_REG 0x4 > +#define PISP_BE_CONTROL_COPY_CONFIG BIT(1) > +#define PISP_BE_CONTROL_QUEUE_JOB BIT(0) > +#define PISP_BE_CONTROL_NUM_TILES(n) ((n) << 16) > +#define PISP_BE_TILE_ADDR_LO_REG 0x8 > +#define PISP_BE_TILE_ADDR_HI_REG 0xc > +#define PISP_BE_STATUS_REG 0x10 > +#define PISP_BE_STATUS_QUEUED BIT(0) > +#define PISP_BE_BATCH_STATUS_REG 0x14 > +#define PISP_BE_INTERRUPT_EN_REG 0x18 > +#define PISP_BE_INTERRUPT_STATUS_REG 0x1c > +#define PISP_BE_AXI_REG 0x20 > +#define PISP_BE_CONFIG_BASE_REG 0x40 > +#define PISP_BE_IO_ADDR_LOW(n) (PISP_BE_CONFIG_BASE_REG + 8 * (n)) > +#define PISP_BE_IO_ADDR_HIGH(n) (PISP_BE_IO_ADDR_LOW((n)) + 4) > +#define PISP_BE_GLOBAL_BAYER_ENABLE 0xb0 > +#define PISP_BE_GLOBAL_RGB_ENABLE 0xb4 > +#define N_HW_ADDRESSES 13 > +#define N_HW_ENABLES 2 > + > +#define PISP_BE_VERSION_2712 0x02252700 > +#define PISP_BE_VERSION_MINOR_BITS 0xf > + > +/* > + * This maps our nodes onto the inputs/outputs of the actual PiSP Back End. > + * Be wary of the word "OUTPUT" which is used ambiguously here. In a V4L2 > + * context it means an input to the hardware (source image or metadata). > + * Elsewhere it means an output from the hardware. > + */ > +enum pispbe_node_ids { > + MAIN_INPUT_NODE, > + TDN_INPUT_NODE, > + STITCH_INPUT_NODE, > + OUTPUT0_NODE, > + OUTPUT1_NODE, > + TDN_OUTPUT_NODE, > + STITCH_OUTPUT_NODE, > + CONFIG_NODE, > + PISPBE_NUM_NODES > +}; > + > +struct pispbe_node_description { > + const char *ent_name; > + enum v4l2_buf_type buf_type; > + unsigned int caps; > +}; > + > +static const struct pispbe_node_description node_desc[PISPBE_NUM_NODES] = { > + /* MAIN_INPUT_NODE */ > + { > + .ent_name = PISPBE_NAME "-input", > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > + }, > + /* TDN_INPUT_NODE */ > + { > + .ent_name = PISPBE_NAME "-tdn_input", > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > + }, > + /* STITCH_INPUT_NODE */ > + { > + .ent_name = PISPBE_NAME "-stitch_input", > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > + }, > + /* OUTPUT0_NODE */ > + { > + .ent_name = PISPBE_NAME "-output0", > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > + }, > + /* OUTPUT1_NODE */ > + { > + .ent_name = PISPBE_NAME "-output1", > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > + }, > + /* TDN_OUTPUT_NODE */ > + { > + .ent_name = PISPBE_NAME "-tdn_output", > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > + }, > + /* STITCH_OUTPUT_NODE */ > + { > + .ent_name = PISPBE_NAME "-stitch_output", > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > + }, > + /* CONFIG_NODE */ > + { > + .ent_name = PISPBE_NAME "-config", > + .buf_type = V4L2_BUF_TYPE_META_OUTPUT, > + .caps = V4L2_CAP_META_OUTPUT, > + } > +}; > + > +#define NODE_DESC_IS_OUTPUT(desc) ( \ > + ((desc)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ > + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ > + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) > + > +#define NODE_IS_META(node) ( \ > + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT)) > +#define NODE_IS_OUTPUT(node) ( \ > + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) > +#define NODE_IS_CAPTURE(node) ( \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE) || \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) > +#define NODE_IS_MPLANE(node) ( \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) || \ > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) > + > +/* > + * Structure to describe a single node /dev/video<N> which represents a single > + * input or output queue to the PiSP Back End device. > + */ > +struct pispbe_node { > + unsigned int id; > + int vfl_dir; > + enum v4l2_buf_type buf_type; > + struct video_device vfd; > + struct media_pad pad; > + struct media_intf_devnode *intf_devnode; > + struct media_link *intf_link; > + struct pispbe_node_group *node_group; > + /* Video device lock */ > + struct mutex node_lock; > + /* vb2_queue lock */ > + struct mutex queue_lock; > + /* Protect pispbe_node->ready_queue and pispbe_buffer->ready_list */ > + spinlock_t ready_lock; > + struct list_head ready_queue; > + struct vb2_queue queue; > + struct v4l2_format format; > + const struct pisp_be_format *pisp_format; > +}; > + > +/* For logging only, use the entity name with "pispbe" and separator removed */ > +#define NODE_NAME(node) \ > + (node_desc[(node)->id].ent_name + sizeof(PISPBE_NAME)) > + > +/* > + * Node group structure, which comprises all the input and output nodes that a > + * single PiSP client will need, along with its own v4l2 and media devices. > + */ > +struct pispbe_node_group { > + unsigned int id; > + struct v4l2_device v4l2_dev; > + struct v4l2_subdev sd; > + struct pispbe_dev *pispbe; > + struct media_device mdev; > + struct pispbe_node node[PISPBE_NUM_NODES]; > + u32 streaming_map; /* bitmap of which nodes are streaming */ > + struct media_pad pad[PISPBE_NUM_NODES]; /* output pads first */ > + struct pisp_be_tiles_config *config; > + dma_addr_t config_dma_addr; > + unsigned int sequence; > +}; > + > +/* Records details of the jobs currently running or queued on the h/w. */ > +struct pispbe_job { > + struct pispbe_node_group *node_group; > + /* > + * An array of buffer pointers - remember it's source buffers first, > + * then captures, then metadata last. > + */ > + struct pispbe_buffer *buf[PISPBE_NUM_NODES]; > +}; > + > +/* Records a job configuration and memory addresses. */ > +struct pispbe_job_descriptor { > + dma_addr_t hw_dma_addrs[N_HW_ADDRESSES]; > + struct pisp_be_tiles_config *config; > + u32 hw_enables[N_HW_ENABLES]; > + dma_addr_t tiles; > +}; > + > +/* > + * Structure representing the entire PiSP Back End device, comprising several > + * node groups which share platform resources and a mutex for the actual HW. > + */ > +struct pispbe_dev { > + struct device *dev; > + struct pispbe_node_group node_group[PISPBE_NUM_NODE_GROUPS]; > + int hw_busy; /* non-zero if a job is queued or is being started */ You could sort the 32-bit field with the rest of the non-64-bit fields below. > + struct pispbe_job queued_job, running_job; > + void __iomem *be_reg_base; > + struct clk *clk; > + int irq; > + u32 hw_version; > + u8 done, started; > + spinlock_t hw_lock; /* protects "hw_busy" flag and streaming_map */ > +}; > + > +static u32 pispbe_rd(struct pispbe_dev *pispbe, unsigned int offset) > +{ > + return readl(pispbe->be_reg_base + offset); > +} > + > +static void pispbe_wr(struct pispbe_dev *pispbe, unsigned int offset, u32 val) > +{ > + writel(val, pispbe->be_reg_base + offset); > +} > + > +/* > + * Queue a job to the h/w. If the h/w is idle it will begin immediately. > + * Caller must ensure it is "safe to queue", i.e. we don't already have a > + * queued, unstarted job. > + */ > +static void pispbe_queue_job(struct pispbe_dev *pispbe, > + struct pispbe_job_descriptor *job) > +{ > + unsigned int begin, end; > + > + if (pispbe_rd(pispbe, PISP_BE_STATUS_REG) & PISP_BE_STATUS_QUEUED) > + dev_err(pispbe->dev, "ERROR: not safe to queue new job!\n"); > + > + /* > + * Write configuration to hardware. DMA addresses and enable flags > + * are passed separately, because the driver needs to sanitize them, > + * and we don't want to modify (or be vulnerable to modifications of) > + * the mmap'd buffer. > + */ > + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { > + pispbe_wr(pispbe, PISP_BE_IO_ADDR_LOW(u), > + lower_32_bits(job->hw_dma_addrs[u])); > + pispbe_wr(pispbe, PISP_BE_IO_ADDR_HIGH(u), > + upper_32_bits(job->hw_dma_addrs[u])); > + } > + pispbe_wr(pispbe, PISP_BE_GLOBAL_BAYER_ENABLE, job->hw_enables[0]); > + pispbe_wr(pispbe, PISP_BE_GLOBAL_RGB_ENABLE, job->hw_enables[1]); > + > + /* Everything else is as supplied by the user. */ > + begin = offsetof(struct pisp_be_config, global.bayer_order) > + / sizeof(u32); The slash should be on the previous line. Same elsewhere. > + end = sizeof(struct pisp_be_config) / sizeof(u32); > + for (unsigned int u = begin; u < end; u++) > + pispbe_wr(pispbe, PISP_BE_CONFIG_BASE_REG + 4 * u, s/4/sizeof(u32)/ > + ((u32 *)job->config)[u]); > + > + /* Read back the addresses -- an error here could be fatal */ > + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { > + unsigned int offset = PISP_BE_IO_ADDR_LOW(u); > + u64 along = pispbe_rd(pispbe, offset); > + > + along += ((u64)pispbe_rd(pispbe, offset + 4)) << 32; > + if (along != (u64)(job->hw_dma_addrs[u])) { > + dev_dbg(pispbe->dev, > + "ISP BE config error: check if ISP RAMs enabled?\n"); > + return; > + } > + } > + > + /* > + * Write tile pointer to hardware. The IOMMU should prevent > + * out-of-bounds offsets reaching non-ISP buffers. > + */ > + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_LO_REG, lower_32_bits(job->tiles)); > + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_HI_REG, upper_32_bits(job->tiles)); > + > + /* Enqueue the job */ > + pispbe_wr(pispbe, PISP_BE_CONTROL_REG, > + PISP_BE_CONTROL_COPY_CONFIG | PISP_BE_CONTROL_QUEUE_JOB | > + PISP_BE_CONTROL_NUM_TILES(job->config->num_tiles)); > +} > + > +struct pispbe_buffer { > + struct vb2_v4l2_buffer vb; > + struct list_head ready_list; > + unsigned int config_index; > +}; > + > +static int pispbe_get_planes_addr(dma_addr_t addr[3], struct pispbe_buffer *buf, > + struct pispbe_node *node) > +{ > + unsigned int num_planes = node->format.fmt.pix_mp.num_planes; > + unsigned int plane_factor = 0; > + unsigned int size; > + unsigned int p; > + > + if (!buf || !node->pisp_format) > + return 0; > + > + /* > + * Determine the base plane size. This will not be the same > + * as node->format.fmt.pix_mp.plane_fmt[0].sizeimage for a single > + * plane buffer in an mplane format. > + */ > + size = node->format.fmt.pix_mp.plane_fmt[0].bytesperline > + * node->format.fmt.pix_mp.height; > + > + for (p = 0; p < num_planes && p < PISPBE_MAX_PLANES; p++) { > + addr[p] = vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, p); > + plane_factor += node->pisp_format->plane_factor[p]; > + } > + > + for (; p < PISPBE_MAX_PLANES && node->pisp_format->plane_factor[p]; p++) { > + /* > + * Calculate the address offset of this plane as needed > + * by the hardware. This is specifically for non-mplane > + * buffer formats, where there are 3 image planes, e.g. > + * for the V4L2_PIX_FMT_YUV420 format. > + */ > + addr[p] = addr[0] + ((size * plane_factor) >> 3); > + plane_factor += node->pisp_format->plane_factor[p]; > + } > + > + return num_planes; > +} > + > +static dma_addr_t pispbe_get_addr(struct pispbe_buffer *buf) > +{ > + if (buf) > + return vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, 0); > + return 0; > +} > + > +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], > + u32 hw_enables[N_HW_ENABLES], > + struct pisp_be_tiles_config *config, > + struct pispbe_buffer *buf[PISPBE_NUM_NODES], > + struct pispbe_node_group *node_group) > +{ > + int ret; > + > + /* Take a copy of the "enable" bitmaps so we can modify them. */ > + hw_enables[0] = config->config.global.bayer_enables; > + hw_enables[1] = config->config.global.rgb_enables; I wonder if hw_enables would be better declared as a struct. > + > + /* > + * Main input first. There are 3 address pointers, corresponding to up > + * to 3 planes. > + */ > + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], > + &node_group->node[MAIN_INPUT_NODE]); > + if (ret <= 0) { > + /* > + * This shouldn't happen; pispbe_schedule_internal should insist > + * on an input. > + */ > + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); > + hw_enables[0] = 0; > + hw_enables[1] = 0; > + return; > + } > + > + /* > + * Now TDN/Stitch inputs and outputs. These are single-plane and only > + * used with Bayer input. Input enables must match the requirements > + * of the processing stages, otherwise the hardware can lock up! > + */ > + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { > + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); > + if (addrs[3] == 0 || > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || > + (config->config.tdn.reset & 1)) { > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | > + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); > + if (!(config->config.tdn.reset & 1)) > + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; > + } > + > + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); > + if (addrs[4] == 0 || > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { > + hw_enables[0] &= > + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | > + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | > + PISP_BE_BAYER_ENABLE_STITCH); > + } > + > + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); > + if (addrs[5] == 0) > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | > + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); > + > + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); > + if (addrs[6] == 0) > + hw_enables[0] &= > + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | > + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); > + } else { > + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ > + hw_enables[0] = 0; > + } > + > + /* Main image output channels. */ > + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { > + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, > + buf[OUTPUT0_NODE + i], > + &node_group->node[OUTPUT0_NODE + i]); > + if (ret <= 0) > + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); > + } > +} > + > +/* > + * Prepare a job description to be submitted to the HW. > + * > + * To schedule a job, we need all streaming nodes (apart from Output0, > + * Output1, Tdn and Stitch) to have a buffer ready, which must > + * include at least a config buffer and a main input image. > + * > + * For Output0, Output1, Tdn and Stitch, a buffer only needs to be > + * available if the blocks are enabled in the config. > + * > + * Needs to be called with hw_lock held. > + * > + * Returns 0 if a job has been successfully prepared, < 0 otherwise. > + */ > +static int pispbe_prepare_job(struct pispbe_node_group *node_group, > + struct pispbe_job_descriptor *job) > +{ > + struct pispbe_buffer *buf[PISPBE_NUM_NODES] = {}; > + struct pispbe_dev *pispbe = node_group->pispbe; > + unsigned int config_index; > + struct pispbe_node *node; > + unsigned long flags; > + > + lockdep_assert_held(&pispbe->hw_lock); > + > + memset(job, 0, sizeof(struct pispbe_job_descriptor)); > + > + if (((BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE)) & > + node_group->streaming_map) != > + (BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE))) > + return -ENODEV; > + > + node = &node_group->node[CONFIG_NODE]; > + spin_lock_irqsave(&node->ready_lock, flags); > + buf[CONFIG_NODE] = list_first_entry_or_null(&node->ready_queue, > + struct pispbe_buffer, > + ready_list); > + if (buf[CONFIG_NODE]) { > + list_del(&buf[CONFIG_NODE]->ready_list); > + pispbe->queued_job.buf[CONFIG_NODE] = buf[CONFIG_NODE]; > + } > + spin_unlock_irqrestore(&node->ready_lock, flags); > + > + /* Exit early if no config buffer has been queued. */ > + if (!buf[CONFIG_NODE]) > + return -ENODEV; > + > + config_index = buf[CONFIG_NODE]->vb.vb2_buf.index; > + job->config = &node_group->config[config_index]; > + job->tiles = node_group->config_dma_addr + > + config_index * sizeof(struct pisp_be_tiles_config) + > + offsetof(struct pisp_be_tiles_config, tiles); > + > + /* remember: srcimages, captures then metadata */ > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > + unsigned int bayer_en = > + job->config->config.global.bayer_enables; > + unsigned int rgb_en = > + job->config->config.global.rgb_enables; > + bool ignore_buffers = false; > + > + /* Config node is handled outside the loop above. */ > + if (i == CONFIG_NODE) > + continue; > + > + buf[i] = NULL; > + if (!(node_group->streaming_map & BIT(i))) > + continue; > + > + if ((!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT0) && > + i == OUTPUT0_NODE) || > + (!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT1) && > + i == OUTPUT1_NODE) || > + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_INPUT) && > + i == TDN_INPUT_NODE) || > + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) && > + i == TDN_OUTPUT_NODE) || > + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_INPUT) && > + i == STITCH_INPUT_NODE) || > + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) && > + i == STITCH_OUTPUT_NODE)) { > + /* > + * Ignore Output0/Output1/Tdn/Stitch buffer check if the > + * global enables aren't set for these blocks. If a > + * buffer has been provided, we dequeue it back to the > + * user with the other in-use buffers. > + */ > + ignore_buffers = true; > + } > + > + node = &node_group->node[i]; > + > + /* Pull a buffer from each V4L2 queue to form the queued job */ > + spin_lock_irqsave(&node->ready_lock, flags); > + buf[i] = list_first_entry_or_null(&node->ready_queue, > + struct pispbe_buffer, > + ready_list); > + if (buf[i]) { > + list_del(&buf[i]->ready_list); > + pispbe->queued_job.buf[i] = buf[i]; > + } > + spin_unlock_irqrestore(&node->ready_lock, flags); > + > + if (!buf[i] && !ignore_buffers) > + goto err_return_buffers; > + } > + > + pispbe->queued_job.node_group = node_group; > + > + /* Convert buffers to DMA addresses for the hardware */ > + pispbe_xlate_addrs(job->hw_dma_addrs, job->hw_enables, > + job->config, buf, node_group); > + > + return 0; > + > +err_return_buffers: > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > + struct pispbe_node *n = &node_group->node[i]; > + > + if (!buf[i]) > + continue; > + > + /* Return the buffer to the ready_list queue */ > + spin_lock_irqsave(&n->ready_lock, flags); > + list_add(&buf[i]->ready_list, &n->ready_queue); > + spin_unlock_irqrestore(&n->ready_lock, flags); > + } > + > + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); > + > + return -ENODEV; > +} > + > +static void pispbe_schedule(struct pispbe_dev *pispbe, > + struct pispbe_node_group *node_group, > + bool clear_hw_busy) > +{ > + struct pispbe_job_descriptor job; > + unsigned long flags; > + > + spin_lock_irqsave(&pispbe->hw_lock, flags); > + > + if (clear_hw_busy) > + pispbe->hw_busy = 0; > + > + if (pispbe->hw_busy) > + goto unlock_and_return; > + > + for (unsigned int i = 0; i < PISPBE_NUM_NODE_GROUPS; i++) { > + int ret; > + > + /* Schedule jobs only for a specific group. */ > + if (node_group && > + &pispbe->node_group[i] != node_group) Fits on the previous line. > + continue; > + > + /* > + * Prepare a job for this group, if the group is not ready > + * continue and try with the next one. > + */ > + ret = pispbe_prepare_job(&pispbe->node_group[i], &job); > + if (ret) > + continue; > + > + /* > + * We can kick the job off without the hw_lock, as this can > + * never run again until hw_busy is cleared, which will happen > + * only when the following job has been queued and an interrupt > + * is rised. > + */ > + pispbe->hw_busy = 1; > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > + > + if (job.config->num_tiles <= 0 || > + job.config->num_tiles > PISP_BACK_END_NUM_TILES || > + !((job.hw_enables[0] | job.hw_enables[1]) & > + PISP_BE_BAYER_ENABLE_INPUT)) { > + /* > + * Bad job. We can't let it proceed as it could lock up > + * the hardware, or worse! > + * > + * For now, just force num_tiles to 0, which causes the > + * H/W to do something bizarre but survivable. It > + * increments (started,done) counters by more than 1, > + * but we seem to survive... > + */ > + dev_dbg(pispbe->dev, > + "Bad job: invalid number of tiles: %d\n", > + job.config->num_tiles); > + job.config->num_tiles = 0; > + } > + > + pispbe_queue_job(pispbe, &job); > + > + return; > + } > + > +unlock_and_return: > + /* No job has been queued, just release the lock and return. */ > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > +} > + > +static void pispbe_isr_jobdone(struct pispbe_dev *pispbe, > + struct pispbe_job *job) > +{ > + struct pispbe_buffer **buf = job->buf; > + u64 ts = ktime_get_ns(); > + > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > + if (buf[i]) { > + buf[i]->vb.vb2_buf.timestamp = ts; > + buf[i]->vb.sequence = job->node_group->sequence; > + vb2_buffer_done(&buf[i]->vb.vb2_buf, > + VB2_BUF_STATE_DONE); > + } > + } > + > + job->node_group->sequence++; > +} > + > +static irqreturn_t pispbe_isr(int irq, void *dev) > +{ > + struct pispbe_dev *pispbe = (struct pispbe_dev *)dev; > + bool can_queue_another = false; > + u8 started, done; > + u32 u; > + > + u = pispbe_rd(pispbe, PISP_BE_INTERRUPT_STATUS_REG); > + if (u == 0) > + return IRQ_NONE; > + > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, u); > + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); > + done = (uint8_t)u; > + started = (uint8_t)(u >> 8); > + > + /* > + * Be aware that done can go up by 2 and started by 1 when: a job that > + * we previously saw "start" now finishes, and we then queued a new job > + * which we see both start and finish "simultaneously". > + */ > + if (pispbe->running_job.node_group && pispbe->done != done) { > + pispbe_isr_jobdone(pispbe, &pispbe->running_job); > + memset(&pispbe->running_job, 0, sizeof(pispbe->running_job)); > + pispbe->done++; > + } > + > + if (pispbe->started != started) { > + pispbe->started++; > + can_queue_another = 1; §> + > + if (pispbe->done != done && pispbe->queued_job.node_group) { > + pispbe_isr_jobdone(pispbe, &pispbe->queued_job); > + pispbe->done++; > + } else { > + pispbe->running_job = pispbe->queued_job; > + } > + > + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); > + } > + > + if (pispbe->done != done || pispbe->started != started) { > + dev_dbg(pispbe->dev, > + "Job counters not matching: done = %u, expected %u - started = %u, expected %u\n", > + pispbe->done, done, pispbe->started, started); > + pispbe->started = started; > + pispbe->done = done; > + } > + > + /* check if there's more to do before going to sleep */ > + pispbe_schedule(pispbe, NULL, can_queue_another); > + > + return IRQ_HANDLED; > +} > + > +static int pisp_be_validate_config(struct pispbe_node_group *node_group, > + struct pisp_be_tiles_config *config) > +{ > + u32 bayer_enables = config->config.global.bayer_enables; > + u32 rgb_enables = config->config.global.rgb_enables; > + struct device *dev = node_group->pispbe->dev; > + struct v4l2_format *fmt; > + unsigned int bpl, size; > + > + if (!(bayer_enables & PISP_BE_BAYER_ENABLE_INPUT) == > + !(rgb_enables & PISP_BE_RGB_ENABLE_INPUT)) { > + dev_dbg(dev, "%s: Not one input enabled\n", __func__); > + return -EIO; > + } > + > + /* Ensure output config strides and buffer sizes match the V4L2 formats. */ > + fmt = &node_group->node[TDN_OUTPUT_NODE].format; > + if (bayer_enables & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) { > + bpl = config->config.tdn_output_format.stride; > + size = bpl * config->config.tdn_output_format.height; > + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { > + dev_dbg(dev, "%s: bpl mismatch on tdn_output\n", > + __func__); > + return -EINVAL; > + } > + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { > + dev_dbg(dev, "%s: size mismatch on tdn_output\n", > + __func__); > + return -EINVAL; > + } > + } > + > + fmt = &node_group->node[STITCH_OUTPUT_NODE].format; > + if (bayer_enables & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) { > + bpl = config->config.stitch_output_format.stride; > + size = bpl * config->config.stitch_output_format.height; > + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { > + dev_dbg(dev, "%s: bpl mismatch on stitch_output\n", > + __func__); > + return -EINVAL; > + } > + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { > + dev_dbg(dev, "%s: size mismatch on stitch_output\n", > + __func__); > + return -EINVAL; > + } > + } > + > + for (unsigned int j = 0; j < PISP_BACK_END_NUM_OUTPUTS; j++) { > + if (!(rgb_enables & PISP_BE_RGB_ENABLE_OUTPUT(j))) > + continue; > + if (config->config.output_format[j].image.format & > + PISP_IMAGE_FORMAT_WALLPAPER_ROLL) > + continue; /* TODO: Size checks for wallpaper formats */ > + > + fmt = &node_group->node[OUTPUT0_NODE + j].format; > + for (unsigned int i = 0; i < fmt->fmt.pix_mp.num_planes; i++) { > + bpl = !i ? config->config.output_format[j].image.stride > + : config->config.output_format[j].image.stride2; > + size = bpl * config->config.output_format[j].image.height; > + > + if (config->config.output_format[j].image.format & > + PISP_IMAGE_FORMAT_SAMPLING_420) > + size >>= 1; > + if (fmt->fmt.pix_mp.plane_fmt[i].bytesperline < bpl) { > + dev_dbg(dev, "%s: bpl mismatch on output %d\n", > + __func__, j); > + return -EINVAL; > + } > + if (fmt->fmt.pix_mp.plane_fmt[i].sizeimage < size) { > + dev_dbg(dev, "%s: size mismatch on output\n", > + __func__); > + return -EINVAL; > + } > + } > + } > + > + return 0; > +} > + > +static int pispbe_node_queue_setup(struct vb2_queue *q, unsigned int *nbuffers, > + unsigned int *nplanes, unsigned int sizes[], > + struct device *alloc_devs[]) > +{ > + struct pispbe_node *node = vb2_get_drv_priv(q); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + *nplanes = 1; > + if (NODE_IS_MPLANE(node)) { > + *nplanes = node->format.fmt.pix_mp.num_planes; > + for (unsigned int i = 0; i < *nplanes; i++) { > + unsigned int size = > + node->format.fmt.pix_mp.plane_fmt[i].sizeimage; > + > + if (sizes[i] && sizes[i] < size) { > + dev_dbg(pispbe->dev, "%s: size %u < %u\n", > + __func__, sizes[i], size); > + return -EINVAL; > + } > + sizes[i] = size; > + } > + } else if (NODE_IS_META(node)) { > + sizes[0] = node->format.fmt.meta.buffersize; > + /* > + * Limit the config node buffer count to the number of internal > + * buffers allocated. > + */ > + if (node->id == CONFIG_NODE) > + *nbuffers = min_t(unsigned int, *nbuffers, > + PISP_BE_NUM_CONFIG_BUFFERS); > + } > + > + dev_dbg(pispbe->dev, > + "Image (or metadata) size %u, nbuffers %u for node %s\n", > + sizes[0], *nbuffers, NODE_NAME(node)); > + > + return 0; > +} > + > +static int pispbe_node_buffer_prepare(struct vb2_buffer *vb) > +{ > + struct pispbe_node *node = vb2_get_drv_priv(vb->vb2_queue); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + unsigned long size = 0; Size can be declared inside the loop. > + unsigned int num_planes = NODE_IS_MPLANE(node) > + ? node->format.fmt.pix_mp.num_planes : 1; > + > + for (unsigned int i = 0; i < num_planes; i++) { > + size = NODE_IS_MPLANE(node) > + ? node->format.fmt.pix_mp.plane_fmt[i].sizeimage > + : node->format.fmt.meta.buffersize; > + > + if (vb2_plane_size(vb, i) < size) { > + dev_dbg(pispbe->dev, > + "data will not fit into plane %d (%lu < %lu)\n", > + i, vb2_plane_size(vb, i), size); > + return -EINVAL; > + } > + > + vb2_set_plane_payload(vb, i, size); > + } > + > + if (node->id == CONFIG_NODE) { > + void *dst = &node->node_group->config[vb->index]; > + void *src = vb2_plane_vaddr(vb, 0); > + > + memcpy(dst, src, sizeof(struct pisp_be_tiles_config)); > + > + return pisp_be_validate_config(node->node_group, dst); > + } > + > + return 0; > +} > + > +static void pispbe_node_buffer_queue(struct vb2_buffer *buf) > +{ > + struct vb2_v4l2_buffer *vbuf = > + container_of(buf, struct vb2_v4l2_buffer, vb2_buf); > + struct pispbe_buffer *buffer = > + container_of(vbuf, struct pispbe_buffer, vb); > + struct pispbe_node *node = vb2_get_drv_priv(buf->vb2_queue); > + struct pispbe_node_group *node_group = node->node_group; > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + unsigned long flags; > + > + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); > + spin_lock_irqsave(&node->ready_lock, flags); > + list_add_tail(&buffer->ready_list, &node->ready_queue); > + spin_unlock_irqrestore(&node->ready_lock, flags); > + > + /* > + * Every time we add a buffer, check if there's now some work for the hw > + * to do, but only for this client. > + */ > + pispbe_schedule(node_group->pispbe, node_group, false); > +} > + > +static int pispbe_node_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct pispbe_node *node = vb2_get_drv_priv(q); > + struct pispbe_node_group *node_group = node->node_group; > + struct pispbe_dev *pispbe = node_group->pispbe; > + unsigned long flags; > + int ret; > + > + ret = pm_runtime_resume_and_get(pispbe->dev); > + if (ret < 0) > + return ret; > + > + spin_lock_irqsave(&pispbe->hw_lock, flags); > + node->node_group->streaming_map |= BIT(node->id); > + node->node_group->sequence = 0; > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > + > + dev_dbg(pispbe->dev, "%s: for node %s (count %u)\n", > + __func__, NODE_NAME(node), count); > + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", > + node->node_group->streaming_map); > + > + /* Maybe we're ready to run. */ > + pispbe_schedule(node_group->pispbe, node_group, false); > + > + return 0; > +} > + > +static void pispbe_node_stop_streaming(struct vb2_queue *q) > +{ > + struct pispbe_node *node = vb2_get_drv_priv(q); > + struct pispbe_node_group *node_group = node->node_group; > + struct pispbe_dev *pispbe = node_group->pispbe; > + struct pispbe_buffer *buf; > + unsigned long flags; > + > + /* > + * Now this is a bit awkward. In a simple M2M device we could just wait > + * for all queued jobs to complete, but here there's a risk that a > + * partial set of buffers was queued and cannot be run. For now, just > + * cancel all buffers stuck in the "ready queue", then wait for any > + * running job. > + * > + * This may return buffers out of order. > + */ > + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); > + spin_lock_irqsave(&pispbe->hw_lock, flags); > + do { > + unsigned long flags1; > + > + spin_lock_irqsave(&node->ready_lock, flags1); > + buf = list_first_entry_or_null(&node->ready_queue, > + struct pispbe_buffer, > + ready_list); > + if (buf) { > + list_del(&buf->ready_list); > + vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR); > + } > + spin_unlock_irqrestore(&node->ready_lock, flags1); > + } while (buf); > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > + > + vb2_wait_for_all_buffers(&node->queue); > + > + spin_lock_irqsave(&pispbe->hw_lock, flags); > + node_group->streaming_map &= ~BIT(node->id); > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > + > + pm_runtime_mark_last_busy(pispbe->dev); > + pm_runtime_put_autosuspend(pispbe->dev); > + > + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", > + node_group->streaming_map); > +} > + > +static const struct vb2_ops pispbe_node_queue_ops = { > + .queue_setup = pispbe_node_queue_setup, > + .buf_prepare = pispbe_node_buffer_prepare, > + .buf_queue = pispbe_node_buffer_queue, > + .start_streaming = pispbe_node_start_streaming, > + .stop_streaming = pispbe_node_stop_streaming, > +}; > + > +static const struct v4l2_file_operations pispbe_fops = { > + .owner = THIS_MODULE, > + .open = v4l2_fh_open, > + .release = vb2_fop_release, > + .poll = vb2_fop_poll, > + .unlocked_ioctl = video_ioctl2, > + .mmap = vb2_fop_mmap > +}; > + > +static int pispbe_node_querycap(struct file *file, void *priv, > + struct v4l2_capability *cap) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + strscpy(cap->driver, PISPBE_NAME, sizeof(cap->driver)); > + strscpy(cap->card, PISPBE_NAME, sizeof(cap->card)); > + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", > + dev_name(pispbe->dev)); > + > + cap->capabilities = V4L2_CAP_VIDEO_CAPTURE_MPLANE | > + V4L2_CAP_VIDEO_OUTPUT_MPLANE | > + V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS | > + V4L2_CAP_META_OUTPUT; > + cap->device_caps = node->vfd.device_caps; > + > + dev_dbg(pispbe->dev, "Caps for node %s: %x and %x (dev %x)\n", > + NODE_NAME(node), cap->capabilities, cap->device_caps, > + node->vfd.device_caps); > + > + return 0; > +} > + > +static int pispbe_node_g_fmt_vid_cap(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > + dev_dbg(pispbe->dev, > + "Cannot get capture fmt for output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + *f = node->format; > + dev_dbg(pispbe->dev, "Get capture format for node %s\n", > + NODE_NAME(node)); > + > + return 0; > +} > + > +static int pispbe_node_g_fmt_vid_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > + dev_dbg(pispbe->dev, > + "Cannot get capture fmt for output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + *f = node->format; > + dev_dbg(pispbe->dev, "Get output format for node %s\n", > + NODE_NAME(node)); > + > + return 0; > +} > + > +static int pispbe_node_g_fmt_meta_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { > + dev_dbg(pispbe->dev, > + "Cannot get capture fmt for meta output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + *f = node->format; > + dev_dbg(pispbe->dev, "Get output format for meta node %s\n", > + NODE_NAME(node)); > + > + return 0; > +} > + > +static const struct pisp_be_format *pispbe_find_fmt(unsigned int fourcc) > +{ > + for (unsigned int i = 0; i < ARRAY_SIZE(supported_formats); i++) { > + if (supported_formats[i].fourcc == fourcc) > + return &supported_formats[i]; > + } > + > + return NULL; > +} > + > +static void pispbe_set_plane_params(struct v4l2_format *f, > + const struct pisp_be_format *fmt) > +{ > + unsigned int nplanes = f->fmt.pix_mp.num_planes; > + unsigned int total_plane_factor = 0; > + > + for (unsigned int i = 0; i < PISPBE_MAX_PLANES; i++) > + total_plane_factor += fmt->plane_factor[i]; > + > + for (unsigned int i = 0; i < nplanes; i++) { > + struct v4l2_plane_pix_format *p = &f->fmt.pix_mp.plane_fmt[i]; > + unsigned int bpl, plane_size; > + > + bpl = (f->fmt.pix_mp.width * fmt->bit_depth) >> 3; > + bpl = ALIGN(max(p->bytesperline, bpl), fmt->align); > + > + plane_size = bpl * f->fmt.pix_mp.height * > + (nplanes > 1 ? fmt->plane_factor[i] : total_plane_factor); > + /* > + * The shift is to divide out the plane_factor fixed point > + * scaling of 8. > + */ > + plane_size = max(p->sizeimage, plane_size >> 3); > + > + p->bytesperline = bpl; > + p->sizeimage = plane_size; > + } > +} > + > +static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node) > +{ > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + u32 pixfmt = f->fmt.pix_mp.pixelformat; > + const struct pisp_be_format *fmt; > + bool is_rgb; > + > + dev_dbg(pispbe->dev, > + "%s: [%s] req %ux%u %p4cc, planes %d\n", > + __func__, NODE_NAME(node), f->fmt.pix_mp.width, > + f->fmt.pix_mp.height, &pixfmt, > + f->fmt.pix_mp.num_planes); > + > + fmt = pispbe_find_fmt(pixfmt); > + if (!fmt) { > + dev_dbg(pispbe->dev, > + "%s: [%s] Format not found, defaulting to YUV420\n", > + __func__, NODE_NAME(node)); > + fmt = pispbe_find_fmt(V4L2_PIX_FMT_YUV420); > + } > + > + f->fmt.pix_mp.pixelformat = fmt->fourcc; > + f->fmt.pix_mp.num_planes = fmt->num_planes; > + f->fmt.pix_mp.field = V4L2_FIELD_NONE; > + f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u), > + PISP_BACK_END_MIN_TILE_WIDTH); > + f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u), > + PISP_BACK_END_MIN_TILE_HEIGHT); > + > + /* > + * Fill in the actual colour space when the requested one was > + * not supported. This also catches the case when the "default" > + * colour space was requested (as that's never in the mask). > + */ > + if (!(V4L2_COLORSPACE_MASK(f->fmt.pix_mp.colorspace) & > + fmt->colorspace_mask)) > + f->fmt.pix_mp.colorspace = fmt->colorspace_default; > + > + /* In all cases, we only support the defaults for these: */ > + f->fmt.pix_mp.ycbcr_enc = > + V4L2_MAP_YCBCR_ENC_DEFAULT(f->fmt.pix_mp.colorspace); > + f->fmt.pix_mp.xfer_func = > + V4L2_MAP_XFER_FUNC_DEFAULT(f->fmt.pix_mp.colorspace); > + > + is_rgb = f->fmt.pix_mp.colorspace == V4L2_COLORSPACE_SRGB; > + f->fmt.pix_mp.quantization = > + V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb, f->fmt.pix_mp.colorspace, > + f->fmt.pix_mp.ycbcr_enc); > + > + /* Set plane size and bytes/line for each plane. */ > + pispbe_set_plane_params(f, fmt); > + > + for (unsigned int i = 0; i < f->fmt.pix_mp.num_planes; i++) { > + dev_dbg(pispbe->dev, > + "%s: [%s] calc plane %d, %ux%u, depth %u, bpl %u size %u\n", > + __func__, NODE_NAME(node), i, f->fmt.pix_mp.width, > + f->fmt.pix_mp.height, fmt->bit_depth, > + f->fmt.pix_mp.plane_fmt[i].bytesperline, > + f->fmt.pix_mp.plane_fmt[i].sizeimage); > + } > +} > + > +static int pispbe_node_try_fmt_vid_cap(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > + dev_dbg(pispbe->dev, > + "Cannot set capture fmt for output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + > + pispbe_try_format(f, node); > + > + return 0; > +} > + > +static int pispbe_node_try_fmt_vid_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (!NODE_IS_OUTPUT(node) || NODE_IS_META(node)) { > + dev_dbg(pispbe->dev, > + "Cannot set capture fmt for output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + > + pispbe_try_format(f, node); > + > + return 0; > +} > + > +static int pispbe_node_try_fmt_meta_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { > + dev_dbg(pispbe->dev, > + "Cannot set capture fmt for meta output node %s\n", > + NODE_NAME(node)); > + return -EINVAL; > + } > + > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > + > + return 0; > +} > + > +static int pispbe_node_s_fmt_vid_cap(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + int ret; > + > + ret = pispbe_node_try_fmt_vid_cap(file, priv, f); > + if (ret < 0) > + return ret; > + > + node->format = *f; > + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); > + > + dev_dbg(pispbe->dev, "Set capture format for node %s to %p4cc\n", > + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); > + > + return 0; > +} > + > +static int pispbe_node_s_fmt_vid_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + int ret; > + > + ret = pispbe_node_try_fmt_vid_out(file, priv, f); > + if (ret < 0) > + return ret; > + > + node->format = *f; > + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); > + > + dev_dbg(pispbe->dev, "Set output format for node %s to %p4cc\n", > + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); > + > + return 0; > +} > + > +static int pispbe_node_s_fmt_meta_out(struct file *file, void *priv, > + struct v4l2_format *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + int ret; > + > + ret = pispbe_node_try_fmt_meta_out(file, priv, f); > + if (ret < 0) > + return ret; > + > + node->format = *f; > + node->pisp_format = &meta_out_supported_formats[0]; > + > + dev_dbg(pispbe->dev, "Set output format for meta node %s to %p4cc\n", > + NODE_NAME(node), &f->fmt.meta.dataformat); > + > + return 0; > +} > + > +static int pispbe_node_enum_fmt(struct file *file, void *priv, > + struct v4l2_fmtdesc *f) > +{ > + struct pispbe_node *node = video_drvdata(file); > + > + if (f->type != node->queue.type) > + return -EINVAL; > + > + if (NODE_IS_META(node)) { > + if (f->index) > + return -EINVAL; > + > + f->pixelformat = V4L2_META_FMT_RPI_BE_CFG; > + f->flags = 0; > + return 0; > + } > + > + if (f->index >= ARRAY_SIZE(supported_formats)) > + return -EINVAL; > + > + f->pixelformat = supported_formats[f->index].fourcc; > + f->flags = 0; > + > + return 0; > +} > + > +static int pispbe_enum_framesizes(struct file *file, void *priv, > + struct v4l2_frmsizeenum *fsize) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + if (NODE_IS_META(node) || fsize->index) > + return -EINVAL; > + > + if (!pispbe_find_fmt(fsize->pixel_format)) { > + dev_dbg(pispbe->dev, "Invalid pixel code: %x\n", > + fsize->pixel_format); > + return -EINVAL; > + } > + > + fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; > + fsize->stepwise.min_width = 32; > + fsize->stepwise.max_width = 65535; > + fsize->stepwise.step_width = 2; > + > + fsize->stepwise.min_height = 32; > + fsize->stepwise.max_height = 65535; > + fsize->stepwise.step_height = 2; > + > + return 0; > +} > + > +static int pispbe_node_streamon(struct file *file, void *priv, > + enum v4l2_buf_type type) > +{ > + struct pispbe_node *node = video_drvdata(file); > + struct pispbe_dev *pispbe = node->node_group->pispbe; > + > + dev_dbg(pispbe->dev, "Stream on for node %s\n", NODE_NAME(node)); > + > + INIT_LIST_HEAD(&node->ready_queue); > + > + return vb2_streamon(&node->queue, type); > +} > + > +static int pispbe_node_streamoff(struct file *file, void *priv, > + enum v4l2_buf_type type) > +{ > + struct pispbe_node *node = video_drvdata(file); > + > + return vb2_streamoff(&node->queue, type); > +} > + > +static const struct v4l2_ioctl_ops pispbe_node_ioctl_ops = { > + .vidioc_querycap = pispbe_node_querycap, > + .vidioc_g_fmt_vid_cap_mplane = pispbe_node_g_fmt_vid_cap, > + .vidioc_g_fmt_vid_out_mplane = pispbe_node_g_fmt_vid_out, > + .vidioc_g_fmt_meta_out = pispbe_node_g_fmt_meta_out, > + .vidioc_try_fmt_vid_cap_mplane = pispbe_node_try_fmt_vid_cap, > + .vidioc_try_fmt_vid_out_mplane = pispbe_node_try_fmt_vid_out, > + .vidioc_try_fmt_meta_out = pispbe_node_try_fmt_meta_out, > + .vidioc_s_fmt_vid_cap_mplane = pispbe_node_s_fmt_vid_cap, > + .vidioc_s_fmt_vid_out_mplane = pispbe_node_s_fmt_vid_out, > + .vidioc_s_fmt_meta_out = pispbe_node_s_fmt_meta_out, > + .vidioc_enum_fmt_vid_cap = pispbe_node_enum_fmt, > + .vidioc_enum_fmt_vid_out = pispbe_node_enum_fmt, > + .vidioc_enum_fmt_meta_out = pispbe_node_enum_fmt, > + .vidioc_enum_framesizes = pispbe_enum_framesizes, > + .vidioc_create_bufs = vb2_ioctl_create_bufs, > + .vidioc_prepare_buf = vb2_ioctl_prepare_buf, > + .vidioc_querybuf = vb2_ioctl_querybuf, > + .vidioc_qbuf = vb2_ioctl_qbuf, > + .vidioc_dqbuf = vb2_ioctl_dqbuf, > + .vidioc_expbuf = vb2_ioctl_expbuf, > + .vidioc_reqbufs = vb2_ioctl_reqbufs, > + .vidioc_streamon = pispbe_node_streamon, > + .vidioc_streamoff = pispbe_node_streamoff, > +}; > + > +static const struct video_device pispbe_videodev = { > + .name = PISPBE_NAME, > + .vfl_dir = VFL_DIR_M2M, /* gets overwritten */ > + .fops = &pispbe_fops, > + .ioctl_ops = &pispbe_node_ioctl_ops, > + .minor = -1, > + .release = video_device_release_empty, > +}; > + > +static void pispbe_node_def_fmt(struct pispbe_node *node) > +{ > + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { > + /* Config node */ > + struct v4l2_format *f = &node->format; > + > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > + f->type = node->buf_type; > + } else { > + struct v4l2_format f = {0}; > + > + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; > + f.fmt.pix_mp.width = 1920; > + f.fmt.pix_mp.height = 1080; > + f.type = node->buf_type; You can assign these in the declaration. The same above. > + pispbe_try_format(&f, node); > + node->format = f; > + } > + > + node->pisp_format = pispbe_find_fmt(node->format.fmt.pix_mp.pixelformat); > +} > + > +/* > + * Initialise a struct pispbe_node and register it as /dev/video<N> > + * to represent one of the PiSP Back End's input or output streams. > + */ > +static int pispbe_init_node(struct pispbe_node_group *node_group, > + unsigned int id) > +{ > + bool output = NODE_DESC_IS_OUTPUT(&node_desc[id]); > + struct pispbe_node *node = &node_group->node[id]; > + struct media_entity *entity = &node->vfd.entity; > + struct pispbe_dev *pispbe = node_group->pispbe; > + struct video_device *vdev = &node->vfd; > + struct vb2_queue *q = &node->queue; > + int ret; > + > + node->id = id; > + node->node_group = node_group; > + node->buf_type = node_desc[id].buf_type; > + > + mutex_init(&node->node_lock); > + mutex_init(&node->queue_lock); > + INIT_LIST_HEAD(&node->ready_queue); > + spin_lock_init(&node->ready_lock); > + > + node->format.type = node->buf_type; > + pispbe_node_def_fmt(node); > + > + q->type = node->buf_type; > + q->io_modes = VB2_MMAP | VB2_DMABUF; > + q->mem_ops = &vb2_dma_contig_memops; > + q->drv_priv = node; > + q->ops = &pispbe_node_queue_ops; > + q->buf_struct_size = sizeof(struct pispbe_buffer); > + q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > + q->dev = node->node_group->pispbe->dev; > + /* get V4L2 to handle node->queue locking */ > + q->lock = &node->queue_lock; > + > + ret = vb2_queue_init(q); > + if (ret < 0) { > + dev_err(pispbe->dev, "vb2_queue_init failed\n"); > + goto err_mutex_destroy; > + } > + > + *vdev = pispbe_videodev; /* default initialization */ > + strscpy(vdev->name, node_desc[id].ent_name, sizeof(vdev->name)); > + vdev->v4l2_dev = &node_group->v4l2_dev; > + vdev->vfl_dir = output ? VFL_DIR_TX : VFL_DIR_RX; > + /* get V4L2 to serialise our ioctls */ > + vdev->lock = &node->node_lock; > + vdev->queue = &node->queue; > + vdev->device_caps = V4L2_CAP_STREAMING | node_desc[id].caps; > + > + node->pad.flags = output ? MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK; > + ret = media_entity_pads_init(entity, 1, &node->pad); > + if (ret) { > + dev_err(pispbe->dev, > + "Failed to register media pads for %s device node\n", > + NODE_NAME(node)); > + goto err_unregister_queue; > + } > + > + ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1); > + if (ret) { > + dev_err(pispbe->dev, > + "Failed to register video %s device node\n", > + NODE_NAME(node)); > + goto err_unregister_queue; > + } > + video_set_drvdata(vdev, node); > + > + if (output) > + ret = media_create_pad_link(entity, 0, &node_group->sd.entity, > + id, MEDIA_LNK_FL_IMMUTABLE | > + MEDIA_LNK_FL_ENABLED); > + else > + ret = media_create_pad_link(&node_group->sd.entity, id, entity, > + 0, MEDIA_LNK_FL_IMMUTABLE | > + MEDIA_LNK_FL_ENABLED); > + if (ret) > + goto err_unregister_video_dev; > + > + dev_dbg(pispbe->dev, "%s device node registered as /dev/video%d\n", > + NODE_NAME(node), node->vfd.num); > + > + return 0; > + > +err_unregister_video_dev: > + video_unregister_device(&node->vfd); > +err_unregister_queue: > + vb2_queue_release(&node->queue); > +err_mutex_destroy: > + mutex_destroy(&node->node_lock); > + mutex_destroy(&node->queue_lock); > + return ret; > +} > + > +static const struct v4l2_subdev_pad_ops pispbe_pad_ops = { > + .link_validate = v4l2_subdev_link_validate_default, > +}; > + > +static const struct v4l2_subdev_ops pispbe_sd_ops = { > + .pad = &pispbe_pad_ops, > +}; > + > +static int pispbe_init_subdev(struct pispbe_node_group *node_group) > +{ > + struct pispbe_dev *pispbe = node_group->pispbe; > + struct v4l2_subdev *sd = &node_group->sd; > + int ret; > + > + v4l2_subdev_init(sd, &pispbe_sd_ops); > + sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; > + sd->owner = THIS_MODULE; > + sd->dev = pispbe->dev; > + strscpy(sd->name, PISPBE_NAME, sizeof(sd->name)); > + > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) > + node_group->pad[i].flags = > + NODE_DESC_IS_OUTPUT(&node_desc[i]) ? > + MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE; > + > + ret = media_entity_pads_init(&sd->entity, PISPBE_NUM_NODES, > + node_group->pad); > + if (ret) > + goto error; > + > + ret = v4l2_device_register_subdev(&node_group->v4l2_dev, sd); > + if (ret) > + goto error; > + > + return 0; > + > +error: > + media_entity_cleanup(&sd->entity); > + return ret; > +} > + > +static int pispbe_init_group(struct pispbe_dev *pispbe, unsigned int id) > +{ > + struct pispbe_node_group *node_group = &pispbe->node_group[id]; > + unsigned int num_registered = 0; > + struct v4l2_device *v4l2_dev; > + struct media_device *mdev; > + int ret; > + > + node_group->id = id; > + node_group->pispbe = pispbe; > + node_group->streaming_map = 0; > + > + dev_dbg(pispbe->dev, "Register nodes for group %u\n", id); > + > + /* Register v4l2_device and media_device */ > + mdev = &node_group->mdev; > + mdev->hw_revision = node_group->pispbe->hw_version; > + mdev->dev = node_group->pispbe->dev; > + strscpy(mdev->model, PISPBE_NAME, sizeof(mdev->model)); > + snprintf(mdev->bus_info, sizeof(mdev->bus_info), > + "platform:%s", dev_name(node_group->pispbe->dev)); This is already done by media_device_init(), no need to repeat here. > + media_device_init(mdev); > + > + v4l2_dev = &node_group->v4l2_dev; > + v4l2_dev->mdev = &node_group->mdev; > + strscpy(v4l2_dev->name, PISPBE_NAME, sizeof(v4l2_dev->name)); > + > + ret = v4l2_device_register(pispbe->dev, &node_group->v4l2_dev); > + if (ret) > + goto err_media_dev_cleanup; > + > + /* Register the PISPBE subdevice. */ > + ret = pispbe_init_subdev(node_group); > + if (ret) > + goto err_unregister_v4l2; > + > + /* Create device video nodes */ > + for (; num_registered < PISPBE_NUM_NODES; num_registered++) { Please initialise num_registered here instead of the declaration. > + ret = pispbe_init_node(node_group, num_registered); > + if (ret) > + goto err_unregister_nodes; > + } > + > + ret = media_device_register(mdev); > + if (ret) > + goto err_unregister_nodes; > + > + node_group->config = > + dma_alloc_coherent(pispbe->dev, > + sizeof(struct pisp_be_tiles_config) * > + PISP_BE_NUM_CONFIG_BUFFERS, > + &node_group->config_dma_addr, GFP_KERNEL); > + if (!node_group->config) { > + dev_err(pispbe->dev, "Unable to allocate cached config buffers.\n"); > + ret = -ENOMEM; > + goto err_unregister_mdev; > + } > + > + return 0; > + > +err_unregister_mdev: > + media_device_unregister(mdev); > +err_unregister_nodes: > + while (num_registered-- > 0) { > + video_unregister_device(&node_group->node[num_registered].vfd); > + vb2_queue_release(&node_group->node[num_registered].queue); > + } > + v4l2_device_unregister_subdev(&node_group->sd); > + media_entity_cleanup(&node_group->sd.entity); > +err_unregister_v4l2: > + v4l2_device_unregister(v4l2_dev); > +err_media_dev_cleanup: > + media_device_cleanup(mdev); > + return ret; > +} > + > +static void pispbe_destroy_node_group(struct pispbe_node_group *node_group) > +{ > + struct pispbe_dev *pispbe = node_group->pispbe; > + > + if (node_group->config) { > + dma_free_coherent(node_group->pispbe->dev, > + sizeof(struct pisp_be_tiles_config) * > + PISP_BE_NUM_CONFIG_BUFFERS, > + node_group->config, > + node_group->config_dma_addr); > + } > + > + dev_dbg(pispbe->dev, "Unregister from media controller\n"); > + > + v4l2_device_unregister_subdev(&node_group->sd); > + media_entity_cleanup(&node_group->sd.entity); > + media_device_unregister(&node_group->mdev); > + > + for (int i = PISPBE_NUM_NODES - 1; i >= 0; i--) { > + video_unregister_device(&node_group->node[i].vfd); > + vb2_queue_release(&node_group->node[i].queue); > + mutex_destroy(&node_group->node[i].node_lock); > + mutex_destroy(&node_group->node[i].queue_lock); > + } > + > + media_device_cleanup(&node_group->mdev); > + v4l2_device_unregister(&node_group->v4l2_dev); > +} > + > +static int pispbe_runtime_suspend(struct device *dev) > +{ > + struct pispbe_dev *pispbe = dev_get_drvdata(dev); > + > + clk_disable_unprepare(pispbe->clk); > + > + return 0; > +} > + > +static int pispbe_runtime_resume(struct device *dev) > +{ > + struct pispbe_dev *pispbe = dev_get_drvdata(dev); > + int ret; > + > + ret = clk_prepare_enable(pispbe->clk); > + if (ret) { > + dev_err(dev, "Unable to enable clock\n"); > + return ret; > + } > + > + dev_dbg(dev, "%s: Enabled clock, rate=%lu\n", > + __func__, clk_get_rate(pispbe->clk)); > + > + return 0; > +} > + > +static int pispbe_hw_init(struct pispbe_dev *pispbe) > +{ > + u32 u; > + > + /* Check the HW is present and has a known version */ > + u = pispbe_rd(pispbe, PISP_BE_VERSION_REG); > + dev_dbg(pispbe->dev, "pispbe_probe: HW version: 0x%08x", u); > + pispbe->hw_version = u; > + if ((u & ~PISP_BE_VERSION_MINOR_BITS) != PISP_BE_VERSION_2712) > + return -ENODEV; > + > + /* Clear leftover interrupts */ > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, 0xFFFFFFFFu); > + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); > + dev_dbg(pispbe->dev, "pispbe_probe: BatchStatus: 0x%08x", u); > + pispbe->done = (uint8_t)u; > + pispbe->started = (uint8_t)(u >> 8); > + u = pispbe_rd(pispbe, PISP_BE_STATUS_REG); > + dev_dbg(pispbe->dev, "pispbe_probe: Status: 0x%08x", u); > + if (u != 0 || pispbe->done != pispbe->started) { > + dev_err(pispbe->dev, "pispbe_probe: HW is stuck or busy\n"); > + return -EBUSY; > + } > + /* > + * AXI QOS=0, CACHE=4'b0010, PROT=3'b011 > + * Also set "chicken bits" 22:20 which enable sub-64-byte bursts > + * and AXI AWID/BID variability (on versions which support this). > + */ > + pispbe_wr(pispbe, PISP_BE_AXI_REG, 0x32703200u); > + > + /* Enable both interrupt flags */ > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_EN_REG, 0x00000003u); > + > + return 0; > +} > + > +/* > + * Probe the ISP-BE hardware block, as a single platform device. > + * This will instantiate multiple "node groups" each with many device nodes. > + */ > +static int pispbe_probe(struct platform_device *pdev) > +{ > + unsigned int num_groups = 0; > + struct pispbe_dev *pispbe; > + int ret; > + > + pispbe = devm_kzalloc(&pdev->dev, sizeof(*pispbe), GFP_KERNEL); > + if (!pispbe) > + return -ENOMEM; > + > + dev_set_drvdata(&pdev->dev, pispbe); > + pispbe->dev = &pdev->dev; > + platform_set_drvdata(pdev, pispbe); > + > + pispbe->be_reg_base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(pispbe->be_reg_base)) { > + dev_err(&pdev->dev, "Failed to get ISP-BE registers address\n"); > + return PTR_ERR(pispbe->be_reg_base); > + } > + > + pispbe->irq = platform_get_irq(pdev, 0); > + if (pispbe->irq <= 0) { > + dev_err(&pdev->dev, "No IRQ resource\n"); > + return -EINVAL; > + } > + > + ret = devm_request_irq(&pdev->dev, pispbe->irq, pispbe_isr, 0, > + PISPBE_NAME, pispbe); > + if (ret) { > + dev_err(&pdev->dev, "Unable to request interrupt\n"); > + return ret; > + } > + > + ret = dma_set_mask_and_coherent(pispbe->dev, DMA_BIT_MASK(36)); > + if (ret) > + return ret; > + > + pispbe->clk = devm_clk_get(&pdev->dev, NULL); > + if (IS_ERR(pispbe->clk)) > + return dev_err_probe(&pdev->dev, PTR_ERR(pispbe->clk), > + "Failed to get clock"); > + > + /* Hardware initialisation */ > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > + pm_runtime_use_autosuspend(pispbe->dev); > + pm_runtime_enable(pispbe->dev); > + > + ret = pm_runtime_resume_and_get(pispbe->dev); You'll need to call the driver's resume function manually instead. The above depends on CONFIG_PM. > + if (ret) > + goto pm_runtime_disable_err; > + > + pispbe->hw_busy = 0; > + spin_lock_init(&pispbe->hw_lock); > + ret = pispbe_hw_init(pispbe); > + if (ret) > + goto pm_runtime_put_err; > + > + /* > + * Initialise and register devices for each node_group, including media > + * device > + */ > + for (num_groups = 0; > + num_groups < PISPBE_NUM_NODE_GROUPS; > + num_groups++) { > + ret = pispbe_init_group(pispbe, num_groups); > + if (ret) > + goto disable_nodes_err; > + } > + > + pm_runtime_mark_last_busy(pispbe->dev); > + pm_runtime_put_autosuspend(pispbe->dev); > + > + return 0; > + > +disable_nodes_err: > + while (num_groups-- > 0) > + pispbe_destroy_node_group(&pispbe->node_group[num_groups]); > +pm_runtime_put_err: > + pm_runtime_put(pispbe->dev); > +pm_runtime_disable_err: > + pm_runtime_dont_use_autosuspend(pispbe->dev); > + pm_runtime_disable(pispbe->dev); > + > + return ret; > +} > + > +static int pispbe_remove(struct platform_device *pdev) > +{ > + struct pispbe_dev *pispbe = platform_get_drvdata(pdev); > + > + for (int i = PISPBE_NUM_NODE_GROUPS - 1; i >= 0; i--) > + pispbe_destroy_node_group(&pispbe->node_group[i]); > + > + pm_runtime_dont_use_autosuspend(pispbe->dev); > + pm_runtime_disable(pispbe->dev); > + > + return 0; > +} > + > +static const struct dev_pm_ops pispbe_pm_ops = { > + SET_RUNTIME_PM_OPS(pispbe_runtime_suspend, pispbe_runtime_resume, NULL) > +}; > + > +static const struct of_device_id pispbe_of_match[] = { > + { > + .compatible = "raspberrypi,pispbe", > + }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, pispbe_of_match); > + > +static struct platform_driver pispbe_pdrv = { > + .probe = pispbe_probe, > + .remove = pispbe_remove, > + .driver = { > + .name = PISPBE_NAME, > + .of_match_table = pispbe_of_match, > + .pm = &pispbe_pm_ops, > + }, > +}; > + > +module_platform_driver(pispbe_pdrv); > + > +MODULE_DESCRIPTION("PiSP Back End driver"); > +MODULE_AUTHOR("David Plowman <david.plowman@raspberrypi.com>"); > +MODULE_AUTHOR("Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>"); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > new file mode 100644 > index 000000000000..ebd320c9888c > --- /dev/null > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > @@ -0,0 +1,519 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * PiSP Back End driver image format definitions. > + * > + * Copyright (c) 2021 Raspberry Pi Ltd Any copyrights up to 2024 perhaps? > + */ > + > +#ifndef _PISP_BE_FORMATS_ > +#define _PISP_BE_FORMATS_ > + > +#include <linux/bits.h> > +#include <linux/videodev2.h> > + > +#define PISPBE_MAX_PLANES 3 > +#define P3(x) ((x) * 8) > + > +struct pisp_be_format { > + unsigned int fourcc; > + unsigned int align; > + unsigned int bit_depth; > + /* 0P3 factor for plane sizing */ > + unsigned int plane_factor[PISPBE_MAX_PLANES]; > + unsigned int num_planes; > + unsigned int colorspace_mask; > + enum v4l2_colorspace colorspace_default; > +}; > + > +#define V4L2_COLORSPACE_MASK(colorspace) BIT(colorspace) > + > +#define V4L2_COLORSPACE_MASK_JPEG \ > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_JPEG) > +#define V4L2_COLORSPACE_MASK_SMPTE170M \ > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SMPTE170M) > +#define V4L2_COLORSPACE_MASK_REC709 \ > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_REC709) > +#define V4L2_COLORSPACE_MASK_SRGB \ > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SRGB) > +#define V4L2_COLORSPACE_MASK_RAW \ > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_RAW) > + > +/* > + * All three colour spaces SRGB, SMPTE170M and REC709 are fundamentally sRGB > + * underneath (as near as makes no difference to us), just with different YCbCr > + * encodings. Therefore the ISP can generate sRGB on its main output and any of > + * the others on its low resolution output. Applications should, when using both > + * outputs, program the colour spaces on them to be the same, matching whatever > + * is requested for the low resolution output, even if the main output is > + * producing an RGB format. In turn this requires us to allow all these colour > + * spaces for every YUV/RGB output format. > + */ > +#define V4L2_COLORSPACE_MASK_ALL_SRGB (V4L2_COLORSPACE_MASK_JPEG | \ > + V4L2_COLORSPACE_MASK_SRGB | \ > + V4L2_COLORSPACE_MASK_SMPTE170M | \ > + V4L2_COLORSPACE_MASK_REC709) > + > +static const struct pisp_be_format supported_formats[] = { > + /* Single plane YUV formats */ > + { > + .fourcc = V4L2_PIX_FMT_YUV420, > + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ > + .align = 128, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YVU420, > + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ > + .align = 128, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_NV12, > + .align = 32, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_NV21, > + .align = 32, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YUYV, > + .align = 64, > + .bit_depth = 16, > + .plane_factor = { P3(1) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_UYVY, > + .align = 64, > + .bit_depth = 16, > + .plane_factor = { P3(1) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YVYU, > + .align = 64, > + .bit_depth = 16, > + .plane_factor = { P3(1) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_VYUY, > + .align = 64, > + .bit_depth = 16, > + .plane_factor = { P3(1) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + /* Multiplane YUV formats */ > + { > + .fourcc = V4L2_PIX_FMT_YUV420M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_NV12M, > + .align = 32, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5) }, > + .num_planes = 2, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_NV21M, > + .align = 32, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5) }, > + .num_planes = 2, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YVU420M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YUV422M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YVU422M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YUV444M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(1), P3(1) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + { > + .fourcc = V4L2_PIX_FMT_YVU444M, > + .align = 64, > + .bit_depth = 8, > + .plane_factor = { P3(1), P3(1), P3(1) }, > + .num_planes = 3, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > + }, > + /* RGB formats */ > + { > + .fourcc = V4L2_PIX_FMT_RGB24, > + .align = 32, > + .bit_depth = 24, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + { > + .fourcc = V4L2_PIX_FMT_BGR24, > + .align = 32, > + .bit_depth = 24, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + { > + .fourcc = V4L2_PIX_FMT_XBGR32, > + .align = 64, > + .bit_depth = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + { > + .fourcc = V4L2_PIX_FMT_RGBX32, > + .align = 64, > + .bit_depth = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + { > + .fourcc = V4L2_PIX_FMT_RGB48, > + .align = 64, > + .bit_depth = 48, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + { > + .fourcc = V4L2_PIX_FMT_BGR48, > + .align = 64, > + .bit_depth = 48, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > + .colorspace_default = V4L2_COLORSPACE_SRGB, > + }, > + /* Bayer formats - 8-bit */ > + { > + .fourcc = V4L2_PIX_FMT_SRGGB8, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SBGGR8, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGRBG8, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGBRG8, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + /* Bayer formats - 16-bit */ > + { > + .fourcc = V4L2_PIX_FMT_SRGGB16, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SBGGR16, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGRBG16, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGBRG16, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + /* Bayer formats unpacked to 16bpp */ > + /* 10 bit */ > + .fourcc = V4L2_PIX_FMT_SRGGB10, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SBGGR10, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGRBG10, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGBRG10, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + /* 12 bit */ > + .fourcc = V4L2_PIX_FMT_SRGGB12, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SBGGR12, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGRBG12, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGBRG12, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + /* 14 bit */ > + .fourcc = V4L2_PIX_FMT_SRGGB14, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SBGGR14, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGRBG14, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_SGBRG14, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + /* Bayer formats - 16-bit PiSP Compressed */ > + { > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_BGGR, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_RGGB, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GRBG, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GBRG, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + /* Greyscale Formats */ > + { > + .fourcc = V4L2_PIX_FMT_GREY, > + .bit_depth = 8, > + .align = 32, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_Y16, > + .bit_depth = 16, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > + { > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_MONO, > + .bit_depth = 8, > + .align = 32, > + .plane_factor = { P3(1.0) }, > + .num_planes = 1, > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > + .colorspace_default = V4L2_COLORSPACE_RAW, > + }, > +}; > + > +static const struct pisp_be_format meta_out_supported_formats[] = { > + /* Configuration buffer format. */ > + { > + .fourcc = V4L2_META_FMT_RPI_BE_CFG, > + }, > +}; > + > +#endif /* _PISP_BE_FORMATS_ */
Hi Sakari, On Sun, May 26, 2024 at 08:59:05PM +0000, Sakari Ailus wrote: > Hi Jacppo, > > Thanks for the update. > > A few comments on the driver itself... > > On Fri, May 24, 2024 at 04:00:22PM +0200, Jacopo Mondi wrote: > > From: Naushir Patuck <naush@raspberrypi.com> > > > > Add support for the Raspberry Pi PiSP Back End. > > > > The driver has been upported from the Raspberry Pi kernel at revision > > f74893f8a0c2 ("drivers: media: pisp_be: Update seqeuence numbers of the > > buffers"). > > > > The ISP documentation is available at: > > https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf > > > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.org> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > MAINTAINERS | 1 + > > drivers/media/platform/Kconfig | 1 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/raspberrypi/Kconfig | 5 + > > drivers/media/platform/raspberrypi/Makefile | 3 + > > .../platform/raspberrypi/pisp_be/Kconfig | 12 + > > .../platform/raspberrypi/pisp_be/Makefile | 6 + > > .../platform/raspberrypi/pisp_be/pisp_be.c | 1848 +++++++++++++++++ > > .../raspberrypi/pisp_be/pisp_be_formats.h | 519 +++++ > > 9 files changed, 2396 insertions(+) > > create mode 100644 drivers/media/platform/raspberrypi/Kconfig > > create mode 100644 drivers/media/platform/raspberrypi/Makefile > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Kconfig > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Makefile > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h [snip] > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > new file mode 100644 > > index 000000000000..c4d13462eb81 > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > @@ -0,0 +1,1848 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * PiSP Back End driver. > > + * Copyright (c) 2021-2024 Raspberry Pi Limited. > > + * > > + */ > > +#include <linux/clk.h> > > +#include <linux/interrupt.h> > > +#include <linux/io.h> > > +#include <linux/kernel.h> > > +#include <linux/lockdep.h> > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > Where is the header included from? If it's just this driver, then I'd put > it in the driver's directory. > > > +#include <linux/module.h> > > +#include <linux/platform_device.h> > > +#include <linux/pm_runtime.h> > > +#include <media/v4l2-device.h> > > +#include <media/v4l2-ioctl.h> > > +#include <media/videobuf2-dma-contig.h> > > +#include <media/videobuf2-vmalloc.h> > > + > > +#include "pisp_be_formats.h" > > + > > +/* Maximum number of config buffers possible */ > > +#define PISP_BE_NUM_CONFIG_BUFFERS VB2_MAX_FRAME > > + > > +/* > > + * We want to support 2 independent instances allowing 2 simultaneous users > > + * of the ISP-BE (of course they share hardware, platform resources and mutex). > > + * Each such instance comprises a group of device nodes representing input > > + * and output queues, and a media controller device node to describe them. > > + */ > > +#define PISPBE_NUM_NODE_GROUPS 2 > > While MC and V4L2 don't have a good support for contexts currently, just > duplicating the device nodes is a really poor solution. We should do better > than that. If we merge this, where is the limit in the number of contexts? > Is it 4? 8? Or when we run out of minor numbers? > > One API-based solution could be moving the IOCTL interface to MC device > node only. This wouldn't be a small change so I'm not proposing doing that > now. I think we could also use the request API. It is a bit more cumbersome to use from a userspace point of view, but this driver is meant to be used from libcamera, so we can isolate applications from the extra burden. We will need to add support for formats in the request API (or rather for requests in the format ioctls). From a kernel point of view, the helpers used by the codec drivers may not be suitable for ISP drivers, but I don't think it would be very difficult to implement other helpers is needed, isolating the ISP driver from the complexity of the request API. This doesn't preclude developing a better userspace API with ioctls on the MC device node only at a later point. If the above-mentioned kernel helpers are done right, transitioning to a new userspace API will have minimal impact on drivers. > The two short term alternatives I can think of are: > > - Merge the driver with one set of device nodes. Once the better APIs are > available, move to use those. That could be a suitable short term option. It would allow merging the userspace code in libcamera, which I would really like to do sooner than later. > - Merge the driver to the staging tree. I'm not very eager to go this route > as the drivers simply end up being abandoned in the staging tree. Work to > get the driver out of staging should continue. I don't like this option. Regardless of whether this particular driver would end up bit-rotting in drivers/staging/ or not (I do agree most drivers do, we should discuss the IPU3 ImgU driver at some point), I think the code quality is suitable for drivers/media/. > Perhaps the upside here is that this isn't the only device that would > benefit from better context support in MC/V4L2 so multiple parties have > incentives to have this matter addressed. [snip]
Hi Laurent, On Mon, May 27, 2024 at 04:19:11AM +0300, Laurent Pinchart wrote: > > One API-based solution could be moving the IOCTL interface to MC device > > node only. This wouldn't be a small change so I'm not proposing doing that > > now. > > I think we could also use the request API. It is a bit more cumbersome > to use from a userspace point of view, but this driver is meant to be > used from libcamera, so we can isolate applications from the extra > burden. > > We will need to add support for formats in the request API (or rather > for requests in the format ioctls). > > From a kernel point of view, the helpers used by the codec drivers may > not be suitable for ISP drivers, but I don't think it would be very > difficult to implement other helpers is needed, isolating the ISP driver > from the complexity of the request API. > > This doesn't preclude developing a better userspace API with ioctls on > the MC device node only at a later point. If the above-mentioned kernel > helpers are done right, transitioning to a new userspace API will have > minimal impact on drivers. This is indeed the third feasible option. I agree. The work on the framework side might not be that much either.
Hi Sakari thanks for review On Sun, May 26, 2024 at 08:59:05PM GMT, Sakari Ailus wrote: > Hi Jacppo, > > Thanks for the update. > > A few comments on the driver itself... > > On Fri, May 24, 2024 at 04:00:22PM +0200, Jacopo Mondi wrote: > > From: Naushir Patuck <naush@raspberrypi.com> > > > > Add support for the Raspberry Pi PiSP Back End. > > > > The driver has been upported from the Raspberry Pi kernel at revision > > f74893f8a0c2 ("drivers: media: pisp_be: Update seqeuence numbers of the > > buffers"). > > > > The ISP documentation is available at: > > https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf > > > > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.org> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > MAINTAINERS | 1 + > > drivers/media/platform/Kconfig | 1 + > > drivers/media/platform/Makefile | 1 + > > drivers/media/platform/raspberrypi/Kconfig | 5 + > > drivers/media/platform/raspberrypi/Makefile | 3 + > > .../platform/raspberrypi/pisp_be/Kconfig | 12 + > > .../platform/raspberrypi/pisp_be/Makefile | 6 + > > .../platform/raspberrypi/pisp_be/pisp_be.c | 1848 +++++++++++++++++ > > .../raspberrypi/pisp_be/pisp_be_formats.h | 519 +++++ > > 9 files changed, 2396 insertions(+) > > create mode 100644 drivers/media/platform/raspberrypi/Kconfig > > create mode 100644 drivers/media/platform/raspberrypi/Makefile > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Kconfig > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/Makefile > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > create mode 100644 drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index ba595fad2fb5..6790e5d8fbe2 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -18522,6 +18522,7 @@ L: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com> > > L: linux-media@vger.kernel.org > > S: Maintained > > F: Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml > > +F: drivers/media/platform/raspberrypi/pisp_be/ > > F: include/uapi/linux/media/raspberrypi/ > > > > RC-CORE / LIRC FRAMEWORK > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index 2d79bfc68c15..36353174a7d9 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -78,6 +78,7 @@ source "drivers/media/platform/nuvoton/Kconfig" > > source "drivers/media/platform/nvidia/Kconfig" > > source "drivers/media/platform/nxp/Kconfig" > > source "drivers/media/platform/qcom/Kconfig" > > +source "drivers/media/platform/raspberrypi/Kconfig" > > source "drivers/media/platform/renesas/Kconfig" > > source "drivers/media/platform/rockchip/Kconfig" > > source "drivers/media/platform/samsung/Kconfig" > > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > > index da17301f7439..4b04c51bdd8b 100644 > > --- a/drivers/media/platform/Makefile > > +++ b/drivers/media/platform/Makefile > > @@ -21,6 +21,7 @@ obj-y += nuvoton/ > > obj-y += nvidia/ > > obj-y += nxp/ > > obj-y += qcom/ > > +obj-y += raspberrypi/ > > obj-y += renesas/ > > obj-y += rockchip/ > > obj-y += samsung/ > > diff --git a/drivers/media/platform/raspberrypi/Kconfig b/drivers/media/platform/raspberrypi/Kconfig > > new file mode 100644 > > index 000000000000..e928f979019e > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/Kconfig > > @@ -0,0 +1,5 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > + > > +comment "Raspberry Pi media platform drivers" > > + > > +source "drivers/media/platform/raspberrypi/pisp_be/Kconfig" > > diff --git a/drivers/media/platform/raspberrypi/Makefile b/drivers/media/platform/raspberrypi/Makefile > > new file mode 100644 > > index 000000000000..c0d1a2dab486 > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +obj-y += pisp_be/ > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > > new file mode 100644 > > index 000000000000..d88e66d5c334 > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig > > @@ -0,0 +1,12 @@ > > +config VIDEO_RASPBERRYPI_PISP_BE > > + tristate "Raspberry Pi PiSP Backend (BE) ISP driver" > > + depends on V4L_PLATFORM_DRIVERS > > + depends on VIDEO_DEV && PM > > + select VIDEO_V4L2_SUBDEV_API > > + select MEDIA_CONTROLLER > > + select VIDEOBUF2_DMA_CONTIG > > + help > > + Say Y here to enable support for the PiSP Backend (BE) ISP driver. > > + > > + To compile this driver as a module, choose M here. The module will be > > + called pisp-be. > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/Makefile b/drivers/media/platform/raspberrypi/pisp_be/Makefile > > new file mode 100644 > > index 000000000000..a70bf5716824 > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/pisp_be/Makefile > > @@ -0,0 +1,6 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +# > > +# Makefile for Raspberry Pi PiSP Backend driver > > +# > > +pisp-be-objs := pisp_be.o > > +obj-$(CONFIG_VIDEO_RASPBERRYPI_PISP_BE) += pisp-be.o > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > new file mode 100644 > > index 000000000000..c4d13462eb81 > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c > > @@ -0,0 +1,1848 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * PiSP Back End driver. > > + * Copyright (c) 2021-2024 Raspberry Pi Limited. > > + * > > + */ > > +#include <linux/clk.h> > > +#include <linux/interrupt.h> > > +#include <linux/io.h> > > +#include <linux/kernel.h> > > +#include <linux/lockdep.h> > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > Where is the header included from? If it's just this driver, then I'd put > it in the driver's directory. > It's the uAPI header file. Or did I miss your question ? > > +#include <linux/module.h> > > +#include <linux/platform_device.h> > > +#include <linux/pm_runtime.h> > > +#include <media/v4l2-device.h> > > +#include <media/v4l2-ioctl.h> > > +#include <media/videobuf2-dma-contig.h> > > +#include <media/videobuf2-vmalloc.h> > > + > > +#include "pisp_be_formats.h" > > + > > +/* Maximum number of config buffers possible */ > > +#define PISP_BE_NUM_CONFIG_BUFFERS VB2_MAX_FRAME > > + > > +/* > > + * We want to support 2 independent instances allowing 2 simultaneous users > > + * of the ISP-BE (of course they share hardware, platform resources and mutex). > > + * Each such instance comprises a group of device nodes representing input > > + * and output queues, and a media controller device node to describe them. > > + */ > > +#define PISPBE_NUM_NODE_GROUPS 2 > > While MC and V4L2 don't have a good support for contexts currently, just > duplicating the device nodes is a really poor solution. We should do better > than that. If we merge this, where is the limit in the number of contexts? > Is it 4? 8? Or when we run out of minor numbers? > > One API-based solution could be moving the IOCTL interface to MC device > node only. This wouldn't be a small change so I'm not proposing doing that > now. > > The two short term alternatives I can think of are: > > - Merge the driver with one set of device nodes. Once the better APIs are > available, move to use those. > > - Merge the driver to the staging tree. I'm not very eager to go this route > as the drivers simply end up being abandoned in the staging tree. Work to > get the driver out of staging should continue. > > Perhaps the upside here is that this isn't the only device that would > benefit from better context support in MC/V4L2 so multiple parties have > incentives to have this matter addressed. > Let's discuss this in the other thread > > + > > +#define PISPBE_NAME "pispbe" > > + > > +/* Some ISP-BE registers */ > > +#define PISP_BE_VERSION_REG 0x0 > > +#define PISP_BE_CONTROL_REG 0x4 > > +#define PISP_BE_CONTROL_COPY_CONFIG BIT(1) > > +#define PISP_BE_CONTROL_QUEUE_JOB BIT(0) > > +#define PISP_BE_CONTROL_NUM_TILES(n) ((n) << 16) > > +#define PISP_BE_TILE_ADDR_LO_REG 0x8 > > +#define PISP_BE_TILE_ADDR_HI_REG 0xc > > +#define PISP_BE_STATUS_REG 0x10 > > +#define PISP_BE_STATUS_QUEUED BIT(0) > > +#define PISP_BE_BATCH_STATUS_REG 0x14 > > +#define PISP_BE_INTERRUPT_EN_REG 0x18 > > +#define PISP_BE_INTERRUPT_STATUS_REG 0x1c > > +#define PISP_BE_AXI_REG 0x20 > > +#define PISP_BE_CONFIG_BASE_REG 0x40 > > +#define PISP_BE_IO_ADDR_LOW(n) (PISP_BE_CONFIG_BASE_REG + 8 * (n)) > > +#define PISP_BE_IO_ADDR_HIGH(n) (PISP_BE_IO_ADDR_LOW((n)) + 4) > > +#define PISP_BE_GLOBAL_BAYER_ENABLE 0xb0 > > +#define PISP_BE_GLOBAL_RGB_ENABLE 0xb4 > > +#define N_HW_ADDRESSES 13 > > +#define N_HW_ENABLES 2 > > + > > +#define PISP_BE_VERSION_2712 0x02252700 > > +#define PISP_BE_VERSION_MINOR_BITS 0xf > > + > > +/* > > + * This maps our nodes onto the inputs/outputs of the actual PiSP Back End. > > + * Be wary of the word "OUTPUT" which is used ambiguously here. In a V4L2 > > + * context it means an input to the hardware (source image or metadata). > > + * Elsewhere it means an output from the hardware. > > + */ > > +enum pispbe_node_ids { > > + MAIN_INPUT_NODE, > > + TDN_INPUT_NODE, > > + STITCH_INPUT_NODE, > > + OUTPUT0_NODE, > > + OUTPUT1_NODE, > > + TDN_OUTPUT_NODE, > > + STITCH_OUTPUT_NODE, > > + CONFIG_NODE, > > + PISPBE_NUM_NODES > > +}; > > + > > +struct pispbe_node_description { > > + const char *ent_name; > > + enum v4l2_buf_type buf_type; > > + unsigned int caps; > > +}; > > + > > +static const struct pispbe_node_description node_desc[PISPBE_NUM_NODES] = { > > + /* MAIN_INPUT_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-input", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > > + }, > > + /* TDN_INPUT_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-tdn_input", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > > + }, > > + /* STITCH_INPUT_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-stitch_input", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > > + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, > > + }, > > + /* OUTPUT0_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-output0", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > > + }, > > + /* OUTPUT1_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-output1", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > > + }, > > + /* TDN_OUTPUT_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-tdn_output", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > > + }, > > + /* STITCH_OUTPUT_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-stitch_output", > > + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, > > + }, > > + /* CONFIG_NODE */ > > + { > > + .ent_name = PISPBE_NAME "-config", > > + .buf_type = V4L2_BUF_TYPE_META_OUTPUT, > > + .caps = V4L2_CAP_META_OUTPUT, > > + } > > +}; > > + > > +#define NODE_DESC_IS_OUTPUT(desc) ( \ > > + ((desc)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ > > + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ > > + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) > > + > > +#define NODE_IS_META(node) ( \ > > + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT)) > > +#define NODE_IS_OUTPUT(node) ( \ > > + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) > > +#define NODE_IS_CAPTURE(node) ( \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE) || \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) > > +#define NODE_IS_MPLANE(node) ( \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) || \ > > + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) > > + > > +/* > > + * Structure to describe a single node /dev/video<N> which represents a single > > + * input or output queue to the PiSP Back End device. > > + */ > > +struct pispbe_node { > > + unsigned int id; > > + int vfl_dir; > > + enum v4l2_buf_type buf_type; > > + struct video_device vfd; > > + struct media_pad pad; > > + struct media_intf_devnode *intf_devnode; > > + struct media_link *intf_link; > > + struct pispbe_node_group *node_group; > > + /* Video device lock */ > > + struct mutex node_lock; > > + /* vb2_queue lock */ > > + struct mutex queue_lock; > > + /* Protect pispbe_node->ready_queue and pispbe_buffer->ready_list */ > > + spinlock_t ready_lock; > > + struct list_head ready_queue; > > + struct vb2_queue queue; > > + struct v4l2_format format; > > + const struct pisp_be_format *pisp_format; > > +}; > > + > > +/* For logging only, use the entity name with "pispbe" and separator removed */ > > +#define NODE_NAME(node) \ > > + (node_desc[(node)->id].ent_name + sizeof(PISPBE_NAME)) > > + > > +/* > > + * Node group structure, which comprises all the input and output nodes that a > > + * single PiSP client will need, along with its own v4l2 and media devices. > > + */ > > +struct pispbe_node_group { > > + unsigned int id; > > + struct v4l2_device v4l2_dev; > > + struct v4l2_subdev sd; > > + struct pispbe_dev *pispbe; > > + struct media_device mdev; > > + struct pispbe_node node[PISPBE_NUM_NODES]; > > + u32 streaming_map; /* bitmap of which nodes are streaming */ > > + struct media_pad pad[PISPBE_NUM_NODES]; /* output pads first */ > > + struct pisp_be_tiles_config *config; > > + dma_addr_t config_dma_addr; > > + unsigned int sequence; > > +}; > > + > > +/* Records details of the jobs currently running or queued on the h/w. */ > > +struct pispbe_job { > > + struct pispbe_node_group *node_group; > > + /* > > + * An array of buffer pointers - remember it's source buffers first, > > + * then captures, then metadata last. > > + */ > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES]; > > +}; > > + > > +/* Records a job configuration and memory addresses. */ > > +struct pispbe_job_descriptor { > > + dma_addr_t hw_dma_addrs[N_HW_ADDRESSES]; > > + struct pisp_be_tiles_config *config; > > + u32 hw_enables[N_HW_ENABLES]; > > + dma_addr_t tiles; > > +}; > > + > > +/* > > + * Structure representing the entire PiSP Back End device, comprising several > > + * node groups which share platform resources and a mutex for the actual HW. > > + */ > > +struct pispbe_dev { > > + struct device *dev; > > + struct pispbe_node_group node_group[PISPBE_NUM_NODE_GROUPS]; > > + int hw_busy; /* non-zero if a job is queued or is being started */ > > You could sort the 32-bit field with the rest of the non-64-bit fields > below. Ack > > > + struct pispbe_job queued_job, running_job; > > + void __iomem *be_reg_base; > > + struct clk *clk; > > + int irq; > > + u32 hw_version; > > + u8 done, started; > > + spinlock_t hw_lock; /* protects "hw_busy" flag and streaming_map */ > > +}; > > + > > +static u32 pispbe_rd(struct pispbe_dev *pispbe, unsigned int offset) > > +{ > > + return readl(pispbe->be_reg_base + offset); > > +} > > + > > +static void pispbe_wr(struct pispbe_dev *pispbe, unsigned int offset, u32 val) > > +{ > > + writel(val, pispbe->be_reg_base + offset); > > +} > > + > > +/* > > + * Queue a job to the h/w. If the h/w is idle it will begin immediately. > > + * Caller must ensure it is "safe to queue", i.e. we don't already have a > > + * queued, unstarted job. > > + */ > > +static void pispbe_queue_job(struct pispbe_dev *pispbe, > > + struct pispbe_job_descriptor *job) > > +{ > > + unsigned int begin, end; > > + > > + if (pispbe_rd(pispbe, PISP_BE_STATUS_REG) & PISP_BE_STATUS_QUEUED) > > + dev_err(pispbe->dev, "ERROR: not safe to queue new job!\n"); > > + > > + /* > > + * Write configuration to hardware. DMA addresses and enable flags > > + * are passed separately, because the driver needs to sanitize them, > > + * and we don't want to modify (or be vulnerable to modifications of) > > + * the mmap'd buffer. > > + */ > > + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { > > + pispbe_wr(pispbe, PISP_BE_IO_ADDR_LOW(u), > > + lower_32_bits(job->hw_dma_addrs[u])); > > + pispbe_wr(pispbe, PISP_BE_IO_ADDR_HIGH(u), > > + upper_32_bits(job->hw_dma_addrs[u])); > > + } > > + pispbe_wr(pispbe, PISP_BE_GLOBAL_BAYER_ENABLE, job->hw_enables[0]); > > + pispbe_wr(pispbe, PISP_BE_GLOBAL_RGB_ENABLE, job->hw_enables[1]); > > + > > + /* Everything else is as supplied by the user. */ > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > + / sizeof(u32); > > The slash should be on the previous line. Same elsewhere. > Please, this is highly subjective and other people (like Laurent) often ask for the contrary. Without any polemic intent, I encourage reviewers (myself included) in considering how much time we spend (and demand) on such subjective issues. Even more when other reviewers might have different opinions, with the end result of pulling contributors in different directions. > > + end = sizeof(struct pisp_be_config) / sizeof(u32); > > + for (unsigned int u = begin; u < end; u++) > > + pispbe_wr(pispbe, PISP_BE_CONFIG_BASE_REG + 4 * u, > > s/4/sizeof(u32)/ ack > > > + ((u32 *)job->config)[u]); > > + > > + /* Read back the addresses -- an error here could be fatal */ > > + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { > > + unsigned int offset = PISP_BE_IO_ADDR_LOW(u); > > + u64 along = pispbe_rd(pispbe, offset); > > + > > + along += ((u64)pispbe_rd(pispbe, offset + 4)) << 32; > > + if (along != (u64)(job->hw_dma_addrs[u])) { > > + dev_dbg(pispbe->dev, > > + "ISP BE config error: check if ISP RAMs enabled?\n"); > > + return; > > + } > > + } > > + > > + /* > > + * Write tile pointer to hardware. The IOMMU should prevent > > + * out-of-bounds offsets reaching non-ISP buffers. > > + */ > > + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_LO_REG, lower_32_bits(job->tiles)); > > + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_HI_REG, upper_32_bits(job->tiles)); > > + > > + /* Enqueue the job */ > > + pispbe_wr(pispbe, PISP_BE_CONTROL_REG, > > + PISP_BE_CONTROL_COPY_CONFIG | PISP_BE_CONTROL_QUEUE_JOB | > > + PISP_BE_CONTROL_NUM_TILES(job->config->num_tiles)); > > +} > > + > > +struct pispbe_buffer { > > + struct vb2_v4l2_buffer vb; > > + struct list_head ready_list; > > + unsigned int config_index; > > +}; > > + > > +static int pispbe_get_planes_addr(dma_addr_t addr[3], struct pispbe_buffer *buf, > > + struct pispbe_node *node) > > +{ > > + unsigned int num_planes = node->format.fmt.pix_mp.num_planes; > > + unsigned int plane_factor = 0; > > + unsigned int size; > > + unsigned int p; > > + > > + if (!buf || !node->pisp_format) > > + return 0; > > + > > + /* > > + * Determine the base plane size. This will not be the same > > + * as node->format.fmt.pix_mp.plane_fmt[0].sizeimage for a single > > + * plane buffer in an mplane format. > > + */ > > + size = node->format.fmt.pix_mp.plane_fmt[0].bytesperline > > + * node->format.fmt.pix_mp.height; > > + > > + for (p = 0; p < num_planes && p < PISPBE_MAX_PLANES; p++) { > > + addr[p] = vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, p); > > + plane_factor += node->pisp_format->plane_factor[p]; > > + } > > + > > + for (; p < PISPBE_MAX_PLANES && node->pisp_format->plane_factor[p]; p++) { > > + /* > > + * Calculate the address offset of this plane as needed > > + * by the hardware. This is specifically for non-mplane > > + * buffer formats, where there are 3 image planes, e.g. > > + * for the V4L2_PIX_FMT_YUV420 format. > > + */ > > + addr[p] = addr[0] + ((size * plane_factor) >> 3); > > + plane_factor += node->pisp_format->plane_factor[p]; > > + } > > + > > + return num_planes; > > +} > > + > > +static dma_addr_t pispbe_get_addr(struct pispbe_buffer *buf) > > +{ > > + if (buf) > > + return vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, 0); > > + return 0; > > +} > > + > > +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], > > + u32 hw_enables[N_HW_ENABLES], > > + struct pisp_be_tiles_config *config, > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES], > > + struct pispbe_node_group *node_group) > > +{ > > + int ret; > > + > > + /* Take a copy of the "enable" bitmaps so we can modify them. */ > > + hw_enables[0] = config->config.global.bayer_enables; > > + hw_enables[1] = config->config.global.rgb_enables; > > I wonder if hw_enables would be better declared as a struct. struct hw_enable { u32 bayer_enable; u32 rgb_enable; }; ? > > > + > > + /* > > + * Main input first. There are 3 address pointers, corresponding to up > > + * to 3 planes. > > + */ > > + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], > > + &node_group->node[MAIN_INPUT_NODE]); > > + if (ret <= 0) { > > + /* > > + * This shouldn't happen; pispbe_schedule_internal should insist > > + * on an input. > > + */ > > + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); > > + hw_enables[0] = 0; > > + hw_enables[1] = 0; > > + return; > > + } > > + > > + /* > > + * Now TDN/Stitch inputs and outputs. These are single-plane and only > > + * used with Bayer input. Input enables must match the requirements > > + * of the processing stages, otherwise the hardware can lock up! > > + */ > > + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { > > + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); > > + if (addrs[3] == 0 || > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || > > + (config->config.tdn.reset & 1)) { > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | > > + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); > > + if (!(config->config.tdn.reset & 1)) > > + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; > > + } > > + > > + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); > > + if (addrs[4] == 0 || > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { > > + hw_enables[0] &= > > + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | > > + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | > > + PISP_BE_BAYER_ENABLE_STITCH); > > + } > > + > > + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); > > + if (addrs[5] == 0) > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | > > + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); > > + > > + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); > > + if (addrs[6] == 0) > > + hw_enables[0] &= > > + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | > > + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); > > + } else { > > + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ > > + hw_enables[0] = 0; > > + } > > + > > + /* Main image output channels. */ > > + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { > > + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, > > + buf[OUTPUT0_NODE + i], > > + &node_group->node[OUTPUT0_NODE + i]); > > + if (ret <= 0) > > + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); > > + } > > +} > > + > > +/* > > + * Prepare a job description to be submitted to the HW. > > + * > > + * To schedule a job, we need all streaming nodes (apart from Output0, > > + * Output1, Tdn and Stitch) to have a buffer ready, which must > > + * include at least a config buffer and a main input image. > > + * > > + * For Output0, Output1, Tdn and Stitch, a buffer only needs to be > > + * available if the blocks are enabled in the config. > > + * > > + * Needs to be called with hw_lock held. > > + * > > + * Returns 0 if a job has been successfully prepared, < 0 otherwise. > > + */ > > +static int pispbe_prepare_job(struct pispbe_node_group *node_group, > > + struct pispbe_job_descriptor *job) > > +{ > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES] = {}; > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + unsigned int config_index; > > + struct pispbe_node *node; > > + unsigned long flags; > > + > > + lockdep_assert_held(&pispbe->hw_lock); > > + > > + memset(job, 0, sizeof(struct pispbe_job_descriptor)); > > + > > + if (((BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE)) & > > + node_group->streaming_map) != > > + (BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE))) > > + return -ENODEV; > > + > > + node = &node_group->node[CONFIG_NODE]; > > + spin_lock_irqsave(&node->ready_lock, flags); > > + buf[CONFIG_NODE] = list_first_entry_or_null(&node->ready_queue, > > + struct pispbe_buffer, > > + ready_list); > > + if (buf[CONFIG_NODE]) { > > + list_del(&buf[CONFIG_NODE]->ready_list); > > + pispbe->queued_job.buf[CONFIG_NODE] = buf[CONFIG_NODE]; > > + } > > + spin_unlock_irqrestore(&node->ready_lock, flags); > > + > > + /* Exit early if no config buffer has been queued. */ > > + if (!buf[CONFIG_NODE]) > > + return -ENODEV; > > + > > + config_index = buf[CONFIG_NODE]->vb.vb2_buf.index; > > + job->config = &node_group->config[config_index]; > > + job->tiles = node_group->config_dma_addr + > > + config_index * sizeof(struct pisp_be_tiles_config) + > > + offsetof(struct pisp_be_tiles_config, tiles); > > + > > + /* remember: srcimages, captures then metadata */ > > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > > + unsigned int bayer_en = > > + job->config->config.global.bayer_enables; > > + unsigned int rgb_en = > > + job->config->config.global.rgb_enables; > > + bool ignore_buffers = false; > > + > > + /* Config node is handled outside the loop above. */ > > + if (i == CONFIG_NODE) > > + continue; > > + > > + buf[i] = NULL; > > + if (!(node_group->streaming_map & BIT(i))) > > + continue; > > + > > + if ((!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT0) && > > + i == OUTPUT0_NODE) || > > + (!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT1) && > > + i == OUTPUT1_NODE) || > > + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_INPUT) && > > + i == TDN_INPUT_NODE) || > > + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) && > > + i == TDN_OUTPUT_NODE) || > > + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_INPUT) && > > + i == STITCH_INPUT_NODE) || > > + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) && > > + i == STITCH_OUTPUT_NODE)) { > > + /* > > + * Ignore Output0/Output1/Tdn/Stitch buffer check if the > > + * global enables aren't set for these blocks. If a > > + * buffer has been provided, we dequeue it back to the > > + * user with the other in-use buffers. > > + */ > > + ignore_buffers = true; > > + } > > + > > + node = &node_group->node[i]; > > + > > + /* Pull a buffer from each V4L2 queue to form the queued job */ > > + spin_lock_irqsave(&node->ready_lock, flags); > > + buf[i] = list_first_entry_or_null(&node->ready_queue, > > + struct pispbe_buffer, > > + ready_list); > > + if (buf[i]) { > > + list_del(&buf[i]->ready_list); > > + pispbe->queued_job.buf[i] = buf[i]; > > + } > > + spin_unlock_irqrestore(&node->ready_lock, flags); > > + > > + if (!buf[i] && !ignore_buffers) > > + goto err_return_buffers; > > + } > > + > > + pispbe->queued_job.node_group = node_group; > > + > > + /* Convert buffers to DMA addresses for the hardware */ > > + pispbe_xlate_addrs(job->hw_dma_addrs, job->hw_enables, > > + job->config, buf, node_group); > > + > > + return 0; > > + > > +err_return_buffers: > > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > > + struct pispbe_node *n = &node_group->node[i]; > > + > > + if (!buf[i]) > > + continue; > > + > > + /* Return the buffer to the ready_list queue */ > > + spin_lock_irqsave(&n->ready_lock, flags); > > + list_add(&buf[i]->ready_list, &n->ready_queue); > > + spin_unlock_irqrestore(&n->ready_lock, flags); > > + } > > + > > + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); > > + > > + return -ENODEV; > > +} > > + > > +static void pispbe_schedule(struct pispbe_dev *pispbe, > > + struct pispbe_node_group *node_group, > > + bool clear_hw_busy) > > +{ > > + struct pispbe_job_descriptor job; > > + unsigned long flags; > > + > > + spin_lock_irqsave(&pispbe->hw_lock, flags); > > + > > + if (clear_hw_busy) > > + pispbe->hw_busy = 0; > > + > > + if (pispbe->hw_busy) > > + goto unlock_and_return; > > + > > + for (unsigned int i = 0; i < PISPBE_NUM_NODE_GROUPS; i++) { > > + int ret; > > + > > + /* Schedule jobs only for a specific group. */ > > + if (node_group && > > + &pispbe->node_group[i] != node_group) > > Fits on the previous line. > ack > > + continue; > > + > > + /* > > + * Prepare a job for this group, if the group is not ready > > + * continue and try with the next one. > > + */ > > + ret = pispbe_prepare_job(&pispbe->node_group[i], &job); > > + if (ret) > > + continue; > > + > > + /* > > + * We can kick the job off without the hw_lock, as this can > > + * never run again until hw_busy is cleared, which will happen > > + * only when the following job has been queued and an interrupt > > + * is rised. > > + */ > > + pispbe->hw_busy = 1; > > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > > + > > + if (job.config->num_tiles <= 0 || > > + job.config->num_tiles > PISP_BACK_END_NUM_TILES || > > + !((job.hw_enables[0] | job.hw_enables[1]) & > > + PISP_BE_BAYER_ENABLE_INPUT)) { > > + /* > > + * Bad job. We can't let it proceed as it could lock up > > + * the hardware, or worse! > > + * > > + * For now, just force num_tiles to 0, which causes the > > + * H/W to do something bizarre but survivable. It > > + * increments (started,done) counters by more than 1, > > + * but we seem to survive... > > + */ > > + dev_dbg(pispbe->dev, > > + "Bad job: invalid number of tiles: %d\n", > > + job.config->num_tiles); > > + job.config->num_tiles = 0; > > + } > > + > > + pispbe_queue_job(pispbe, &job); > > + > > + return; > > + } > > + > > +unlock_and_return: > > + /* No job has been queued, just release the lock and return. */ > > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > > +} > > + > > +static void pispbe_isr_jobdone(struct pispbe_dev *pispbe, > > + struct pispbe_job *job) > > +{ > > + struct pispbe_buffer **buf = job->buf; > > + u64 ts = ktime_get_ns(); > > + > > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { > > + if (buf[i]) { > > + buf[i]->vb.vb2_buf.timestamp = ts; > > + buf[i]->vb.sequence = job->node_group->sequence; > > + vb2_buffer_done(&buf[i]->vb.vb2_buf, > > + VB2_BUF_STATE_DONE); > > + } > > + } > > + > > + job->node_group->sequence++; > > +} > > + > > +static irqreturn_t pispbe_isr(int irq, void *dev) > > +{ > > + struct pispbe_dev *pispbe = (struct pispbe_dev *)dev; > > + bool can_queue_another = false; > > + u8 started, done; > > + u32 u; > > + > > + u = pispbe_rd(pispbe, PISP_BE_INTERRUPT_STATUS_REG); > > + if (u == 0) > > + return IRQ_NONE; > > + > > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, u); > > + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); > > + done = (uint8_t)u; > > + started = (uint8_t)(u >> 8); > > + > > + /* > > + * Be aware that done can go up by 2 and started by 1 when: a job that > > + * we previously saw "start" now finishes, and we then queued a new job > > + * which we see both start and finish "simultaneously". > > + */ > > + if (pispbe->running_job.node_group && pispbe->done != done) { > > + pispbe_isr_jobdone(pispbe, &pispbe->running_job); > > + memset(&pispbe->running_job, 0, sizeof(pispbe->running_job)); > > + pispbe->done++; > > + } > > + > > + if (pispbe->started != started) { > > + pispbe->started++; > > + can_queue_another = 1; > §> + > > + if (pispbe->done != done && pispbe->queued_job.node_group) { > > + pispbe_isr_jobdone(pispbe, &pispbe->queued_job); > > + pispbe->done++; > > + } else { > > + pispbe->running_job = pispbe->queued_job; > > + } > > + > > + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); > > + } > > + > > + if (pispbe->done != done || pispbe->started != started) { > > + dev_dbg(pispbe->dev, > > + "Job counters not matching: done = %u, expected %u - started = %u, expected %u\n", > > + pispbe->done, done, pispbe->started, started); > > + pispbe->started = started; > > + pispbe->done = done; > > + } > > + > > + /* check if there's more to do before going to sleep */ > > + pispbe_schedule(pispbe, NULL, can_queue_another); > > + > > + return IRQ_HANDLED; > > +} > > + > > +static int pisp_be_validate_config(struct pispbe_node_group *node_group, > > + struct pisp_be_tiles_config *config) > > +{ > > + u32 bayer_enables = config->config.global.bayer_enables; > > + u32 rgb_enables = config->config.global.rgb_enables; > > + struct device *dev = node_group->pispbe->dev; > > + struct v4l2_format *fmt; > > + unsigned int bpl, size; > > + > > + if (!(bayer_enables & PISP_BE_BAYER_ENABLE_INPUT) == > > + !(rgb_enables & PISP_BE_RGB_ENABLE_INPUT)) { > > + dev_dbg(dev, "%s: Not one input enabled\n", __func__); > > + return -EIO; > > + } > > + > > + /* Ensure output config strides and buffer sizes match the V4L2 formats. */ > > + fmt = &node_group->node[TDN_OUTPUT_NODE].format; > > + if (bayer_enables & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) { > > + bpl = config->config.tdn_output_format.stride; > > + size = bpl * config->config.tdn_output_format.height; > > + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { > > + dev_dbg(dev, "%s: bpl mismatch on tdn_output\n", > > + __func__); > > + return -EINVAL; > > + } > > + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { > > + dev_dbg(dev, "%s: size mismatch on tdn_output\n", > > + __func__); > > + return -EINVAL; > > + } > > + } > > + > > + fmt = &node_group->node[STITCH_OUTPUT_NODE].format; > > + if (bayer_enables & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) { > > + bpl = config->config.stitch_output_format.stride; > > + size = bpl * config->config.stitch_output_format.height; > > + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { > > + dev_dbg(dev, "%s: bpl mismatch on stitch_output\n", > > + __func__); > > + return -EINVAL; > > + } > > + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { > > + dev_dbg(dev, "%s: size mismatch on stitch_output\n", > > + __func__); > > + return -EINVAL; > > + } > > + } > > + > > + for (unsigned int j = 0; j < PISP_BACK_END_NUM_OUTPUTS; j++) { > > + if (!(rgb_enables & PISP_BE_RGB_ENABLE_OUTPUT(j))) > > + continue; > > + if (config->config.output_format[j].image.format & > > + PISP_IMAGE_FORMAT_WALLPAPER_ROLL) > > + continue; /* TODO: Size checks for wallpaper formats */ > > + > > + fmt = &node_group->node[OUTPUT0_NODE + j].format; > > + for (unsigned int i = 0; i < fmt->fmt.pix_mp.num_planes; i++) { > > + bpl = !i ? config->config.output_format[j].image.stride > > + : config->config.output_format[j].image.stride2; > > + size = bpl * config->config.output_format[j].image.height; > > + > > + if (config->config.output_format[j].image.format & > > + PISP_IMAGE_FORMAT_SAMPLING_420) > > + size >>= 1; > > + if (fmt->fmt.pix_mp.plane_fmt[i].bytesperline < bpl) { > > + dev_dbg(dev, "%s: bpl mismatch on output %d\n", > > + __func__, j); > > + return -EINVAL; > > + } > > + if (fmt->fmt.pix_mp.plane_fmt[i].sizeimage < size) { > > + dev_dbg(dev, "%s: size mismatch on output\n", > > + __func__); > > + return -EINVAL; > > + } > > + } > > + } > > + > > + return 0; > > +} > > + > > +static int pispbe_node_queue_setup(struct vb2_queue *q, unsigned int *nbuffers, > > + unsigned int *nplanes, unsigned int sizes[], > > + struct device *alloc_devs[]) > > +{ > > + struct pispbe_node *node = vb2_get_drv_priv(q); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + *nplanes = 1; > > + if (NODE_IS_MPLANE(node)) { > > + *nplanes = node->format.fmt.pix_mp.num_planes; > > + for (unsigned int i = 0; i < *nplanes; i++) { > > + unsigned int size = > > + node->format.fmt.pix_mp.plane_fmt[i].sizeimage; > > + > > + if (sizes[i] && sizes[i] < size) { > > + dev_dbg(pispbe->dev, "%s: size %u < %u\n", > > + __func__, sizes[i], size); > > + return -EINVAL; > > + } > > + sizes[i] = size; > > + } > > + } else if (NODE_IS_META(node)) { > > + sizes[0] = node->format.fmt.meta.buffersize; > > + /* > > + * Limit the config node buffer count to the number of internal > > + * buffers allocated. > > + */ > > + if (node->id == CONFIG_NODE) > > + *nbuffers = min_t(unsigned int, *nbuffers, > > + PISP_BE_NUM_CONFIG_BUFFERS); > > + } > > + > > + dev_dbg(pispbe->dev, > > + "Image (or metadata) size %u, nbuffers %u for node %s\n", > > + sizes[0], *nbuffers, NODE_NAME(node)); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_buffer_prepare(struct vb2_buffer *vb) > > +{ > > + struct pispbe_node *node = vb2_get_drv_priv(vb->vb2_queue); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + unsigned long size = 0; > > Size can be declared inside the loop. > ack > > + unsigned int num_planes = NODE_IS_MPLANE(node) > > + ? node->format.fmt.pix_mp.num_planes : 1; > > + > > + for (unsigned int i = 0; i < num_planes; i++) { > > + size = NODE_IS_MPLANE(node) > > + ? node->format.fmt.pix_mp.plane_fmt[i].sizeimage > > + : node->format.fmt.meta.buffersize; > > + > > + if (vb2_plane_size(vb, i) < size) { > > + dev_dbg(pispbe->dev, > > + "data will not fit into plane %d (%lu < %lu)\n", > > + i, vb2_plane_size(vb, i), size); > > + return -EINVAL; > > + } > > + > > + vb2_set_plane_payload(vb, i, size); > > + } > > + > > + if (node->id == CONFIG_NODE) { > > + void *dst = &node->node_group->config[vb->index]; > > + void *src = vb2_plane_vaddr(vb, 0); > > + > > + memcpy(dst, src, sizeof(struct pisp_be_tiles_config)); > > + > > + return pisp_be_validate_config(node->node_group, dst); > > + } > > + > > + return 0; > > +} > > + > > +static void pispbe_node_buffer_queue(struct vb2_buffer *buf) > > +{ > > + struct vb2_v4l2_buffer *vbuf = > > + container_of(buf, struct vb2_v4l2_buffer, vb2_buf); > > + struct pispbe_buffer *buffer = > > + container_of(vbuf, struct pispbe_buffer, vb); > > + struct pispbe_node *node = vb2_get_drv_priv(buf->vb2_queue); > > + struct pispbe_node_group *node_group = node->node_group; > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + unsigned long flags; > > + > > + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); > > + spin_lock_irqsave(&node->ready_lock, flags); > > + list_add_tail(&buffer->ready_list, &node->ready_queue); > > + spin_unlock_irqrestore(&node->ready_lock, flags); > > + > > + /* > > + * Every time we add a buffer, check if there's now some work for the hw > > + * to do, but only for this client. > > + */ > > + pispbe_schedule(node_group->pispbe, node_group, false); > > +} > > + > > +static int pispbe_node_start_streaming(struct vb2_queue *q, unsigned int count) > > +{ > > + struct pispbe_node *node = vb2_get_drv_priv(q); > > + struct pispbe_node_group *node_group = node->node_group; > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + unsigned long flags; > > + int ret; > > + > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > + if (ret < 0) > > + return ret; > > + > > + spin_lock_irqsave(&pispbe->hw_lock, flags); > > + node->node_group->streaming_map |= BIT(node->id); > > + node->node_group->sequence = 0; > > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > > + > > + dev_dbg(pispbe->dev, "%s: for node %s (count %u)\n", > > + __func__, NODE_NAME(node), count); > > + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", > > + node->node_group->streaming_map); > > + > > + /* Maybe we're ready to run. */ > > + pispbe_schedule(node_group->pispbe, node_group, false); > > + > > + return 0; > > +} > > + > > +static void pispbe_node_stop_streaming(struct vb2_queue *q) > > +{ > > + struct pispbe_node *node = vb2_get_drv_priv(q); > > + struct pispbe_node_group *node_group = node->node_group; > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + struct pispbe_buffer *buf; > > + unsigned long flags; > > + > > + /* > > + * Now this is a bit awkward. In a simple M2M device we could just wait > > + * for all queued jobs to complete, but here there's a risk that a > > + * partial set of buffers was queued and cannot be run. For now, just > > + * cancel all buffers stuck in the "ready queue", then wait for any > > + * running job. > > + * > > + * This may return buffers out of order. > > + */ > > + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); > > + spin_lock_irqsave(&pispbe->hw_lock, flags); > > + do { > > + unsigned long flags1; > > + > > + spin_lock_irqsave(&node->ready_lock, flags1); > > + buf = list_first_entry_or_null(&node->ready_queue, > > + struct pispbe_buffer, > > + ready_list); > > + if (buf) { > > + list_del(&buf->ready_list); > > + vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR); > > + } > > + spin_unlock_irqrestore(&node->ready_lock, flags1); > > + } while (buf); > > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > > + > > + vb2_wait_for_all_buffers(&node->queue); > > + > > + spin_lock_irqsave(&pispbe->hw_lock, flags); > > + node_group->streaming_map &= ~BIT(node->id); > > + spin_unlock_irqrestore(&pispbe->hw_lock, flags); > > + > > + pm_runtime_mark_last_busy(pispbe->dev); > > + pm_runtime_put_autosuspend(pispbe->dev); > > + > > + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", > > + node_group->streaming_map); > > +} > > + > > +static const struct vb2_ops pispbe_node_queue_ops = { > > + .queue_setup = pispbe_node_queue_setup, > > + .buf_prepare = pispbe_node_buffer_prepare, > > + .buf_queue = pispbe_node_buffer_queue, > > + .start_streaming = pispbe_node_start_streaming, > > + .stop_streaming = pispbe_node_stop_streaming, > > +}; > > + > > +static const struct v4l2_file_operations pispbe_fops = { > > + .owner = THIS_MODULE, > > + .open = v4l2_fh_open, > > + .release = vb2_fop_release, > > + .poll = vb2_fop_poll, > > + .unlocked_ioctl = video_ioctl2, > > + .mmap = vb2_fop_mmap > > +}; > > + > > +static int pispbe_node_querycap(struct file *file, void *priv, > > + struct v4l2_capability *cap) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + strscpy(cap->driver, PISPBE_NAME, sizeof(cap->driver)); > > + strscpy(cap->card, PISPBE_NAME, sizeof(cap->card)); > > + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", > > + dev_name(pispbe->dev)); > > + > > + cap->capabilities = V4L2_CAP_VIDEO_CAPTURE_MPLANE | > > + V4L2_CAP_VIDEO_OUTPUT_MPLANE | > > + V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS | > > + V4L2_CAP_META_OUTPUT; > > + cap->device_caps = node->vfd.device_caps; > > + > > + dev_dbg(pispbe->dev, "Caps for node %s: %x and %x (dev %x)\n", > > + NODE_NAME(node), cap->capabilities, cap->device_caps, > > + node->vfd.device_caps); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_g_fmt_vid_cap(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot get capture fmt for output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + *f = node->format; > > + dev_dbg(pispbe->dev, "Get capture format for node %s\n", > > + NODE_NAME(node)); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_g_fmt_vid_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot get capture fmt for output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + *f = node->format; > > + dev_dbg(pispbe->dev, "Get output format for node %s\n", > > + NODE_NAME(node)); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_g_fmt_meta_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot get capture fmt for meta output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + *f = node->format; > > + dev_dbg(pispbe->dev, "Get output format for meta node %s\n", > > + NODE_NAME(node)); > > + > > + return 0; > > +} > > + > > +static const struct pisp_be_format *pispbe_find_fmt(unsigned int fourcc) > > +{ > > + for (unsigned int i = 0; i < ARRAY_SIZE(supported_formats); i++) { > > + if (supported_formats[i].fourcc == fourcc) > > + return &supported_formats[i]; > > + } > > + > > + return NULL; > > +} > > + > > +static void pispbe_set_plane_params(struct v4l2_format *f, > > + const struct pisp_be_format *fmt) > > +{ > > + unsigned int nplanes = f->fmt.pix_mp.num_planes; > > + unsigned int total_plane_factor = 0; > > + > > + for (unsigned int i = 0; i < PISPBE_MAX_PLANES; i++) > > + total_plane_factor += fmt->plane_factor[i]; > > + > > + for (unsigned int i = 0; i < nplanes; i++) { > > + struct v4l2_plane_pix_format *p = &f->fmt.pix_mp.plane_fmt[i]; > > + unsigned int bpl, plane_size; > > + > > + bpl = (f->fmt.pix_mp.width * fmt->bit_depth) >> 3; > > + bpl = ALIGN(max(p->bytesperline, bpl), fmt->align); > > + > > + plane_size = bpl * f->fmt.pix_mp.height * > > + (nplanes > 1 ? fmt->plane_factor[i] : total_plane_factor); > > + /* > > + * The shift is to divide out the plane_factor fixed point > > + * scaling of 8. > > + */ > > + plane_size = max(p->sizeimage, plane_size >> 3); > > + > > + p->bytesperline = bpl; > > + p->sizeimage = plane_size; > > + } > > +} > > + > > +static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node) > > +{ > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + u32 pixfmt = f->fmt.pix_mp.pixelformat; > > + const struct pisp_be_format *fmt; > > + bool is_rgb; > > + > > + dev_dbg(pispbe->dev, > > + "%s: [%s] req %ux%u %p4cc, planes %d\n", > > + __func__, NODE_NAME(node), f->fmt.pix_mp.width, > > + f->fmt.pix_mp.height, &pixfmt, > > + f->fmt.pix_mp.num_planes); > > + > > + fmt = pispbe_find_fmt(pixfmt); > > + if (!fmt) { > > + dev_dbg(pispbe->dev, > > + "%s: [%s] Format not found, defaulting to YUV420\n", > > + __func__, NODE_NAME(node)); > > + fmt = pispbe_find_fmt(V4L2_PIX_FMT_YUV420); > > + } > > + > > + f->fmt.pix_mp.pixelformat = fmt->fourcc; > > + f->fmt.pix_mp.num_planes = fmt->num_planes; > > + f->fmt.pix_mp.field = V4L2_FIELD_NONE; > > + f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u), > > + PISP_BACK_END_MIN_TILE_WIDTH); > > + f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u), > > + PISP_BACK_END_MIN_TILE_HEIGHT); > > + > > + /* > > + * Fill in the actual colour space when the requested one was > > + * not supported. This also catches the case when the "default" > > + * colour space was requested (as that's never in the mask). > > + */ > > + if (!(V4L2_COLORSPACE_MASK(f->fmt.pix_mp.colorspace) & > > + fmt->colorspace_mask)) > > + f->fmt.pix_mp.colorspace = fmt->colorspace_default; > > + > > + /* In all cases, we only support the defaults for these: */ > > + f->fmt.pix_mp.ycbcr_enc = > > + V4L2_MAP_YCBCR_ENC_DEFAULT(f->fmt.pix_mp.colorspace); > > + f->fmt.pix_mp.xfer_func = > > + V4L2_MAP_XFER_FUNC_DEFAULT(f->fmt.pix_mp.colorspace); > > + > > + is_rgb = f->fmt.pix_mp.colorspace == V4L2_COLORSPACE_SRGB; > > + f->fmt.pix_mp.quantization = > > + V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb, f->fmt.pix_mp.colorspace, > > + f->fmt.pix_mp.ycbcr_enc); > > + > > + /* Set plane size and bytes/line for each plane. */ > > + pispbe_set_plane_params(f, fmt); > > + > > + for (unsigned int i = 0; i < f->fmt.pix_mp.num_planes; i++) { > > + dev_dbg(pispbe->dev, > > + "%s: [%s] calc plane %d, %ux%u, depth %u, bpl %u size %u\n", > > + __func__, NODE_NAME(node), i, f->fmt.pix_mp.width, > > + f->fmt.pix_mp.height, fmt->bit_depth, > > + f->fmt.pix_mp.plane_fmt[i].bytesperline, > > + f->fmt.pix_mp.plane_fmt[i].sizeimage); > > + } > > +} > > + > > +static int pispbe_node_try_fmt_vid_cap(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot set capture fmt for output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + > > + pispbe_try_format(f, node); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_try_fmt_vid_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (!NODE_IS_OUTPUT(node) || NODE_IS_META(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot set capture fmt for output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + > > + pispbe_try_format(f, node); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_try_fmt_meta_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { > > + dev_dbg(pispbe->dev, > > + "Cannot set capture fmt for meta output node %s\n", > > + NODE_NAME(node)); > > + return -EINVAL; > > + } > > + > > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_s_fmt_vid_cap(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + int ret; > > + > > + ret = pispbe_node_try_fmt_vid_cap(file, priv, f); > > + if (ret < 0) > > + return ret; > > + > > + node->format = *f; > > + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); > > + > > + dev_dbg(pispbe->dev, "Set capture format for node %s to %p4cc\n", > > + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_s_fmt_vid_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + int ret; > > + > > + ret = pispbe_node_try_fmt_vid_out(file, priv, f); > > + if (ret < 0) > > + return ret; > > + > > + node->format = *f; > > + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); > > + > > + dev_dbg(pispbe->dev, "Set output format for node %s to %p4cc\n", > > + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_s_fmt_meta_out(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + int ret; > > + > > + ret = pispbe_node_try_fmt_meta_out(file, priv, f); > > + if (ret < 0) > > + return ret; > > + > > + node->format = *f; > > + node->pisp_format = &meta_out_supported_formats[0]; > > + > > + dev_dbg(pispbe->dev, "Set output format for meta node %s to %p4cc\n", > > + NODE_NAME(node), &f->fmt.meta.dataformat); > > + > > + return 0; > > +} > > + > > +static int pispbe_node_enum_fmt(struct file *file, void *priv, > > + struct v4l2_fmtdesc *f) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + > > + if (f->type != node->queue.type) > > + return -EINVAL; > > + > > + if (NODE_IS_META(node)) { > > + if (f->index) > > + return -EINVAL; > > + > > + f->pixelformat = V4L2_META_FMT_RPI_BE_CFG; > > + f->flags = 0; > > + return 0; > > + } > > + > > + if (f->index >= ARRAY_SIZE(supported_formats)) > > + return -EINVAL; > > + > > + f->pixelformat = supported_formats[f->index].fourcc; > > + f->flags = 0; > > + > > + return 0; > > +} > > + > > +static int pispbe_enum_framesizes(struct file *file, void *priv, > > + struct v4l2_frmsizeenum *fsize) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + if (NODE_IS_META(node) || fsize->index) > > + return -EINVAL; > > + > > + if (!pispbe_find_fmt(fsize->pixel_format)) { > > + dev_dbg(pispbe->dev, "Invalid pixel code: %x\n", > > + fsize->pixel_format); > > + return -EINVAL; > > + } > > + > > + fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; > > + fsize->stepwise.min_width = 32; > > + fsize->stepwise.max_width = 65535; > > + fsize->stepwise.step_width = 2; > > + > > + fsize->stepwise.min_height = 32; > > + fsize->stepwise.max_height = 65535; > > + fsize->stepwise.step_height = 2; > > + > > + return 0; > > +} > > + > > +static int pispbe_node_streamon(struct file *file, void *priv, > > + enum v4l2_buf_type type) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + struct pispbe_dev *pispbe = node->node_group->pispbe; > > + > > + dev_dbg(pispbe->dev, "Stream on for node %s\n", NODE_NAME(node)); > > + > > + INIT_LIST_HEAD(&node->ready_queue); > > + > > + return vb2_streamon(&node->queue, type); > > +} > > + > > +static int pispbe_node_streamoff(struct file *file, void *priv, > > + enum v4l2_buf_type type) > > +{ > > + struct pispbe_node *node = video_drvdata(file); > > + > > + return vb2_streamoff(&node->queue, type); > > +} > > + > > +static const struct v4l2_ioctl_ops pispbe_node_ioctl_ops = { > > + .vidioc_querycap = pispbe_node_querycap, > > + .vidioc_g_fmt_vid_cap_mplane = pispbe_node_g_fmt_vid_cap, > > + .vidioc_g_fmt_vid_out_mplane = pispbe_node_g_fmt_vid_out, > > + .vidioc_g_fmt_meta_out = pispbe_node_g_fmt_meta_out, > > + .vidioc_try_fmt_vid_cap_mplane = pispbe_node_try_fmt_vid_cap, > > + .vidioc_try_fmt_vid_out_mplane = pispbe_node_try_fmt_vid_out, > > + .vidioc_try_fmt_meta_out = pispbe_node_try_fmt_meta_out, > > + .vidioc_s_fmt_vid_cap_mplane = pispbe_node_s_fmt_vid_cap, > > + .vidioc_s_fmt_vid_out_mplane = pispbe_node_s_fmt_vid_out, > > + .vidioc_s_fmt_meta_out = pispbe_node_s_fmt_meta_out, > > + .vidioc_enum_fmt_vid_cap = pispbe_node_enum_fmt, > > + .vidioc_enum_fmt_vid_out = pispbe_node_enum_fmt, > > + .vidioc_enum_fmt_meta_out = pispbe_node_enum_fmt, > > + .vidioc_enum_framesizes = pispbe_enum_framesizes, > > + .vidioc_create_bufs = vb2_ioctl_create_bufs, > > + .vidioc_prepare_buf = vb2_ioctl_prepare_buf, > > + .vidioc_querybuf = vb2_ioctl_querybuf, > > + .vidioc_qbuf = vb2_ioctl_qbuf, > > + .vidioc_dqbuf = vb2_ioctl_dqbuf, > > + .vidioc_expbuf = vb2_ioctl_expbuf, > > + .vidioc_reqbufs = vb2_ioctl_reqbufs, > > + .vidioc_streamon = pispbe_node_streamon, > > + .vidioc_streamoff = pispbe_node_streamoff, > > +}; > > + > > +static const struct video_device pispbe_videodev = { > > + .name = PISPBE_NAME, > > + .vfl_dir = VFL_DIR_M2M, /* gets overwritten */ > > + .fops = &pispbe_fops, > > + .ioctl_ops = &pispbe_node_ioctl_ops, > > + .minor = -1, > > + .release = video_device_release_empty, > > +}; > > + > > +static void pispbe_node_def_fmt(struct pispbe_node *node) > > +{ > > + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { > > + /* Config node */ > > + struct v4l2_format *f = &node->format; > > + > > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > > + f->type = node->buf_type; > > + } else { > > + struct v4l2_format f = {0}; > > + > > + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; > > + f.fmt.pix_mp.width = 1920; > > + f.fmt.pix_mp.height = 1080; > > + f.type = node->buf_type; > > You can assign these in the declaration. The same above. Here indeed I can. Above I don't think I can (if you mean in the if() branch) > > > + pispbe_try_format(&f, node); > > + node->format = f; > > + } > > + > > + node->pisp_format = pispbe_find_fmt(node->format.fmt.pix_mp.pixelformat); > > +} > > + > > +/* > > + * Initialise a struct pispbe_node and register it as /dev/video<N> > > + * to represent one of the PiSP Back End's input or output streams. > > + */ > > +static int pispbe_init_node(struct pispbe_node_group *node_group, > > + unsigned int id) > > +{ > > + bool output = NODE_DESC_IS_OUTPUT(&node_desc[id]); > > + struct pispbe_node *node = &node_group->node[id]; > > + struct media_entity *entity = &node->vfd.entity; > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + struct video_device *vdev = &node->vfd; > > + struct vb2_queue *q = &node->queue; > > + int ret; > > + > > + node->id = id; > > + node->node_group = node_group; > > + node->buf_type = node_desc[id].buf_type; > > + > > + mutex_init(&node->node_lock); > > + mutex_init(&node->queue_lock); > > + INIT_LIST_HEAD(&node->ready_queue); > > + spin_lock_init(&node->ready_lock); > > + > > + node->format.type = node->buf_type; > > + pispbe_node_def_fmt(node); > > + > > + q->type = node->buf_type; > > + q->io_modes = VB2_MMAP | VB2_DMABUF; > > + q->mem_ops = &vb2_dma_contig_memops; > > + q->drv_priv = node; > > + q->ops = &pispbe_node_queue_ops; > > + q->buf_struct_size = sizeof(struct pispbe_buffer); > > + q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > > + q->dev = node->node_group->pispbe->dev; > > + /* get V4L2 to handle node->queue locking */ > > + q->lock = &node->queue_lock; > > + > > + ret = vb2_queue_init(q); > > + if (ret < 0) { > > + dev_err(pispbe->dev, "vb2_queue_init failed\n"); > > + goto err_mutex_destroy; > > + } > > + > > + *vdev = pispbe_videodev; /* default initialization */ > > + strscpy(vdev->name, node_desc[id].ent_name, sizeof(vdev->name)); > > + vdev->v4l2_dev = &node_group->v4l2_dev; > > + vdev->vfl_dir = output ? VFL_DIR_TX : VFL_DIR_RX; > > + /* get V4L2 to serialise our ioctls */ > > + vdev->lock = &node->node_lock; > > + vdev->queue = &node->queue; > > + vdev->device_caps = V4L2_CAP_STREAMING | node_desc[id].caps; > > + > > + node->pad.flags = output ? MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK; > > + ret = media_entity_pads_init(entity, 1, &node->pad); > > + if (ret) { > > + dev_err(pispbe->dev, > > + "Failed to register media pads for %s device node\n", > > + NODE_NAME(node)); > > + goto err_unregister_queue; > > + } > > + > > + ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1); > > + if (ret) { > > + dev_err(pispbe->dev, > > + "Failed to register video %s device node\n", > > + NODE_NAME(node)); > > + goto err_unregister_queue; > > + } > > + video_set_drvdata(vdev, node); > > + > > + if (output) > > + ret = media_create_pad_link(entity, 0, &node_group->sd.entity, > > + id, MEDIA_LNK_FL_IMMUTABLE | > > + MEDIA_LNK_FL_ENABLED); > > + else > > + ret = media_create_pad_link(&node_group->sd.entity, id, entity, > > + 0, MEDIA_LNK_FL_IMMUTABLE | > > + MEDIA_LNK_FL_ENABLED); > > + if (ret) > > + goto err_unregister_video_dev; > > + > > + dev_dbg(pispbe->dev, "%s device node registered as /dev/video%d\n", > > + NODE_NAME(node), node->vfd.num); > > + > > + return 0; > > + > > +err_unregister_video_dev: > > + video_unregister_device(&node->vfd); > > +err_unregister_queue: > > + vb2_queue_release(&node->queue); > > +err_mutex_destroy: > > + mutex_destroy(&node->node_lock); > > + mutex_destroy(&node->queue_lock); > > + return ret; > > +} > > + > > +static const struct v4l2_subdev_pad_ops pispbe_pad_ops = { > > + .link_validate = v4l2_subdev_link_validate_default, > > +}; > > + > > +static const struct v4l2_subdev_ops pispbe_sd_ops = { > > + .pad = &pispbe_pad_ops, > > +}; > > + > > +static int pispbe_init_subdev(struct pispbe_node_group *node_group) > > +{ > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + struct v4l2_subdev *sd = &node_group->sd; > > + int ret; > > + > > + v4l2_subdev_init(sd, &pispbe_sd_ops); > > + sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; > > + sd->owner = THIS_MODULE; > > + sd->dev = pispbe->dev; > > + strscpy(sd->name, PISPBE_NAME, sizeof(sd->name)); > > + > > + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) > > + node_group->pad[i].flags = > > + NODE_DESC_IS_OUTPUT(&node_desc[i]) ? > > + MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE; > > + > > + ret = media_entity_pads_init(&sd->entity, PISPBE_NUM_NODES, > > + node_group->pad); > > + if (ret) > > + goto error; > > + > > + ret = v4l2_device_register_subdev(&node_group->v4l2_dev, sd); > > + if (ret) > > + goto error; > > + > > + return 0; > > + > > +error: > > + media_entity_cleanup(&sd->entity); > > + return ret; > > +} > > + > > +static int pispbe_init_group(struct pispbe_dev *pispbe, unsigned int id) > > +{ > > + struct pispbe_node_group *node_group = &pispbe->node_group[id]; > > + unsigned int num_registered = 0; > > + struct v4l2_device *v4l2_dev; > > + struct media_device *mdev; > > + int ret; > > + > > + node_group->id = id; > > + node_group->pispbe = pispbe; > > + node_group->streaming_map = 0; > > + > > + dev_dbg(pispbe->dev, "Register nodes for group %u\n", id); > > + > > + /* Register v4l2_device and media_device */ > > + mdev = &node_group->mdev; > > + mdev->hw_revision = node_group->pispbe->hw_version; > > + mdev->dev = node_group->pispbe->dev; > > + strscpy(mdev->model, PISPBE_NAME, sizeof(mdev->model)); > > + snprintf(mdev->bus_info, sizeof(mdev->bus_info), > > + "platform:%s", dev_name(node_group->pispbe->dev)); > > This is already done by media_device_init(), no need to repeat here. > ack, I'll drop > > + media_device_init(mdev); > > + > > + v4l2_dev = &node_group->v4l2_dev; > > + v4l2_dev->mdev = &node_group->mdev; > > + strscpy(v4l2_dev->name, PISPBE_NAME, sizeof(v4l2_dev->name)); > > + > > + ret = v4l2_device_register(pispbe->dev, &node_group->v4l2_dev); > > + if (ret) > > + goto err_media_dev_cleanup; > > + > > + /* Register the PISPBE subdevice. */ > > + ret = pispbe_init_subdev(node_group); > > + if (ret) > > + goto err_unregister_v4l2; > > + > > + /* Create device video nodes */ > > + for (; num_registered < PISPBE_NUM_NODES; num_registered++) { > > Please initialise num_registered here instead of the declaration. > yep > > + ret = pispbe_init_node(node_group, num_registered); > > + if (ret) > > + goto err_unregister_nodes; > > + } > > + > > + ret = media_device_register(mdev); > > + if (ret) > > + goto err_unregister_nodes; > > + > > + node_group->config = > > + dma_alloc_coherent(pispbe->dev, > > + sizeof(struct pisp_be_tiles_config) * > > + PISP_BE_NUM_CONFIG_BUFFERS, > > + &node_group->config_dma_addr, GFP_KERNEL); > > + if (!node_group->config) { > > + dev_err(pispbe->dev, "Unable to allocate cached config buffers.\n"); > > + ret = -ENOMEM; > > + goto err_unregister_mdev; > > + } > > + > > + return 0; > > + > > +err_unregister_mdev: > > + media_device_unregister(mdev); > > +err_unregister_nodes: > > + while (num_registered-- > 0) { > > + video_unregister_device(&node_group->node[num_registered].vfd); > > + vb2_queue_release(&node_group->node[num_registered].queue); > > + } > > + v4l2_device_unregister_subdev(&node_group->sd); > > + media_entity_cleanup(&node_group->sd.entity); > > +err_unregister_v4l2: > > + v4l2_device_unregister(v4l2_dev); > > +err_media_dev_cleanup: > > + media_device_cleanup(mdev); > > + return ret; > > +} > > + > > +static void pispbe_destroy_node_group(struct pispbe_node_group *node_group) > > +{ > > + struct pispbe_dev *pispbe = node_group->pispbe; > > + > > + if (node_group->config) { > > + dma_free_coherent(node_group->pispbe->dev, > > + sizeof(struct pisp_be_tiles_config) * > > + PISP_BE_NUM_CONFIG_BUFFERS, > > + node_group->config, > > + node_group->config_dma_addr); > > + } > > + > > + dev_dbg(pispbe->dev, "Unregister from media controller\n"); > > + > > + v4l2_device_unregister_subdev(&node_group->sd); > > + media_entity_cleanup(&node_group->sd.entity); > > + media_device_unregister(&node_group->mdev); > > + > > + for (int i = PISPBE_NUM_NODES - 1; i >= 0; i--) { > > + video_unregister_device(&node_group->node[i].vfd); > > + vb2_queue_release(&node_group->node[i].queue); > > + mutex_destroy(&node_group->node[i].node_lock); > > + mutex_destroy(&node_group->node[i].queue_lock); > > + } > > + > > + media_device_cleanup(&node_group->mdev); > > + v4l2_device_unregister(&node_group->v4l2_dev); > > +} > > + > > +static int pispbe_runtime_suspend(struct device *dev) > > +{ > > + struct pispbe_dev *pispbe = dev_get_drvdata(dev); > > + > > + clk_disable_unprepare(pispbe->clk); > > + > > + return 0; > > +} > > + > > +static int pispbe_runtime_resume(struct device *dev) > > +{ > > + struct pispbe_dev *pispbe = dev_get_drvdata(dev); > > + int ret; > > + > > + ret = clk_prepare_enable(pispbe->clk); > > + if (ret) { > > + dev_err(dev, "Unable to enable clock\n"); > > + return ret; > > + } > > + > > + dev_dbg(dev, "%s: Enabled clock, rate=%lu\n", > > + __func__, clk_get_rate(pispbe->clk)); > > + > > + return 0; > > +} > > + > > +static int pispbe_hw_init(struct pispbe_dev *pispbe) > > +{ > > + u32 u; > > + > > + /* Check the HW is present and has a known version */ > > + u = pispbe_rd(pispbe, PISP_BE_VERSION_REG); > > + dev_dbg(pispbe->dev, "pispbe_probe: HW version: 0x%08x", u); > > + pispbe->hw_version = u; > > + if ((u & ~PISP_BE_VERSION_MINOR_BITS) != PISP_BE_VERSION_2712) > > + return -ENODEV; > > + > > + /* Clear leftover interrupts */ > > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, 0xFFFFFFFFu); > > + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); > > + dev_dbg(pispbe->dev, "pispbe_probe: BatchStatus: 0x%08x", u); > > + pispbe->done = (uint8_t)u; > > + pispbe->started = (uint8_t)(u >> 8); > > + u = pispbe_rd(pispbe, PISP_BE_STATUS_REG); > > + dev_dbg(pispbe->dev, "pispbe_probe: Status: 0x%08x", u); > > + if (u != 0 || pispbe->done != pispbe->started) { > > + dev_err(pispbe->dev, "pispbe_probe: HW is stuck or busy\n"); > > + return -EBUSY; > > + } > > + /* > > + * AXI QOS=0, CACHE=4'b0010, PROT=3'b011 > > + * Also set "chicken bits" 22:20 which enable sub-64-byte bursts > > + * and AXI AWID/BID variability (on versions which support this). > > + */ > > + pispbe_wr(pispbe, PISP_BE_AXI_REG, 0x32703200u); > > + > > + /* Enable both interrupt flags */ > > + pispbe_wr(pispbe, PISP_BE_INTERRUPT_EN_REG, 0x00000003u); > > + > > + return 0; > > +} > > + > > +/* > > + * Probe the ISP-BE hardware block, as a single platform device. > > + * This will instantiate multiple "node groups" each with many device nodes. > > + */ > > +static int pispbe_probe(struct platform_device *pdev) > > +{ > > + unsigned int num_groups = 0; > > + struct pispbe_dev *pispbe; > > + int ret; > > + > > + pispbe = devm_kzalloc(&pdev->dev, sizeof(*pispbe), GFP_KERNEL); > > + if (!pispbe) > > + return -ENOMEM; > > + > > + dev_set_drvdata(&pdev->dev, pispbe); > > + pispbe->dev = &pdev->dev; > > + platform_set_drvdata(pdev, pispbe); > > + > > + pispbe->be_reg_base = devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR(pispbe->be_reg_base)) { > > + dev_err(&pdev->dev, "Failed to get ISP-BE registers address\n"); > > + return PTR_ERR(pispbe->be_reg_base); > > + } > > + > > + pispbe->irq = platform_get_irq(pdev, 0); > > + if (pispbe->irq <= 0) { > > + dev_err(&pdev->dev, "No IRQ resource\n"); > > + return -EINVAL; > > + } > > + > > + ret = devm_request_irq(&pdev->dev, pispbe->irq, pispbe_isr, 0, > > + PISPBE_NAME, pispbe); > > + if (ret) { > > + dev_err(&pdev->dev, "Unable to request interrupt\n"); > > + return ret; > > + } > > + > > + ret = dma_set_mask_and_coherent(pispbe->dev, DMA_BIT_MASK(36)); > > + if (ret) > > + return ret; > > + > > + pispbe->clk = devm_clk_get(&pdev->dev, NULL); > > + if (IS_ERR(pispbe->clk)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(pispbe->clk), > > + "Failed to get clock"); > > + > > + /* Hardware initialisation */ > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > + pm_runtime_use_autosuspend(pispbe->dev); > > + pm_runtime_enable(pispbe->dev); > > + > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > You'll need to call the driver's resume function manually instead. The > above depends on CONFIG_PM. > The driver selects CONFIG_PM, doesn't it ? > > + if (ret) > > + goto pm_runtime_disable_err; > > + > > + pispbe->hw_busy = 0; > > + spin_lock_init(&pispbe->hw_lock); > > + ret = pispbe_hw_init(pispbe); > > + if (ret) > > + goto pm_runtime_put_err; > > + > > + /* > > + * Initialise and register devices for each node_group, including media > > + * device > > + */ > > + for (num_groups = 0; > > + num_groups < PISPBE_NUM_NODE_GROUPS; > > + num_groups++) { > > + ret = pispbe_init_group(pispbe, num_groups); > > + if (ret) > > + goto disable_nodes_err; > > + } > > + > > + pm_runtime_mark_last_busy(pispbe->dev); > > + pm_runtime_put_autosuspend(pispbe->dev); > > + > > + return 0; > > + > > +disable_nodes_err: > > + while (num_groups-- > 0) > > + pispbe_destroy_node_group(&pispbe->node_group[num_groups]); > > +pm_runtime_put_err: > > + pm_runtime_put(pispbe->dev); > > +pm_runtime_disable_err: > > + pm_runtime_dont_use_autosuspend(pispbe->dev); > > + pm_runtime_disable(pispbe->dev); > > + > > + return ret; > > +} > > + > > +static int pispbe_remove(struct platform_device *pdev) > > +{ > > + struct pispbe_dev *pispbe = platform_get_drvdata(pdev); > > + > > + for (int i = PISPBE_NUM_NODE_GROUPS - 1; i >= 0; i--) > > + pispbe_destroy_node_group(&pispbe->node_group[i]); > > + > > + pm_runtime_dont_use_autosuspend(pispbe->dev); > > + pm_runtime_disable(pispbe->dev); > > + > > + return 0; > > +} > > + > > +static const struct dev_pm_ops pispbe_pm_ops = { > > + SET_RUNTIME_PM_OPS(pispbe_runtime_suspend, pispbe_runtime_resume, NULL) > > +}; > > + > > +static const struct of_device_id pispbe_of_match[] = { > > + { > > + .compatible = "raspberrypi,pispbe", > > + }, > > + { /* sentinel */ }, > > +}; > > +MODULE_DEVICE_TABLE(of, pispbe_of_match); > > + > > +static struct platform_driver pispbe_pdrv = { > > + .probe = pispbe_probe, > > + .remove = pispbe_remove, > > + .driver = { > > + .name = PISPBE_NAME, > > + .of_match_table = pispbe_of_match, > > + .pm = &pispbe_pm_ops, > > + }, > > +}; > > + > > +module_platform_driver(pispbe_pdrv); > > + > > +MODULE_DESCRIPTION("PiSP Back End driver"); > > +MODULE_AUTHOR("David Plowman <david.plowman@raspberrypi.com>"); > > +MODULE_AUTHOR("Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>"); > > +MODULE_LICENSE("GPL"); > > diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > > new file mode 100644 > > index 000000000000..ebd320c9888c > > --- /dev/null > > +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h > > @@ -0,0 +1,519 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * PiSP Back End driver image format definitions. > > + * > > + * Copyright (c) 2021 Raspberry Pi Ltd > > Any copyrights up to 2024 perhaps? Indeed > > > + */ > > + > > +#ifndef _PISP_BE_FORMATS_ > > +#define _PISP_BE_FORMATS_ > > + > > +#include <linux/bits.h> > > +#include <linux/videodev2.h> > > + > > +#define PISPBE_MAX_PLANES 3 > > +#define P3(x) ((x) * 8) > > + > > +struct pisp_be_format { > > + unsigned int fourcc; > > + unsigned int align; > > + unsigned int bit_depth; > > + /* 0P3 factor for plane sizing */ > > + unsigned int plane_factor[PISPBE_MAX_PLANES]; > > + unsigned int num_planes; > > + unsigned int colorspace_mask; > > + enum v4l2_colorspace colorspace_default; > > +}; > > + > > +#define V4L2_COLORSPACE_MASK(colorspace) BIT(colorspace) > > + > > +#define V4L2_COLORSPACE_MASK_JPEG \ > > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_JPEG) > > +#define V4L2_COLORSPACE_MASK_SMPTE170M \ > > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SMPTE170M) > > +#define V4L2_COLORSPACE_MASK_REC709 \ > > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_REC709) > > +#define V4L2_COLORSPACE_MASK_SRGB \ > > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SRGB) > > +#define V4L2_COLORSPACE_MASK_RAW \ > > + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_RAW) > > + > > +/* > > + * All three colour spaces SRGB, SMPTE170M and REC709 are fundamentally sRGB > > + * underneath (as near as makes no difference to us), just with different YCbCr > > + * encodings. Therefore the ISP can generate sRGB on its main output and any of > > + * the others on its low resolution output. Applications should, when using both > > + * outputs, program the colour spaces on them to be the same, matching whatever > > + * is requested for the low resolution output, even if the main output is > > + * producing an RGB format. In turn this requires us to allow all these colour > > + * spaces for every YUV/RGB output format. > > + */ > > +#define V4L2_COLORSPACE_MASK_ALL_SRGB (V4L2_COLORSPACE_MASK_JPEG | \ > > + V4L2_COLORSPACE_MASK_SRGB | \ > > + V4L2_COLORSPACE_MASK_SMPTE170M | \ > > + V4L2_COLORSPACE_MASK_REC709) > > + > > +static const struct pisp_be_format supported_formats[] = { > > + /* Single plane YUV formats */ > > + { > > + .fourcc = V4L2_PIX_FMT_YUV420, > > + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ > > + .align = 128, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YVU420, > > + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ > > + .align = 128, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_NV12, > > + .align = 32, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_NV21, > > + .align = 32, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YUYV, > > + .align = 64, > > + .bit_depth = 16, > > + .plane_factor = { P3(1) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_UYVY, > > + .align = 64, > > + .bit_depth = 16, > > + .plane_factor = { P3(1) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YVYU, > > + .align = 64, > > + .bit_depth = 16, > > + .plane_factor = { P3(1) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_VYUY, > > + .align = 64, > > + .bit_depth = 16, > > + .plane_factor = { P3(1) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + /* Multiplane YUV formats */ > > + { > > + .fourcc = V4L2_PIX_FMT_YUV420M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_NV12M, > > + .align = 32, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5) }, > > + .num_planes = 2, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_NV21M, > > + .align = 32, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5) }, > > + .num_planes = 2, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YVU420M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YUV422M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YVU422M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YUV444M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(1), P3(1) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_YVU444M, > > + .align = 64, > > + .bit_depth = 8, > > + .plane_factor = { P3(1), P3(1), P3(1) }, > > + .num_planes = 3, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, > > + }, > > + /* RGB formats */ > > + { > > + .fourcc = V4L2_PIX_FMT_RGB24, > > + .align = 32, > > + .bit_depth = 24, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_BGR24, > > + .align = 32, > > + .bit_depth = 24, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_XBGR32, > > + .align = 64, > > + .bit_depth = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_RGBX32, > > + .align = 64, > > + .bit_depth = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_RGB48, > > + .align = 64, > > + .bit_depth = 48, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_BGR48, > > + .align = 64, > > + .bit_depth = 48, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, > > + .colorspace_default = V4L2_COLORSPACE_SRGB, > > + }, > > + /* Bayer formats - 8-bit */ > > + { > > + .fourcc = V4L2_PIX_FMT_SRGGB8, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SBGGR8, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGRBG8, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGBRG8, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + /* Bayer formats - 16-bit */ > > + { > > + .fourcc = V4L2_PIX_FMT_SRGGB16, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SBGGR16, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGRBG16, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGBRG16, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + /* Bayer formats unpacked to 16bpp */ > > + /* 10 bit */ > > + .fourcc = V4L2_PIX_FMT_SRGGB10, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SBGGR10, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGRBG10, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGBRG10, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + /* 12 bit */ > > + .fourcc = V4L2_PIX_FMT_SRGGB12, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SBGGR12, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGRBG12, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGBRG12, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + /* 14 bit */ > > + .fourcc = V4L2_PIX_FMT_SRGGB14, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SBGGR14, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGRBG14, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_SGBRG14, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + /* Bayer formats - 16-bit PiSP Compressed */ > > + { > > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_BGGR, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_RGGB, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GRBG, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GBRG, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + /* Greyscale Formats */ > > + { > > + .fourcc = V4L2_PIX_FMT_GREY, > > + .bit_depth = 8, > > + .align = 32, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_Y16, > > + .bit_depth = 16, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > + { > > + .fourcc = V4L2_PIX_FMT_PISP_COMP1_MONO, > > + .bit_depth = 8, > > + .align = 32, > > + .plane_factor = { P3(1.0) }, > > + .num_planes = 1, > > + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, > > + .colorspace_default = V4L2_COLORSPACE_RAW, > > + }, > > +}; > > + > > +static const struct pisp_be_format meta_out_supported_formats[] = { > > + /* Configuration buffer format. */ > > + { > > + .fourcc = V4L2_META_FMT_RPI_BE_CFG, > > + }, > > +}; > > + > > +#endif /* _PISP_BE_FORMATS_ */ Thanks j > > -- > Kind regards, > > Sakari Ailus
Hi Jacopo, On Mon, May 27, 2024 at 09:56:00AM +0200, Jacopo Mondi wrote: > > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > > > Where is the header included from? If it's just this driver, then I'd put > > it in the driver's directory. > > > > It's the uAPI header file. Or did I miss your question ? If it's uapi, then you should have uapi in its header path. I.e. #include <uapi/linux...> > > > + /* Everything else is as supplied by the user. */ > > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > > + / sizeof(u32); > > > > The slash should be on the previous line. Same elsewhere. > > > > Please, this is highly subjective and other people (like Laurent) often > ask for the contrary. Without any polemic intent, I encourage reviewers > (myself included) in considering how much time we spend (and > demand) on such subjective issues. Even more when other reviewers might have > different opinions, with the end result of pulling contributors in > different directions. Having binary operators at the beginning of a statement split on multiple lines is simply uncommon, perhaps around 10 % of the cases in the media tree based on a quick look. Keeping the coding style consistent is beneficial for us all. ... > > > +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], > > > + u32 hw_enables[N_HW_ENABLES], > > > + struct pisp_be_tiles_config *config, > > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES], > > > + struct pispbe_node_group *node_group) > > > +{ > > > + int ret; > > > + > > > + /* Take a copy of the "enable" bitmaps so we can modify them. */ > > > + hw_enables[0] = config->config.global.bayer_enables; > > > + hw_enables[1] = config->config.global.rgb_enables; > > > > I wonder if hw_enables would be better declared as a struct. > > struct hw_enable { > u32 bayer_enable; > u32 rgb_enable; > }; > > ? You currently have an array of struct hw_enable here. > > > > > > + > > > + /* > > > + * Main input first. There are 3 address pointers, corresponding to up > > > + * to 3 planes. > > > + */ > > > + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], > > > + &node_group->node[MAIN_INPUT_NODE]); > > > + if (ret <= 0) { > > > + /* > > > + * This shouldn't happen; pispbe_schedule_internal should insist > > > + * on an input. > > > + */ > > > + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); > > > + hw_enables[0] = 0; > > > + hw_enables[1] = 0; > > > + return; > > > + } > > > + > > > + /* > > > + * Now TDN/Stitch inputs and outputs. These are single-plane and only > > > + * used with Bayer input. Input enables must match the requirements > > > + * of the processing stages, otherwise the hardware can lock up! > > > + */ > > > + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { > > > + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); > > > + if (addrs[3] == 0 || > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || > > > + (config->config.tdn.reset & 1)) { > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | > > > + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); > > > + if (!(config->config.tdn.reset & 1)) > > > + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; > > > + } > > > + > > > + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); > > > + if (addrs[4] == 0 || > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { > > > + hw_enables[0] &= > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | > > > + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | > > > + PISP_BE_BAYER_ENABLE_STITCH); > > > + } > > > + > > > + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); > > > + if (addrs[5] == 0) > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | > > > + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); > > > + > > > + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); > > > + if (addrs[6] == 0) > > > + hw_enables[0] &= > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | > > > + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); > > > + } else { > > > + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ > > > + hw_enables[0] = 0; > > > + } > > > + > > > + /* Main image output channels. */ > > > + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { > > > + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, > > > + buf[OUTPUT0_NODE + i], > > > + &node_group->node[OUTPUT0_NODE + i]); > > > + if (ret <= 0) > > > + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); > > > + } > > > +} ... > > > +static void pispbe_node_def_fmt(struct pispbe_node *node) > > > +{ > > > + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { > > > + /* Config node */ > > > + struct v4l2_format *f = &node->format; > > > + > > > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > > > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > > > + f->type = node->buf_type; > > > + } else { > > > + struct v4l2_format f = {0}; > > > + > > > + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; > > > + f.fmt.pix_mp.width = 1920; > > > + f.fmt.pix_mp.height = 1080; > > > + f.type = node->buf_type; > > > > You can assign these in the declaration. The same above. > > Here indeed I can. Above I don't think I can (if you mean in the if() > branch) Ack. ... > > > + /* Hardware initialisation */ > > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > > + pm_runtime_use_autosuspend(pispbe->dev); > > > + pm_runtime_enable(pispbe->dev); > > > + > > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > > > You'll need to call the driver's resume function manually instead. The > > above depends on CONFIG_PM. > > > > The driver selects CONFIG_PM, doesn't it ? It depends on PM. It'd be trivial to remove that dependency.
On Mon, May 27, 2024 at 08:14:00AM +0000, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 27, 2024 at 09:56:00AM +0200, Jacopo Mondi wrote: > > > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > > > > > Where is the header included from? If it's just this driver, then I'd put > > > it in the driver's directory. > > > > It's the uAPI header file. Or did I miss your question ? > > If it's uapi, then you should have uapi in its header path. I.e. > > #include <uapi/linux...> > > > > > + /* Everything else is as supplied by the user. */ > > > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > > > + / sizeof(u32); > > > > > > The slash should be on the previous line. Same elsewhere. > > > > > > > Please, this is highly subjective and other people (like Laurent) often > > ask for the contrary. Without any polemic intent, I encourage reviewers > > (myself included) in considering how much time we spend (and > > demand) on such subjective issues. Even more when other reviewers might have > > different opinions, with the end result of pulling contributors in > > different directions. > > Having binary operators at the beginning of a statement split on multiple > lines is simply uncommon, perhaps around 10 % of the cases in the media > tree based on a quick look. Keeping the coding style consistent is > beneficial for us all. I've been slowly but steadily working on increasing that number :-) I think the style above is the most readable, and I would leave it to driver authors (as long as they're consistent within a driver). > > ... > > > > > +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], > > > > + u32 hw_enables[N_HW_ENABLES], > > > > + struct pisp_be_tiles_config *config, > > > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES], > > > > + struct pispbe_node_group *node_group) > > > > +{ > > > > + int ret; > > > > + > > > > + /* Take a copy of the "enable" bitmaps so we can modify them. */ > > > > + hw_enables[0] = config->config.global.bayer_enables; > > > > + hw_enables[1] = config->config.global.rgb_enables; > > > > > > I wonder if hw_enables would be better declared as a struct. > > > > struct hw_enable { > > u32 bayer_enable; > > u32 rgb_enable; > > }; > > > > ? > > You currently have an array of struct hw_enable here. > > > > > + > > > > + /* > > > > + * Main input first. There are 3 address pointers, corresponding to up > > > > + * to 3 planes. > > > > + */ > > > > + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], > > > > + &node_group->node[MAIN_INPUT_NODE]); > > > > + if (ret <= 0) { > > > > + /* > > > > + * This shouldn't happen; pispbe_schedule_internal should insist > > > > + * on an input. > > > > + */ > > > > + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); > > > > + hw_enables[0] = 0; > > > > + hw_enables[1] = 0; > > > > + return; > > > > + } > > > > + > > > > + /* > > > > + * Now TDN/Stitch inputs and outputs. These are single-plane and only > > > > + * used with Bayer input. Input enables must match the requirements > > > > + * of the processing stages, otherwise the hardware can lock up! > > > > + */ > > > > + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { > > > > + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); > > > > + if (addrs[3] == 0 || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || > > > > + (config->config.tdn.reset & 1)) { > > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | > > > > + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); > > > > + if (!(config->config.tdn.reset & 1)) > > > > + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; > > > > + } > > > > + > > > > + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); > > > > + if (addrs[4] == 0 || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { > > > > + hw_enables[0] &= > > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | > > > > + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | > > > > + PISP_BE_BAYER_ENABLE_STITCH); > > > > + } > > > > + > > > > + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); > > > > + if (addrs[5] == 0) > > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | > > > > + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); > > > > + > > > > + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); > > > > + if (addrs[6] == 0) > > > > + hw_enables[0] &= > > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | > > > > + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); > > > > + } else { > > > > + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ > > > > + hw_enables[0] = 0; > > > > + } > > > > + > > > > + /* Main image output channels. */ > > > > + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { > > > > + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, > > > > + buf[OUTPUT0_NODE + i], > > > > + &node_group->node[OUTPUT0_NODE + i]); > > > > + if (ret <= 0) > > > > + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); > > > > + } > > > > +} > > ... > > > > > +static void pispbe_node_def_fmt(struct pispbe_node *node) > > > > +{ > > > > + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { > > > > + /* Config node */ > > > > + struct v4l2_format *f = &node->format; > > > > + > > > > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > > > > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > > > > + f->type = node->buf_type; > > > > + } else { > > > > + struct v4l2_format f = {0}; > > > > + > > > > + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; > > > > + f.fmt.pix_mp.width = 1920; > > > > + f.fmt.pix_mp.height = 1080; > > > > + f.type = node->buf_type; > > > > > > You can assign these in the declaration. The same above. > > > > Here indeed I can. Above I don't think I can (if you mean in the if() > > branch) > > Ack. > > ... > > > > > + /* Hardware initialisation */ > > > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > > > + pm_runtime_use_autosuspend(pispbe->dev); > > > > + pm_runtime_enable(pispbe->dev); > > > > + > > > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > > > > > You'll need to call the driver's resume function manually instead. The > > > above depends on CONFIG_PM. > > > > The driver selects CONFIG_PM, doesn't it ? > > It depends on PM. > > It'd be trivial to remove that dependency. For drivers such as sensor drivers that need to work on a wide variety of platforms, with varying configurations, I agree that not depending on CONFIG_PM is a good thing (I reserve the right to change my mind though :-)). For this driver, I don't think the dependency is an issue.
Hi Laurent, On Mon, May 27, 2024 at 11:31:33AM +0300, Laurent Pinchart wrote: > On Mon, May 27, 2024 at 08:14:00AM +0000, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Mon, May 27, 2024 at 09:56:00AM +0200, Jacopo Mondi wrote: > > > > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > > > > > > > Where is the header included from? If it's just this driver, then I'd put > > > > it in the driver's directory. > > > > > > It's the uAPI header file. Or did I miss your question ? > > > > If it's uapi, then you should have uapi in its header path. I.e. > > > > #include <uapi/linux...> > > > > > > > + /* Everything else is as supplied by the user. */ > > > > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > > > > + / sizeof(u32); > > > > > > > > The slash should be on the previous line. Same elsewhere. > > > > > > > > > > Please, this is highly subjective and other people (like Laurent) often > > > ask for the contrary. Without any polemic intent, I encourage reviewers > > > (myself included) in considering how much time we spend (and > > > demand) on such subjective issues. Even more when other reviewers might have > > > different opinions, with the end result of pulling contributors in > > > different directions. > > > > Having binary operators at the beginning of a statement split on multiple > > lines is simply uncommon, perhaps around 10 % of the cases in the media > > tree based on a quick look. Keeping the coding style consistent is > > beneficial for us all. > > I've been slowly but steadily working on increasing that number :-) I > think the style above is the most readable, and I would leave it to > driver authors (as long as they're consistent within a driver). This has been one of the differences between what's commonly (albeit not explicitly I guess) used in Linux compared to the GNU coding standards which is explicit about it. I prefer to keep it at the end of the line which apparently is the preference of a largish majority. ... > > > > > + /* Hardware initialisation */ > > > > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > > > > + pm_runtime_use_autosuspend(pispbe->dev); > > > > > + pm_runtime_enable(pispbe->dev); > > > > > + > > > > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > > > > > > > You'll need to call the driver's resume function manually instead. The > > > > above depends on CONFIG_PM. > > > > > > The driver selects CONFIG_PM, doesn't it ? > > > > It depends on PM. > > > > It'd be trivial to remove that dependency. > > For drivers such as sensor drivers that need to work on a wide variety > of platforms, with varying configurations, I agree that not depending on > CONFIG_PM is a good thing (I reserve the right to change my mind though > :-)). For this driver, I don't think the dependency is an issue. People tend to copy these from one driver to another so there is value in doing it properly even if the benefits for this driver might be minor.
On Mon, May 27, 2024 at 08:14:00AM GMT, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 27, 2024 at 09:56:00AM +0200, Jacopo Mondi wrote: > > > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > > > > > Where is the header included from? If it's just this driver, then I'd put > > > it in the driver's directory. > > > > > > > It's the uAPI header file. Or did I miss your question ? > > If it's uapi, then you should have uapi in its header path. I.e. > > #include <uapi/linux...> > ok > > > > + /* Everything else is as supplied by the user. */ > > > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > > > + / sizeof(u32); > > > > > > The slash should be on the previous line. Same elsewhere. > > > > > > > Please, this is highly subjective and other people (like Laurent) often > > ask for the contrary. Without any polemic intent, I encourage reviewers > > (myself included) in considering how much time we spend (and > > demand) on such subjective issues. Even more when other reviewers might have > > different opinions, with the end result of pulling contributors in > > different directions. > > Having binary operators at the beginning of a statement split on multiple > lines is simply uncommon, perhaps around 10 % of the cases in the media > tree based on a quick look. Keeping the coding style consistent is > beneficial for us all. > > ... > > > > > +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], > > > > + u32 hw_enables[N_HW_ENABLES], > > > > + struct pisp_be_tiles_config *config, > > > > + struct pispbe_buffer *buf[PISPBE_NUM_NODES], > > > > + struct pispbe_node_group *node_group) > > > > +{ > > > > + int ret; > > > > + > > > > + /* Take a copy of the "enable" bitmaps so we can modify them. */ > > > > + hw_enables[0] = config->config.global.bayer_enables; > > > > + hw_enables[1] = config->config.global.rgb_enables; > > > > > > I wonder if hw_enables would be better declared as a struct. > > > > struct hw_enable { > > u32 bayer_enable; > > u32 rgb_enable; > > }; > > > > ? > > You currently have an array of struct hw_enable here. > not really, I have an array of u32 struct pispbe_job_descriptor { dma_addr_t hw_dma_addrs[N_HW_ADDRESSES]; struct pisp_be_tiles_config *config; u32 hw_enables[N_HW_ENABLES]; which is actually one for the bayer input enable flags and one for the rgb output enable flags. So one structure as proposed above will do > > > > > > > > > + > > > > + /* > > > > + * Main input first. There are 3 address pointers, corresponding to up > > > > + * to 3 planes. > > > > + */ > > > > + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], > > > > + &node_group->node[MAIN_INPUT_NODE]); > > > > + if (ret <= 0) { > > > > + /* > > > > + * This shouldn't happen; pispbe_schedule_internal should insist > > > > + * on an input. > > > > + */ > > > > + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); > > > > + hw_enables[0] = 0; > > > > + hw_enables[1] = 0; > > > > + return; > > > > + } > > > > + > > > > + /* > > > > + * Now TDN/Stitch inputs and outputs. These are single-plane and only > > > > + * used with Bayer input. Input enables must match the requirements > > > > + * of the processing stages, otherwise the hardware can lock up! > > > > + */ > > > > + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { > > > > + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); > > > > + if (addrs[3] == 0 || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || > > > > + (config->config.tdn.reset & 1)) { > > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | > > > > + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); > > > > + if (!(config->config.tdn.reset & 1)) > > > > + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; > > > > + } > > > > + > > > > + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); > > > > + if (addrs[4] == 0 || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || > > > > + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { > > > > + hw_enables[0] &= > > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | > > > > + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | > > > > + PISP_BE_BAYER_ENABLE_STITCH); > > > > + } > > > > + > > > > + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); > > > > + if (addrs[5] == 0) > > > > + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | > > > > + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); > > > > + > > > > + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); > > > > + if (addrs[6] == 0) > > > > + hw_enables[0] &= > > > > + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | > > > > + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); > > > > + } else { > > > > + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ > > > > + hw_enables[0] = 0; > > > > + } > > > > + > > > > + /* Main image output channels. */ > > > > + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { > > > > + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, > > > > + buf[OUTPUT0_NODE + i], > > > > + &node_group->node[OUTPUT0_NODE + i]); > > > > + if (ret <= 0) > > > > + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); > > > > + } > > > > +} > > ... > > > > > +static void pispbe_node_def_fmt(struct pispbe_node *node) > > > > +{ > > > > + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { > > > > + /* Config node */ > > > > + struct v4l2_format *f = &node->format; > > > > + > > > > + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; > > > > + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); > > > > + f->type = node->buf_type; > > > > + } else { > > > > + struct v4l2_format f = {0}; > > > > + > > > > + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; > > > > + f.fmt.pix_mp.width = 1920; > > > > + f.fmt.pix_mp.height = 1080; > > > > + f.type = node->buf_type; > > > > > > You can assign these in the declaration. The same above. > > > > Here indeed I can. Above I don't think I can (if you mean in the if() > > branch) > > Ack. > > ... > > > > > + /* Hardware initialisation */ > > > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > > > + pm_runtime_use_autosuspend(pispbe->dev); > > > > + pm_runtime_enable(pispbe->dev); > > > > + > > > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > > > > > You'll need to call the driver's resume function manually instead. The > > > above depends on CONFIG_PM. > > > > > > > The driver selects CONFIG_PM, doesn't it ? > > It depends on PM. > > It'd be trivial to remove that dependency. > I don't think we'll ever have a raspberry pi kernel without CONFIG_PM. But I've now read your reply to Laurent and I'll change this. > -- > Regards, > > Sakari Ailus
Hi Sakari, Laurent On Mon, May 27, 2024 at 06:44:25AM GMT, Sakari Ailus wrote: > Hi Laurent, > > On Mon, May 27, 2024 at 04:19:11AM +0300, Laurent Pinchart wrote: > > > One API-based solution could be moving the IOCTL interface to MC device > > > node only. This wouldn't be a small change so I'm not proposing doing that > > > now. > > > > I think we could also use the request API. It is a bit more cumbersome > > to use from a userspace point of view, but this driver is meant to be > > used from libcamera, so we can isolate applications from the extra > > burden. > > > > We will need to add support for formats in the request API (or rather > > for requests in the format ioctls). > > > > From a kernel point of view, the helpers used by the codec drivers may > > not be suitable for ISP drivers, but I don't think it would be very > > difficult to implement other helpers is needed, isolating the ISP driver > > from the complexity of the request API. > > > > This doesn't preclude developing a better userspace API with ioctls on > > the MC device node only at a later point. If the above-mentioned kernel > > helpers are done right, transitioning to a new userspace API will have > > minimal impact on drivers. > > This is indeed the third feasible option. I agree. The work on the > framework side might not be that much either. > For the time being, I would like to move forward and merge the version of the driver with a single enabled context. As you can see the driver multiples the contexts by creating two groups The number of groups is defined by /* * We want to support 2 independent instances allowing 2 simultaneous users * of the ISP-BE (of course they share hardware, platform resources and mutex). * Each such instance comprises a group of device nodes representing input * and output queues, and a media controller device node to describe them. */ #define PISPBE_NUM_NODE_GROUPS 2 Can I simply set this to 1 or should the driver be reworked to remove the group concept completely (it will be quite some rework). You can guess what my preference is, and considering we want to experiment with a different API the group part will possibily need to be reintroduced. Also if we simply set PISPBE_NUM_NODE_GROUPS=1, the downstream RPi kernel will solely need to have 1 patch that restores the value to 2 to be able to use the mainline kernel driver instead of keeping their multi-context downstream version in use until multi-context is finalized in mainline. > -- > Regards, > > Sakari Ailus
Hi Sakari, On Mon, May 27, 2024 at 08:45:22AM +0000, Sakari Ailus wrote: > On Mon, May 27, 2024 at 11:31:33AM +0300, Laurent Pinchart wrote: > > On Mon, May 27, 2024 at 08:14:00AM +0000, Sakari Ailus wrote: > > > Hi Jacopo, > > > > > > On Mon, May 27, 2024 at 09:56:00AM +0200, Jacopo Mondi wrote: > > > > > > +#include <linux/media/raspberrypi/pisp_be_config.h> > > > > > > > > > > Where is the header included from? If it's just this driver, then I'd put > > > > > it in the driver's directory. > > > > > > > > It's the uAPI header file. Or did I miss your question ? > > > > > > If it's uapi, then you should have uapi in its header path. I.e. > > > > > > #include <uapi/linux...> > > > > > > > > > + /* Everything else is as supplied by the user. */ > > > > > > + begin = offsetof(struct pisp_be_config, global.bayer_order) > > > > > > + / sizeof(u32); > > > > > > > > > > The slash should be on the previous line. Same elsewhere. > > > > > > > > > > > > > Please, this is highly subjective and other people (like Laurent) often > > > > ask for the contrary. Without any polemic intent, I encourage reviewers > > > > (myself included) in considering how much time we spend (and > > > > demand) on such subjective issues. Even more when other reviewers might have > > > > different opinions, with the end result of pulling contributors in > > > > different directions. > > > > > > Having binary operators at the beginning of a statement split on multiple > > > lines is simply uncommon, perhaps around 10 % of the cases in the media > > > tree based on a quick look. Keeping the coding style consistent is > > > beneficial for us all. > > > > I've been slowly but steadily working on increasing that number :-) I > > think the style above is the most readable, and I would leave it to > > driver authors (as long as they're consistent within a driver). > > This has been one of the differences between what's commonly (albeit not > explicitly I guess) used in Linux compared to the GNU coding standards > which is explicit about it. > > I prefer to keep it at the end of the line which apparently is the > preference of a largish majority. > > ... > > > > > > > + /* Hardware initialisation */ > > > > > > + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); > > > > > > + pm_runtime_use_autosuspend(pispbe->dev); > > > > > > + pm_runtime_enable(pispbe->dev); > > > > > > + > > > > > > + ret = pm_runtime_resume_and_get(pispbe->dev); > > > > > > > > > > You'll need to call the driver's resume function manually instead. The > > > > > above depends on CONFIG_PM. > > > > > > > > The driver selects CONFIG_PM, doesn't it ? > > > > > > It depends on PM. > > > > > > It'd be trivial to remove that dependency. > > > > For drivers such as sensor drivers that need to work on a wide variety > > of platforms, with varying configurations, I agree that not depending on > > CONFIG_PM is a good thing (I reserve the right to change my mind though > > :-)). For this driver, I don't think the dependency is an issue. > > People tend to copy these from one driver to another so there is value in > doing it properly even if the benefits for this driver might be minor. For most ISP drivers I don't really see much value in supporting !CONFIG_PM. I don't think it's worth doing so here, especially given that it will never be tested.
Hi Jacopo, On Mon, May 27, 2024 at 12:18:54PM +0200, Jacopo Mondi wrote: > Hi Sakari, Laurent > > On Mon, May 27, 2024 at 06:44:25AM GMT, Sakari Ailus wrote: > > Hi Laurent, > > > > On Mon, May 27, 2024 at 04:19:11AM +0300, Laurent Pinchart wrote: > > > > One API-based solution could be moving the IOCTL interface to MC device > > > > node only. This wouldn't be a small change so I'm not proposing doing that > > > > now. > > > > > > I think we could also use the request API. It is a bit more cumbersome > > > to use from a userspace point of view, but this driver is meant to be > > > used from libcamera, so we can isolate applications from the extra > > > burden. > > > > > > We will need to add support for formats in the request API (or rather > > > for requests in the format ioctls). > > > > > > From a kernel point of view, the helpers used by the codec drivers may > > > not be suitable for ISP drivers, but I don't think it would be very > > > difficult to implement other helpers is needed, isolating the ISP driver > > > from the complexity of the request API. > > > > > > This doesn't preclude developing a better userspace API with ioctls on > > > the MC device node only at a later point. If the above-mentioned kernel > > > helpers are done right, transitioning to a new userspace API will have > > > minimal impact on drivers. > > > > This is indeed the third feasible option. I agree. The work on the > > framework side might not be that much either. > > > > For the time being, I would like to move forward and merge the version > of the driver with a single enabled context. > > As you can see the driver multiples the contexts by creating two > groups > > The number of groups is defined by > > /* > * We want to support 2 independent instances allowing 2 simultaneous users > * of the ISP-BE (of course they share hardware, platform resources and mutex). > * Each such instance comprises a group of device nodes representing input > * and output queues, and a media controller device node to describe them. > */ > #define PISPBE_NUM_NODE_GROUPS 2 > > Can I simply set this to 1 or should the driver be reworked to remove > the group concept completely (it will be quite some rework). > > You can guess what my preference is, and considering we want to > experiment with a different API the group part will possibily need to > be reintroduced. I believe you can also guess what my preference is. :-) I don't expect we'll need the number of groups in the upstream driver. Before deciding what to do here I'd like to arrive to a conclusion on how this gets addressed so the desired functionality is available in the upstream driver. Maybe the Request API is indeed something to consider here. I wonder what Laurent thinks. > > Also if we simply set PISPBE_NUM_NODE_GROUPS=1, the downstream RPi > kernel will solely need to have 1 patch that restores the value to 2 > to be able to use the mainline kernel driver instead of keeping their > multi-context downstream version in use until multi-context is > finalized in mainline.
Hello, On Mon, May 27, 2024 at 12:43:37PM +0000, Sakari Ailus wrote: > On Mon, May 27, 2024 at 12:18:54PM +0200, Jacopo Mondi wrote: > > On Mon, May 27, 2024 at 06:44:25AM GMT, Sakari Ailus wrote: > > > On Mon, May 27, 2024 at 04:19:11AM +0300, Laurent Pinchart wrote: > > > > > One API-based solution could be moving the IOCTL interface to MC device > > > > > node only. This wouldn't be a small change so I'm not proposing doing that > > > > > now. > > > > > > > > I think we could also use the request API. It is a bit more cumbersome > > > > to use from a userspace point of view, but this driver is meant to be > > > > used from libcamera, so we can isolate applications from the extra > > > > burden. > > > > > > > > We will need to add support for formats in the request API (or rather > > > > for requests in the format ioctls). > > > > > > > > From a kernel point of view, the helpers used by the codec drivers may > > > > not be suitable for ISP drivers, but I don't think it would be very > > > > difficult to implement other helpers is needed, isolating the ISP driver > > > > from the complexity of the request API. > > > > > > > > This doesn't preclude developing a better userspace API with ioctls on > > > > the MC device node only at a later point. If the above-mentioned kernel > > > > helpers are done right, transitioning to a new userspace API will have > > > > minimal impact on drivers. > > > > > > This is indeed the third feasible option. I agree. The work on the > > > framework side might not be that much either. > > > > For the time being, I would like to move forward and merge the version > > of the driver with a single enabled context. > > > > As you can see the driver multiples the contexts by creating two > > groups > > > > The number of groups is defined by > > > > /* > > * We want to support 2 independent instances allowing 2 simultaneous users > > * of the ISP-BE (of course they share hardware, platform resources and mutex). > > * Each such instance comprises a group of device nodes representing input > > * and output queues, and a media controller device node to describe them. > > */ > > #define PISPBE_NUM_NODE_GROUPS 2 > > > > Can I simply set this to 1 or should the driver be reworked to remove > > the group concept completely (it will be quite some rework). > > > > You can guess what my preference is, and considering we want to > > experiment with a different API the group part will possibily need to > > be reintroduced. > > I believe you can also guess what my preference is. :-) > > I don't expect we'll need the number of groups in the upstream driver. > > Before deciding what to do here I'd like to arrive to a conclusion on how > this gets addressed so the desired functionality is available in the > upstream driver. > > Maybe the Request API is indeed something to consider here. > > I wonder what Laurent thinks. Using the request API, we will still have contexts. Instead of having one media device per context, the contexts will be dynamically allocated, one per file handle. Would it be enough, as a first step forward, to refactor the contexts and move the media device and other related pieces out, keeping the fields that we expect will stay per-context ? > > Also if we simply set PISPBE_NUM_NODE_GROUPS=1, the downstream RPi > > kernel will solely need to have 1 patch that restores the value to 2 > > to be able to use the mainline kernel driver instead of keeping their > > multi-context downstream version in use until multi-context is > > finalized in mainline.
Hi Laurent, Sakari On Mon, May 27, 2024 at 06:39:24PM GMT, Laurent Pinchart wrote: > Hello, > > On Mon, May 27, 2024 at 12:43:37PM +0000, Sakari Ailus wrote: > > On Mon, May 27, 2024 at 12:18:54PM +0200, Jacopo Mondi wrote: > > > On Mon, May 27, 2024 at 06:44:25AM GMT, Sakari Ailus wrote: > > > > On Mon, May 27, 2024 at 04:19:11AM +0300, Laurent Pinchart wrote: > > > > > > One API-based solution could be moving the IOCTL interface to MC device > > > > > > node only. This wouldn't be a small change so I'm not proposing doing that > > > > > > now. > > > > > > > > > > I think we could also use the request API. It is a bit more cumbersome > > > > > to use from a userspace point of view, but this driver is meant to be > > > > > used from libcamera, so we can isolate applications from the extra > > > > > burden. > > > > > > > > > > We will need to add support for formats in the request API (or rather > > > > > for requests in the format ioctls). > > > > > > > > > > From a kernel point of view, the helpers used by the codec drivers may > > > > > not be suitable for ISP drivers, but I don't think it would be very > > > > > difficult to implement other helpers is needed, isolating the ISP driver > > > > > from the complexity of the request API. > > > > > > > > > > This doesn't preclude developing a better userspace API with ioctls on > > > > > the MC device node only at a later point. If the above-mentioned kernel > > > > > helpers are done right, transitioning to a new userspace API will have > > > > > minimal impact on drivers. > > > > > > > > This is indeed the third feasible option. I agree. The work on the > > > > framework side might not be that much either. > > > > > > For the time being, I would like to move forward and merge the version > > > of the driver with a single enabled context. > > > > > > As you can see the driver multiples the contexts by creating two > > > groups > > > > > > The number of groups is defined by > > > > > > /* > > > * We want to support 2 independent instances allowing 2 simultaneous users > > > * of the ISP-BE (of course they share hardware, platform resources and mutex). > > > * Each such instance comprises a group of device nodes representing input > > > * and output queues, and a media controller device node to describe them. > > > */ > > > #define PISPBE_NUM_NODE_GROUPS 2 > > > > > > Can I simply set this to 1 or should the driver be reworked to remove > > > the group concept completely (it will be quite some rework). > > > > > > You can guess what my preference is, and considering we want to > > > experiment with a different API the group part will possibily need to > > > be reintroduced. > > > > I believe you can also guess what my preference is. :-) > > I can yes :) > > I don't expect we'll need the number of groups in the upstream driver. > > No, not the number, you're right, it would be silly to keep the macro and define it to 1. I'm all for removing the for-loops that create and destroy groups and for removing from the group structure the fields that are now global (namely the v4l2_device, the subdev and the media_device), but I would like to keep the 'group' wrapper in-place, even if we'll end up having a single group in mainline. > > Before deciding what to do here I'd like to arrive to a conclusion on how > > this gets addressed so the desired functionality is available in the > > upstream driver. > > > > Maybe the Request API is indeed something to consider here. > > > > I wonder what Laurent thinks. > > Using the request API, we will still have contexts. Instead of having > one media device per context, the contexts will be dynamically > allocated, one per file handle. Would it be enough, as a first step > forward, to refactor the contexts and move the media device and other > related pieces out, keeping the fields that we expect will stay > per-context ? > I suspect we'll have to re-introduce contexts somehow, that's the reason why I would like to keep the group structure in place. I can experiment with removing the global fields from the group and check how much refactoring does it take to do so. > > > Also if we simply set PISPBE_NUM_NODE_GROUPS=1, the downstream RPi > > > kernel will solely need to have 1 patch that restores the value to 2 > > > to be able to use the mainline kernel driver instead of keeping their > > > multi-context downstream version in use until multi-context is > > > finalized in mainline. > > -- > Regards, > > Laurent Pinchart
diff --git a/MAINTAINERS b/MAINTAINERS index ba595fad2fb5..6790e5d8fbe2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18522,6 +18522,7 @@ L: Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com> L: linux-media@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml +F: drivers/media/platform/raspberrypi/pisp_be/ F: include/uapi/linux/media/raspberrypi/ RC-CORE / LIRC FRAMEWORK diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 2d79bfc68c15..36353174a7d9 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -78,6 +78,7 @@ source "drivers/media/platform/nuvoton/Kconfig" source "drivers/media/platform/nvidia/Kconfig" source "drivers/media/platform/nxp/Kconfig" source "drivers/media/platform/qcom/Kconfig" +source "drivers/media/platform/raspberrypi/Kconfig" source "drivers/media/platform/renesas/Kconfig" source "drivers/media/platform/rockchip/Kconfig" source "drivers/media/platform/samsung/Kconfig" diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile index da17301f7439..4b04c51bdd8b 100644 --- a/drivers/media/platform/Makefile +++ b/drivers/media/platform/Makefile @@ -21,6 +21,7 @@ obj-y += nuvoton/ obj-y += nvidia/ obj-y += nxp/ obj-y += qcom/ +obj-y += raspberrypi/ obj-y += renesas/ obj-y += rockchip/ obj-y += samsung/ diff --git a/drivers/media/platform/raspberrypi/Kconfig b/drivers/media/platform/raspberrypi/Kconfig new file mode 100644 index 000000000000..e928f979019e --- /dev/null +++ b/drivers/media/platform/raspberrypi/Kconfig @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only + +comment "Raspberry Pi media platform drivers" + +source "drivers/media/platform/raspberrypi/pisp_be/Kconfig" diff --git a/drivers/media/platform/raspberrypi/Makefile b/drivers/media/platform/raspberrypi/Makefile new file mode 100644 index 000000000000..c0d1a2dab486 --- /dev/null +++ b/drivers/media/platform/raspberrypi/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-y += pisp_be/ diff --git a/drivers/media/platform/raspberrypi/pisp_be/Kconfig b/drivers/media/platform/raspberrypi/pisp_be/Kconfig new file mode 100644 index 000000000000..d88e66d5c334 --- /dev/null +++ b/drivers/media/platform/raspberrypi/pisp_be/Kconfig @@ -0,0 +1,12 @@ +config VIDEO_RASPBERRYPI_PISP_BE + tristate "Raspberry Pi PiSP Backend (BE) ISP driver" + depends on V4L_PLATFORM_DRIVERS + depends on VIDEO_DEV && PM + select VIDEO_V4L2_SUBDEV_API + select MEDIA_CONTROLLER + select VIDEOBUF2_DMA_CONTIG + help + Say Y here to enable support for the PiSP Backend (BE) ISP driver. + + To compile this driver as a module, choose M here. The module will be + called pisp-be. diff --git a/drivers/media/platform/raspberrypi/pisp_be/Makefile b/drivers/media/platform/raspberrypi/pisp_be/Makefile new file mode 100644 index 000000000000..a70bf5716824 --- /dev/null +++ b/drivers/media/platform/raspberrypi/pisp_be/Makefile @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for Raspberry Pi PiSP Backend driver +# +pisp-be-objs := pisp_be.o +obj-$(CONFIG_VIDEO_RASPBERRYPI_PISP_BE) += pisp-be.o diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c new file mode 100644 index 000000000000..c4d13462eb81 --- /dev/null +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c @@ -0,0 +1,1848 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * PiSP Back End driver. + * Copyright (c) 2021-2024 Raspberry Pi Limited. + * + */ +#include <linux/clk.h> +#include <linux/interrupt.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/lockdep.h> +#include <linux/media/raspberrypi/pisp_be_config.h> +#include <linux/module.h> +#include <linux/platform_device.h> +#include <linux/pm_runtime.h> +#include <media/v4l2-device.h> +#include <media/v4l2-ioctl.h> +#include <media/videobuf2-dma-contig.h> +#include <media/videobuf2-vmalloc.h> + +#include "pisp_be_formats.h" + +/* Maximum number of config buffers possible */ +#define PISP_BE_NUM_CONFIG_BUFFERS VB2_MAX_FRAME + +/* + * We want to support 2 independent instances allowing 2 simultaneous users + * of the ISP-BE (of course they share hardware, platform resources and mutex). + * Each such instance comprises a group of device nodes representing input + * and output queues, and a media controller device node to describe them. + */ +#define PISPBE_NUM_NODE_GROUPS 2 + +#define PISPBE_NAME "pispbe" + +/* Some ISP-BE registers */ +#define PISP_BE_VERSION_REG 0x0 +#define PISP_BE_CONTROL_REG 0x4 +#define PISP_BE_CONTROL_COPY_CONFIG BIT(1) +#define PISP_BE_CONTROL_QUEUE_JOB BIT(0) +#define PISP_BE_CONTROL_NUM_TILES(n) ((n) << 16) +#define PISP_BE_TILE_ADDR_LO_REG 0x8 +#define PISP_BE_TILE_ADDR_HI_REG 0xc +#define PISP_BE_STATUS_REG 0x10 +#define PISP_BE_STATUS_QUEUED BIT(0) +#define PISP_BE_BATCH_STATUS_REG 0x14 +#define PISP_BE_INTERRUPT_EN_REG 0x18 +#define PISP_BE_INTERRUPT_STATUS_REG 0x1c +#define PISP_BE_AXI_REG 0x20 +#define PISP_BE_CONFIG_BASE_REG 0x40 +#define PISP_BE_IO_ADDR_LOW(n) (PISP_BE_CONFIG_BASE_REG + 8 * (n)) +#define PISP_BE_IO_ADDR_HIGH(n) (PISP_BE_IO_ADDR_LOW((n)) + 4) +#define PISP_BE_GLOBAL_BAYER_ENABLE 0xb0 +#define PISP_BE_GLOBAL_RGB_ENABLE 0xb4 +#define N_HW_ADDRESSES 13 +#define N_HW_ENABLES 2 + +#define PISP_BE_VERSION_2712 0x02252700 +#define PISP_BE_VERSION_MINOR_BITS 0xf + +/* + * This maps our nodes onto the inputs/outputs of the actual PiSP Back End. + * Be wary of the word "OUTPUT" which is used ambiguously here. In a V4L2 + * context it means an input to the hardware (source image or metadata). + * Elsewhere it means an output from the hardware. + */ +enum pispbe_node_ids { + MAIN_INPUT_NODE, + TDN_INPUT_NODE, + STITCH_INPUT_NODE, + OUTPUT0_NODE, + OUTPUT1_NODE, + TDN_OUTPUT_NODE, + STITCH_OUTPUT_NODE, + CONFIG_NODE, + PISPBE_NUM_NODES +}; + +struct pispbe_node_description { + const char *ent_name; + enum v4l2_buf_type buf_type; + unsigned int caps; +}; + +static const struct pispbe_node_description node_desc[PISPBE_NUM_NODES] = { + /* MAIN_INPUT_NODE */ + { + .ent_name = PISPBE_NAME "-input", + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, + }, + /* TDN_INPUT_NODE */ + { + .ent_name = PISPBE_NAME "-tdn_input", + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, + }, + /* STITCH_INPUT_NODE */ + { + .ent_name = PISPBE_NAME "-stitch_input", + .buf_type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + .caps = V4L2_CAP_VIDEO_OUTPUT_MPLANE, + }, + /* OUTPUT0_NODE */ + { + .ent_name = PISPBE_NAME "-output0", + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, + }, + /* OUTPUT1_NODE */ + { + .ent_name = PISPBE_NAME "-output1", + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, + }, + /* TDN_OUTPUT_NODE */ + { + .ent_name = PISPBE_NAME "-tdn_output", + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, + }, + /* STITCH_OUTPUT_NODE */ + { + .ent_name = PISPBE_NAME "-stitch_output", + .buf_type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, + .caps = V4L2_CAP_VIDEO_CAPTURE_MPLANE, + }, + /* CONFIG_NODE */ + { + .ent_name = PISPBE_NAME "-config", + .buf_type = V4L2_BUF_TYPE_META_OUTPUT, + .caps = V4L2_CAP_META_OUTPUT, + } +}; + +#define NODE_DESC_IS_OUTPUT(desc) ( \ + ((desc)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ + ((desc)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) + +#define NODE_IS_META(node) ( \ + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT)) +#define NODE_IS_OUTPUT(node) ( \ + ((node)->buf_type == V4L2_BUF_TYPE_META_OUTPUT) || \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT) || \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)) +#define NODE_IS_CAPTURE(node) ( \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE) || \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) +#define NODE_IS_MPLANE(node) ( \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) || \ + ((node)->buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)) + +/* + * Structure to describe a single node /dev/video<N> which represents a single + * input or output queue to the PiSP Back End device. + */ +struct pispbe_node { + unsigned int id; + int vfl_dir; + enum v4l2_buf_type buf_type; + struct video_device vfd; + struct media_pad pad; + struct media_intf_devnode *intf_devnode; + struct media_link *intf_link; + struct pispbe_node_group *node_group; + /* Video device lock */ + struct mutex node_lock; + /* vb2_queue lock */ + struct mutex queue_lock; + /* Protect pispbe_node->ready_queue and pispbe_buffer->ready_list */ + spinlock_t ready_lock; + struct list_head ready_queue; + struct vb2_queue queue; + struct v4l2_format format; + const struct pisp_be_format *pisp_format; +}; + +/* For logging only, use the entity name with "pispbe" and separator removed */ +#define NODE_NAME(node) \ + (node_desc[(node)->id].ent_name + sizeof(PISPBE_NAME)) + +/* + * Node group structure, which comprises all the input and output nodes that a + * single PiSP client will need, along with its own v4l2 and media devices. + */ +struct pispbe_node_group { + unsigned int id; + struct v4l2_device v4l2_dev; + struct v4l2_subdev sd; + struct pispbe_dev *pispbe; + struct media_device mdev; + struct pispbe_node node[PISPBE_NUM_NODES]; + u32 streaming_map; /* bitmap of which nodes are streaming */ + struct media_pad pad[PISPBE_NUM_NODES]; /* output pads first */ + struct pisp_be_tiles_config *config; + dma_addr_t config_dma_addr; + unsigned int sequence; +}; + +/* Records details of the jobs currently running or queued on the h/w. */ +struct pispbe_job { + struct pispbe_node_group *node_group; + /* + * An array of buffer pointers - remember it's source buffers first, + * then captures, then metadata last. + */ + struct pispbe_buffer *buf[PISPBE_NUM_NODES]; +}; + +/* Records a job configuration and memory addresses. */ +struct pispbe_job_descriptor { + dma_addr_t hw_dma_addrs[N_HW_ADDRESSES]; + struct pisp_be_tiles_config *config; + u32 hw_enables[N_HW_ENABLES]; + dma_addr_t tiles; +}; + +/* + * Structure representing the entire PiSP Back End device, comprising several + * node groups which share platform resources and a mutex for the actual HW. + */ +struct pispbe_dev { + struct device *dev; + struct pispbe_node_group node_group[PISPBE_NUM_NODE_GROUPS]; + int hw_busy; /* non-zero if a job is queued or is being started */ + struct pispbe_job queued_job, running_job; + void __iomem *be_reg_base; + struct clk *clk; + int irq; + u32 hw_version; + u8 done, started; + spinlock_t hw_lock; /* protects "hw_busy" flag and streaming_map */ +}; + +static u32 pispbe_rd(struct pispbe_dev *pispbe, unsigned int offset) +{ + return readl(pispbe->be_reg_base + offset); +} + +static void pispbe_wr(struct pispbe_dev *pispbe, unsigned int offset, u32 val) +{ + writel(val, pispbe->be_reg_base + offset); +} + +/* + * Queue a job to the h/w. If the h/w is idle it will begin immediately. + * Caller must ensure it is "safe to queue", i.e. we don't already have a + * queued, unstarted job. + */ +static void pispbe_queue_job(struct pispbe_dev *pispbe, + struct pispbe_job_descriptor *job) +{ + unsigned int begin, end; + + if (pispbe_rd(pispbe, PISP_BE_STATUS_REG) & PISP_BE_STATUS_QUEUED) + dev_err(pispbe->dev, "ERROR: not safe to queue new job!\n"); + + /* + * Write configuration to hardware. DMA addresses and enable flags + * are passed separately, because the driver needs to sanitize them, + * and we don't want to modify (or be vulnerable to modifications of) + * the mmap'd buffer. + */ + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { + pispbe_wr(pispbe, PISP_BE_IO_ADDR_LOW(u), + lower_32_bits(job->hw_dma_addrs[u])); + pispbe_wr(pispbe, PISP_BE_IO_ADDR_HIGH(u), + upper_32_bits(job->hw_dma_addrs[u])); + } + pispbe_wr(pispbe, PISP_BE_GLOBAL_BAYER_ENABLE, job->hw_enables[0]); + pispbe_wr(pispbe, PISP_BE_GLOBAL_RGB_ENABLE, job->hw_enables[1]); + + /* Everything else is as supplied by the user. */ + begin = offsetof(struct pisp_be_config, global.bayer_order) + / sizeof(u32); + end = sizeof(struct pisp_be_config) / sizeof(u32); + for (unsigned int u = begin; u < end; u++) + pispbe_wr(pispbe, PISP_BE_CONFIG_BASE_REG + 4 * u, + ((u32 *)job->config)[u]); + + /* Read back the addresses -- an error here could be fatal */ + for (unsigned int u = 0; u < N_HW_ADDRESSES; ++u) { + unsigned int offset = PISP_BE_IO_ADDR_LOW(u); + u64 along = pispbe_rd(pispbe, offset); + + along += ((u64)pispbe_rd(pispbe, offset + 4)) << 32; + if (along != (u64)(job->hw_dma_addrs[u])) { + dev_dbg(pispbe->dev, + "ISP BE config error: check if ISP RAMs enabled?\n"); + return; + } + } + + /* + * Write tile pointer to hardware. The IOMMU should prevent + * out-of-bounds offsets reaching non-ISP buffers. + */ + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_LO_REG, lower_32_bits(job->tiles)); + pispbe_wr(pispbe, PISP_BE_TILE_ADDR_HI_REG, upper_32_bits(job->tiles)); + + /* Enqueue the job */ + pispbe_wr(pispbe, PISP_BE_CONTROL_REG, + PISP_BE_CONTROL_COPY_CONFIG | PISP_BE_CONTROL_QUEUE_JOB | + PISP_BE_CONTROL_NUM_TILES(job->config->num_tiles)); +} + +struct pispbe_buffer { + struct vb2_v4l2_buffer vb; + struct list_head ready_list; + unsigned int config_index; +}; + +static int pispbe_get_planes_addr(dma_addr_t addr[3], struct pispbe_buffer *buf, + struct pispbe_node *node) +{ + unsigned int num_planes = node->format.fmt.pix_mp.num_planes; + unsigned int plane_factor = 0; + unsigned int size; + unsigned int p; + + if (!buf || !node->pisp_format) + return 0; + + /* + * Determine the base plane size. This will not be the same + * as node->format.fmt.pix_mp.plane_fmt[0].sizeimage for a single + * plane buffer in an mplane format. + */ + size = node->format.fmt.pix_mp.plane_fmt[0].bytesperline + * node->format.fmt.pix_mp.height; + + for (p = 0; p < num_planes && p < PISPBE_MAX_PLANES; p++) { + addr[p] = vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, p); + plane_factor += node->pisp_format->plane_factor[p]; + } + + for (; p < PISPBE_MAX_PLANES && node->pisp_format->plane_factor[p]; p++) { + /* + * Calculate the address offset of this plane as needed + * by the hardware. This is specifically for non-mplane + * buffer formats, where there are 3 image planes, e.g. + * for the V4L2_PIX_FMT_YUV420 format. + */ + addr[p] = addr[0] + ((size * plane_factor) >> 3); + plane_factor += node->pisp_format->plane_factor[p]; + } + + return num_planes; +} + +static dma_addr_t pispbe_get_addr(struct pispbe_buffer *buf) +{ + if (buf) + return vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, 0); + return 0; +} + +static void pispbe_xlate_addrs(dma_addr_t addrs[N_HW_ADDRESSES], + u32 hw_enables[N_HW_ENABLES], + struct pisp_be_tiles_config *config, + struct pispbe_buffer *buf[PISPBE_NUM_NODES], + struct pispbe_node_group *node_group) +{ + int ret; + + /* Take a copy of the "enable" bitmaps so we can modify them. */ + hw_enables[0] = config->config.global.bayer_enables; + hw_enables[1] = config->config.global.rgb_enables; + + /* + * Main input first. There are 3 address pointers, corresponding to up + * to 3 planes. + */ + ret = pispbe_get_planes_addr(addrs, buf[MAIN_INPUT_NODE], + &node_group->node[MAIN_INPUT_NODE]); + if (ret <= 0) { + /* + * This shouldn't happen; pispbe_schedule_internal should insist + * on an input. + */ + dev_warn(node_group->pispbe->dev, "ISP-BE missing input\n"); + hw_enables[0] = 0; + hw_enables[1] = 0; + return; + } + + /* + * Now TDN/Stitch inputs and outputs. These are single-plane and only + * used with Bayer input. Input enables must match the requirements + * of the processing stages, otherwise the hardware can lock up! + */ + if (hw_enables[0] & PISP_BE_BAYER_ENABLE_INPUT) { + addrs[3] = pispbe_get_addr(buf[TDN_INPUT_NODE]); + if (addrs[3] == 0 || + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN_INPUT) || + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_TDN) || + (config->config.tdn.reset & 1)) { + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_INPUT | + PISP_BE_BAYER_ENABLE_TDN_DECOMPRESS); + if (!(config->config.tdn.reset & 1)) + hw_enables[0] &= ~PISP_BE_BAYER_ENABLE_TDN; + } + + addrs[4] = pispbe_get_addr(buf[STITCH_INPUT_NODE]); + if (addrs[4] == 0 || + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH_INPUT) || + !(hw_enables[0] & PISP_BE_BAYER_ENABLE_STITCH)) { + hw_enables[0] &= + ~(PISP_BE_BAYER_ENABLE_STITCH_INPUT | + PISP_BE_BAYER_ENABLE_STITCH_DECOMPRESS | + PISP_BE_BAYER_ENABLE_STITCH); + } + + addrs[5] = pispbe_get_addr(buf[TDN_OUTPUT_NODE]); + if (addrs[5] == 0) + hw_enables[0] &= ~(PISP_BE_BAYER_ENABLE_TDN_COMPRESS | + PISP_BE_BAYER_ENABLE_TDN_OUTPUT); + + addrs[6] = pispbe_get_addr(buf[STITCH_OUTPUT_NODE]); + if (addrs[6] == 0) + hw_enables[0] &= + ~(PISP_BE_BAYER_ENABLE_STITCH_COMPRESS | + PISP_BE_BAYER_ENABLE_STITCH_OUTPUT); + } else { + /* No Bayer input? Disable entire Bayer pipe (else lockup) */ + hw_enables[0] = 0; + } + + /* Main image output channels. */ + for (unsigned int i = 0; i < PISP_BACK_END_NUM_OUTPUTS; i++) { + ret = pispbe_get_planes_addr(addrs + 7 + 3 * i, + buf[OUTPUT0_NODE + i], + &node_group->node[OUTPUT0_NODE + i]); + if (ret <= 0) + hw_enables[1] &= ~(PISP_BE_RGB_ENABLE_OUTPUT0 << i); + } +} + +/* + * Prepare a job description to be submitted to the HW. + * + * To schedule a job, we need all streaming nodes (apart from Output0, + * Output1, Tdn and Stitch) to have a buffer ready, which must + * include at least a config buffer and a main input image. + * + * For Output0, Output1, Tdn and Stitch, a buffer only needs to be + * available if the blocks are enabled in the config. + * + * Needs to be called with hw_lock held. + * + * Returns 0 if a job has been successfully prepared, < 0 otherwise. + */ +static int pispbe_prepare_job(struct pispbe_node_group *node_group, + struct pispbe_job_descriptor *job) +{ + struct pispbe_buffer *buf[PISPBE_NUM_NODES] = {}; + struct pispbe_dev *pispbe = node_group->pispbe; + unsigned int config_index; + struct pispbe_node *node; + unsigned long flags; + + lockdep_assert_held(&pispbe->hw_lock); + + memset(job, 0, sizeof(struct pispbe_job_descriptor)); + + if (((BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE)) & + node_group->streaming_map) != + (BIT(CONFIG_NODE) | BIT(MAIN_INPUT_NODE))) + return -ENODEV; + + node = &node_group->node[CONFIG_NODE]; + spin_lock_irqsave(&node->ready_lock, flags); + buf[CONFIG_NODE] = list_first_entry_or_null(&node->ready_queue, + struct pispbe_buffer, + ready_list); + if (buf[CONFIG_NODE]) { + list_del(&buf[CONFIG_NODE]->ready_list); + pispbe->queued_job.buf[CONFIG_NODE] = buf[CONFIG_NODE]; + } + spin_unlock_irqrestore(&node->ready_lock, flags); + + /* Exit early if no config buffer has been queued. */ + if (!buf[CONFIG_NODE]) + return -ENODEV; + + config_index = buf[CONFIG_NODE]->vb.vb2_buf.index; + job->config = &node_group->config[config_index]; + job->tiles = node_group->config_dma_addr + + config_index * sizeof(struct pisp_be_tiles_config) + + offsetof(struct pisp_be_tiles_config, tiles); + + /* remember: srcimages, captures then metadata */ + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { + unsigned int bayer_en = + job->config->config.global.bayer_enables; + unsigned int rgb_en = + job->config->config.global.rgb_enables; + bool ignore_buffers = false; + + /* Config node is handled outside the loop above. */ + if (i == CONFIG_NODE) + continue; + + buf[i] = NULL; + if (!(node_group->streaming_map & BIT(i))) + continue; + + if ((!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT0) && + i == OUTPUT0_NODE) || + (!(rgb_en & PISP_BE_RGB_ENABLE_OUTPUT1) && + i == OUTPUT1_NODE) || + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_INPUT) && + i == TDN_INPUT_NODE) || + (!(bayer_en & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) && + i == TDN_OUTPUT_NODE) || + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_INPUT) && + i == STITCH_INPUT_NODE) || + (!(bayer_en & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) && + i == STITCH_OUTPUT_NODE)) { + /* + * Ignore Output0/Output1/Tdn/Stitch buffer check if the + * global enables aren't set for these blocks. If a + * buffer has been provided, we dequeue it back to the + * user with the other in-use buffers. + */ + ignore_buffers = true; + } + + node = &node_group->node[i]; + + /* Pull a buffer from each V4L2 queue to form the queued job */ + spin_lock_irqsave(&node->ready_lock, flags); + buf[i] = list_first_entry_or_null(&node->ready_queue, + struct pispbe_buffer, + ready_list); + if (buf[i]) { + list_del(&buf[i]->ready_list); + pispbe->queued_job.buf[i] = buf[i]; + } + spin_unlock_irqrestore(&node->ready_lock, flags); + + if (!buf[i] && !ignore_buffers) + goto err_return_buffers; + } + + pispbe->queued_job.node_group = node_group; + + /* Convert buffers to DMA addresses for the hardware */ + pispbe_xlate_addrs(job->hw_dma_addrs, job->hw_enables, + job->config, buf, node_group); + + return 0; + +err_return_buffers: + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { + struct pispbe_node *n = &node_group->node[i]; + + if (!buf[i]) + continue; + + /* Return the buffer to the ready_list queue */ + spin_lock_irqsave(&n->ready_lock, flags); + list_add(&buf[i]->ready_list, &n->ready_queue); + spin_unlock_irqrestore(&n->ready_lock, flags); + } + + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); + + return -ENODEV; +} + +static void pispbe_schedule(struct pispbe_dev *pispbe, + struct pispbe_node_group *node_group, + bool clear_hw_busy) +{ + struct pispbe_job_descriptor job; + unsigned long flags; + + spin_lock_irqsave(&pispbe->hw_lock, flags); + + if (clear_hw_busy) + pispbe->hw_busy = 0; + + if (pispbe->hw_busy) + goto unlock_and_return; + + for (unsigned int i = 0; i < PISPBE_NUM_NODE_GROUPS; i++) { + int ret; + + /* Schedule jobs only for a specific group. */ + if (node_group && + &pispbe->node_group[i] != node_group) + continue; + + /* + * Prepare a job for this group, if the group is not ready + * continue and try with the next one. + */ + ret = pispbe_prepare_job(&pispbe->node_group[i], &job); + if (ret) + continue; + + /* + * We can kick the job off without the hw_lock, as this can + * never run again until hw_busy is cleared, which will happen + * only when the following job has been queued and an interrupt + * is rised. + */ + pispbe->hw_busy = 1; + spin_unlock_irqrestore(&pispbe->hw_lock, flags); + + if (job.config->num_tiles <= 0 || + job.config->num_tiles > PISP_BACK_END_NUM_TILES || + !((job.hw_enables[0] | job.hw_enables[1]) & + PISP_BE_BAYER_ENABLE_INPUT)) { + /* + * Bad job. We can't let it proceed as it could lock up + * the hardware, or worse! + * + * For now, just force num_tiles to 0, which causes the + * H/W to do something bizarre but survivable. It + * increments (started,done) counters by more than 1, + * but we seem to survive... + */ + dev_dbg(pispbe->dev, + "Bad job: invalid number of tiles: %d\n", + job.config->num_tiles); + job.config->num_tiles = 0; + } + + pispbe_queue_job(pispbe, &job); + + return; + } + +unlock_and_return: + /* No job has been queued, just release the lock and return. */ + spin_unlock_irqrestore(&pispbe->hw_lock, flags); +} + +static void pispbe_isr_jobdone(struct pispbe_dev *pispbe, + struct pispbe_job *job) +{ + struct pispbe_buffer **buf = job->buf; + u64 ts = ktime_get_ns(); + + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) { + if (buf[i]) { + buf[i]->vb.vb2_buf.timestamp = ts; + buf[i]->vb.sequence = job->node_group->sequence; + vb2_buffer_done(&buf[i]->vb.vb2_buf, + VB2_BUF_STATE_DONE); + } + } + + job->node_group->sequence++; +} + +static irqreturn_t pispbe_isr(int irq, void *dev) +{ + struct pispbe_dev *pispbe = (struct pispbe_dev *)dev; + bool can_queue_another = false; + u8 started, done; + u32 u; + + u = pispbe_rd(pispbe, PISP_BE_INTERRUPT_STATUS_REG); + if (u == 0) + return IRQ_NONE; + + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, u); + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); + done = (uint8_t)u; + started = (uint8_t)(u >> 8); + + /* + * Be aware that done can go up by 2 and started by 1 when: a job that + * we previously saw "start" now finishes, and we then queued a new job + * which we see both start and finish "simultaneously". + */ + if (pispbe->running_job.node_group && pispbe->done != done) { + pispbe_isr_jobdone(pispbe, &pispbe->running_job); + memset(&pispbe->running_job, 0, sizeof(pispbe->running_job)); + pispbe->done++; + } + + if (pispbe->started != started) { + pispbe->started++; + can_queue_another = 1; + + if (pispbe->done != done && pispbe->queued_job.node_group) { + pispbe_isr_jobdone(pispbe, &pispbe->queued_job); + pispbe->done++; + } else { + pispbe->running_job = pispbe->queued_job; + } + + memset(&pispbe->queued_job, 0, sizeof(pispbe->queued_job)); + } + + if (pispbe->done != done || pispbe->started != started) { + dev_dbg(pispbe->dev, + "Job counters not matching: done = %u, expected %u - started = %u, expected %u\n", + pispbe->done, done, pispbe->started, started); + pispbe->started = started; + pispbe->done = done; + } + + /* check if there's more to do before going to sleep */ + pispbe_schedule(pispbe, NULL, can_queue_another); + + return IRQ_HANDLED; +} + +static int pisp_be_validate_config(struct pispbe_node_group *node_group, + struct pisp_be_tiles_config *config) +{ + u32 bayer_enables = config->config.global.bayer_enables; + u32 rgb_enables = config->config.global.rgb_enables; + struct device *dev = node_group->pispbe->dev; + struct v4l2_format *fmt; + unsigned int bpl, size; + + if (!(bayer_enables & PISP_BE_BAYER_ENABLE_INPUT) == + !(rgb_enables & PISP_BE_RGB_ENABLE_INPUT)) { + dev_dbg(dev, "%s: Not one input enabled\n", __func__); + return -EIO; + } + + /* Ensure output config strides and buffer sizes match the V4L2 formats. */ + fmt = &node_group->node[TDN_OUTPUT_NODE].format; + if (bayer_enables & PISP_BE_BAYER_ENABLE_TDN_OUTPUT) { + bpl = config->config.tdn_output_format.stride; + size = bpl * config->config.tdn_output_format.height; + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { + dev_dbg(dev, "%s: bpl mismatch on tdn_output\n", + __func__); + return -EINVAL; + } + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { + dev_dbg(dev, "%s: size mismatch on tdn_output\n", + __func__); + return -EINVAL; + } + } + + fmt = &node_group->node[STITCH_OUTPUT_NODE].format; + if (bayer_enables & PISP_BE_BAYER_ENABLE_STITCH_OUTPUT) { + bpl = config->config.stitch_output_format.stride; + size = bpl * config->config.stitch_output_format.height; + if (fmt->fmt.pix_mp.plane_fmt[0].bytesperline < bpl) { + dev_dbg(dev, "%s: bpl mismatch on stitch_output\n", + __func__); + return -EINVAL; + } + if (fmt->fmt.pix_mp.plane_fmt[0].sizeimage < size) { + dev_dbg(dev, "%s: size mismatch on stitch_output\n", + __func__); + return -EINVAL; + } + } + + for (unsigned int j = 0; j < PISP_BACK_END_NUM_OUTPUTS; j++) { + if (!(rgb_enables & PISP_BE_RGB_ENABLE_OUTPUT(j))) + continue; + if (config->config.output_format[j].image.format & + PISP_IMAGE_FORMAT_WALLPAPER_ROLL) + continue; /* TODO: Size checks for wallpaper formats */ + + fmt = &node_group->node[OUTPUT0_NODE + j].format; + for (unsigned int i = 0; i < fmt->fmt.pix_mp.num_planes; i++) { + bpl = !i ? config->config.output_format[j].image.stride + : config->config.output_format[j].image.stride2; + size = bpl * config->config.output_format[j].image.height; + + if (config->config.output_format[j].image.format & + PISP_IMAGE_FORMAT_SAMPLING_420) + size >>= 1; + if (fmt->fmt.pix_mp.plane_fmt[i].bytesperline < bpl) { + dev_dbg(dev, "%s: bpl mismatch on output %d\n", + __func__, j); + return -EINVAL; + } + if (fmt->fmt.pix_mp.plane_fmt[i].sizeimage < size) { + dev_dbg(dev, "%s: size mismatch on output\n", + __func__); + return -EINVAL; + } + } + } + + return 0; +} + +static int pispbe_node_queue_setup(struct vb2_queue *q, unsigned int *nbuffers, + unsigned int *nplanes, unsigned int sizes[], + struct device *alloc_devs[]) +{ + struct pispbe_node *node = vb2_get_drv_priv(q); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + *nplanes = 1; + if (NODE_IS_MPLANE(node)) { + *nplanes = node->format.fmt.pix_mp.num_planes; + for (unsigned int i = 0; i < *nplanes; i++) { + unsigned int size = + node->format.fmt.pix_mp.plane_fmt[i].sizeimage; + + if (sizes[i] && sizes[i] < size) { + dev_dbg(pispbe->dev, "%s: size %u < %u\n", + __func__, sizes[i], size); + return -EINVAL; + } + sizes[i] = size; + } + } else if (NODE_IS_META(node)) { + sizes[0] = node->format.fmt.meta.buffersize; + /* + * Limit the config node buffer count to the number of internal + * buffers allocated. + */ + if (node->id == CONFIG_NODE) + *nbuffers = min_t(unsigned int, *nbuffers, + PISP_BE_NUM_CONFIG_BUFFERS); + } + + dev_dbg(pispbe->dev, + "Image (or metadata) size %u, nbuffers %u for node %s\n", + sizes[0], *nbuffers, NODE_NAME(node)); + + return 0; +} + +static int pispbe_node_buffer_prepare(struct vb2_buffer *vb) +{ + struct pispbe_node *node = vb2_get_drv_priv(vb->vb2_queue); + struct pispbe_dev *pispbe = node->node_group->pispbe; + unsigned long size = 0; + unsigned int num_planes = NODE_IS_MPLANE(node) + ? node->format.fmt.pix_mp.num_planes : 1; + + for (unsigned int i = 0; i < num_planes; i++) { + size = NODE_IS_MPLANE(node) + ? node->format.fmt.pix_mp.plane_fmt[i].sizeimage + : node->format.fmt.meta.buffersize; + + if (vb2_plane_size(vb, i) < size) { + dev_dbg(pispbe->dev, + "data will not fit into plane %d (%lu < %lu)\n", + i, vb2_plane_size(vb, i), size); + return -EINVAL; + } + + vb2_set_plane_payload(vb, i, size); + } + + if (node->id == CONFIG_NODE) { + void *dst = &node->node_group->config[vb->index]; + void *src = vb2_plane_vaddr(vb, 0); + + memcpy(dst, src, sizeof(struct pisp_be_tiles_config)); + + return pisp_be_validate_config(node->node_group, dst); + } + + return 0; +} + +static void pispbe_node_buffer_queue(struct vb2_buffer *buf) +{ + struct vb2_v4l2_buffer *vbuf = + container_of(buf, struct vb2_v4l2_buffer, vb2_buf); + struct pispbe_buffer *buffer = + container_of(vbuf, struct pispbe_buffer, vb); + struct pispbe_node *node = vb2_get_drv_priv(buf->vb2_queue); + struct pispbe_node_group *node_group = node->node_group; + struct pispbe_dev *pispbe = node->node_group->pispbe; + unsigned long flags; + + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); + spin_lock_irqsave(&node->ready_lock, flags); + list_add_tail(&buffer->ready_list, &node->ready_queue); + spin_unlock_irqrestore(&node->ready_lock, flags); + + /* + * Every time we add a buffer, check if there's now some work for the hw + * to do, but only for this client. + */ + pispbe_schedule(node_group->pispbe, node_group, false); +} + +static int pispbe_node_start_streaming(struct vb2_queue *q, unsigned int count) +{ + struct pispbe_node *node = vb2_get_drv_priv(q); + struct pispbe_node_group *node_group = node->node_group; + struct pispbe_dev *pispbe = node_group->pispbe; + unsigned long flags; + int ret; + + ret = pm_runtime_resume_and_get(pispbe->dev); + if (ret < 0) + return ret; + + spin_lock_irqsave(&pispbe->hw_lock, flags); + node->node_group->streaming_map |= BIT(node->id); + node->node_group->sequence = 0; + spin_unlock_irqrestore(&pispbe->hw_lock, flags); + + dev_dbg(pispbe->dev, "%s: for node %s (count %u)\n", + __func__, NODE_NAME(node), count); + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", + node->node_group->streaming_map); + + /* Maybe we're ready to run. */ + pispbe_schedule(node_group->pispbe, node_group, false); + + return 0; +} + +static void pispbe_node_stop_streaming(struct vb2_queue *q) +{ + struct pispbe_node *node = vb2_get_drv_priv(q); + struct pispbe_node_group *node_group = node->node_group; + struct pispbe_dev *pispbe = node_group->pispbe; + struct pispbe_buffer *buf; + unsigned long flags; + + /* + * Now this is a bit awkward. In a simple M2M device we could just wait + * for all queued jobs to complete, but here there's a risk that a + * partial set of buffers was queued and cannot be run. For now, just + * cancel all buffers stuck in the "ready queue", then wait for any + * running job. + * + * This may return buffers out of order. + */ + dev_dbg(pispbe->dev, "%s: for node %s\n", __func__, NODE_NAME(node)); + spin_lock_irqsave(&pispbe->hw_lock, flags); + do { + unsigned long flags1; + + spin_lock_irqsave(&node->ready_lock, flags1); + buf = list_first_entry_or_null(&node->ready_queue, + struct pispbe_buffer, + ready_list); + if (buf) { + list_del(&buf->ready_list); + vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR); + } + spin_unlock_irqrestore(&node->ready_lock, flags1); + } while (buf); + spin_unlock_irqrestore(&pispbe->hw_lock, flags); + + vb2_wait_for_all_buffers(&node->queue); + + spin_lock_irqsave(&pispbe->hw_lock, flags); + node_group->streaming_map &= ~BIT(node->id); + spin_unlock_irqrestore(&pispbe->hw_lock, flags); + + pm_runtime_mark_last_busy(pispbe->dev); + pm_runtime_put_autosuspend(pispbe->dev); + + dev_dbg(pispbe->dev, "Nodes streaming for this group now 0x%x\n", + node_group->streaming_map); +} + +static const struct vb2_ops pispbe_node_queue_ops = { + .queue_setup = pispbe_node_queue_setup, + .buf_prepare = pispbe_node_buffer_prepare, + .buf_queue = pispbe_node_buffer_queue, + .start_streaming = pispbe_node_start_streaming, + .stop_streaming = pispbe_node_stop_streaming, +}; + +static const struct v4l2_file_operations pispbe_fops = { + .owner = THIS_MODULE, + .open = v4l2_fh_open, + .release = vb2_fop_release, + .poll = vb2_fop_poll, + .unlocked_ioctl = video_ioctl2, + .mmap = vb2_fop_mmap +}; + +static int pispbe_node_querycap(struct file *file, void *priv, + struct v4l2_capability *cap) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + strscpy(cap->driver, PISPBE_NAME, sizeof(cap->driver)); + strscpy(cap->card, PISPBE_NAME, sizeof(cap->card)); + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", + dev_name(pispbe->dev)); + + cap->capabilities = V4L2_CAP_VIDEO_CAPTURE_MPLANE | + V4L2_CAP_VIDEO_OUTPUT_MPLANE | + V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS | + V4L2_CAP_META_OUTPUT; + cap->device_caps = node->vfd.device_caps; + + dev_dbg(pispbe->dev, "Caps for node %s: %x and %x (dev %x)\n", + NODE_NAME(node), cap->capabilities, cap->device_caps, + node->vfd.device_caps); + + return 0; +} + +static int pispbe_node_g_fmt_vid_cap(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { + dev_dbg(pispbe->dev, + "Cannot get capture fmt for output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + *f = node->format; + dev_dbg(pispbe->dev, "Get capture format for node %s\n", + NODE_NAME(node)); + + return 0; +} + +static int pispbe_node_g_fmt_vid_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { + dev_dbg(pispbe->dev, + "Cannot get capture fmt for output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + *f = node->format; + dev_dbg(pispbe->dev, "Get output format for node %s\n", + NODE_NAME(node)); + + return 0; +} + +static int pispbe_node_g_fmt_meta_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { + dev_dbg(pispbe->dev, + "Cannot get capture fmt for meta output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + *f = node->format; + dev_dbg(pispbe->dev, "Get output format for meta node %s\n", + NODE_NAME(node)); + + return 0; +} + +static const struct pisp_be_format *pispbe_find_fmt(unsigned int fourcc) +{ + for (unsigned int i = 0; i < ARRAY_SIZE(supported_formats); i++) { + if (supported_formats[i].fourcc == fourcc) + return &supported_formats[i]; + } + + return NULL; +} + +static void pispbe_set_plane_params(struct v4l2_format *f, + const struct pisp_be_format *fmt) +{ + unsigned int nplanes = f->fmt.pix_mp.num_planes; + unsigned int total_plane_factor = 0; + + for (unsigned int i = 0; i < PISPBE_MAX_PLANES; i++) + total_plane_factor += fmt->plane_factor[i]; + + for (unsigned int i = 0; i < nplanes; i++) { + struct v4l2_plane_pix_format *p = &f->fmt.pix_mp.plane_fmt[i]; + unsigned int bpl, plane_size; + + bpl = (f->fmt.pix_mp.width * fmt->bit_depth) >> 3; + bpl = ALIGN(max(p->bytesperline, bpl), fmt->align); + + plane_size = bpl * f->fmt.pix_mp.height * + (nplanes > 1 ? fmt->plane_factor[i] : total_plane_factor); + /* + * The shift is to divide out the plane_factor fixed point + * scaling of 8. + */ + plane_size = max(p->sizeimage, plane_size >> 3); + + p->bytesperline = bpl; + p->sizeimage = plane_size; + } +} + +static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node) +{ + struct pispbe_dev *pispbe = node->node_group->pispbe; + u32 pixfmt = f->fmt.pix_mp.pixelformat; + const struct pisp_be_format *fmt; + bool is_rgb; + + dev_dbg(pispbe->dev, + "%s: [%s] req %ux%u %p4cc, planes %d\n", + __func__, NODE_NAME(node), f->fmt.pix_mp.width, + f->fmt.pix_mp.height, &pixfmt, + f->fmt.pix_mp.num_planes); + + fmt = pispbe_find_fmt(pixfmt); + if (!fmt) { + dev_dbg(pispbe->dev, + "%s: [%s] Format not found, defaulting to YUV420\n", + __func__, NODE_NAME(node)); + fmt = pispbe_find_fmt(V4L2_PIX_FMT_YUV420); + } + + f->fmt.pix_mp.pixelformat = fmt->fourcc; + f->fmt.pix_mp.num_planes = fmt->num_planes; + f->fmt.pix_mp.field = V4L2_FIELD_NONE; + f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u), + PISP_BACK_END_MIN_TILE_WIDTH); + f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u), + PISP_BACK_END_MIN_TILE_HEIGHT); + + /* + * Fill in the actual colour space when the requested one was + * not supported. This also catches the case when the "default" + * colour space was requested (as that's never in the mask). + */ + if (!(V4L2_COLORSPACE_MASK(f->fmt.pix_mp.colorspace) & + fmt->colorspace_mask)) + f->fmt.pix_mp.colorspace = fmt->colorspace_default; + + /* In all cases, we only support the defaults for these: */ + f->fmt.pix_mp.ycbcr_enc = + V4L2_MAP_YCBCR_ENC_DEFAULT(f->fmt.pix_mp.colorspace); + f->fmt.pix_mp.xfer_func = + V4L2_MAP_XFER_FUNC_DEFAULT(f->fmt.pix_mp.colorspace); + + is_rgb = f->fmt.pix_mp.colorspace == V4L2_COLORSPACE_SRGB; + f->fmt.pix_mp.quantization = + V4L2_MAP_QUANTIZATION_DEFAULT(is_rgb, f->fmt.pix_mp.colorspace, + f->fmt.pix_mp.ycbcr_enc); + + /* Set plane size and bytes/line for each plane. */ + pispbe_set_plane_params(f, fmt); + + for (unsigned int i = 0; i < f->fmt.pix_mp.num_planes; i++) { + dev_dbg(pispbe->dev, + "%s: [%s] calc plane %d, %ux%u, depth %u, bpl %u size %u\n", + __func__, NODE_NAME(node), i, f->fmt.pix_mp.width, + f->fmt.pix_mp.height, fmt->bit_depth, + f->fmt.pix_mp.plane_fmt[i].bytesperline, + f->fmt.pix_mp.plane_fmt[i].sizeimage); + } +} + +static int pispbe_node_try_fmt_vid_cap(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (!NODE_IS_CAPTURE(node) || NODE_IS_META(node)) { + dev_dbg(pispbe->dev, + "Cannot set capture fmt for output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + + pispbe_try_format(f, node); + + return 0; +} + +static int pispbe_node_try_fmt_vid_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (!NODE_IS_OUTPUT(node) || NODE_IS_META(node)) { + dev_dbg(pispbe->dev, + "Cannot set capture fmt for output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + + pispbe_try_format(f, node); + + return 0; +} + +static int pispbe_node_try_fmt_meta_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (!NODE_IS_META(node) || NODE_IS_CAPTURE(node)) { + dev_dbg(pispbe->dev, + "Cannot set capture fmt for meta output node %s\n", + NODE_NAME(node)); + return -EINVAL; + } + + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); + + return 0; +} + +static int pispbe_node_s_fmt_vid_cap(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + int ret; + + ret = pispbe_node_try_fmt_vid_cap(file, priv, f); + if (ret < 0) + return ret; + + node->format = *f; + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); + + dev_dbg(pispbe->dev, "Set capture format for node %s to %p4cc\n", + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); + + return 0; +} + +static int pispbe_node_s_fmt_vid_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + int ret; + + ret = pispbe_node_try_fmt_vid_out(file, priv, f); + if (ret < 0) + return ret; + + node->format = *f; + node->pisp_format = pispbe_find_fmt(f->fmt.pix_mp.pixelformat); + + dev_dbg(pispbe->dev, "Set output format for node %s to %p4cc\n", + NODE_NAME(node), &f->fmt.pix_mp.pixelformat); + + return 0; +} + +static int pispbe_node_s_fmt_meta_out(struct file *file, void *priv, + struct v4l2_format *f) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + int ret; + + ret = pispbe_node_try_fmt_meta_out(file, priv, f); + if (ret < 0) + return ret; + + node->format = *f; + node->pisp_format = &meta_out_supported_formats[0]; + + dev_dbg(pispbe->dev, "Set output format for meta node %s to %p4cc\n", + NODE_NAME(node), &f->fmt.meta.dataformat); + + return 0; +} + +static int pispbe_node_enum_fmt(struct file *file, void *priv, + struct v4l2_fmtdesc *f) +{ + struct pispbe_node *node = video_drvdata(file); + + if (f->type != node->queue.type) + return -EINVAL; + + if (NODE_IS_META(node)) { + if (f->index) + return -EINVAL; + + f->pixelformat = V4L2_META_FMT_RPI_BE_CFG; + f->flags = 0; + return 0; + } + + if (f->index >= ARRAY_SIZE(supported_formats)) + return -EINVAL; + + f->pixelformat = supported_formats[f->index].fourcc; + f->flags = 0; + + return 0; +} + +static int pispbe_enum_framesizes(struct file *file, void *priv, + struct v4l2_frmsizeenum *fsize) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + if (NODE_IS_META(node) || fsize->index) + return -EINVAL; + + if (!pispbe_find_fmt(fsize->pixel_format)) { + dev_dbg(pispbe->dev, "Invalid pixel code: %x\n", + fsize->pixel_format); + return -EINVAL; + } + + fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE; + fsize->stepwise.min_width = 32; + fsize->stepwise.max_width = 65535; + fsize->stepwise.step_width = 2; + + fsize->stepwise.min_height = 32; + fsize->stepwise.max_height = 65535; + fsize->stepwise.step_height = 2; + + return 0; +} + +static int pispbe_node_streamon(struct file *file, void *priv, + enum v4l2_buf_type type) +{ + struct pispbe_node *node = video_drvdata(file); + struct pispbe_dev *pispbe = node->node_group->pispbe; + + dev_dbg(pispbe->dev, "Stream on for node %s\n", NODE_NAME(node)); + + INIT_LIST_HEAD(&node->ready_queue); + + return vb2_streamon(&node->queue, type); +} + +static int pispbe_node_streamoff(struct file *file, void *priv, + enum v4l2_buf_type type) +{ + struct pispbe_node *node = video_drvdata(file); + + return vb2_streamoff(&node->queue, type); +} + +static const struct v4l2_ioctl_ops pispbe_node_ioctl_ops = { + .vidioc_querycap = pispbe_node_querycap, + .vidioc_g_fmt_vid_cap_mplane = pispbe_node_g_fmt_vid_cap, + .vidioc_g_fmt_vid_out_mplane = pispbe_node_g_fmt_vid_out, + .vidioc_g_fmt_meta_out = pispbe_node_g_fmt_meta_out, + .vidioc_try_fmt_vid_cap_mplane = pispbe_node_try_fmt_vid_cap, + .vidioc_try_fmt_vid_out_mplane = pispbe_node_try_fmt_vid_out, + .vidioc_try_fmt_meta_out = pispbe_node_try_fmt_meta_out, + .vidioc_s_fmt_vid_cap_mplane = pispbe_node_s_fmt_vid_cap, + .vidioc_s_fmt_vid_out_mplane = pispbe_node_s_fmt_vid_out, + .vidioc_s_fmt_meta_out = pispbe_node_s_fmt_meta_out, + .vidioc_enum_fmt_vid_cap = pispbe_node_enum_fmt, + .vidioc_enum_fmt_vid_out = pispbe_node_enum_fmt, + .vidioc_enum_fmt_meta_out = pispbe_node_enum_fmt, + .vidioc_enum_framesizes = pispbe_enum_framesizes, + .vidioc_create_bufs = vb2_ioctl_create_bufs, + .vidioc_prepare_buf = vb2_ioctl_prepare_buf, + .vidioc_querybuf = vb2_ioctl_querybuf, + .vidioc_qbuf = vb2_ioctl_qbuf, + .vidioc_dqbuf = vb2_ioctl_dqbuf, + .vidioc_expbuf = vb2_ioctl_expbuf, + .vidioc_reqbufs = vb2_ioctl_reqbufs, + .vidioc_streamon = pispbe_node_streamon, + .vidioc_streamoff = pispbe_node_streamoff, +}; + +static const struct video_device pispbe_videodev = { + .name = PISPBE_NAME, + .vfl_dir = VFL_DIR_M2M, /* gets overwritten */ + .fops = &pispbe_fops, + .ioctl_ops = &pispbe_node_ioctl_ops, + .minor = -1, + .release = video_device_release_empty, +}; + +static void pispbe_node_def_fmt(struct pispbe_node *node) +{ + if (NODE_IS_META(node) && NODE_IS_OUTPUT(node)) { + /* Config node */ + struct v4l2_format *f = &node->format; + + f->fmt.meta.dataformat = V4L2_META_FMT_RPI_BE_CFG; + f->fmt.meta.buffersize = sizeof(struct pisp_be_tiles_config); + f->type = node->buf_type; + } else { + struct v4l2_format f = {0}; + + f.fmt.pix_mp.pixelformat = V4L2_PIX_FMT_YUV420; + f.fmt.pix_mp.width = 1920; + f.fmt.pix_mp.height = 1080; + f.type = node->buf_type; + pispbe_try_format(&f, node); + node->format = f; + } + + node->pisp_format = pispbe_find_fmt(node->format.fmt.pix_mp.pixelformat); +} + +/* + * Initialise a struct pispbe_node and register it as /dev/video<N> + * to represent one of the PiSP Back End's input or output streams. + */ +static int pispbe_init_node(struct pispbe_node_group *node_group, + unsigned int id) +{ + bool output = NODE_DESC_IS_OUTPUT(&node_desc[id]); + struct pispbe_node *node = &node_group->node[id]; + struct media_entity *entity = &node->vfd.entity; + struct pispbe_dev *pispbe = node_group->pispbe; + struct video_device *vdev = &node->vfd; + struct vb2_queue *q = &node->queue; + int ret; + + node->id = id; + node->node_group = node_group; + node->buf_type = node_desc[id].buf_type; + + mutex_init(&node->node_lock); + mutex_init(&node->queue_lock); + INIT_LIST_HEAD(&node->ready_queue); + spin_lock_init(&node->ready_lock); + + node->format.type = node->buf_type; + pispbe_node_def_fmt(node); + + q->type = node->buf_type; + q->io_modes = VB2_MMAP | VB2_DMABUF; + q->mem_ops = &vb2_dma_contig_memops; + q->drv_priv = node; + q->ops = &pispbe_node_queue_ops; + q->buf_struct_size = sizeof(struct pispbe_buffer); + q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; + q->dev = node->node_group->pispbe->dev; + /* get V4L2 to handle node->queue locking */ + q->lock = &node->queue_lock; + + ret = vb2_queue_init(q); + if (ret < 0) { + dev_err(pispbe->dev, "vb2_queue_init failed\n"); + goto err_mutex_destroy; + } + + *vdev = pispbe_videodev; /* default initialization */ + strscpy(vdev->name, node_desc[id].ent_name, sizeof(vdev->name)); + vdev->v4l2_dev = &node_group->v4l2_dev; + vdev->vfl_dir = output ? VFL_DIR_TX : VFL_DIR_RX; + /* get V4L2 to serialise our ioctls */ + vdev->lock = &node->node_lock; + vdev->queue = &node->queue; + vdev->device_caps = V4L2_CAP_STREAMING | node_desc[id].caps; + + node->pad.flags = output ? MEDIA_PAD_FL_SOURCE : MEDIA_PAD_FL_SINK; + ret = media_entity_pads_init(entity, 1, &node->pad); + if (ret) { + dev_err(pispbe->dev, + "Failed to register media pads for %s device node\n", + NODE_NAME(node)); + goto err_unregister_queue; + } + + ret = video_register_device(vdev, VFL_TYPE_VIDEO, -1); + if (ret) { + dev_err(pispbe->dev, + "Failed to register video %s device node\n", + NODE_NAME(node)); + goto err_unregister_queue; + } + video_set_drvdata(vdev, node); + + if (output) + ret = media_create_pad_link(entity, 0, &node_group->sd.entity, + id, MEDIA_LNK_FL_IMMUTABLE | + MEDIA_LNK_FL_ENABLED); + else + ret = media_create_pad_link(&node_group->sd.entity, id, entity, + 0, MEDIA_LNK_FL_IMMUTABLE | + MEDIA_LNK_FL_ENABLED); + if (ret) + goto err_unregister_video_dev; + + dev_dbg(pispbe->dev, "%s device node registered as /dev/video%d\n", + NODE_NAME(node), node->vfd.num); + + return 0; + +err_unregister_video_dev: + video_unregister_device(&node->vfd); +err_unregister_queue: + vb2_queue_release(&node->queue); +err_mutex_destroy: + mutex_destroy(&node->node_lock); + mutex_destroy(&node->queue_lock); + return ret; +} + +static const struct v4l2_subdev_pad_ops pispbe_pad_ops = { + .link_validate = v4l2_subdev_link_validate_default, +}; + +static const struct v4l2_subdev_ops pispbe_sd_ops = { + .pad = &pispbe_pad_ops, +}; + +static int pispbe_init_subdev(struct pispbe_node_group *node_group) +{ + struct pispbe_dev *pispbe = node_group->pispbe; + struct v4l2_subdev *sd = &node_group->sd; + int ret; + + v4l2_subdev_init(sd, &pispbe_sd_ops); + sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER; + sd->owner = THIS_MODULE; + sd->dev = pispbe->dev; + strscpy(sd->name, PISPBE_NAME, sizeof(sd->name)); + + for (unsigned int i = 0; i < PISPBE_NUM_NODES; i++) + node_group->pad[i].flags = + NODE_DESC_IS_OUTPUT(&node_desc[i]) ? + MEDIA_PAD_FL_SINK : MEDIA_PAD_FL_SOURCE; + + ret = media_entity_pads_init(&sd->entity, PISPBE_NUM_NODES, + node_group->pad); + if (ret) + goto error; + + ret = v4l2_device_register_subdev(&node_group->v4l2_dev, sd); + if (ret) + goto error; + + return 0; + +error: + media_entity_cleanup(&sd->entity); + return ret; +} + +static int pispbe_init_group(struct pispbe_dev *pispbe, unsigned int id) +{ + struct pispbe_node_group *node_group = &pispbe->node_group[id]; + unsigned int num_registered = 0; + struct v4l2_device *v4l2_dev; + struct media_device *mdev; + int ret; + + node_group->id = id; + node_group->pispbe = pispbe; + node_group->streaming_map = 0; + + dev_dbg(pispbe->dev, "Register nodes for group %u\n", id); + + /* Register v4l2_device and media_device */ + mdev = &node_group->mdev; + mdev->hw_revision = node_group->pispbe->hw_version; + mdev->dev = node_group->pispbe->dev; + strscpy(mdev->model, PISPBE_NAME, sizeof(mdev->model)); + snprintf(mdev->bus_info, sizeof(mdev->bus_info), + "platform:%s", dev_name(node_group->pispbe->dev)); + media_device_init(mdev); + + v4l2_dev = &node_group->v4l2_dev; + v4l2_dev->mdev = &node_group->mdev; + strscpy(v4l2_dev->name, PISPBE_NAME, sizeof(v4l2_dev->name)); + + ret = v4l2_device_register(pispbe->dev, &node_group->v4l2_dev); + if (ret) + goto err_media_dev_cleanup; + + /* Register the PISPBE subdevice. */ + ret = pispbe_init_subdev(node_group); + if (ret) + goto err_unregister_v4l2; + + /* Create device video nodes */ + for (; num_registered < PISPBE_NUM_NODES; num_registered++) { + ret = pispbe_init_node(node_group, num_registered); + if (ret) + goto err_unregister_nodes; + } + + ret = media_device_register(mdev); + if (ret) + goto err_unregister_nodes; + + node_group->config = + dma_alloc_coherent(pispbe->dev, + sizeof(struct pisp_be_tiles_config) * + PISP_BE_NUM_CONFIG_BUFFERS, + &node_group->config_dma_addr, GFP_KERNEL); + if (!node_group->config) { + dev_err(pispbe->dev, "Unable to allocate cached config buffers.\n"); + ret = -ENOMEM; + goto err_unregister_mdev; + } + + return 0; + +err_unregister_mdev: + media_device_unregister(mdev); +err_unregister_nodes: + while (num_registered-- > 0) { + video_unregister_device(&node_group->node[num_registered].vfd); + vb2_queue_release(&node_group->node[num_registered].queue); + } + v4l2_device_unregister_subdev(&node_group->sd); + media_entity_cleanup(&node_group->sd.entity); +err_unregister_v4l2: + v4l2_device_unregister(v4l2_dev); +err_media_dev_cleanup: + media_device_cleanup(mdev); + return ret; +} + +static void pispbe_destroy_node_group(struct pispbe_node_group *node_group) +{ + struct pispbe_dev *pispbe = node_group->pispbe; + + if (node_group->config) { + dma_free_coherent(node_group->pispbe->dev, + sizeof(struct pisp_be_tiles_config) * + PISP_BE_NUM_CONFIG_BUFFERS, + node_group->config, + node_group->config_dma_addr); + } + + dev_dbg(pispbe->dev, "Unregister from media controller\n"); + + v4l2_device_unregister_subdev(&node_group->sd); + media_entity_cleanup(&node_group->sd.entity); + media_device_unregister(&node_group->mdev); + + for (int i = PISPBE_NUM_NODES - 1; i >= 0; i--) { + video_unregister_device(&node_group->node[i].vfd); + vb2_queue_release(&node_group->node[i].queue); + mutex_destroy(&node_group->node[i].node_lock); + mutex_destroy(&node_group->node[i].queue_lock); + } + + media_device_cleanup(&node_group->mdev); + v4l2_device_unregister(&node_group->v4l2_dev); +} + +static int pispbe_runtime_suspend(struct device *dev) +{ + struct pispbe_dev *pispbe = dev_get_drvdata(dev); + + clk_disable_unprepare(pispbe->clk); + + return 0; +} + +static int pispbe_runtime_resume(struct device *dev) +{ + struct pispbe_dev *pispbe = dev_get_drvdata(dev); + int ret; + + ret = clk_prepare_enable(pispbe->clk); + if (ret) { + dev_err(dev, "Unable to enable clock\n"); + return ret; + } + + dev_dbg(dev, "%s: Enabled clock, rate=%lu\n", + __func__, clk_get_rate(pispbe->clk)); + + return 0; +} + +static int pispbe_hw_init(struct pispbe_dev *pispbe) +{ + u32 u; + + /* Check the HW is present and has a known version */ + u = pispbe_rd(pispbe, PISP_BE_VERSION_REG); + dev_dbg(pispbe->dev, "pispbe_probe: HW version: 0x%08x", u); + pispbe->hw_version = u; + if ((u & ~PISP_BE_VERSION_MINOR_BITS) != PISP_BE_VERSION_2712) + return -ENODEV; + + /* Clear leftover interrupts */ + pispbe_wr(pispbe, PISP_BE_INTERRUPT_STATUS_REG, 0xFFFFFFFFu); + u = pispbe_rd(pispbe, PISP_BE_BATCH_STATUS_REG); + dev_dbg(pispbe->dev, "pispbe_probe: BatchStatus: 0x%08x", u); + pispbe->done = (uint8_t)u; + pispbe->started = (uint8_t)(u >> 8); + u = pispbe_rd(pispbe, PISP_BE_STATUS_REG); + dev_dbg(pispbe->dev, "pispbe_probe: Status: 0x%08x", u); + if (u != 0 || pispbe->done != pispbe->started) { + dev_err(pispbe->dev, "pispbe_probe: HW is stuck or busy\n"); + return -EBUSY; + } + /* + * AXI QOS=0, CACHE=4'b0010, PROT=3'b011 + * Also set "chicken bits" 22:20 which enable sub-64-byte bursts + * and AXI AWID/BID variability (on versions which support this). + */ + pispbe_wr(pispbe, PISP_BE_AXI_REG, 0x32703200u); + + /* Enable both interrupt flags */ + pispbe_wr(pispbe, PISP_BE_INTERRUPT_EN_REG, 0x00000003u); + + return 0; +} + +/* + * Probe the ISP-BE hardware block, as a single platform device. + * This will instantiate multiple "node groups" each with many device nodes. + */ +static int pispbe_probe(struct platform_device *pdev) +{ + unsigned int num_groups = 0; + struct pispbe_dev *pispbe; + int ret; + + pispbe = devm_kzalloc(&pdev->dev, sizeof(*pispbe), GFP_KERNEL); + if (!pispbe) + return -ENOMEM; + + dev_set_drvdata(&pdev->dev, pispbe); + pispbe->dev = &pdev->dev; + platform_set_drvdata(pdev, pispbe); + + pispbe->be_reg_base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(pispbe->be_reg_base)) { + dev_err(&pdev->dev, "Failed to get ISP-BE registers address\n"); + return PTR_ERR(pispbe->be_reg_base); + } + + pispbe->irq = platform_get_irq(pdev, 0); + if (pispbe->irq <= 0) { + dev_err(&pdev->dev, "No IRQ resource\n"); + return -EINVAL; + } + + ret = devm_request_irq(&pdev->dev, pispbe->irq, pispbe_isr, 0, + PISPBE_NAME, pispbe); + if (ret) { + dev_err(&pdev->dev, "Unable to request interrupt\n"); + return ret; + } + + ret = dma_set_mask_and_coherent(pispbe->dev, DMA_BIT_MASK(36)); + if (ret) + return ret; + + pispbe->clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(pispbe->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(pispbe->clk), + "Failed to get clock"); + + /* Hardware initialisation */ + pm_runtime_set_autosuspend_delay(pispbe->dev, 200); + pm_runtime_use_autosuspend(pispbe->dev); + pm_runtime_enable(pispbe->dev); + + ret = pm_runtime_resume_and_get(pispbe->dev); + if (ret) + goto pm_runtime_disable_err; + + pispbe->hw_busy = 0; + spin_lock_init(&pispbe->hw_lock); + ret = pispbe_hw_init(pispbe); + if (ret) + goto pm_runtime_put_err; + + /* + * Initialise and register devices for each node_group, including media + * device + */ + for (num_groups = 0; + num_groups < PISPBE_NUM_NODE_GROUPS; + num_groups++) { + ret = pispbe_init_group(pispbe, num_groups); + if (ret) + goto disable_nodes_err; + } + + pm_runtime_mark_last_busy(pispbe->dev); + pm_runtime_put_autosuspend(pispbe->dev); + + return 0; + +disable_nodes_err: + while (num_groups-- > 0) + pispbe_destroy_node_group(&pispbe->node_group[num_groups]); +pm_runtime_put_err: + pm_runtime_put(pispbe->dev); +pm_runtime_disable_err: + pm_runtime_dont_use_autosuspend(pispbe->dev); + pm_runtime_disable(pispbe->dev); + + return ret; +} + +static int pispbe_remove(struct platform_device *pdev) +{ + struct pispbe_dev *pispbe = platform_get_drvdata(pdev); + + for (int i = PISPBE_NUM_NODE_GROUPS - 1; i >= 0; i--) + pispbe_destroy_node_group(&pispbe->node_group[i]); + + pm_runtime_dont_use_autosuspend(pispbe->dev); + pm_runtime_disable(pispbe->dev); + + return 0; +} + +static const struct dev_pm_ops pispbe_pm_ops = { + SET_RUNTIME_PM_OPS(pispbe_runtime_suspend, pispbe_runtime_resume, NULL) +}; + +static const struct of_device_id pispbe_of_match[] = { + { + .compatible = "raspberrypi,pispbe", + }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, pispbe_of_match); + +static struct platform_driver pispbe_pdrv = { + .probe = pispbe_probe, + .remove = pispbe_remove, + .driver = { + .name = PISPBE_NAME, + .of_match_table = pispbe_of_match, + .pm = &pispbe_pm_ops, + }, +}; + +module_platform_driver(pispbe_pdrv); + +MODULE_DESCRIPTION("PiSP Back End driver"); +MODULE_AUTHOR("David Plowman <david.plowman@raspberrypi.com>"); +MODULE_AUTHOR("Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>"); +MODULE_LICENSE("GPL"); diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h new file mode 100644 index 000000000000..ebd320c9888c --- /dev/null +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be_formats.h @@ -0,0 +1,519 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * PiSP Back End driver image format definitions. + * + * Copyright (c) 2021 Raspberry Pi Ltd + */ + +#ifndef _PISP_BE_FORMATS_ +#define _PISP_BE_FORMATS_ + +#include <linux/bits.h> +#include <linux/videodev2.h> + +#define PISPBE_MAX_PLANES 3 +#define P3(x) ((x) * 8) + +struct pisp_be_format { + unsigned int fourcc; + unsigned int align; + unsigned int bit_depth; + /* 0P3 factor for plane sizing */ + unsigned int plane_factor[PISPBE_MAX_PLANES]; + unsigned int num_planes; + unsigned int colorspace_mask; + enum v4l2_colorspace colorspace_default; +}; + +#define V4L2_COLORSPACE_MASK(colorspace) BIT(colorspace) + +#define V4L2_COLORSPACE_MASK_JPEG \ + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_JPEG) +#define V4L2_COLORSPACE_MASK_SMPTE170M \ + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SMPTE170M) +#define V4L2_COLORSPACE_MASK_REC709 \ + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_REC709) +#define V4L2_COLORSPACE_MASK_SRGB \ + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_SRGB) +#define V4L2_COLORSPACE_MASK_RAW \ + V4L2_COLORSPACE_MASK(V4L2_COLORSPACE_RAW) + +/* + * All three colour spaces SRGB, SMPTE170M and REC709 are fundamentally sRGB + * underneath (as near as makes no difference to us), just with different YCbCr + * encodings. Therefore the ISP can generate sRGB on its main output and any of + * the others on its low resolution output. Applications should, when using both + * outputs, program the colour spaces on them to be the same, matching whatever + * is requested for the low resolution output, even if the main output is + * producing an RGB format. In turn this requires us to allow all these colour + * spaces for every YUV/RGB output format. + */ +#define V4L2_COLORSPACE_MASK_ALL_SRGB (V4L2_COLORSPACE_MASK_JPEG | \ + V4L2_COLORSPACE_MASK_SRGB | \ + V4L2_COLORSPACE_MASK_SMPTE170M | \ + V4L2_COLORSPACE_MASK_REC709) + +static const struct pisp_be_format supported_formats[] = { + /* Single plane YUV formats */ + { + .fourcc = V4L2_PIX_FMT_YUV420, + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ + .align = 128, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YVU420, + /* 128 alignment to ensure U/V planes are 64 byte aligned. */ + .align = 128, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_NV12, + .align = 32, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_NV21, + .align = 32, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YUYV, + .align = 64, + .bit_depth = 16, + .plane_factor = { P3(1) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_UYVY, + .align = 64, + .bit_depth = 16, + .plane_factor = { P3(1) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YVYU, + .align = 64, + .bit_depth = 16, + .plane_factor = { P3(1) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_VYUY, + .align = 64, + .bit_depth = 16, + .plane_factor = { P3(1) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + /* Multiplane YUV formats */ + { + .fourcc = V4L2_PIX_FMT_YUV420M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_NV12M, + .align = 32, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5) }, + .num_planes = 2, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_NV21M, + .align = 32, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5) }, + .num_planes = 2, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YVU420M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.25), P3(0.25) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YUV422M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YVU422M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(0.5), P3(0.5) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YUV444M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(1), P3(1) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + { + .fourcc = V4L2_PIX_FMT_YVU444M, + .align = 64, + .bit_depth = 8, + .plane_factor = { P3(1), P3(1), P3(1) }, + .num_planes = 3, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SMPTE170M, + }, + /* RGB formats */ + { + .fourcc = V4L2_PIX_FMT_RGB24, + .align = 32, + .bit_depth = 24, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + { + .fourcc = V4L2_PIX_FMT_BGR24, + .align = 32, + .bit_depth = 24, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + { + .fourcc = V4L2_PIX_FMT_XBGR32, + .align = 64, + .bit_depth = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + { + .fourcc = V4L2_PIX_FMT_RGBX32, + .align = 64, + .bit_depth = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + { + .fourcc = V4L2_PIX_FMT_RGB48, + .align = 64, + .bit_depth = 48, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + { + .fourcc = V4L2_PIX_FMT_BGR48, + .align = 64, + .bit_depth = 48, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_ALL_SRGB, + .colorspace_default = V4L2_COLORSPACE_SRGB, + }, + /* Bayer formats - 8-bit */ + { + .fourcc = V4L2_PIX_FMT_SRGGB8, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SBGGR8, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGRBG8, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGBRG8, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + /* Bayer formats - 16-bit */ + { + .fourcc = V4L2_PIX_FMT_SRGGB16, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SBGGR16, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGRBG16, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGBRG16, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + /* Bayer formats unpacked to 16bpp */ + /* 10 bit */ + .fourcc = V4L2_PIX_FMT_SRGGB10, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SBGGR10, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGRBG10, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGBRG10, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + /* 12 bit */ + .fourcc = V4L2_PIX_FMT_SRGGB12, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SBGGR12, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGRBG12, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGBRG12, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + /* 14 bit */ + .fourcc = V4L2_PIX_FMT_SRGGB14, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SBGGR14, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGRBG14, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_SGBRG14, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + /* Bayer formats - 16-bit PiSP Compressed */ + { + .fourcc = V4L2_PIX_FMT_PISP_COMP1_BGGR, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_PISP_COMP1_RGGB, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GRBG, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_PISP_COMP1_GBRG, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + /* Greyscale Formats */ + { + .fourcc = V4L2_PIX_FMT_GREY, + .bit_depth = 8, + .align = 32, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_Y16, + .bit_depth = 16, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, + { + .fourcc = V4L2_PIX_FMT_PISP_COMP1_MONO, + .bit_depth = 8, + .align = 32, + .plane_factor = { P3(1.0) }, + .num_planes = 1, + .colorspace_mask = V4L2_COLORSPACE_MASK_RAW, + .colorspace_default = V4L2_COLORSPACE_RAW, + }, +}; + +static const struct pisp_be_format meta_out_supported_formats[] = { + /* Configuration buffer format. */ + { + .fourcc = V4L2_META_FMT_RPI_BE_CFG, + }, +}; + +#endif /* _PISP_BE_FORMATS_ */