| Message ID | 20240605110907.621053-1-sebastian.wick@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] edid-decode: build: compile with -Wno-variadic-macros | expand |
On 05/06/2024 13:09, Sebastian Wick wrote: > Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com> > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git ./meson.build ../meson.build > index ca57652..80f810f 100644 > --- ./meson.build > +++ ../meson.build > @@ -7,6 +7,7 @@ edid_decode_args = [ > '-Wno-missing-field-initializers', > '-Wno-unused-parameter', > '-Wimplicit-fallthrough', > + '-Wno-variadic-macros', > ] > edid_decode_link_args = [] > Can you provide a proper commit log? E.g. why is this needed? Regards, Hans
When building as a subproject, I get warnings: ../subprojects/edid-decode/edid-decode.h:516:23: warning: ISO C++ does not permit named variadic macros [-Wvariadic-macros] 516 | #define warn(fmt, args...) msg(true, fmt, ##args) I cannot tell you why this happens though. I tried to reproduce this without a subproject by passing different compiler options and trying different standard versions but did not manage. So, I'm not sure why this is needed other than silencing annoying warnings in libdisplay-info. On Thu, Jun 6, 2024 at 8:02 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote: > > On 05/06/2024 13:09, Sebastian Wick wrote: > > Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com> > > --- > > meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git ./meson.build ../meson.build > > index ca57652..80f810f 100644 > > --- ./meson.build > > +++ ../meson.build > > @@ -7,6 +7,7 @@ edid_decode_args = [ > > '-Wno-missing-field-initializers', > > '-Wno-unused-parameter', > > '-Wimplicit-fallthrough', > > + '-Wno-variadic-macros', > > ] > > edid_decode_link_args = [] > > > > Can you provide a proper commit log? E.g. why is this needed? > > Regards, > > Hans >
diff --git ./meson.build ../meson.build index ca57652..80f810f 100644 --- ./meson.build +++ ../meson.build @@ -7,6 +7,7 @@ edid_decode_args = [ '-Wno-missing-field-initializers', '-Wno-unused-parameter', '-Wimplicit-fallthrough', + '-Wno-variadic-macros', ] edid_decode_link_args = []
Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com> --- meson.build | 1 + 1 file changed, 1 insertion(+)