From patchwork Thu Jun 20 12:47:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 13705355 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E525B1ACE61 for ; Thu, 20 Jun 2024 12:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718887676; cv=none; b=oO4ZbSPrNl8Ccz8lgV03CbcIvOECOcJ0aGJGwRXFi9k97N/t1R8urweBQHpNQxfPt7fmM6M+Bi3NHHKP5KuHRgr7tR5ZAi5xAJD0mc7J8uen44AcS+/a/c9jxALxiGR0XxP9uVOKBygMt3cfBbW1VmOq/DMa51WUpxqqTZWQwmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718887676; c=relaxed/simple; bh=XrspX98ISckG3Sj6/BzKitPRpRn8XaSj2KqHKFT+dR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DjrOGD79mn1JOZoeh9uWksMlAsM21PV1yb0zMBrfwGhB6gA1pZR1ZoieFKnF8s7zh9+Q2OJOiNtXAchdzusAonmd4LU8SiaiSeQAGrDZOox/ex+gEgmxCTd9ba3Fcnktumu5RnM8IrGpVAfDwuSzwqQyQVgrPzHIJpGcU0CG2lI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TShp/ttk; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TShp/ttk" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2ec3432633dso931201fa.3 for ; Thu, 20 Jun 2024 05:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718887673; x=1719492473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kU4UhCQc9+764HGn+BU4tW5vcAuXA5Pmyz8qsif4vWs=; b=TShp/ttkj6f+2k7sB5BAii9rHyo8IkuYGZLaoGQElxSvsNhcR7bv2ZmcFbGFhRXuX9 JTKg97w//PutvFYMRicsqFUI54AFvN9OiGBsBVmViHXL6k6QgtZIksa2i54fQL1OXSw2 m1MH6uwhVziExFNzHbywuvEJe/7XIhsA5To6dPpYG3UIf3Bi3ldq3R5qlruXpoABw5mj FuxHcWryuOObRUFkR7Xn3Ch7NUxbHqBsXPHsWVD+pg4Qw+kufNKv1oS6Vx2OrJDWQxTd 26IELgTp3pkJPQGBuZ/1mhRZdS17EXQde6uKFyaRix7GWmw6WkT/o9WhhHKg4NW4ieJj L8Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718887673; x=1719492473; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kU4UhCQc9+764HGn+BU4tW5vcAuXA5Pmyz8qsif4vWs=; b=hDuwds1w52S4sb5dMdWc49lkHcRz4cELKRgZNi4U2H4oSRkmfbVK1wfi1O5uyb/mdh VEREKduDbe+yaXSoiJESptAfWYJcCkrufHt2EZnD4poocNW/9kd6acqvYwI1SS6bZI2n GfVdFKwTGUFJz32ztxyC2jMm7xG2Q0AfNm4qAHZgb0U0MO1/DxtjPRYtUeMxy23c/HxM ELoN12AiWhyCEVvRpan/XtZDZWWC9S3LKY/U5NVTDppSR6L4Syxb9/F53G23I2tihoFA 6UxZJIV03ZwVLwWFrkfPxZtcWLTTC9JFPgjvBXVSa4v+L3wuRmSANWFu5bKKtrurIjZv ZtwQ== X-Forwarded-Encrypted: i=1; AJvYcCXWdqCIzumOQYD5jk8O+wCTiZiLJWoav1BPIDiImv/VZLWJ0Bxnk7EbuVEUjm+RTkWyKAQCKIl+G+k6UJxsdBtNe7ApO45z+3XsuQQ= X-Gm-Message-State: AOJu0YwE0IcNpUqyITI+X/0OrNVCG7SA8v2GgMjYV6omKsqlYTlsjkaO Oi0dlMJ0O4Jty/9SatSmkK/S/iJomZdppTVCXbxpEmyA2+oMrGAPlGRolhEsz/o= X-Google-Smtp-Source: AGHT+IE2pOh2daHEILK+6XHiitvdvq9yF5/zOOktvf9tbV6nGyW3jjGwlRafV2mntrPBpgXDbVkYMg== X-Received: by 2002:a2e:a553:0:b0:2ec:ca8:4897 with SMTP id 38308e7fff4ca-2ec3cfe83camr37809031fa.4.1718887673146; Thu, 20 Jun 2024 05:47:53 -0700 (PDT) Received: from localhost.localdomain (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c17ba8sm22421411fa.72.2024.06.20.05.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 05:47:52 -0700 (PDT) From: Vladimir Zapolskiy To: Sakari Ailus Cc: Krzysztof Kozlowski , Rob Herring , Conor Dooley , Mauro Carvalho Chehab , linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 3/3] media: i2c: og01a1b: Add support of an input system clock Date: Thu, 20 Jun 2024 15:47:45 +0300 Message-ID: <20240620124745.1265011-4-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240620124745.1265011-1-vladimir.zapolskiy@linaro.org> References: <20240620124745.1265011-1-vladimir.zapolskiy@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To be properly configured at probe time the sensor module contains a required reference to xvclk clock on OF platforms, which is now enabled on probe and checked for a supported frequency rate. Signed-off-by: Vladimir Zapolskiy --- drivers/media/i2c/og01a1b.c | 43 +++++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/og01a1b.c b/drivers/media/i2c/og01a1b.c index 9e756c1c47df..929a7e32bd6a 100644 --- a/drivers/media/i2c/og01a1b.c +++ b/drivers/media/i2c/og01a1b.c @@ -3,6 +3,7 @@ #include #include +#include #include #include #include @@ -418,6 +419,9 @@ static const struct og01a1b_mode supported_modes[] = { }; struct og01a1b { + struct device *dev; + struct clk *xvclk; + struct v4l2_subdev sd; struct media_pad pad; struct v4l2_ctrl_handler ctrl_handler; @@ -898,8 +902,9 @@ static int og01a1b_identify_module(struct og01a1b *og01a1b) return 0; } -static int og01a1b_check_hwcfg(struct device *dev) +static int og01a1b_check_hwcfg(struct og01a1b *og01a1b) { + struct device *dev = og01a1b->dev; struct fwnode_handle *ep; struct fwnode_handle *fwnode = dev_fwnode(dev); struct v4l2_fwnode_endpoint bus_cfg = { @@ -913,10 +918,13 @@ static int og01a1b_check_hwcfg(struct device *dev) return -ENXIO; ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk); - if (ret) { - dev_err(dev, "can't get clock frequency"); - return ret; + if (!og01a1b->xvclk) { + dev_err(dev, "can't get clock frequency"); + return ret; + } + + mclk = clk_get_rate(og01a1b->xvclk); } if (mclk != OG01A1B_MCLK) { @@ -977,6 +985,7 @@ static void og01a1b_remove(struct i2c_client *client) v4l2_ctrl_handler_free(sd->ctrl_handler); pm_runtime_disable(&client->dev); mutex_destroy(&og01a1b->mutex); + clk_disable_unprepare(og01a1b->xvclk); } static int og01a1b_probe(struct i2c_client *client) @@ -984,22 +993,35 @@ static int og01a1b_probe(struct i2c_client *client) struct og01a1b *og01a1b; int ret; - ret = og01a1b_check_hwcfg(&client->dev); + og01a1b = devm_kzalloc(&client->dev, sizeof(*og01a1b), GFP_KERNEL); + if (!og01a1b) + return -ENOMEM; + + og01a1b->dev = &client->dev; + + og01a1b->xvclk = devm_clk_get_optional(&client->dev, NULL); + if (IS_ERR(og01a1b->xvclk)) { + ret = PTR_ERR(og01a1b->xvclk); + dev_err(&client->dev, "failed to get clock: %d\n", ret); + return ret; + } + + ret = og01a1b_check_hwcfg(og01a1b); if (ret) { dev_err(&client->dev, "failed to check HW configuration: %d", ret); return ret; } - og01a1b = devm_kzalloc(&client->dev, sizeof(*og01a1b), GFP_KERNEL); - if (!og01a1b) - return -ENOMEM; + ret = clk_prepare_enable(og01a1b->xvclk); + if (ret) + return ret; v4l2_i2c_subdev_init(&og01a1b->sd, client, &og01a1b_subdev_ops); ret = og01a1b_identify_module(og01a1b); if (ret) { dev_err(&client->dev, "failed to find sensor: %d", ret); - return ret; + goto disable_clk; } mutex_init(&og01a1b->mutex); @@ -1045,6 +1067,9 @@ static int og01a1b_probe(struct i2c_client *client) v4l2_ctrl_handler_free(og01a1b->sd.ctrl_handler); mutex_destroy(&og01a1b->mutex); +disable_clk: + clk_disable_unprepare(og01a1b->xvclk); + return ret; }