| Message ID | 20240628132948.871568-5-jacopo.mondi@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: uapi: pisp_be: More late fixes | expand |
Hi Jacopo, Thank you for this fix. On Fri, 28 Jun 2024 at 14:30, Jacopo Mondi <jacopo.mondi@ideasonboard.com> wrote: > > The order of the members of pisp_be_tiles_config is relevant > as the driver logic assumes 'config' to be at offset 0. > > Re-sort the member to match the driver's expectations. > > Fixes: c6c49bac8770 ("media: uapi: Add Raspberry Pi PiSP Back End uAPI") > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Acked-by: Naushir Patuck <naush@raspberrypi.com> > --- > include/uapi/linux/media/raspberrypi/pisp_be_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h > index 27d0cc417d6b..f8650ca92bf8 100644 > --- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h > +++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h > @@ -919,9 +919,9 @@ struct pisp_tile { > * @config: PiSP Back End configuration > */ > struct pisp_be_tiles_config { > + struct pisp_be_config config; > struct pisp_tile tiles[PISP_BACK_END_NUM_TILES]; > __u32 num_tiles; > - struct pisp_be_config config; > } __attribute__((packed)); > > #endif /* _UAPI_PISP_BE_CONFIG_H_ */ > -- > 2.45.2 >
diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h index 27d0cc417d6b..f8650ca92bf8 100644 --- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h +++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h @@ -919,9 +919,9 @@ struct pisp_tile { * @config: PiSP Back End configuration */ struct pisp_be_tiles_config { + struct pisp_be_config config; struct pisp_tile tiles[PISP_BACK_END_NUM_TILES]; __u32 num_tiles; - struct pisp_be_config config; } __attribute__((packed)); #endif /* _UAPI_PISP_BE_CONFIG_H_ */
The order of the members of pisp_be_tiles_config is relevant as the driver logic assumes 'config' to be at offset 0. Re-sort the member to match the driver's expectations. Fixes: c6c49bac8770 ("media: uapi: Add Raspberry Pi PiSP Back End uAPI") Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- include/uapi/linux/media/raspberrypi/pisp_be_config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.45.2