| Message ID | 20240710044633.81372-2-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: imx335: Support vertical flip | expand |
Hi Umang, On Wed, Jul 10, 2024 at 10:16:31AM +0530, Umang Jain wrote: > In commit 81495a59baeb ("media: imx335: Fix active area height discrepency") > the height for the mode struct was rectified to '1944'. However, the > name of mode struct is still reflecting to '1940'. Update it. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/media/i2c/imx335.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c > index 990d74214cc2..6c1e61b6696b 100644 > --- a/drivers/media/i2c/imx335.c > +++ b/drivers/media/i2c/imx335.c > @@ -252,7 +252,7 @@ static const int imx335_tpg_val[] = { > }; > > /* Sensor mode registers */ > -static const struct cci_reg_sequence mode_2592x1940_regs[] = { > +static const struct cci_reg_sequence mode_2592x1944_regs[] = { > { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY }, > { IMX335_REG_MASTER_MODE, 0x00 }, > { IMX335_REG_WINMODE, 0x04 }, > @@ -416,8 +416,8 @@ static const struct imx335_mode supported_mode = { > .vblank_max = 133060, > .pclk = 396000000, > .reg_list = { > - .num_of_regs = ARRAY_SIZE(mode_2592x1940_regs), > - .regs = mode_2592x1940_regs, > + .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs), > + .regs = mode_2592x1944_regs, > }, > }; > > -- > 2.45.0 > > Looks good to me. Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com> Thanks & Regards, Tommaso
Quoting Umang Jain (2024-07-10 05:46:31) > In commit 81495a59baeb ("media: imx335: Fix active area height discrepency") > the height for the mode struct was rectified to '1944'. However, the > name of mode struct is still reflecting to '1940'. Update it. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/media/i2c/imx335.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c > index 990d74214cc2..6c1e61b6696b 100644 > --- a/drivers/media/i2c/imx335.c > +++ b/drivers/media/i2c/imx335.c > @@ -252,7 +252,7 @@ static const int imx335_tpg_val[] = { > }; > > /* Sensor mode registers */ > -static const struct cci_reg_sequence mode_2592x1940_regs[] = { > +static const struct cci_reg_sequence mode_2592x1944_regs[] = { > { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY }, > { IMX335_REG_MASTER_MODE, 0x00 }, > { IMX335_REG_WINMODE, 0x04 }, > @@ -416,8 +416,8 @@ static const struct imx335_mode supported_mode = { > .vblank_max = 133060, > .pclk = 396000000, > .reg_list = { > - .num_of_regs = ARRAY_SIZE(mode_2592x1940_regs), > - .regs = mode_2592x1940_regs, > + .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs), > + .regs = mode_2592x1944_regs, > }, > }; > > -- > 2.45.0 >
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 990d74214cc2..6c1e61b6696b 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -252,7 +252,7 @@ static const int imx335_tpg_val[] = { }; /* Sensor mode registers */ -static const struct cci_reg_sequence mode_2592x1940_regs[] = { +static const struct cci_reg_sequence mode_2592x1944_regs[] = { { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY }, { IMX335_REG_MASTER_MODE, 0x00 }, { IMX335_REG_WINMODE, 0x04 }, @@ -416,8 +416,8 @@ static const struct imx335_mode supported_mode = { .vblank_max = 133060, .pclk = 396000000, .reg_list = { - .num_of_regs = ARRAY_SIZE(mode_2592x1940_regs), - .regs = mode_2592x1940_regs, + .num_of_regs = ARRAY_SIZE(mode_2592x1944_regs), + .regs = mode_2592x1944_regs, }, };
In commit 81495a59baeb ("media: imx335: Fix active area height discrepency") the height for the mode struct was rectified to '1944'. However, the name of mode struct is still reflecting to '1940'. Update it. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- drivers/media/i2c/imx335.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)