| Message ID | 20240729-add-mtk-isp-3-0-support-v6-1-c374c9e0c672@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Mediatek ISP3.0 | expand |
Il 29/07/24 16:48, Julien Stephan ha scritto: > From: Louis Kuo <louis.kuo@mediatek.com> > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > .../bindings/media/mediatek,mt8365-seninf.yaml | 259 +++++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 266 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > new file mode 100644 > index 000000000000..8bd78ef424ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > @@ -0,0 +1,259 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Sensor Interface 3.0 > + ..snip.. > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/mediatek,mt8365-clk.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/phy/phy.h> > + #include <dt-bindings/power/mediatek,mt8365-power.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + csi@15040000 { > + compatible = "mediatek,mt8365-seninf"; > + reg = <0 0x15040000 0 0x6000>; > + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&camsys CLK_CAM_SENIF>, > + <&topckgen CLK_TOP_SENIF_SEL>; > + clock-names = "camsys", "top_mux"; > + > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; > + > + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>; > + phy-names = "csi0", "csi1"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + seninf_in1: endpoint { > + clock-lanes = <2>; > + data-lanes = <1 3 0 4>; > + remote-endpoint = <&isp1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + }; > + > + port@2 { > + reg = <2>; > + }; > + > + port@3 { > + reg = <3>; > + }; I don't really get why you got all those empty ports here, as you could simply avoid adding all of the empty nodes instead. I don't have strong opinions about that anyway so, regardless of that.... Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > + > + port@4 { > + reg = <4>; > + seninf_camsv1_endpoint: endpoint { > + remote-endpoint = <&camsv1_endpoint>; > + }; > + }; > + > + port@5 { > + reg = <5>; > + seninf_camsv2_endpoint: endpoint { > + remote-endpoint = <&camsv2_endpoint>; > + }; > + }; > + > + port@6 { > + reg = <6>; > + }; > + > + port@7 { > + reg = <7>; > + }; > + > + port@8 { > + reg = <8>; > + }; > + > + port@9 { > + reg = <9>; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d6c90161c7bf..6bd7df1c3e08 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14158,6 +14158,13 @@ M: Sean Wang <sean.wang@mediatek.com> > S: Maintained > F: drivers/char/hw_random/mtk-rng.c > > +MEDIATEK ISP3.0 DRIVER > +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > +M: Julien Stephan <jstephan@baylibre.com> > +M: Andy Hsieh <andy.hsieh@mediatek.com> > +S: Supported > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > + > MEDIATEK SMI DRIVER > M: Yong Wu <yong.wu@mediatek.com> > L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) >
Il 29/07/24 16:57, AngeloGioacchino Del Regno ha scritto: > Il 29/07/24 16:48, Julien Stephan ha scritto: >> From: Louis Kuo <louis.kuo@mediatek.com> >> >> This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in >> some Mediatek SoC, such as the mt8365 >> >> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> >> Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Signed-off-by: Julien Stephan <jstephan@baylibre.com> >> --- >> .../bindings/media/mediatek,mt8365-seninf.yaml | 259 +++++++++++++++++++++ >> MAINTAINERS | 7 + >> 2 files changed, 266 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml >> b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml >> new file mode 100644 >> index 000000000000..8bd78ef424ac >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml >> @@ -0,0 +1,259 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (c) 2023 MediaTek, BayLibre >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek Sensor Interface 3.0 >> + > > ..snip.. > >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/mediatek,mt8365-clk.h> >> + #include <dt-bindings/interrupt-controller/irq.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> >> + #include <dt-bindings/phy/phy.h> >> + #include <dt-bindings/power/mediatek,mt8365-power.h> >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + csi@15040000 { >> + compatible = "mediatek,mt8365-seninf"; >> + reg = <0 0x15040000 0 0x6000>; >> + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>; >> + clocks = <&camsys CLK_CAM_SENIF>, >> + <&topckgen CLK_TOP_SENIF_SEL>; >> + clock-names = "camsys", "top_mux"; >> + >> + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; >> + >> + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>; >> + phy-names = "csi0", "csi1"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + seninf_in1: endpoint { >> + clock-lanes = <2>; >> + data-lanes = <1 3 0 4>; >> + remote-endpoint = <&isp1_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + }; >> + >> + port@2 { >> + reg = <2>; >> + }; >> + >> + port@3 { >> + reg = <3>; >> + }; > > I don't really get why you got all those empty ports here, as you could simply > avoid adding all of the empty nodes instead. > > I don't have strong opinions about that anyway so, regardless of that.... > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Wait a minute. No. The ports are all required?! Why?! Regards, Angelo >> + >> + port@4 { >> + reg = <4>; >> + seninf_camsv1_endpoint: endpoint { >> + remote-endpoint = <&camsv1_endpoint>; >> + }; >> + }; >> + >> + port@5 { >> + reg = <5>; >> + seninf_camsv2_endpoint: endpoint { >> + remote-endpoint = <&camsv2_endpoint>; >> + }; >> + }; >> + >> + port@6 { >> + reg = <6>; >> + }; >> + >> + port@7 { >> + reg = <7>; >> + }; >> + >> + port@8 { >> + reg = <8>; >> + }; >> + >> + port@9 { >> + reg = <9>; >> + }; >> + }; >> + }; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d6c90161c7bf..6bd7df1c3e08 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -14158,6 +14158,13 @@ M: Sean Wang <sean.wang@mediatek.com> >> S: Maintained >> F: drivers/char/hw_random/mtk-rng.c >> +MEDIATEK ISP3.0 DRIVER >> +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> +M: Julien Stephan <jstephan@baylibre.com> >> +M: Andy Hsieh <andy.hsieh@mediatek.com> >> +S: Supported >> +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml >> + >> MEDIATEK SMI DRIVER >> M: Yong Wu <yong.wu@mediatek.com> >> L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) >> >
Hi Angelo, On Mon, Jul 29, 2024 at 05:08:35PM +0200, AngeloGioacchino Del Regno wrote: > Il 29/07/24 16:57, AngeloGioacchino Del Regno ha scritto: > > Il 29/07/24 16:48, Julien Stephan ha scritto: > >> From: Louis Kuo <louis.kuo@mediatek.com> > >> > >> This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > >> some Mediatek SoC, such as the mt8365 > >> > >> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > >> Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> > >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Signed-off-by: Julien Stephan <jstephan@baylibre.com> > >> --- > >> .../bindings/media/mediatek,mt8365-seninf.yaml | 259 +++++++++++++++++++++ > >> MAINTAINERS | 7 + > >> 2 files changed, 266 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > >> b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > >> new file mode 100644 > >> index 000000000000..8bd78ef424ac > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > >> @@ -0,0 +1,259 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +# Copyright (c) 2023 MediaTek, BayLibre > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: MediaTek Sensor Interface 3.0 > >> + > > > > ..snip.. > > > >> +additionalProperties: false > >> + > >> +examples: > >> + - | > >> + #include <dt-bindings/clock/mediatek,mt8365-clk.h> > >> + #include <dt-bindings/interrupt-controller/irq.h> > >> + #include <dt-bindings/interrupt-controller/arm-gic.h> > >> + #include <dt-bindings/phy/phy.h> > >> + #include <dt-bindings/power/mediatek,mt8365-power.h> > >> + > >> + soc { > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + > >> + csi@15040000 { > >> + compatible = "mediatek,mt8365-seninf"; > >> + reg = <0 0x15040000 0 0x6000>; > >> + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>; > >> + clocks = <&camsys CLK_CAM_SENIF>, > >> + <&topckgen CLK_TOP_SENIF_SEL>; > >> + clock-names = "camsys", "top_mux"; > >> + > >> + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; > >> + > >> + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>; > >> + phy-names = "csi0", "csi1"; > >> + > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + port@0 { > >> + reg = <0>; > >> + seninf_in1: endpoint { > >> + clock-lanes = <2>; > >> + data-lanes = <1 3 0 4>; > >> + remote-endpoint = <&isp1_out>; > >> + }; > >> + }; > >> + > >> + port@1 { > >> + reg = <1>; > >> + }; > >> + > >> + port@2 { > >> + reg = <2>; > >> + }; > >> + > >> + port@3 { > >> + reg = <3>; > >> + }; > > > > I don't really get why you got all those empty ports here, as you could simply > > avoid adding all of the empty nodes instead. > > > > I don't have strong opinions about that anyway so, regardless of that.... > > > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Wait a minute. No. The ports are all required?! Why?! Because they exist at the hardware level, even if not all of them are supported in drivers in this series. Ports 6 to 9, for instance, are connected to ISPs that have no current mainline support, but they exist in the hardware. > >> + > >> + port@4 { > >> + reg = <4>; > >> + seninf_camsv1_endpoint: endpoint { > >> + remote-endpoint = <&camsv1_endpoint>; > >> + }; > >> + }; > >> + > >> + port@5 { > >> + reg = <5>; > >> + seninf_camsv2_endpoint: endpoint { > >> + remote-endpoint = <&camsv2_endpoint>; > >> + }; > >> + }; > >> + > >> + port@6 { > >> + reg = <6>; > >> + }; > >> + > >> + port@7 { > >> + reg = <7>; > >> + }; > >> + > >> + port@8 { > >> + reg = <8>; > >> + }; > >> + > >> + port@9 { > >> + reg = <9>; > >> + }; > >> + }; > >> + }; > >> + }; > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index d6c90161c7bf..6bd7df1c3e08 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -14158,6 +14158,13 @@ M: Sean Wang <sean.wang@mediatek.com> > >> S: Maintained > >> F: drivers/char/hw_random/mtk-rng.c > >> +MEDIATEK ISP3.0 DRIVER > >> +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> +M: Julien Stephan <jstephan@baylibre.com> > >> +M: Andy Hsieh <andy.hsieh@mediatek.com> > >> +S: Supported > >> +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > >> + > >> MEDIATEK SMI DRIVER > >> M: Yong Wu <yong.wu@mediatek.com> > >> L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) > >>
On Mon, 29 Jul 2024 16:48:00 +0200, Julien Stephan wrote: > From: Louis Kuo <louis.kuo@mediatek.com> > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo <louis.kuo@mediatek.com> > Signed-off-by: Phi-Bang Nguyen <pnguyen@baylibre.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > .../bindings/media/mediatek,mt8365-seninf.yaml | 259 +++++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 266 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml new file mode 100644 index 000000000000..8bd78ef424ac --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml @@ -0,0 +1,259 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2023 MediaTek, BayLibre +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek Sensor Interface 3.0 + +maintainers: + - Laurent Pinchart <laurent.pinchart@ideasonboard.com> + - Julien Stephan <jstephan@baylibre.com> + - Andy Hsieh <andy.hsieh@mediatek.com> + +description: + The ISP3.0 SENINF is the CSI-2 and parallel camera sensor interface found in + multiple MediaTek SoCs. It can support up to three physical CSI-2 input ports, + configured in DPHY (2 or 4 data lanes) or CPHY depending on the SoC. + On the output side, SENINF can be connected either to CAMSV instance or + to the internal ISP. CAMSV is used to bypass the internal ISP processing + in order to connect either an external ISP, or a sensor (RAW, YUV). + +properties: + compatible: + const: mediatek,mt8365-seninf + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + items: + - description: Seninf camsys clock + - description: Seninf top mux clock + + clock-names: + items: + - const: camsys + - const: top_mux + + phys: + minItems: 2 + maxItems: 2 + description: + phandle to the PHYs connected to CSI0/A, CSI1, CSI0B + + phy-names: + description: + list of PHYs names + minItems: 2 + maxItems: 2 + items: + enum: [ csi0, csi1, csi0b] + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: CSI0 or CSI0A port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + clock-lanes: + maxItems: 1 + data-lanes: + minItems: 1 + maxItems: 4 + + port@1: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: CSI1 port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + clock-lanes: + maxItems: 1 + data-lanes: + minItems: 1 + maxItems: 4 + + port@2: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: CSI2 port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + clock-lanes: + maxItems: 1 + data-lanes: + minItems: 1 + maxItems: 4 + + port@3: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: CSI0B port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + clock-lanes: + maxItems: 1 + data-lanes: + minItems: 1 + maxItems: 2 + + port@4: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for cam0 + + port@5: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for cam1 + + port@6: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for camsv0 + + port@7: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for camsv1 + + port@8: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for camsv2 + + port@9: + $ref: /schemas/graph.yaml#/properties/port + description: connection point for camsv3 + + required: + - port@0 + - port@1 + - port@2 + - port@3 + - port@4 + - port@5 + - port@6 + - port@7 + - port@8 + - port@9 + +required: + - compatible + - interrupts + - clocks + - clock-names + - power-domains + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/mediatek,mt8365-clk.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/phy/phy.h> + #include <dt-bindings/power/mediatek,mt8365-power.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + csi@15040000 { + compatible = "mediatek,mt8365-seninf"; + reg = <0 0x15040000 0 0x6000>; + interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_LOW>; + clocks = <&camsys CLK_CAM_SENIF>, + <&topckgen CLK_TOP_SENIF_SEL>; + clock-names = "camsys", "top_mux"; + + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; + + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>; + phy-names = "csi0", "csi1"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + seninf_in1: endpoint { + clock-lanes = <2>; + data-lanes = <1 3 0 4>; + remote-endpoint = <&isp1_out>; + }; + }; + + port@1 { + reg = <1>; + }; + + port@2 { + reg = <2>; + }; + + port@3 { + reg = <3>; + }; + + port@4 { + reg = <4>; + seninf_camsv1_endpoint: endpoint { + remote-endpoint = <&camsv1_endpoint>; + }; + }; + + port@5 { + reg = <5>; + seninf_camsv2_endpoint: endpoint { + remote-endpoint = <&camsv2_endpoint>; + }; + }; + + port@6 { + reg = <6>; + }; + + port@7 { + reg = <7>; + }; + + port@8 { + reg = <8>; + }; + + port@9 { + reg = <9>; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index d6c90161c7bf..6bd7df1c3e08 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14158,6 +14158,13 @@ M: Sean Wang <sean.wang@mediatek.com> S: Maintained F: drivers/char/hw_random/mtk-rng.c +MEDIATEK ISP3.0 DRIVER +M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> +M: Julien Stephan <jstephan@baylibre.com> +M: Andy Hsieh <andy.hsieh@mediatek.com> +S: Supported +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml + MEDIATEK SMI DRIVER M: Yong Wu <yong.wu@mediatek.com> L: linux-mediatek@lists.infradead.org (moderated for non-subscribers)