| Message ID | 20240731-imx335-gpio-v3-1-443bfa6ce864@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: imx335: Fix reset-gpio handling | expand |
On 31/07/2024 09:02, Umang Jain wrote: > It's easy to get the polarity of GPIOs in the device tree wrong, as > shown by a recently fixed bug in the imx335 driver. To lower the chance > of future mistakes, especially in new bindings that would take the > imx335 binding as a starting point, add the reset-gpios property to the > DT example. This showcases the correct polarity of the XCLR signal for > Sony sensors in the most common case of the signal not being inverted on > the board. > Just one sentence like - make the example complete by adding reset-gpios with proper polarity - would be enough. Concise, yet still informative, commit msgs are preferred, usually. This device is not different than 1000 others which use GPIOs and for every device you must use proper polarity. Commit msg suggests that here we should explain something more. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml index 106c36ee966d..77bf3a4ee89d 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml @@ -75,6 +75,8 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> + i2c { #address-cells = <1>; #size-cells = <0>; @@ -92,6 +94,8 @@ examples: ovdd-supply = <&camera_vddo_1v8>; dvdd-supply = <&camera_vddd_1v2>; + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; + port { imx335: endpoint { remote-endpoint = <&cam>;
It's easy to get the polarity of GPIOs in the device tree wrong, as shown by a recently fixed bug in the imx335 driver. To lower the chance of future mistakes, especially in new bindings that would take the imx335 binding as a starting point, add the reset-gpios property to the DT example. This showcases the correct polarity of the XCLR signal for Sony sensors in the most common case of the signal not being inverted on the board. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ++++ 1 file changed, 4 insertions(+)