diff mbox series

[v4,1/2] ARM: dts: aspeed: Add properties of scu and gfx for video

Message ID 20240814005421.3362441-2-jammy_huang@aspeedtech.com (mailing list archive)
State New
Headers show
Series media: aspeed: Allow to capture from SoC display (GFX) | expand

Commit Message

Jammy Huang Aug. 14, 2024, 12:54 a.m. UTC
To have video support capture from SoC display(GFX), these properties
are added to allow video to control related registers.

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
 arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Krzysztof Kozlowski Aug. 14, 2024, 6:07 a.m. UTC | #1
On 14/08/2024 02:54, Jammy Huang wrote:
> To have video support capture from SoC display(GFX), these properties
> are added to allow video to control related registers.
> 
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

NAK, you still keep adding undocumented properties. I commented already
that you did not document the bindings for new properties. I also said
what you need to do, so why doing something entirely else?

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
index 7fb421153596..9f122717dfe3 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
@@ -451,6 +451,8 @@  video: video@1e700000 {
 					 <&syscon ASPEED_CLK_GATE_ECLK>;
 				clock-names = "vclk", "eclk";
 				interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+				aspeed,scu = <&syscon>;
+				aspeed,gfx = <&gfx>;
 				status = "disabled";
 			};