| Message ID | 20240827071122.26706-1-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: atomisp: Remove unused declartions | expand |
Subject: [PATCH] media: atomisp: Remove unused declartions Hi, Zekun > v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3 > ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain > the declarations untouched in the header files. So, let's remove these > unused declartions. > You just remove one declartion. Or: declartions => declartion. these => this. Best Regards, Changhuang
Hi, Zekun > v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3 > ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain > the declarations untouched in the header files. So, let's remove these > unused declartions. > You just remove one declartion. Or: declartions => declartion. these => this. Best Regards, Changhuang
Hi, Changhuang, Thanks for your review, I will send v2 to fix this. Best Regards, Zekun 在 2024/8/29 20:58, Changhuang Liang 写道: > Hi, Zekun > >> v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3 >> ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain >> the declarations untouched in the header files. So, let's remove these >> unused declartions. >> > > You just remove one declartion. > Or: > declartions => declartion. > these => this. > > Best Regards, > Changhuang >
Hi, Zekun > > Hi, Zekun > > > >> v4l2_get_acpi_sensor_info() has been removed since commit > >> d80be6a10cd3 > >> ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain > >> the declarations untouched in the header files. So, let's remove > >> these unused declartions. > >> Also header files => header file > > > > You just remove one declartion. > > Or: > > declartions => declartion. > > these => this. > > Best Regards, Changhuang
diff --git a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h index fdeb247036b0..ca31eea41f39 100644 --- a/drivers/staging/media/atomisp/include/linux/atomisp_platform.h +++ b/drivers/staging/media/atomisp/include/linux/atomisp_platform.h @@ -175,8 +175,6 @@ int atomisp_register_sensor_no_gmin(struct v4l2_subdev *subdev, u32 lanes, enum atomisp_bayer_order bayer_order); void atomisp_unregister_subdev(struct v4l2_subdev *subdev); -int v4l2_get_acpi_sensor_info(struct device *dev, char **module_id_str); - /* API from old platform_camera.h, new CPUID implementation */ #define __IS_SOC(x) (boot_cpu_data.x86_vfm == x) #define __IS_SOCS(x, y) (boot_cpu_data.x86_vfm == x || boot_cpu_data.x86_vfm == y)
v4l2_get_acpi_sensor_info() has been removed since commit d80be6a10cd3 ("media: atomisp: Drop v4l2_get_acpi_sensor_info() function"), remain the declarations untouched in the header files. So, let's remove these unused declartions. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 2 -- 1 file changed, 2 deletions(-)