| Message ID | 20240829125203.539977-3-liaochen4@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: mt9v111: workaround | expand |
Hi Liao Chen, > -----Original Message----- > From: Liao Chen <liaochen4@huawei.com> > Sent: Thursday, August 29, 2024 1:52 PM > Subject: [PATCH -next 2/2] media: i2c: mt9v111: Drop redundant comma > > Drop the redundant comma from mt9v111_of_match array to make the code clean. LGTM. Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Actually, Removing the trailing comma in the terminator entry for the ID table making code robust against (theoretical) misrebases or other similar things where the new entry goes _after_ the termination without the compiler noticing." > > Signed-off-by: Liao Chen <liaochen4@huawei.com> > --- > drivers/media/i2c/mt9v111.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index > b6a2623798c5..723fe138e7bc 100644 > --- a/drivers/media/i2c/mt9v111.c > +++ b/drivers/media/i2c/mt9v111.c > @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client) > > static const struct of_device_id mt9v111_of_match[] = { > { .compatible = "aptina,mt9v111", }, > - { /* sentinel */ }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, mt9v111_of_match); > > -- > 2.34.1
Hi Liao, Thank you for the patch. On Thu, Aug 29, 2024 at 12:52:03PM +0000, Liao Chen wrote: > Drop the redundant comma from mt9v111_of_match array to make the code > clean. > > Signed-off-by: Liao Chen <liaochen4@huawei.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/mt9v111.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c > index b6a2623798c5..723fe138e7bc 100644 > --- a/drivers/media/i2c/mt9v111.c > +++ b/drivers/media/i2c/mt9v111.c > @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client) > > static const struct of_device_id mt9v111_of_match[] = { > { .compatible = "aptina,mt9v111", }, > - { /* sentinel */ }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, mt9v111_of_match); >
diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index b6a2623798c5..723fe138e7bc 100644 --- a/drivers/media/i2c/mt9v111.c +++ b/drivers/media/i2c/mt9v111.c @@ -1263,7 +1263,7 @@ static void mt9v111_remove(struct i2c_client *client) static const struct of_device_id mt9v111_of_match[] = { { .compatible = "aptina,mt9v111", }, - { /* sentinel */ }, + { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, mt9v111_of_match);
Drop the redundant comma from mt9v111_of_match array to make the code clean. Signed-off-by: Liao Chen <liaochen4@huawei.com> --- drivers/media/i2c/mt9v111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)