From patchwork Mon Sep 2 21:54:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= X-Patchwork-Id: 13787710 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202F5187861; Mon, 2 Sep 2024 21:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725314032; cv=none; b=r0GHIuZPImSKvzAfY/c4kwmM1ZQYCFDfelk1K1BIZtOZjPhalSgk8zh+w0FitAVD/kp2ZvGNXFV38OabNGuZ0w555I3ckboxD+LMpO6icCNCFGwpVAao/mnERFmyyIaSW102iFoVPcjF/MDT7uRFUwujMfHr1YPhSJ8t/qtVdZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725314032; c=relaxed/simple; bh=9y1+rob707fVscoaOVH3GGqvvVNzLu3ec+SynkWUoeA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ifa0op7NjT0huokH+0meC/l1Ju+6e1NgfbcBWLUBcehT6dlsIFN2eAjSWVTgLSe9TQGjF1wk+89HIzaELDO/eaJquqSUMEMqDQtntkAM51yaltAebtN4CU+S9zhTjmFoUbX354kMaMZA4f1Sw4fot4N4tICglZKl/6/v+zTg82c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QCIwphNq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QCIwphNq" Received: by smtp.kernel.org (Postfix) with ESMTPS id 97772C4CED5; Mon, 2 Sep 2024 21:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725314031; bh=9y1+rob707fVscoaOVH3GGqvvVNzLu3ec+SynkWUoeA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=QCIwphNqJbnUvjqpuYqvpyfLiXVq92vU6pSPs3/GB0kaci7abxd/hOr4ojCI5IjJM M1CVocLumKnCTsPpLXk74KWFsagQFn4RRHzpUMQDN37op3/XbPDE6O5YsSByszAAq5 Is/bwvPcnPjIhqX28U7nyo611dRbWHJVpWkgc0K7wHlYJVzlsj6bj6fnGqoI/W6lcr gvEWXfHrAGX/8WuMRRplTU1DJiR5XkTF96jHWze1WCrZRcpBlM3n8wyK/OCYN0Hxqh 7Ez4tiIHyzlNsw0ccFqd1Cxjkt3YglEVNqldjxgi0NkLM7GcBE7tWZ96qEBIZYO2F5 k30A+3iHB38gA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8CECD13CF; Mon, 2 Sep 2024 21:53:51 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Mon, 02 Sep 2024 23:54:33 +0200 Subject: [PATCH 06/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240902-imx214-v1-6-c96cba989315@apitzsch.eu> References: <20240902-imx214-v1-0-c96cba989315@apitzsch.eu> In-Reply-To: <20240902-imx214-v1-0-c96cba989315@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Andr?= =?utf-8?q?=C3=A9_Apitzsch?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1725314079; l=1091; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=HFABq6UojHq6xPex+89Y3/RAN3+y1TJKl8g/kxaNZSk=; b=Msd9f5rbQTW34HekOlyEb7HG4TUIjNHAQI4g0krKKyieCr99yxUQrU+QdJfmKe8rYt/uoD3Uq OKQSqLTLQPgC6t/L+iJNIfGQOHgvV9i2VGnnkabvZP+ooEPIcVSYCqP X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Signed-off-by: André Apitzsch Acked-by: Ricardo Ribalda --- drivers/media/i2c/imx214.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 91664e188fd0..4507e12dd4cd 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -254,7 +254,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = { { CCI_REG8(0x3011), 0x00 }, { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, { IMX214_REG_SHORT_EXPOSURE, 500 }, { IMX214_REG_ANALOG_GAIN, 0 }, @@ -328,7 +327,6 @@ static const struct cci_reg_sequence mode_1920x1080[] = { { CCI_REG8(0x3011), 0x00 }, { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, { IMX214_REG_SHORT_EXPOSURE, 500 }, { IMX214_REG_ANALOG_GAIN, 0 },