diff mbox series

[1/3] media: atomisp: csi2-bridge: Add DMI quirk for t4ka3 on Xiaomi Mipad2

Message ID 20240902095229.59059-1-hdegoede@redhat.com (mailing list archive)
State New
Headers show
Series [1/3] media: atomisp: csi2-bridge: Add DMI quirk for t4ka3 on Xiaomi Mipad2 | expand

Commit Message

Hans de Goede Sept. 2, 2024, 9:52 a.m. UTC
The t4ka3 sensor on the Xiaomi Mipad2 is used as a back facing sensor,
it uses 4 CSI lanes, but the _DSM has CsiLanes set to 2. Extend
the existing Xiaomi Mipad2 DMI quirk to override the wrong _DSM setting.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Hans de Goede Sept. 2, 2024, 10:37 a.m. UTC | #1
Hi,

On 9/2/24 11:52 AM, Hans de Goede wrote:
> The t4ka3 sensor on the Xiaomi Mipad2 is used as a back facing sensor,
> it uses 4 CSI lanes, but the _DSM has CsiLanes set to 2. Extend
> the existing Xiaomi Mipad2 DMI quirk to override the wrong _DSM setting.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

I have merged these 3 patches in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
now.

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans


> ---
>  drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> index 31c9e05a1435..b2a3243ae2d4 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
> @@ -109,6 +109,8 @@ static struct gmin_cfg_var lenovo_ideapad_miix_310_vars[] = {
>  static struct gmin_cfg_var xiaomi_mipad2_vars[] = {
>  	/* _DSM contains the wrong CsiPort for the front facing OV5693 sensor */
>  	{ "INT33BE:00", "CsiPort", "0" },
> +	/* _DSM contains the wrong CsiLanes for the back facing T4KA3 sensor */
> +	{ "XMCC0003:00", "CsiLanes", "4" },
>  	{}
>  };
>
Andy Shevchenko Sept. 2, 2024, 11:06 a.m. UTC | #2
On Mon, Sep 02, 2024 at 11:52:27AM +0200, Hans de Goede wrote:
> The t4ka3 sensor on the Xiaomi Mipad2 is used as a back facing sensor,
> it uses 4 CSI lanes, but the _DSM has CsiLanes set to 2. Extend
> the existing Xiaomi Mipad2 DMI quirk to override the wrong _DSM setting.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
index 31c9e05a1435..b2a3243ae2d4 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c
@@ -109,6 +109,8 @@  static struct gmin_cfg_var lenovo_ideapad_miix_310_vars[] = {
 static struct gmin_cfg_var xiaomi_mipad2_vars[] = {
 	/* _DSM contains the wrong CsiPort for the front facing OV5693 sensor */
 	{ "INT33BE:00", "CsiPort", "0" },
+	/* _DSM contains the wrong CsiLanes for the back facing T4KA3 sensor */
+	{ "XMCC0003:00", "CsiLanes", "4" },
 	{}
 };