diff mbox series

[2/3] media: atomisp: Drop dev_dbg() calls from hmm_[alloc|free]()

Message ID 20240902095229.59059-2-hdegoede@redhat.com (mailing list archive)
State New
Headers show
Series [1/3] media: atomisp: csi2-bridge: Add DMI quirk for t4ka3 on Xiaomi Mipad2 | expand

Commit Message

Hans de Goede Sept. 2, 2024, 9:52 a.m. UTC
Debug logging every alloc + free just polutes the debug logs without
adding much value, remove the alloc + free dev_dbg() calls.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/hmm/hmm.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Andy Shevchenko Sept. 2, 2024, 11:06 a.m. UTC | #1
On Mon, Sep 02, 2024 at 11:52:28AM +0200, Hans de Goede wrote:
> Debug logging every alloc + free just polutes the debug logs without
> adding much value, remove the alloc + free dev_dbg() calls.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

Agree on the point and ideally we should remove/replace most of (all?) the
messages by trace points.
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c
index 3e2899ad8517..e8c5d728fd55 100644
--- a/drivers/staging/media/atomisp/pci/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c
@@ -204,9 +204,6 @@  static ia_css_ptr __hmm_alloc(size_t bytes, enum hmm_bo_type type,
 		goto bind_err;
 	}
 
-	dev_dbg(atomisp_dev, "pages: 0x%08x (%zu bytes), type: %d, vmalloc %p\n",
-		bo->start, bytes, type, vmalloc_noprof);
-
 	return bo->start;
 
 bind_err:
@@ -231,8 +228,6 @@  void hmm_free(ia_css_ptr virt)
 {
 	struct hmm_buffer_object *bo;
 
-	dev_dbg(atomisp_dev, "%s: free 0x%08x\n", __func__, virt);
-
 	if (WARN_ON(virt == mmgr_EXCEPTION))
 		return;