diff mbox series

[v4,3/3] media: i2c: imx290: Check for availability in probe()

Message ID 20240903-imx290-avail-v4-3-e4a6c0837f0b@skidata.com (mailing list archive)
State New
Headers show
Series media: i2c: imx290: check for availability in probe() | expand

Commit Message

Benjamin Bara Sept. 3, 2024, 2:54 p.m. UTC 
From: Benjamin Bara <benjamin.bara@skidata.com>

Currently, the V4L2 subdevice is also created when the device is not
available/connected. From userspace perspective, there is no visible
difference between a working and not-working subdevice (except when
trying it out).

This commit adds a simple preparation step, which includes an
availability check, before the subdev is initialized.

Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
---
Changes since v3:
- thanks to the feedback of Dave, I decided to switch to a write instead
  of a read for the availability check.
- instead of only writing the STANDBY register, re-use stop_streaming() to
  ensure a proper state.
- reword commit message.
---
 drivers/media/i2c/imx290.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff mbox series

Patch

diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 47cfb6a9e9b5..49a5bf9c17da 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -1589,6 +1589,16 @@  static int imx290_probe(struct i2c_client *client)
 	pm_runtime_set_autosuspend_delay(dev, 1000);
 	pm_runtime_use_autosuspend(dev);
 
+	/*
+	 * Make sure the sensor is available, in STANDBY and not streaming
+	 * before the V4L2 subdev is initialized.
+	 */
+	ret = imx290_stop_streaming(imx290);
+	if (ret) {
+		ret = dev_err_probe(dev, ret, "Could not initialize device\n");
+		goto err_pm;
+	}
+
 	/* Initialize the V4L2 subdev. */
 	ret = imx290_subdev_init(imx290);
 	if (ret)