[v2,5/9] dt-bindings: media: Add amlogic,c3-isp.yaml

Commit Message

Keke Li via B4 Relay Sept. 9, 2024, 7:24 a.m. UTC

From: Keke Li <[e-mail]>

c3-isp is used to process raw image.

Signed-off-by: Keke Li <[e-mail]>
---
 .../devicetree/bindings/media/amlogic,c3-isp.yaml  | 98 ++++++++++++++++++++++
 1 file changed, 98 insertions(+)

Comments

Krzysztof Kozlowski Sept. 9, 2024, 10:15 a.m. UTC | #1

On Mon, Sep 09, 2024 at 03:24:15PM +0800, Keke Li wrote:
> c3-isp is used to process raw image.
> 
> Signed-off-by: Keke Li <[e-mail]>
> ---
>  .../devicetree/bindings/media/amlogic,c3-isp.yaml  | 98 ++++++++++++++++++++++
>  1 file changed, 98 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
> new file mode 100644
> index 000000000000..dfa439cdc380
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/amlogic,c3-isp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic C3 Image Signal Processing Unit
> +
> +maintainers:
> +  - Keke Li <[e-mail]>
> +
> +description:
> +  Amlogic ISP is the RAW image processing module
> +  and supports three channels image output.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - amlogic,c3-isp
> +
> +  reg:
> +    maxItems: 1
> +
> +  reg-names:
> +    items:
> +      - const: isp
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2
> +
> +  clock-names:
> +    items:
> +      - const: vapb
> +      - const: isp0
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +

Only one port? Then use "port" instead of "ports".

Best regards,
Krzysztof

Keke Li Sept. 10, 2024, 2:22 a.m. UTC | #2

Hi Krzysztof,

         Thanks for your reply.

On 2024/9/9 18:15, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Mon, Sep 09, 2024 at 03:24:15PM +0800, Keke Li wrote:
>> c3-isp is used to process raw image.
>>
>> Signed-off-by: Keke Li <[e-mail]>
>> ---
>>   .../devicetree/bindings/media/amlogic,c3-isp.yaml  | 98 ++++++++++++++++++++++
>>   1 file changed, 98 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> new file mode 100644
>> index 000000000000..dfa439cdc380
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
>> @@ -0,0 +1,98 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/amlogic,c3-isp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 Image Signal Processing Unit
>> +
>> +maintainers:
>> +  - Keke Li <[e-mail]>
>> +
>> +description:
>> +  Amlogic ISP is the RAW image processing module
>> +  and supports three channels image output.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - amlogic,c3-isp
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  reg-names:
>> +    items:
>> +      - const: isp
>> +
>> +  power-domains:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 2
>> +
>> +  clock-names:
>> +    items:
>> +      - const: vapb
>> +      - const: isp0
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +
> Only one port? Then use "port" instead of "ports".

Yes, it has only one port.

I will use "port" instead of "ports".

Thanks again.

>
> Best regards,
> Krzysztof
>

Patch

diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
new file mode 100644
index 000000000000..dfa439cdc380
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/amlogic,c3-isp.yaml
@@ -0,0 +1,98 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/amlogic,c3-isp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic C3 Image Signal Processing Unit
+
+maintainers:
+  - Keke Li <[e-mail]>
+
+description:
+  Amlogic ISP is the RAW image processing module
+  and supports three channels image output.
+
+properties:
+  compatible:
+    enum:
+      - amlogic,c3-isp
+
+  reg:
+    maxItems: 1
+
+  reg-names:
+    items:
+      - const: isp
+
+  power-domains:
+    maxItems: 1
+
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: vapb
+      - const: isp0
+
+  interrupts:
+    maxItems: 1
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+
+    properties:
+      port@0:
+        $ref: /schemas/graph.yaml#/properties/port
+        description: input port node.
+
+    required:
+      - port@0
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - power-domains
+  - clocks
+  - clock-names
+  - interrupts
+  - ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>
+    #include <dt-bindings/power/amlogic,c3-pwrc.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        isp: isp@ff000000 {
+            compatible = "amlogic,c3-isp";
+            reg = <0x0 0xff000000 0x0 0xf000>;
+            reg-names = "isp";
+            power-domains = <&pwrc PWRC_C3_ISP_TOP_ID>;
+            clocks = <&clkc_periphs CLKID_VAPB>,
+                     <&clkc_periphs CLKID_ISP0>;
+            clock-names = "vapb", "isp0";
+            interrupts = <GIC_SPI 145 IRQ_TYPE_EDGE_RISING>;
+
+            ports {
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                port@0 {
+                    reg = <0>;
+                    c3_isp_in: endpoint {
+                        remote-endpoint = <&c3_adap_out>;
+                    };
+                };
+            };
+        };
+    };
+...