diff mbox series

[v2,2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string

Message ID 20241012084732.1036652-3-guoniu.zhou@oss.nxp.com (mailing list archive)
State New
Headers show
Series media: nxp: imx8-isi: Add i.MX8ULP support | expand

Commit Message

G.N. Zhou (OSS) Oct. 12, 2024, 8:47 a.m. UTC 
From: "Guoniu.zhou" <guoniu.zhou@nxp.com>

Add the compatible string support for i.MX8ULP ISI.

Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
---
 Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Laurent Pinchart Oct. 13, 2024, 4:24 p.m. UTC | #1 
Hi Guoniu,

Thank you for the patch.

On Sat, Oct 12, 2024 at 04:47:35PM +0800, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> 
> Add the compatible string support for i.MX8ULP ISI.
> 
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> index 4d5348d456a1..f43b91984f01 100644
> --- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
> @@ -21,6 +21,7 @@ properties:
>      enum:
>        - fsl,imx8mn-isi
>        - fsl,imx8mp-isi
> +      - fsl,imx8ulp-isi
>        - fsl,imx93-isi
>  
>    reg:
> @@ -75,6 +76,7 @@ allOf:
>            contains:
>              enum:
>                - fsl,imx8mn-isi
> +              - fsl,imx8ulp-isi
>                - fsl,imx93-isi
>      then:
>        properties:
Krzysztof Kozlowski Oct. 14, 2024, 7:30 a.m. UTC | #2 
On Sat, Oct 12, 2024 at 04:47:35PM +0800, guoniu.zhou@oss.nxp.com wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>

Are you sure your name includes the dot? Or you just use login as full
name?

> 
> Add the compatible string support for i.MX8ULP ISI.
> 
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> ---
>  Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Best regards,
Krzysztof
G.N. Zhou (OSS) Oct. 14, 2024, 8:27 a.m. UTC | #3 
Hi Krzsztof,

Thanks for your replying.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, October 14, 2024 3:31 PM
> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
> Cc: linux-media@vger.kernel.org; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; jacopo@jmondi.org;
> mchehab@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.d; festevam@gmail.com; devicetree@vger.kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI
> compatible string
> 
> On Sat, Oct 12, 2024 at 04:47:35PM +0800, guoniu.zhou@oss.nxp.com wrote:
> > From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> 
> Are you sure your name includes the dot? Or you just use login as full name?

Do you mean the dot in "Guoniu.zhou". If yes, it's not a part of my but to distinguish family name and given name.

> 
> >
> > Add the compatible string support for i.MX8ULP ISI.
> >
> > Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Oct. 14, 2024, 8:49 a.m. UTC | #4 
On 14/10/2024 10:27, G.N. Zhou (OSS) wrote:
> Hi Krzsztof,
> 
> Thanks for your replying.
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, October 14, 2024 3:31 PM
>> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
>> Cc: linux-media@vger.kernel.org; Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com>; jacopo@jmondi.org;
>> mchehab@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
>> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
>> kernel@pengutronix.d; festevam@gmail.com; devicetree@vger.kernel.org;
>> imx@lists.linux.dev; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI
>> compatible string
>>
>> On Sat, Oct 12, 2024 at 04:47:35PM +0800, guoniu.zhou@oss.nxp.com wrote:
>>> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
>>
>> Are you sure your name includes the dot? Or you just use login as full name?
> 
> Do you mean the dot in "Guoniu.zhou". If yes, it's not a part of my but to distinguish family name and given name.

I am not familiar with rules of transliteration/translation of your
family name into English, however I think usually a space is used to
distinguish the family and given name, e.g. "Guoniu Zhou"




Best regards,
Krzysztof
G.N. Zhou (OSS) Oct. 14, 2024, 9:06 a.m. UTC | #5 
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, October 14, 2024 4:50 PM
> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
> Cc: linux-media@vger.kernel.org; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; jacopo@jmondi.org;
> mchehab@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.d; festevam@gmail.com; devicetree@vger.kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI
> compatible string
> 
> On 14/10/2024 10:27, G.N. Zhou (OSS) wrote:
> > Hi Krzsztof,
> >
> > Thanks for your replying.
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: Monday, October 14, 2024 3:31 PM
> >> To: G.N. Zhou (OSS) <guoniu.zhou@oss.nxp.com>
> >> Cc: linux-media@vger.kernel.org; Laurent Pinchart
> >> <laurent.pinchart@ideasonboard.com>; jacopo@jmondi.org;
> >> mchehab@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> >> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> >> kernel@pengutronix.d; festevam@gmail.com; devicetree@vger.kernel.org;
> >> imx@lists.linux.dev; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v2 2/2] dt-bindings: media: nxp,imx8-isi: Add
> >> i.MX8ULP ISI compatible string
> >>
> >> On Sat, Oct 12, 2024 at 04:47:35PM +0800, guoniu.zhou@oss.nxp.com
> wrote:
> >>> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
> >>
> >> Are you sure your name includes the dot? Or you just use login as full name?
> >
> > Do you mean the dot in "Guoniu.zhou". If yes, it's not a part of my but to
> distinguish family name and given name.
> 
> I am not familiar with rules of transliteration/translation of your family name
> into English, however I think usually a space is used to distinguish the family
> and given name, e.g. "Guoniu Zhou"

Thanks for your suggestion and I totally agreed with you. Let me change it in any other version.

> 
> 
> 
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
index 4d5348d456a1..f43b91984f01 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml
@@ -21,6 +21,7 @@  properties:
     enum:
       - fsl,imx8mn-isi
       - fsl,imx8mp-isi
+      - fsl,imx8ulp-isi
       - fsl,imx93-isi
 
   reg:
@@ -75,6 +76,7 @@  allOf:
           contains:
             enum:
               - fsl,imx8mn-isi
+              - fsl,imx8ulp-isi
               - fsl,imx93-isi
     then:
       properties: