From patchwork Tue Dec 17 21:39:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= X-Patchwork-Id: 13912549 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAEC21FA174; Tue, 17 Dec 2024 21:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734471564; cv=none; b=NjFGB02L+Ft5bDx8nqIUOSsuxC6gESoaEuaGVtYd/LV3b4C31aGTB0EICN8BjT1EV0OrdZ7lcTwGBTdz9hJyQBWjjxF0L94vWjAj3qYkywlVzunn4tzWPkDzEGyA+/DqDDloDTzOCUO5mxLWjgSyAq9cUav9txJCTT8hhKZ57Uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734471564; c=relaxed/simple; bh=g18RPaeqHc7WCL7LO4MEZKXFn9sFkhIKOlaP207TmTE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oCDE8ee/l5hC2y7tiino3gXgHCeAg1GCv92eDSkgehj6Xly10XsoSf8+emGI9kl8q0ViXM2/bpVSyqyTt+9C5odNWlsDaepa50TpxRDHUG8F5ko4cMaocyoyyRkKcpG/KNVja6KBdd6HSnsfROjomkUKWlM6MxOutIX2G8sypWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oU1Fx109; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oU1Fx109" Received: by smtp.kernel.org (Postfix) with ESMTPS id 62B61C4CEE6; Tue, 17 Dec 2024 21:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734471563; bh=g18RPaeqHc7WCL7LO4MEZKXFn9sFkhIKOlaP207TmTE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=oU1Fx109R5Uj0zVvTlpiU7BsD2uzMG/jv2gmx8qodQPGc7znsAPwagR6GTyfT4fzG lp27UF71kl5icQrXiXJtEtQ51RSSzb+Sxd2D694KUczv6KkzRGKkYhtmYqr/ypdikN VwGCk7nUyGtshNRou6ZLc3GxbkvLJjN2va6v2mTSVbbEcdGQ4J8JqG+Dfxv4RH0vtk I4G33JkLjl8rHO/VV9+v7Tu74ppWRVfHnTKMQL/uEZrZbMNByhSujjQyY1AFOYaR0u d6QEBGiH0l+c2HXnYemCYBvvw7AzSPPY2YfYG3qJODmcBMleOwwxamEOywCvZp84yH AtEknYFg3+w5w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5623EE7717F; Tue, 17 Dec 2024 21:39:23 +0000 (UTC) From: =?utf-8?q?Andr=C3=A9_Apitzsch_via_B4_Relay?= Date: Tue, 17 Dec 2024 22:39:17 +0100 Subject: [PATCH v5 05/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241217-imx214-v5-5-387f52adef4d@apitzsch.eu> References: <20241217-imx214-v5-0-387f52adef4d@apitzsch.eu> In-Reply-To: <20241217-imx214-v5-0-387f52adef4d@apitzsch.eu> To: Ricardo Ribalda , Sakari Ailus , Mauro Carvalho Chehab Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Stevenson , Vincent Knecht , =?utf-8?q?Andr=C3=A9_Apitzsch?= , Ricardo Ribalda X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1734471561; l=1197; i=git@apitzsch.eu; s=20240325; h=from:subject:message-id; bh=xnGMMDNqIaP7nP/gicDjO9ZlDo7V8r+Yz/cn6oUDZ/k=; b=1Dege11Ww+izmOgPbmRGw1CBPpIt+OsghgnZcNl8mZNSePvTNAMnetQfwi9uRr9cSpRGqscsR b9WMcSZ/Ty3AwrARiHxxzQWBkzSv2VYM12IZw1oHqGT1BbovwmcsEDS X-Developer-Key: i=git@apitzsch.eu; a=ed25519; pk=wxovcZRfvNYBMcTw4QFFtNEP4qv39gnBfnfyImXZxiU= X-Endpoint-Received: by B4 Relay for git@apitzsch.eu/20240325 with auth_id=142 X-Original-From: =?utf-8?q?Andr=C3=A9_Apitzsch?= Reply-To: git@apitzsch.eu From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index d40373aa7ac496b78bfdb90f1cc6e68b0e21faaa..4e9a8e0e2c5f2ac3fd72be06906979dcd3aaa2a4 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -252,7 +252,6 @@ static const struct cci_reg_sequence mode_4096x2304[] = { { CCI_REG8(0x3011), 0x00 }, { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, { IMX214_REG_SHORT_EXPOSURE, 500 }, { IMX214_REG_ANALOG_GAIN, 0 }, @@ -326,7 +325,6 @@ static const struct cci_reg_sequence mode_1920x1080[] = { { CCI_REG8(0x3011), 0x00 }, { IMX214_REG_STATS_OUT_EN, IMX214_STATS_OUT_ON }, - { IMX214_REG_EXPOSURE, IMX214_EXPOSURE_DEFAULT }, { IMX214_REG_SHORT_EXPOSURE, 500 }, { IMX214_REG_ANALOG_GAIN, 0 },