| Message ID | 20241227-c3isp-v5-1-c7124e762ff6@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Amlogic C3 ISP support | expand |
On 27/12/2024 08:09, Keke Li via B4 Relay wrote: > From: Keke Li <keke.li@amlogic.com> > > c3-mipi-csi2 is used to receive mipi data from image sensor. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Keke Li <keke.li@amlogic.com> > --- > .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ > MAINTAINERS | 6 + > 2 files changed, 137 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > new file mode 100644 > index 000000000000..76b68d1e7316 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml > @@ -0,0 +1,131 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic C3 MIPI CSI-2 receiver > + > +maintainers: > + - Keke Li <keke.li@amlogic.com> > + > +description: > + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. > + It receives the MIPI data from the image sensor and sends MIPI data > + to MIPI adapter. > + > +properties: > + compatible: > + enum: > + - amlogic,c3-mipi-csi2 > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: aphy > + - const: dphy > + - const: host > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: vapb > + - const: phy0 > + > + assigned-clocks: true > + > + assigned-clock-rates: true NAK Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak whatever crap past reviewers. Drop all new properties and drop my review tag. Best regards, Krzysztof
Hi Krzysztof Thanks for your reply On 2024/12/27 15:19, Krzysztof Kozlowski wrote: > [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > [ EXTERNAL EMAIL ] > > On 27/12/2024 08:09, Keke Li via B4 Relay wrote: >> From: Keke Li <keke.li@amlogic.com> >> >> c3-mipi-csi2 is used to receive mipi data from image sensor. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Keke Li <keke.li@amlogic.com> >> --- >> .../bindings/media/amlogic,c3-mipi-csi2.yaml | 131 +++++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 137 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml >> new file mode 100644 >> index 000000000000..76b68d1e7316 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml >> @@ -0,0 +1,131 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic C3 MIPI CSI-2 receiver >> + >> +maintainers: >> + - Keke Li <keke.li@amlogic.com> >> + >> +description: >> + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. >> + It receives the MIPI data from the image sensor and sends MIPI data >> + to MIPI adapter. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,c3-mipi-csi2 >> + >> + reg: >> + maxItems: 3 >> + >> + reg-names: >> + items: >> + - const: aphy >> + - const: dphy >> + - const: host >> + >> + power-domains: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: vapb >> + - const: phy0 >> + >> + assigned-clocks: true >> + >> + assigned-clock-rates: true > NAK > > Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak > whatever crap past reviewers. > > Drop all new properties and drop my review tag. OK, will drop all new properties and drop your review tag. Thanks > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml new file mode 100644 index 000000000000..76b68d1e7316 --- /dev/null +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml @@ -0,0 +1,131 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic C3 MIPI CSI-2 receiver + +maintainers: + - Keke Li <keke.li@amlogic.com> + +description: + MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller. + It receives the MIPI data from the image sensor and sends MIPI data + to MIPI adapter. + +properties: + compatible: + enum: + - amlogic,c3-mipi-csi2 + + reg: + maxItems: 3 + + reg-names: + items: + - const: aphy + - const: dphy + - const: host + + power-domains: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: vapb + - const: phy0 + + assigned-clocks: true + + assigned-clock-rates: true + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: input port node, connected to sensor. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + required: + - data-lanes + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: output port node + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - reg-names + - power-domains + - clocks + - clock-names + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h> + #include <dt-bindings/power/amlogic,c3-pwrc.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + csi: csi@ff018000 { + compatible = "amlogic,c3-mipi-csi2"; + reg = <0x0 0xff018000 0x0 0x400>, + <0x0 0xff019000 0x0 0x300>, + <0x0 0xff01a000 0x0 0x100>; + reg-names = "aphy", "dphy", "host"; + power-domains = <&pwrc PWRC_C3_MIPI_ISP_WRAP_ID>; + clocks = <&clkc_periphs CLKID_VAPB>, + <&clkc_periphs CLKID_CSI_PHY0>; + clock-names = "vapb", "phy0"; + assigned-clocks = <&clkc_periphs CLKID_VAPB>, + <&clkc_periphs CLKID_CSI_PHY0>; + assigned-clock-rates = <0>, <200000000>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + c3_mipi_csi_in: endpoint { + remote-endpoint = <&imx290_out>; + data-lanes = <1 2 3 4>; + }; + }; + + port@1 { + reg = <1>; + c3_mipi_csi_out: endpoint { + remote-endpoint = <&c3_adap_in>; + }; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index d2ab799a0659..2b06962db506 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1243,6 +1243,12 @@ F: Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml F: drivers/perf/amlogic/ F: include/soc/amlogic/ +AMLOGIC MIPI CSI2 DRIVER +M: Keke Li <keke.li@amlogic.com> +L: linux-media@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml + AMLOGIC RTC DRIVER M: Yiting Deng <yiting.deng@amlogic.com> M: Xianwei Zhao <xianwei.zhao@amlogic.com>