| Message ID | 20241227-c3isp-v5-3-c7124e762ff6@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Amlogic C3 ISP support | expand |
On 27/12/2024 08:09, Keke Li via B4 Relay wrote: > From: Keke Li <keke.li@amlogic.com> > > c3-mipi-adapter is used to organize mipi data and > send raw data to ISP module. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Keke Li <keke.li@amlogic.com> > --- > .../bindings/media/amlogic,c3-mipi-adapter.yaml | 115 +++++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 121 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml > new file mode 100644 > index 000000000000..1105fee2d7a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic C3 MIPI adapter receiver > + > +maintainers: > + - Keke Li <keke.li@amlogic.com> > + > +description: > + MIPI adapter is used to convert the MIPI CSI-2 data > + into an ISP supported data format. > + > +properties: > + compatible: > + enum: > + - amlogic,c3-mipi-adapter > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: top > + - const: fd > + - const: rd > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: vapb > + - const: isp0 > + > + assigned-clocks: true > + > + assigned-clock-rates: true NAK. Drop my review tag. You cannot keep someone's review while making significant changes. Please carefully read submitting patches before next posting. Best regards, Krzysztof
Hi Krzysztof Thanks for your reply On 2024/12/27 15:20, Krzysztof Kozlowski wrote: > [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > [ EXTERNAL EMAIL ] > > On 27/12/2024 08:09, Keke Li via B4 Relay wrote: >> From: Keke Li <keke.li@amlogic.com> >> >> c3-mipi-adapter is used to organize mipi data and >> send raw data to ISP module. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Keke Li <keke.li@amlogic.com> >> --- >> .../bindings/media/amlogic,c3-mipi-adapter.yaml | 115 +++++++++++++++++++++ >> MAINTAINERS | 6 ++ >> 2 files changed, 121 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml >> new file mode 100644 >> index 000000000000..1105fee2d7a8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml >> @@ -0,0 +1,115 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic C3 MIPI adapter receiver >> + >> +maintainers: >> + - Keke Li <keke.li@amlogic.com> >> + >> +description: >> + MIPI adapter is used to convert the MIPI CSI-2 data >> + into an ISP supported data format. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,c3-mipi-adapter >> + >> + reg: >> + maxItems: 3 >> + >> + reg-names: >> + items: >> + - const: top >> + - const: fd >> + - const: rd >> + >> + power-domains: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: vapb >> + - const: isp0 >> + >> + assigned-clocks: true >> + >> + assigned-clock-rates: true > NAK. Drop my review tag. You cannot keep someone's review while making > significant changes. Please carefully read submitting patches before > next posting. OK, I see Thanks! > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml new file mode 100644 index 000000000000..1105fee2d7a8 --- /dev/null +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml @@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic C3 MIPI adapter receiver + +maintainers: + - Keke Li <keke.li@amlogic.com> + +description: + MIPI adapter is used to convert the MIPI CSI-2 data + into an ISP supported data format. + +properties: + compatible: + enum: + - amlogic,c3-mipi-adapter + + reg: + maxItems: 3 + + reg-names: + items: + - const: top + - const: fd + - const: rd + + power-domains: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: vapb + - const: isp0 + + assigned-clocks: true + + assigned-clock-rates: true + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: input port node. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: output port node. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - reg-names + - power-domains + - clocks + - clock-names + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h> + #include <dt-bindings/power/amlogic,c3-pwrc.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + adap: adap@ff010000 { + compatible = "amlogic,c3-mipi-adapter"; + reg = <0x0 0xff010000 0x0 0x100>, + <0x0 0xff01b000 0x0 0x100>, + <0x0 0xff01d000 0x0 0x200>; + reg-names = "top", "fd", "rd"; + power-domains = <&pwrc PWRC_C3_ISP_TOP_ID>; + clocks = <&clkc_periphs CLKID_VAPB>, + <&clkc_periphs CLKID_ISP0>; + clock-names = "vapb", "isp0"; + assigned-clocks = <&clkc_periphs CLKID_VAPB>, + <&clkc_periphs CLKID_ISP0>; + assigned-clock-rates = <0>, <400000000>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + c3_adap_in: endpoint { + remote-endpoint = <&c3_mipi_csi_out>; + }; + }; + + port@1 { + reg = <1>; + c3_adap_out: endpoint { + remote-endpoint = <&c3_isp_in>; + }; + }; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 1d1416b15570..af4239f2f3fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1243,6 +1243,12 @@ F: Documentation/devicetree/bindings/perf/amlogic,g12-ddr-pmu.yaml F: drivers/perf/amlogic/ F: include/soc/amlogic/ +AMLOGIC MIPI ADAPTER DRIVER +M: Keke Li <keke.li@amlogic.com> +L: linux-media@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml + AMLOGIC MIPI CSI2 DRIVER M: Keke Li <keke.li@amlogic.com> L: linux-media@vger.kernel.org