diff mbox series

[v2] media: dt-bindings: adv7180: Document the 'interrupts' property

Message ID 20250110185026.590049-1-festevam@gmail.com (mailing list archive)
State New
Headers show
Series [v2] media: dt-bindings: adv7180: Document the 'interrupts' property | expand

Commit Message

Fabio Estevam Jan. 10, 2025, 6:50 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

The ADV7180 family of chips have an INTRQ pin that can be connected
to a SoC GPIO.

Allow the 'interrupts' property to be described to fix the following
dt-schema warning:

'interrupt-parent', 'interrupts' do not match any of the
regexes: 'pinctrl-[0-9]+'

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Detail the interrupt description.

 Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski Jan. 13, 2025, 9:15 a.m. UTC | #1
On Fri, Jan 10, 2025 at 03:50:26PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The ADV7180 family of chips have an INTRQ pin that can be connected
> to a SoC GPIO.
> 
> Allow the 'interrupts' property to be described to fix the following
> dt-schema warning:
> 
> 'interrupt-parent', 'interrupts' do not match any of the
> regexes: 'pinctrl-[0-9]+'

Please don't wrap the warning message, unless it would be really, really
long. Wrapping makes grepping difficult.

> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Detail the interrupt description.
> 
>  Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> index 4371a0ef2761..ede774dff4a8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
> @@ -49,6 +49,12 @@ properties:
>        Indicates that the output is a BT.656-4 compatible stream.
>      type: boolean
>  
> +  interrupts:
> +    description:
> +      The ADV7180 chips can generate interrupt in the INTRQ pin.

That's the same what is said in "items" with description, so no need for
above description. Longer schema for no benefits makes it less readable.

> +    items:
> +      - description: INTRQ pin interrupt.
> +

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
index 4371a0ef2761..ede774dff4a8 100644
--- a/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/adv7180.yaml
@@ -49,6 +49,12 @@  properties:
       Indicates that the output is a BT.656-4 compatible stream.
     type: boolean
 
+  interrupts:
+    description:
+      The ADV7180 chips can generate interrupt in the INTRQ pin.
+    items:
+      - description: INTRQ pin interrupt.
+
   port:
     $ref: /schemas/graph.yaml#/$defs/port-base
     unevaluatedProperties: false