diff mbox series

[v2] media: dw9719: Add of_match table

Message ID 20250208-dw9761dts-v2-1-c038f8a2fb94@apitzsch.eu (mailing list archive)
State New
Headers show
Series [v2] media: dw9719: Add of_match table | expand

Commit Message

André Apitzsch via B4 Relay Feb. 8, 2025, 11:13 a.m. UTC 
From: André Apitzsch <git@apitzsch.eu>

Add of_match table for "dongwoon,dw9719" and "dongwoon,dw9761"
compatible string. This fixes automatic driver loading when using a
device-tree, and if built as a module like major linux distributions do.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
This patch depends on https://lore.kernel.org/linux-media/20241105203658.29737-1-hdegoede@redhat.com/
---
 drivers/media/i2c/dw9719.c | 8 ++++++++
 1 file changed, 8 insertions(+)


---
base-commit: 8f6629c004b193d23612641c3607e785819e97ab
change-id: 20250206-dw9761dts-cdcc0c714b1a
prerequisite-message-id: 20241105203658.29737-1-hdegoede@redhat.com:v1
prerequisite-patch-id: b0a57666bd20b97291583c3052065dc314a37e79

Best regards,

Comments

Sakari Ailus Feb. 9, 2025, 2:20 p.m. UTC | #1 
Hi André,

On Sat, Feb 08, 2025 at 12:13:49PM +0100, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@apitzsch.eu>
> 
> Add of_match table for "dongwoon,dw9719" and "dongwoon,dw9761"
> compatible string. This fixes automatic driver loading when using a
> device-tree, and if built as a module like major linux distributions do.
> 
> Signed-off-by: André Apitzsch <git@apitzsch.eu>

How about the DT bindings?

The configuration should be documented, too. See e.g. for an example
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml .
André Apitzsch Feb. 9, 2025, 9:01 p.m. UTC | #2 
Hi,

Am Sonntag, dem 09.02.2025 um 14:20 +0000 schrieb Sakari Ailus:
> Hi André,
> 
> On Sat, Feb 08, 2025 at 12:13:49PM +0100, André Apitzsch via B4 Relay
> wrote:
> > From: André Apitzsch <git@apitzsch.eu>
> > 
> > Add of_match table for "dongwoon,dw9719" and "dongwoon,dw9761"
> > compatible string. This fixes automatic driver loading when using a
> > device-tree, and if built as a module like major linux
> > distributions do.
> > 
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> 
> How about the DT bindings?
> 
> The configuration should be documented, too. See e.g. for an example
> Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml .
> 

I was hoping, I could add it, when using the binding in a device tree.
I'll prepare a new version that also has a DT bindings patch.

Regards,
André
diff mbox series

Patch

diff --git a/drivers/media/i2c/dw9719.c b/drivers/media/i2c/dw9719.c
index 032fbcb981f20f4e93202415e62f67379897a048..6c76212d4c698462a9128d26ef95f0eccb243c7c 100644
--- a/drivers/media/i2c/dw9719.c
+++ b/drivers/media/i2c/dw9719.c
@@ -360,6 +360,13 @@  static const struct i2c_device_id dw9719_id_table[] = {
 };
 MODULE_DEVICE_TABLE(i2c, dw9719_id_table);
 
+static const struct of_device_id dw9719_of_table[] = {
+	{ .compatible = "dongwoon,dw9719" },
+	{ .compatible = "dongwoon,dw9761" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, dw9719_of_table);
+
 static DEFINE_RUNTIME_DEV_PM_OPS(dw9719_pm_ops, dw9719_suspend, dw9719_resume,
 				 NULL);
 
@@ -367,6 +374,7 @@  static struct i2c_driver dw9719_i2c_driver = {
 	.driver = {
 		.name = "dw9719",
 		.pm = pm_sleep_ptr(&dw9719_pm_ops),
+		.of_match_table = of_match_ptr(dw9719_of_table),
 	},
 	.probe = dw9719_probe,
 	.remove = dw9719_remove,