| Message ID | 20250212165053.3378513-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: uapi: rkisp1-config: Fix typo in extensible params example | expand |
Hi Niklas On Wed, Feb 12, 2025 at 05:50:53PM +0100, Niklas Söderlund wrote: > The define used for the version in the example diagram do not match what > is defined in enum rksip1_ext_param_buffer_version, nor the description > above it. Correct the typo to make it clear which define to use. > > Fixes: e9d05e9d5db1 ("media: uapi: rkisp1-config: Add extensible params format") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thanks for spotting Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > include/uapi/linux/rkisp1-config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > index 430daceafac7..2d995f3c1ca3 100644 > --- a/include/uapi/linux/rkisp1-config.h > +++ b/include/uapi/linux/rkisp1-config.h > @@ -1528,7 +1528,7 @@ enum rksip1_ext_param_buffer_version { > * The expected memory layout of the parameters buffer is:: > * > * +-------------------- struct rkisp1_ext_params_cfg -------------------+ > - * | version = RKISP_EXT_PARAMS_BUFFER_V1; | > + * | version = RKISP1_EXT_PARAM_BUFFER_V1; | > * | data_size = sizeof(struct rkisp1_ext_params_bls_config) | > * | + sizeof(struct rkisp1_ext_params_dpcc_config); | > * | +------------------------- data ---------------------------------+ | > -- > 2.48.1 >
Hi Niklas, Thank you for the patch. On Wed, Feb 12, 2025 at 05:50:53PM +0100, Niklas Söderlund wrote: > The define used for the version in the example diagram do not match what s/do/does/ > is defined in enum rksip1_ext_param_buffer_version, nor the description > above it. Correct the typo to make it clear which define to use. > > Fixes: e9d05e9d5db1 ("media: uapi: rkisp1-config: Add extensible params format") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/uapi/linux/rkisp1-config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h > index 430daceafac7..2d995f3c1ca3 100644 > --- a/include/uapi/linux/rkisp1-config.h > +++ b/include/uapi/linux/rkisp1-config.h > @@ -1528,7 +1528,7 @@ enum rksip1_ext_param_buffer_version { > * The expected memory layout of the parameters buffer is:: > * > * +-------------------- struct rkisp1_ext_params_cfg -------------------+ > - * | version = RKISP_EXT_PARAMS_BUFFER_V1; | > + * | version = RKISP1_EXT_PARAM_BUFFER_V1; | > * | data_size = sizeof(struct rkisp1_ext_params_bls_config) | > * | + sizeof(struct rkisp1_ext_params_dpcc_config); | > * | +------------------------- data ---------------------------------+ |
diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h index 430daceafac7..2d995f3c1ca3 100644 --- a/include/uapi/linux/rkisp1-config.h +++ b/include/uapi/linux/rkisp1-config.h @@ -1528,7 +1528,7 @@ enum rksip1_ext_param_buffer_version { * The expected memory layout of the parameters buffer is:: * * +-------------------- struct rkisp1_ext_params_cfg -------------------+ - * | version = RKISP_EXT_PARAMS_BUFFER_V1; | + * | version = RKISP1_EXT_PARAM_BUFFER_V1; | * | data_size = sizeof(struct rkisp1_ext_params_bls_config) | * | + sizeof(struct rkisp1_ext_params_dpcc_config); | * | +------------------------- data ---------------------------------+ |
The define used for the version in the example diagram do not match what is defined in enum rksip1_ext_param_buffer_version, nor the description above it. Correct the typo to make it clear which define to use. Fixes: e9d05e9d5db1 ("media: uapi: rkisp1-config: Add extensible params format") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- include/uapi/linux/rkisp1-config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)