| Message ID | 20250225124008.195405-1-sebastian.fricke@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fixup! media: v4l2-common: Add helpers to calculate bytesperline and sizeimage | expand |
Hey, sorry about missing this in the patch series, if you don't like the fixup path, then I can send a new patch series as well. I just thought the change was minor enough and addressed the final comments. Regards, Sebastian ---- On Tue, 25 Feb 2025 13:40:08 +0100 Sebastian Fricke <sebastian.fricke@collabora.com> wrote --- > --- > drivers/media/v4l2-core/v4l2-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c > index 07a999f75755..aa86b8c6aa75 100644 > --- a/drivers/media/v4l2-core/v4l2-common.c > +++ b/drivers/media/v4l2-core/v4l2-common.c > @@ -360,7 +360,7 @@ static inline unsigned int v4l2_format_block_height(const struct v4l2_format_inf > } > > static inline unsigned int v4l2_format_plane_stride(const struct v4l2_format_info *info, int plane, > - unsigned int width) > + unsigned int width) > { > unsigned int hdiv = plane ? info->hdiv : 1; > unsigned int aligned_width = > -- > 2.25.1 > >
On 2/25/25 13:46, Sebastian Fricke wrote: > Hey, > > sorry about missing this in the patch series, if you don't like the fixup path, then I can send a new patch series as well. > I just thought the change was minor enough and addressed the final comments. Ah, this relates to patch 01/12 of this patch series: https://patchwork.linuxtv.org/project/linux-media/list/?series=14577 Next time it might be better to just reply to the offending patch with the fixup. That way it is clear for the maintainer what the fixup is for. Regards, Hans > > Regards, > Sebastian > > ---- On Tue, 25 Feb 2025 13:40:08 +0100 Sebastian Fricke <sebastian.fricke@collabora.com> wrote --- > > --- > > drivers/media/v4l2-core/v4l2-common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c > > index 07a999f75755..aa86b8c6aa75 100644 > > --- a/drivers/media/v4l2-core/v4l2-common.c > > +++ b/drivers/media/v4l2-core/v4l2-common.c > > @@ -360,7 +360,7 @@ static inline unsigned int v4l2_format_block_height(const struct v4l2_format_inf > > } > > > > static inline unsigned int v4l2_format_plane_stride(const struct v4l2_format_info *info, int plane, > > - unsigned int width) > > + unsigned int width) > > { > > unsigned int hdiv = plane ? info->hdiv : 1; > > unsigned int aligned_width = > > -- > > 2.25.1 > > > > >
Le mardi 25 février 2025 à 13:50 +0100, Hans Verkuil a écrit : > On 2/25/25 13:46, Sebastian Fricke wrote: > > Hey, > > > > sorry about missing this in the patch series, if you don't like the > > fixup path, then I can send a new patch series as well. > > I just thought the change was minor enough and addressed the final > > comments. > > Ah, this relates to patch 01/12 of this patch series: > > https://patchwork.linuxtv.org/project/linux-media/list/?series=14577 > > Next time it might be better to just reply to the offending patch > with the fixup. > > That way it is clear for the maintainer what the fixup is for. I believe you could have used: git send-email -in-reply-to=9db356bd-4d71-4975-91c6-7435bee8aef3@xs4all.nl <somepatch> To make that a reply. cheers, Nicolas > > Regards, > > Hans > > > > > Regards, > > Sebastian > > > > ---- On Tue, 25 Feb 2025 13:40:08 +0100 Sebastian Fricke > > <sebastian.fricke@collabora.com> wrote --- > > > --- > > > drivers/media/v4l2-core/v4l2-common.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-common.c > > b/drivers/media/v4l2-core/v4l2-common.c > > > index 07a999f75755..aa86b8c6aa75 100644 > > > --- a/drivers/media/v4l2-core/v4l2-common.c > > > +++ b/drivers/media/v4l2-core/v4l2-common.c > > > @@ -360,7 +360,7 @@ static inline unsigned int > > v4l2_format_block_height(const struct v4l2_format_inf > > > } > > > > > > static inline unsigned int v4l2_format_plane_stride(const > > struct v4l2_format_info *info, int plane, > > > - unsigned int width) > > > + unsigned int width) > > > { > > > unsigned int hdiv = plane ? info->hdiv : 1; > > > unsigned int aligned_width = > > > -- > > > 2.25.1 > > > > > > > > >
diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 07a999f75755..aa86b8c6aa75 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -360,7 +360,7 @@ static inline unsigned int v4l2_format_block_height(const struct v4l2_format_inf } static inline unsigned int v4l2_format_plane_stride(const struct v4l2_format_info *info, int plane, - unsigned int width) + unsigned int width) { unsigned int hdiv = plane ? info->hdiv : 1; unsigned int aligned_width =