| Message ID | 20250227114558.3097101-4-stefan.klug@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix full range quantization on rkisp1 based devices | expand |
Hi Stefan, Thank you for the patch. On Thu, Feb 27, 2025 at 12:45:01PM +0100, Stefan Klug wrote: > The effect modes are not shifts but numbers which are already defined a > few lines above. Remove the misleading defines. s/misleading/misleading and unused/ (I didn't expect you to intentionally break the build, and I'm sure it would be caught by my build tests, but making it clear for reviewers is always nice) > > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> No need to resubmit for this, I can update the commit message. > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > index bf0260600a19..139177db9c6d 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > @@ -327,13 +327,6 @@ > #define RKISP1_CIF_IMG_EFF_CTRL_CFG_UPD BIT(4) > #define RKISP1_CIF_IMG_EFF_CTRL_YCBCR_FULL BIT(5) > > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_BLACKWHITE_SHIFT 0 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_NEGATIVE_SHIFT 1 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SEPIA_SHIFT 2 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_COLOR_SEL_SHIFT 3 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_EMBOSS_SHIFT 4 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SKETCH_SHIFT 5 > -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SHARPEN_SHIFT 6 > #define RKISP1_CIF_IMG_EFF_CTRL_MODE_MASK 0xe > > /* IMG_EFF_COLOR_SEL */
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h index bf0260600a19..139177db9c6d 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h @@ -327,13 +327,6 @@ #define RKISP1_CIF_IMG_EFF_CTRL_CFG_UPD BIT(4) #define RKISP1_CIF_IMG_EFF_CTRL_YCBCR_FULL BIT(5) -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_BLACKWHITE_SHIFT 0 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_NEGATIVE_SHIFT 1 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SEPIA_SHIFT 2 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_COLOR_SEL_SHIFT 3 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_EMBOSS_SHIFT 4 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SKETCH_SHIFT 5 -#define RKISP1_CIF_IMG_EFF_CTRL_MODE_SHARPEN_SHIFT 6 #define RKISP1_CIF_IMG_EFF_CTRL_MODE_MASK 0xe /* IMG_EFF_COLOR_SEL */
The effect modes are not shifts but numbers which are already defined a few lines above. Remove the misleading defines. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> --- drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 7 ------- 1 file changed, 7 deletions(-)