From patchwork Mon Mar 17 00:39:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 14018565 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBAAD155322 for ; Mon, 17 Mar 2025 00:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742171994; cv=none; b=fBC90VCGcqDhfgPqDV/PVJ4S/kp1fJd/TqrDUpJ1WOuFaipppq1/2mjxlD365CFtsn4fBJrmlYwcqNbrFjO95GEyCxFiBmY6XVotltWDwhdPXni7Oc2cm3rr3Ftd9e6cUE0LLhXaSJjpeQ8ghF1vCskme/dNiFDH0tQAI0nPYRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742171994; c=relaxed/simple; bh=BseOSyrWbC7XsN7Ir+jFiDNzEQWe5FkrG+nPfKJhH3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Eg1oLTvR/9JJJ3U9d4N6ixi/kN1PrXsDCk84aok3eAq88EhSkOQztBiBKjb0Gks0IHftOE6hyUm56kaO5fp+9V6GYzrE+kxLLJoq1SZfVwV7gApI08yo/+lITOJfIKII/L2roT8SigOIn9w6RhdugRYu5MYkarV/ICu+CDmm1Hk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eOyyBbPI; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eOyyBbPI" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aaeec07b705so606450466b.2 for ; Sun, 16 Mar 2025 17:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742171990; x=1742776790; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9CgiISetOnuxy15HQS3MAPprAz1pVNJBASTHqb0R23I=; b=eOyyBbPIbg+Fi+qJ0SIKD7AmsuvhuHBn3AktJ6Qkn2l317ppI9xtuSvfjam+RN7l+D wZF/a1iqAx4lbHBoFypAN4w5puZbRA5LrIpOsfKKv33CKONov3yRqIAwgaABvoyLuhQT FsGUmlYXooLEfuBFrWEWN1Z0NgCdJVfHEJ3SpSqQIXOnaxh6cr6rL1n+MmXbDZycOnPI rdtYxkYvWvVei0iPyc0dxQXYIIRw7FGbCYUGm/R9eeymG8hA8SsRfP1ejl4rVMjpqvhA 9JzHQ19zmJgFdhXcy+JAdy7VkRvI/AOahksdboq+cHPZ0OHzZA4AwhXZ9s9ItwA2YKwm ImiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742171990; x=1742776790; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9CgiISetOnuxy15HQS3MAPprAz1pVNJBASTHqb0R23I=; b=SVF5M5keCmSCheLXHqKA2xOuhdaV3ObpTdpJj2nK0H8NZ6D+xY7LOM+cwJgXgxc8Z7 vYpbtLib3KYlhBhOZfiMROe8coXsP68RKkxAtidYRLe3d92ECMSkOKR8WOtMlQ+u2lZm kwg95jllBOcwYtL1yEk0KoA6CZauwchTi6aZVQVq/lv3lK9g3BBS5xZCrozNjsaEddED lUyLbEWDnXOFOkB7iKZobpOe32iqlmtUU6q3WlMMCHFCi+uC/yELXdImEDPmA9YiN7SN u+Eao3S/fkxkRFLxyJsTqUfgm3wP0/nNNHZglsh5zpH/pspF6HhANJD00cl4ZH2cqKtW 8r0g== X-Forwarded-Encrypted: i=1; AJvYcCXtixHMVo0VZzI+MIciLVDFTlurmJmZt1MrpbR4n+NtzBM2b7017Oc5Ym3JbFjwzffstB1RRUXzz6ufDg==@vger.kernel.org X-Gm-Message-State: AOJu0Ywo4ATlEelgtGEzi27mO87CKIbySdBq2md04geBEaUoECm+6pjL XQEfi13JP79r3eMjLJ7p0cPcYwE4taJhq6vUDD4TISR67o96huBPQZC3wvm4Aqo= X-Gm-Gg: ASbGncsRmKtrGQPZ8Qws9sMEO5D+kNd69W1bcbpjCDzK/IZIoEWQp7xinv+UvtqdNj8 nng8m9UvIOKYd5/+VqI8UuzGfTFv52U9PauFGvVseSQJPeHhMBo6+M4wAm9i56WVDpxNi4HMvDg vIR33zCLxl9S1h7EKG4h9RIse+5aP3fukty4BMCbDrCJOUkYV/pE9+nFHwo/NvYvpW1u7qAwS0x teuz5m7CcgOy6ZvpRreZjqh9R/umhgL5XOtW1k4LnjQfJHEGeY9Kb617epEsCc+ZAOZ4dkgJaZ3 /blePq4q7E+YgkOES6Twva4ZlEvlhKJXiqig/dtJpLy78pQ4K47LKmsXLGdQ794T8bFu8JuvCSG 8/9NOGpcA/iP1eluZfQAQqF/FH3j4xqcPbo27fYtXS6aPfUBnxPx1EVDQNB5ttRyu7vp9 X-Google-Smtp-Source: AGHT+IHN6MpPoVaqeceUTiJ12TLHptJq+aSorclyfov0XAOk0vnOAfc+Ft0TUVap5T6G00OSbPu+0A== X-Received: by 2002:a17:907:7d87:b0:ac3:26fb:f420 with SMTP id a640c23a62f3a-ac3303715c9mr1205541966b.42.1742171990333; Sun, 16 Mar 2025 17:39:50 -0700 (PDT) Received: from [192.168.178.107] (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3146aefadsm562407166b.8.2025.03.16.17.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 17:39:49 -0700 (PDT) From: Bryan O'Donoghue Date: Mon, 17 Mar 2025 00:39:39 +0000 Subject: [PATCH 7/8] media: i2c: ov02e10: Remove redundant dev_dbg() and some extra dev_err() Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-7-bd924634b889@linaro.org> References: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-0-bd924634b889@linaro.org> In-Reply-To: <20250317-b4-media-comitters-next-25-03-13-ov02e10-v1-0-bd924634b889@linaro.org> To: Mauro Carvalho Chehab , Sakari Ailus , Liam Girdwood , Mark Brown Cc: Jingjing Xiong , Hao Yao , Jim Lai , You-Sheng Yang , Alan Stern , Hans de Goede , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.14.2 Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov02e10.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/media/i2c/ov02e10.c b/drivers/media/i2c/ov02e10.c index 40c4d3ee36e3e2a0bb8be3ff10d016e2bb9bbc9d..2c15df8ca733aa4f37e125ac3bfb51a319e34c6e 100644 --- a/drivers/media/i2c/ov02e10.c +++ b/drivers/media/i2c/ov02e10.c @@ -316,7 +316,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) switch (ctrl->id) { case V4L2_CID_ANALOGUE_GAIN: - dev_dbg(&client->dev, "set analog gain\n"); cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG, OV02E10_PAGE_1, &ret); cci_write(ov02e10->regmap, OV02E10_REG_ANALOG_GAIN, @@ -324,7 +323,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_DIGITAL_GAIN: - dev_dbg(&client->dev, "set digital gain\n"); cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG, OV02E10_PAGE_1, &ret); cci_write(ov02e10->regmap, OV02E10_REG_DIGITAL_GAIN, @@ -332,7 +330,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_EXPOSURE: - dev_dbg(&client->dev, "set exposure\n"); cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG, OV02E10_PAGE_1, &ret); cci_write(ov02e10->regmap, OV02E10_REG_EXPOSURE, @@ -340,7 +337,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_VBLANK: - dev_dbg(&client->dev, "set vblank\n"); cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG, OV02E10_PAGE_1, &ret); cci_write(ov02e10->regmap, OV02E10_REG_VTS, @@ -348,7 +344,6 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) break; case V4L2_CID_TEST_PATTERN: - dev_dbg(&client->dev, "set test pattern\n"); cci_write(ov02e10->regmap, OV02E10_REG_PAGE_FLAG, OV02E10_PAGE_1, &ret); ov02e10_test_pattern(ov02e10, ctrl->val, &ret); @@ -358,7 +353,7 @@ static int ov02e10_set_ctrl(struct v4l2_ctrl *ctrl) ret = -EINVAL; break; } - dev_dbg(&client->dev, "will update cmd\n"); + cci_write(ov02e10->regmap, OV02E10_REG_COMMAND_UPDATE, OV02E10_COMMAND_UPDATE, &ret); @@ -510,7 +505,6 @@ static int ov02e10_set_stream(struct v4l2_subdev *sd, int enable) ret = ov02e10_start_streaming(ov02e10); if (ret) { - dev_dbg(&client->dev, "start streaming failed\n"); enable = 0; ov02e10_stop_streaming(ov02e10); pm_runtime_put(&client->dev); @@ -903,7 +897,6 @@ static int ov02e10_probe(struct i2c_client *client) /* Set default mode to max resolution */ ov02e->cur_mode = &supported_modes[0]; - dev_dbg(&client->dev, "will Init controls\n"); ret = ov02e10_init_controls(ov02e); if (ret) return ret; @@ -917,10 +910,8 @@ static int ov02e10_probe(struct i2c_client *client) /* Initialize source pad */ ov02e->pad.flags = MEDIA_PAD_FL_SOURCE; ret = media_entity_pads_init(&ov02e->sd.entity, 1, &ov02e->pad); - if (ret) { - dev_err(&client->dev, "%s failed:%d\n", __func__, ret); + if (ret) goto error_handler_free; - } ret = v4l2_async_register_subdev_sensor(&ov02e->sd); if (ret < 0) { @@ -944,11 +935,10 @@ static int ov02e10_probe(struct i2c_client *client) error_handler_free: v4l2_ctrl_handler_free(ov02e->sd.ctrl_handler); mutex_destroy(&ov02e->mutex); - dev_err(&client->dev, "%s failed:%d\n", __func__, ret); + error_power_off: ov02e10_power_off(&client->dev); - dev_dbg(&client->dev, "probe done\n"); return ret; }