diff mbox series

[v3,3/3] arm64: dts: qcom: sa8775p-ride: enable video

Message ID 20250320-dtbinding-v3-3-2a16fced51d5@quicinc.com (mailing list archive)
State New
Headers show
Series media: qcom: iris: add support for SA8775P | expand

Commit Message

Vikash Garodia March 20, 2025, 6:06 p.m. UTC 
Enable video nodes on the sa8775p-ride board and point to the
appropriate firmware files.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Bryan O'Donoghue March 20, 2025, 9:47 p.m. UTC | #1 
On 20/03/2025 18:06, Vikash Garodia wrote:
> +
> +&iris {
> +	firmware-name = "qcom/vpu/vpu30_p4_s6.mbn";
> +
> +	status = "okay";
> +};

You're out of alphanumeric order here.

Should be:

  };

+
+&iris {
+       firmware-name = "qcom/vpu/vpu30_p4_s6.mbn";
+
+       status = "okay";
+};
+
  &mdss0 {

---
bod
Vikash Garodia March 21, 2025, 3:16 a.m. UTC | #2 
On 3/21/2025 3:17 AM, Bryan O'Donoghue wrote:
> On 20/03/2025 18:06, Vikash Garodia wrote:
>> +
>> +&iris {
>> +    firmware-name = "qcom/vpu/vpu30_p4_s6.mbn";
>> +
>> +    status = "okay";
>> +};
> 
> You're out of alphanumeric order here.
ACK. Will update.

Regards,
Vikash
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
index 175f8b1e3b2ded15fc3265ac8c26b14473b618f6..ec3fa2739e1df2d5aebee7184c15e996a71b4550 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
@@ -1038,3 +1038,9 @@  &usb_2_hsphy {
 &xo_board_clk {
 	clock-frequency = <38400000>;
 };
+
+&iris {
+	firmware-name = "qcom/vpu/vpu30_p4_s6.mbn";
+
+	status = "okay";
+};