| Message ID | 20250407-dma-buf-ecc-heap-v3-1-97cdd36a5f29@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dma-buf: heaps: Support carved-out heaps | expand |
Am 07.04.25 um 18:29 schrieb Maxime Ripard: > The system heap is storing its struct dma_heap pointer in a global > variable but isn't using it anywhere. > > Let's move the global variable into system_heap_create() to make it > local. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> Reviewed-by: Christian König <christian.koenig@amd.com> Going to push this one to drm-misc-next, but I can't judge if in any way possible if patch #2 is correct or not. Regards, Christian. > --- > drivers/dma-buf/heaps/system_heap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c > index 26d5dc89ea1663a0d078e3a5723ca3d8d12b935f..82b1b714300d6ff5f3e543059dd8215ceaa00c69 100644 > --- a/drivers/dma-buf/heaps/system_heap.c > +++ b/drivers/dma-buf/heaps/system_heap.c > @@ -19,12 +19,10 @@ > #include <linux/module.h> > #include <linux/scatterlist.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > > -static struct dma_heap *sys_heap; > - > struct system_heap_buffer { > struct dma_heap *heap; > struct list_head attachments; > struct mutex lock; > unsigned long len; > @@ -422,10 +420,11 @@ static const struct dma_heap_ops system_heap_ops = { > }; > > static int __init system_heap_create(void) > { > struct dma_heap_export_info exp_info; > + struct dma_heap *sys_heap; > > exp_info.name = "system"; > exp_info.ops = &system_heap_ops; > exp_info.priv = NULL; > >
diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 26d5dc89ea1663a0d078e3a5723ca3d8d12b935f..82b1b714300d6ff5f3e543059dd8215ceaa00c69 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -19,12 +19,10 @@ #include <linux/module.h> #include <linux/scatterlist.h> #include <linux/slab.h> #include <linux/vmalloc.h> -static struct dma_heap *sys_heap; - struct system_heap_buffer { struct dma_heap *heap; struct list_head attachments; struct mutex lock; unsigned long len; @@ -422,10 +420,11 @@ static const struct dma_heap_ops system_heap_ops = { }; static int __init system_heap_create(void) { struct dma_heap_export_info exp_info; + struct dma_heap *sys_heap; exp_info.name = "system"; exp_info.ops = &system_heap_ops; exp_info.priv = NULL;
The system heap is storing its struct dma_heap pointer in a global variable but isn't using it anywhere. Let's move the global variable into system_heap_create() to make it local. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/dma-buf/heaps/system_heap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)