From patchwork Thu Apr 10 15:40:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dufresne X-Patchwork-Id: 14046741 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7181EB1AA; Thu, 10 Apr 2025 15:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744299616; cv=none; b=nEoZcEmGyehQuAdU/qCzPJlor8jlGc9szypz5T0D1PpZBmkkqAa9wZkMCMRnMpQF0xMgcgGMGxXtqVrOYyJhkMSzdgxDitDerTw68oUGvWL3JShA9NXsllNBGZrEU37eGLJ1WG+vLhC91z/6w8FZHix4qG9D11xvJf8uz725TCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744299616; c=relaxed/simple; bh=sYHUv9c2J/bW3e3pKAK6dhvM8isdWLfu3/aJgKmmQAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ulHPgSwOtAdoXUW3XTvPY7CTRFANZdKxdtYXa1y1ltQD2VEmEG1tSIEMmWEvUgiAfpgC+o77+gkov69dJi+ApeW5ZrG8Ut3USdNsIZfhB3m99ril8fRnZULt15bfBvUxDqp9kCgl1aBXaYxxGIvTncgtP698mDgej47KbSSXo8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=B+JplglO; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="B+JplglO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744299612; bh=sYHUv9c2J/bW3e3pKAK6dhvM8isdWLfu3/aJgKmmQAs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=B+JplglOyc37V+r+6c35ApCFQpCh+3wLwskOatNhYatyYtHxgYyA7beYAKW0J2uiF 0DxobBqM12+r7MDosajLlfhZnMmgoh/V0i73YRnz0vYmXFD9jrdI7spdyHXkqER8bz IIKuH1Wzv3tF1FSnaQb0F+PzQswZYfZEWQqSKViBeAa5+PnhRt2d2n0ngpcwldnkYN LGh4lasrI3kyyVAE1WgN0F66T2Ni/EmDoWpYzeJSkPC9DHeXekgddWatWUOoUh9Vmo woTB8pF+kSXRR+gS8YjVMH8k1kBzcR8OITGwvKz2xAcO3WFuwZ/Rb1axTfMbjcNxYo inXeCL90JVezA== Received: from [192.168.13.180] (unknown [IPv6:2606:6d00:11:e976::5ac]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id AFCF817E0808; Thu, 10 Apr 2025 17:40:10 +0200 (CEST) From: Nicolas Dufresne Date: Thu, 10 Apr 2025 11:40:00 -0400 Subject: [PATCH v2 5/5] media: mtk-vcodec: Don't try to decode 422/444 VP9 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250410-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v2-5-5b99ec0450e6@collabora.com> References: <20250410-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v2-0-5b99ec0450e6@collabora.com> In-Reply-To: <20250410-sebastianfricke-vcodec_manual_request_completion_with_state_machine-v2-0-5b99ec0450e6@collabora.com> To: Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, linux-media@vger.kernel.org, Sebastian Fricke , Nicolas Dufresne X-Mailer: b4 0.14.2 This is not supported by the hardware and trying to decode these leads to LAT timeout errors. Signed-off-by: Nicolas Dufresne Reviewed-by: AngeloGioacchino Del Regno --- .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c index 1b08f95ba04ee137b46d61d866b030857f439429..ab6ab9ef33dbd0d4735f82e74526b376f2502550 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c @@ -492,6 +492,12 @@ static int mtk_vdec_s_ctrl(struct v4l2_ctrl *ctrl) mtk_v4l2_vdec_err(ctx, "VP9: bit_depth:%d", frame->bit_depth); return -EINVAL; } + + if (!(frame->flags & V4L2_VP9_FRAME_FLAG_X_SUBSAMPLING) || + !(frame->flags & V4L2_VP9_FRAME_FLAG_Y_SUBSAMPLING)) { + mtk_v4l2_vdec_err(ctx, "VP9: only 420 subsampling is supported"); + return -EINVAL; + } break; case V4L2_CID_STATELESS_AV1_SEQUENCE: seq = (struct v4l2_ctrl_av1_sequence *)hdr_ctrl->p_new.p;